Upgrade to Pro — share decks privately, control downloads, hide ads and more …

つらくないコードレビューの運用

Sponsored · Your Podcast. Everywhere. Effortlessly. Share. Educate. Inspire. Entertain. You do you. We'll handle the rest. →
Avatar for Kazuhiro Serizawa Kazuhiro Serizawa
May 25, 2016
Programming
20k
43

 つらくないコードレビューの運用

コード改善 meetup #1 発表スライドです

Avatar for Kazuhiro Serizawa

Kazuhiro Serizawa

May 25, 2016

More Decks by Kazuhiro Serizawa

See All by Kazuhiro Serizawa
Accelerating Machine Learning I/O by Overlapping Data Staging and Mini-batch Generations
Avatar for Kazuhiro Serizawa serihiro
1
360
hpc170_slide.pdf
Avatar for Kazuhiro Serizawa serihiro
0
92
画像解像度別ImageNetの100 iterationの合計処理時間比較
Avatar for Kazuhiro Serizawa serihiro
0
150
深層ニューラルネットワークにおける訓練高速化のための自動最適化
Avatar for Kazuhiro Serizawa serihiro
0
81
Introduction to Parallel Computing 2.2
Avatar for Kazuhiro Serizawa serihiro
0
83
My summer internship result at Treasure Data 2018 #td_intern
Avatar for Kazuhiro Serizawa serihiro
0
2.2k
startupでもrails使うなら これだけはやっとけ的 tips集
Avatar for Kazuhiro Serizawa serihiro
19
10k
５分で分かるかもしれないjava8 Stream API
Avatar for Kazuhiro Serizawa serihiro
1
2.3k

Other Decks in Programming

See All in Programming
RailsTokyo 2026#4: AI様があれば、
Hotwireの弱点は消えるか？
Avatar for Naofumi Kagami naofumi
4
510
開発体験を左右するライブラリの API 設計 - GraphQL スキーマ構築ライブラリから考える #tskaigi
Avatar for izumin5210 izumin5210
2
460
ビジネスモデルから紐解く、AI+型駆動開発
Avatar for Hiroki Omote hirokiomote
2
1.2k
1人1案件のプロダクトエンジニア時代に、"プロセス監督"としてチャレンジしたこと
Avatar for のんちゃん non0113
0
170
Spec-Driven Development with AI Agents (Workshop, May 2026)
Avatar for Anton Arhipov antonarhipov
4
420
ECR拡張スキャンでSBOMを収集して サプライチェーン攻撃の影響調査を 爆速で終わらせてみた
Avatar for アキキー | Akihisa Ikeda akihisaikeda
2
180
TypeSpec で繋ぐ複数プロダクトの型安全
Avatar for Mitsui maroon8021
1
200
サークル参加から学ぶ、小さな事業の回し方
Avatar for yuzneri yuzneri
0
220
Swiftのレキシカルスコープ管理
Avatar for kntk kntkymt
0
180
tsserverとは何だったのか、これからどうなるのか
Avatar for Ryota Nakamura nowaki28
1
340
TSKaigi2026-静的解析への投資がAI時代のコード品質を支える ── カスタムESLintルールの設計と運用
Avatar for HayatoKudou hayatokudou
5
960
AIエージェントの隔離技術の徹底比較
Avatar for kawayu kawayu
0
400

Featured

See All Featured
Agile Leadership in an Agile Organization
Avatar for Dr. Kim W Petersen kimpetersen
PRO
0
150
Navigating the Design Leadership Dip - Product Design Week Design Leaders+ Conference 2024
Avatar for Andy Polaine apolaine
1
320
Easily Structure & Communicate Ideas using Wireframe
Avatar for Afnizar Nur Ghifari afnizarnur
194
17k
Odyssey Design
Avatar for Ryan Kendrick rkendrick25
PRO
2
620
Effective software design: The role of men in debugging patriarchy in IT @ Voxxed Days AMS
Avatar for Kenny Baas-Schwegler baasie
0
360
Designing Experiences People Love
Avatar for Jonathan Moore moore
143
24k
How to Grow Your eCommerce with AI & Automation
Avatar for Katarina Dahlin katarinadahlin
PRO
1
190
Have SEOs Ruined the Internet? - User Awareness of SEO in 2025
Avatar for Akash Hashmi akashhashmi
0
340
Evolution of real-time – Irina Nazarova, EuRuKo, 2024
Avatar for Irina Nazarova irinanazarova
9
1.3k
ラッコキーワード サービス紹介資料
Avatar for ラッコ株式会社 rakko
1
3.4M
The Director’s Chair: Orchestrating AI for Truly Effective Learning
Avatar for Mike Taylor tmiket
1
170
A brief & incomplete history of 
UX Design for the World Wide Web: 1989–2019
Avatar for Jason CranfordTeague jct
2
380

Transcript

  1. ͭΒ͘ͳ͍ ίʔυϨϏϡʔͷӡ༻ ίʔυվળ meetup #1 2016.5.26

  2. About me • Kazuhiro Serizawa • github: serihiro • work

    at • serverside engineer • like %i(ruby erlang elixir)

  3. ࠓ೔࿩͞ͳ͍͜ͱ • ίʔυϨϏϡʔͷ۩ମతͳํ๏࿦ • ޮՌతͳίʔυϨϏϡʔͷ࢓ํ http://www.slideshare.net/rootmoon/7-37892729 ͓͢͢Ίʂ

  4. ࠓ೔࿩͢͜ͱ ίʔυϨϏϡʔ ΈΜͳͰ΍Ε͹ ͭΒ͘ͳ͍

  5. ίʔυϨϏϡʔ͋Δ͋Δ • ϨϏϡʔ͓͡͞Μ͕͍Δ ϨϏϡʔ͓ئ͍͠·͢ʂ ϨϏϡʔ͓ئ͍͠·͢ʂ ϨϏϡʔ͓ئ͍͠·͢ʂ ϨϏϡʔ͓ئ͍͠·͢ʂ ࠓ೔΋ϨϏϡʔͰ̍೔͕ऴΘ͓ͬͨʜ

  6. ίʔυϨϏϡʔ͋Δ͋Δ • ࢓༷ʹৄ͍͠ਓ͚͕ͩϨϏϡʔ͍ͯ͠Δ ϨϏϡʔ͓ئ͍͠·͢ʂ ͜͜෼͔Βͳ͍ΜͰ
 "͞ΜʹϨϏϡʔ͓ئ͍ͯ͠ ࠓ೔΋ϨϏϡʔָ͕͍͓͠ʜ ͡Ό͋"͞Μ͓ئ͍͠·͢ʂ

  7. ίʔυϨϏϡʔ͋Δ͋Δ • ͰɺproductionͰόά͕ݟ͔ͭΔͱ "͞Μ͕ϨϏϡʔ
 ͯ͘͠Εͨͷʹʜ ͪΐ͏ͪΐʜͪΐ͏ͪΐʜ "͞Μʜ

  8. ʮϨϏϡʔ͓͡͞Μʯ໰୊ • ʢ΄΅ʣಛఆͷਓ͚͕ͩϨϏϡʔ͍ͯ͠Δ • ʢ΄΅ʣಛఆͷਓ͚͕ͩϨϏϡʔ͢Δͱ • ಛఆͷਓͷෛ୲͕େ͖ͯͭ͘Β͍ࢥ͍Λ͢Δ • νʔϜ಺Ͱίʔυͷ஌ݟ͕ڞ༗͞Εͳ͍ •

    νʔϜϝϯόʔͷϨϏϡʔྗ͕ҭͨͳ͍ • ͍ͭ·Ͱ΋͋ΒΏΔ͜ͱ͕ଐਓతͰεέʔϧ͠ͳ͍૊৫ʹ…

  9. ͳͥʮϨϏϡʔ͓͡͞Μʯ͕
 ੜ·Εͯ͠·͏ͷ͔ • ৭ʑཧ༝͸͋Δͱࢥ͍·͢ • ௕͘ӡ༻ͯ͠ΔͷͰ৽ࢀϝϯόʔ͕͠Βͳ͍͜ͱ͕ଟ͍ • ϝϯόʔͷ࣮ྗ͕ࠩେ͖͍ • ͳΜͱͳ͘


    ̋̋͞Μ͕΍Βͳ͍ͱμϝͳؾ͕͢Δ or
 ࠷ॳʹ࡞ͬͨਓ͕ϨϏϡʔ͠ͳ͍ͱμϝͳؾ͕͢Δ or
 ͓ͬ͞Μ͕ϨϏϡʔ͠ͳ͍ͱμϝͳؾ͕͢Δ

  10. Ͱ΋͜Εͬͯ
 ͜͏͢Ε͹ղܾ͢ΔͷͰ͸ʁ • ௕͘ӡ༻ͯ͠ΔͷͰ৽ࢀϝϯόʔ͕͠Βͳ͍ ͜ͱ͕ଟ͍ • ϝϯόʔͷ࣮ྗ͕ࠩେ͖͍ • ͳΜͱͳ͘ →ֶ΂ʂ

    →஁͑Ζʂ →ཧ༝͕ͳ͍ͳΒࢭΊΑ͏ʂ

  11. ͜ΕΛղܾ͢ΔͨΊͷఏҊ νʔϜશһͰ
 ϨϏϡʔ͠Α͏

  12. ΋͠νʔϜશһͰϨϏϡʔ͢Δ Α͏ʹͳΔͱ • ୭΋͕ޓ͍ͷίʔυΛϨϏϡʔ͢Δ • ϓϩμΫτͷ੹೚͕ڞ༗͞ΕΔ • ίʔυͷ࢓༷Λ޿͘ڞ༗͢Δ • ݁Ռͱͯ͠ϨϏϡʔ͓͡͞Μ͕͍ͳ͘ͳΓɺ୭͔

    ͕ͭΒ͍ࢥ͍Λ͢Δ։ൃ͸ͳ͘ͳΔʂ
 …ͷ͔ʁ

  13. Α͋͘Δݱ࣮ ࣗ෼ͷλεΫͰखҰഋͩ ͔ΒϨϏϡʔ͢Δͷେม ࢓ࣄͰͦΜͳʹ ษڧͨ͘͠ͳ͍ ΍ͬͺΓԶ͕ϨϏϡʔ͠ͳ͍ͱෆ҆ ͪΌΜͱϨϏϡʔ
 Ͱ͖Δࣗ৴͕ͳ͍

  14. Ͱ΋ϨϏϡʔ͸΍Βͳ͍ͱ
 Ͱ͖ΔΑ͏ʹͳΔͷ͸೉͍͠ʢܦݧ্ʣ • ͷͰ΍ͬͺΓνʔϜͰϨϏϡʔΛճͤΔΑ͏ ʹͳͬͯཉ͍͠ͱݸਓతʹ͸ࢥ͏ • ͳͷͰνʔϜͰϨϏϡʔΛճ͠΍͘͢͢Δͨ Ίʹ࣮ࡍʹࢲ͕΍͍ͬͯΔtipsΛ͍͔ͭ͘঺հ

  15. ϨϏϡʔͯ͠΄͍͠಺༰ͷઆ໌Λ ৄࡉʹॻ͘Α͏ʹ࢓૊ΈԽ͢Δ • PullRequestͷDescriptionΛςϯϓϨԽ

  16. ϨϏϡΞʔ͸hubotͰ
 ެฏʹׂΓৼΔ • hubot pluginʰhubot-reviewer-lottoʱΛ࢖͏ https://github.com/sakatam/hubot-reviewer-lotto

  17. ϨϏϡΞʔΛؾݣ͏ • ʮ͜Ε΋͔ͨ͠͠Β೉͍͔͠΋ͳʙʯ
 ͱࢥͬͨΒϨϏϡΞʔʹ੠Λ͔͚ͯΈΔ • ͓ޓ͍ʹෆ໌ͳ఺Λฉ͖΍͘͢͢Δ
 งғؾͮ͘Γ͕ॏཁ

  18. ʮϨϏϡʔ=ษڧͷ৔ʯͱͯ͠ ೝࣝ͢Δ • ࢦఠ͢Δ͜ͱ͕ͳͯ͘΋࢓༷ͰΘ͔Βͳ͍ॴ͕͋ͬͨ Βੵۃతʹ࣭໰͢Δ • ࢦఠ͢Δ͜ͱ͕ͳͯ͘΋࣭໰͢Δ͚ͩͰ΋ϨϏϡΞʔɾ ϨϏϡʔΠ૒ํͷؾ͖ͮʹͭͳ͕Δࣄ͸ଟ͍ • ʮԿ͔ࢦఠ͠ͳ͍ͱ͍͚ͳ͍ʯͱ͍͏ϓϨογϟʔ͕

    ͋ΔͱϨϏϡʔͨ͘͠ͳ͘ͳΔɻੵۃతʹΈΜͳͰ࣭ ໰͋ͬͯͦ͠͏͍͏ϓϨογϟʔΛͳ͘͢͜ͱ͕ॏཁ

  19. ʮϨϏϡʔ=ษڧͷ৔ʯͱͯ͠ ೝࣝ͢Δ • ซͤͯಡΈ͍ͨ http://qiita.com/kkoide1332/items/c6ee6f007617114c8f0b

  20. ·ͱΊ • ίʔυϨϏϡʔ͓͡͞Μ͸ੜ·Ε΍͍͢ • ίʔυϨϏϡʔ͓͡͞Μ͕͍ΔνʔϜ͸͍Ζ ͍ΖͭΒ͍ • ΈΜͳͰίʔυϨϏϡʔΛճ͢͜ͱͰɺͭΒ ͍ίʔυϨϏϡʔ͔ΒϝϯόʔʹϝϦοτ͕ ͋ͬͯͭΒ͘ͳ͍ίʔυϨϏϡʔ΁