Upgrade to Pro — share decks privately, control downloads, hide ads and more …

つらくないコードレビューの運用

Avatar for Kazuhiro Serizawa Kazuhiro Serizawa
May 25, 2016
Programming
20k
43

 つらくないコードレビューの運用

コード改善 meetup #1 発表スライドです

Avatar for Kazuhiro Serizawa

Kazuhiro Serizawa

May 25, 2016

More Decks by Kazuhiro Serizawa

See All by Kazuhiro Serizawa
Accelerating Machine Learning I/O by Overlapping Data Staging and Mini-batch Generations
Avatar for Kazuhiro Serizawa serihiro
1
360
hpc170_slide.pdf
Avatar for Kazuhiro Serizawa serihiro
0
98
画像解像度別ImageNetの100 iterationの合計処理時間比較
Avatar for Kazuhiro Serizawa serihiro
0
160
深層ニューラルネットワークにおける訓練高速化のための自動最適化
Avatar for Kazuhiro Serizawa serihiro
0
87
Introduction to Parallel Computing 2.2
Avatar for Kazuhiro Serizawa serihiro
0
85
My summer internship result at Treasure Data 2018 #td_intern
Avatar for Kazuhiro Serizawa serihiro
0
2.2k
startupでもrails使うなら これだけはやっとけ的 tips集
Avatar for Kazuhiro Serizawa serihiro
19
10k
５分で分かるかもしれないjava8 Stream API
Avatar for Kazuhiro Serizawa serihiro
1
2.3k

Other Decks in Programming

See All in Programming
コンテキストの使い捨てをやめる — ビジネスルール駆動開発と miko —
Avatar for ioki ioki
0
260
AI 輔助遺留系統現代化的經驗分享
Avatar for James Wang jame2408
1
1.1k
AIを活用したE2Eテスト実装効率化のあゆみ / ebisu-mobile-14-kotetu
Avatar for kotetu (kotetuco) kotetuco
0
150
エンジニア向け会社紹介/Findy Company Profile
Avatar for Findy findyinc
6
360k
TypeScript+Orvalで実現する型安全かつ堅牢でスケーラブルなマルチチャネル通知基盤 / TSKaigi Night talks ~after conference~
Avatar for doriven d0riven
0
380
技術的負債解消で開発者の未来を開く- AIの力でコード刷新
Avatar for Kato Ryo kmd2kmd
0
130
Oxlintのカスタムルールの現況
Avatar for syumai syumai
6
1.2k
セキュリティの専門家じゃなくてもできる。「セキュリティ意識」をアップデートして サプライチェーン攻撃への耐性を高めよう。
Avatar for tk3fftk tk3fftk
5
1k
才能？センス？知らん、 続けたもん勝ちだ。-- 結婚・出産・癌を越えてなお、私がプロダクトを創り続ける理由
Avatar for 16bit_idol 16bitidol
2
620
気圧・高度・GPSを記録&可視化するアプリ「Koudo」を作った話
Avatar for Hajime Kato hjmkth
1
330
Hunting Vulnerabilities in Symfony with LLMs
Avatar for Vincent Amstoutz vinceamstoutz
0
570
The ROI of Quarkus for Spring Boot Applications
Avatar for Holly Cummins hollycummins
0
150

Featured

See All Featured
The Language of Interfaces
Avatar for Des Traynor destraynor
162
27k
Code Review Best Practice
Avatar for Trisha Gee trishagee
74
20k
Facilitating Awesome Meetings
Avatar for Lara Hogan lara
57
7k
Measuring & Analyzing Core Web Vitals
Avatar for Philip Tellis bluesmoon
9
870
Ecommerce SEO: The Keys for Success Now & Beyond - #SERPConf2024
Avatar for Aleyda Solis aleyda
1
2k
Max Prin - Stacking Signals: How International SEO Comes Together (And Falls Apart)
Avatar for Tech SEO Connect techseoconnect
PRO
0
190
Keith and Marios Guide to Fast Websites
Avatar for Keith Pitt keithpitt
413
23k
A Modern Web Designer's Workflow
Avatar for Chris Coyier chriscoyier
698
190k
The Myth of the Modular Monolith - Day 2 Keynote - Rails World 2024
Avatar for Eileen M. Uchitelle eileencodes
28
3.5k
New Earth Scene 8
Avatar for Sydney Stone popppiees
3
2.4k
4 Signs Your Business is Dying
Avatar for Josh Pigford shpigford
187
22k
Practical Tips for Bootstrapping Information Extraction Pipelines
Avatar for Matthew Honnibal honnibal
25
2k

Transcript

  1. ͭΒ͘ͳ͍ ίʔυϨϏϡʔͷӡ༻ ίʔυվળ meetup #1 2016.5.26

  2. About me • Kazuhiro Serizawa • github: serihiro • work

    at • serverside engineer • like %i(ruby erlang elixir)

  3. ࠓ೔࿩͞ͳ͍͜ͱ • ίʔυϨϏϡʔͷ۩ମతͳํ๏࿦ • ޮՌతͳίʔυϨϏϡʔͷ࢓ํ http://www.slideshare.net/rootmoon/7-37892729 ͓͢͢Ίʂ

  4. ࠓ೔࿩͢͜ͱ ίʔυϨϏϡʔ ΈΜͳͰ΍Ε͹ ͭΒ͘ͳ͍

  5. ίʔυϨϏϡʔ͋Δ͋Δ • ϨϏϡʔ͓͡͞Μ͕͍Δ ϨϏϡʔ͓ئ͍͠·͢ʂ ϨϏϡʔ͓ئ͍͠·͢ʂ ϨϏϡʔ͓ئ͍͠·͢ʂ ϨϏϡʔ͓ئ͍͠·͢ʂ ࠓ೔΋ϨϏϡʔͰ̍೔͕ऴΘ͓ͬͨʜ

  6. ίʔυϨϏϡʔ͋Δ͋Δ • ࢓༷ʹৄ͍͠ਓ͚͕ͩϨϏϡʔ͍ͯ͠Δ ϨϏϡʔ͓ئ͍͠·͢ʂ ͜͜෼͔Βͳ͍ΜͰ
 "͞ΜʹϨϏϡʔ͓ئ͍ͯ͠ ࠓ೔΋ϨϏϡʔָ͕͍͓͠ʜ ͡Ό͋"͞Μ͓ئ͍͠·͢ʂ

  7. ίʔυϨϏϡʔ͋Δ͋Δ • ͰɺproductionͰόά͕ݟ͔ͭΔͱ "͞Μ͕ϨϏϡʔ
 ͯ͘͠Εͨͷʹʜ ͪΐ͏ͪΐʜͪΐ͏ͪΐʜ "͞Μʜ

  8. ʮϨϏϡʔ͓͡͞Μʯ໰୊ • ʢ΄΅ʣಛఆͷਓ͚͕ͩϨϏϡʔ͍ͯ͠Δ • ʢ΄΅ʣಛఆͷਓ͚͕ͩϨϏϡʔ͢Δͱ • ಛఆͷਓͷෛ୲͕େ͖ͯͭ͘Β͍ࢥ͍Λ͢Δ • νʔϜ಺Ͱίʔυͷ஌ݟ͕ڞ༗͞Εͳ͍ •

    νʔϜϝϯόʔͷϨϏϡʔྗ͕ҭͨͳ͍ • ͍ͭ·Ͱ΋͋ΒΏΔ͜ͱ͕ଐਓతͰεέʔϧ͠ͳ͍૊৫ʹ…

  9. ͳͥʮϨϏϡʔ͓͡͞Μʯ͕
 ੜ·Εͯ͠·͏ͷ͔ • ৭ʑཧ༝͸͋Δͱࢥ͍·͢ • ௕͘ӡ༻ͯ͠ΔͷͰ৽ࢀϝϯόʔ͕͠Βͳ͍͜ͱ͕ଟ͍ • ϝϯόʔͷ࣮ྗ͕ࠩେ͖͍ • ͳΜͱͳ͘


    ̋̋͞Μ͕΍Βͳ͍ͱμϝͳؾ͕͢Δ or
 ࠷ॳʹ࡞ͬͨਓ͕ϨϏϡʔ͠ͳ͍ͱμϝͳؾ͕͢Δ or
 ͓ͬ͞Μ͕ϨϏϡʔ͠ͳ͍ͱμϝͳؾ͕͢Δ

  10. Ͱ΋͜Εͬͯ
 ͜͏͢Ε͹ղܾ͢ΔͷͰ͸ʁ • ௕͘ӡ༻ͯ͠ΔͷͰ৽ࢀϝϯόʔ͕͠Βͳ͍ ͜ͱ͕ଟ͍ • ϝϯόʔͷ࣮ྗ͕ࠩେ͖͍ • ͳΜͱͳ͘ →ֶ΂ʂ

    →஁͑Ζʂ →ཧ༝͕ͳ͍ͳΒࢭΊΑ͏ʂ

  11. ͜ΕΛղܾ͢ΔͨΊͷఏҊ νʔϜશһͰ
 ϨϏϡʔ͠Α͏

  12. ΋͠νʔϜશһͰϨϏϡʔ͢Δ Α͏ʹͳΔͱ • ୭΋͕ޓ͍ͷίʔυΛϨϏϡʔ͢Δ • ϓϩμΫτͷ੹೚͕ڞ༗͞ΕΔ • ίʔυͷ࢓༷Λ޿͘ڞ༗͢Δ • ݁Ռͱͯ͠ϨϏϡʔ͓͡͞Μ͕͍ͳ͘ͳΓɺ୭͔

    ͕ͭΒ͍ࢥ͍Λ͢Δ։ൃ͸ͳ͘ͳΔʂ
 …ͷ͔ʁ

  13. Α͋͘Δݱ࣮ ࣗ෼ͷλεΫͰखҰഋͩ ͔ΒϨϏϡʔ͢Δͷେม ࢓ࣄͰͦΜͳʹ ษڧͨ͘͠ͳ͍ ΍ͬͺΓԶ͕ϨϏϡʔ͠ͳ͍ͱෆ҆ ͪΌΜͱϨϏϡʔ
 Ͱ͖Δࣗ৴͕ͳ͍

  14. Ͱ΋ϨϏϡʔ͸΍Βͳ͍ͱ
 Ͱ͖ΔΑ͏ʹͳΔͷ͸೉͍͠ʢܦݧ্ʣ • ͷͰ΍ͬͺΓνʔϜͰϨϏϡʔΛճͤΔΑ͏ ʹͳͬͯཉ͍͠ͱݸਓతʹ͸ࢥ͏ • ͳͷͰνʔϜͰϨϏϡʔΛճ͠΍͘͢͢Δͨ Ίʹ࣮ࡍʹࢲ͕΍͍ͬͯΔtipsΛ͍͔ͭ͘঺հ

  15. ϨϏϡʔͯ͠΄͍͠಺༰ͷઆ໌Λ ৄࡉʹॻ͘Α͏ʹ࢓૊ΈԽ͢Δ • PullRequestͷDescriptionΛςϯϓϨԽ

  16. ϨϏϡΞʔ͸hubotͰ
 ެฏʹׂΓৼΔ • hubot pluginʰhubot-reviewer-lottoʱΛ࢖͏ https://github.com/sakatam/hubot-reviewer-lotto

  17. ϨϏϡΞʔΛؾݣ͏ • ʮ͜Ε΋͔ͨ͠͠Β೉͍͔͠΋ͳʙʯ
 ͱࢥͬͨΒϨϏϡΞʔʹ੠Λ͔͚ͯΈΔ • ͓ޓ͍ʹෆ໌ͳ఺Λฉ͖΍͘͢͢Δ
 งғؾͮ͘Γ͕ॏཁ

  18. ʮϨϏϡʔ=ษڧͷ৔ʯͱͯ͠ ೝࣝ͢Δ • ࢦఠ͢Δ͜ͱ͕ͳͯ͘΋࢓༷ͰΘ͔Βͳ͍ॴ͕͋ͬͨ Βੵۃతʹ࣭໰͢Δ • ࢦఠ͢Δ͜ͱ͕ͳͯ͘΋࣭໰͢Δ͚ͩͰ΋ϨϏϡΞʔɾ ϨϏϡʔΠ૒ํͷؾ͖ͮʹͭͳ͕Δࣄ͸ଟ͍ • ʮԿ͔ࢦఠ͠ͳ͍ͱ͍͚ͳ͍ʯͱ͍͏ϓϨογϟʔ͕

    ͋ΔͱϨϏϡʔͨ͘͠ͳ͘ͳΔɻੵۃతʹΈΜͳͰ࣭ ໰͋ͬͯͦ͠͏͍͏ϓϨογϟʔΛͳ͘͢͜ͱ͕ॏཁ

  19. ʮϨϏϡʔ=ษڧͷ৔ʯͱͯ͠ ೝࣝ͢Δ • ซͤͯಡΈ͍ͨ http://qiita.com/kkoide1332/items/c6ee6f007617114c8f0b

  20. ·ͱΊ • ίʔυϨϏϡʔ͓͡͞Μ͸ੜ·Ε΍͍͢ • ίʔυϨϏϡʔ͓͡͞Μ͕͍ΔνʔϜ͸͍Ζ ͍ΖͭΒ͍ • ΈΜͳͰίʔυϨϏϡʔΛճ͢͜ͱͰɺͭΒ ͍ίʔυϨϏϡʔ͔ΒϝϯόʔʹϝϦοτ͕ ͋ͬͯͭΒ͘ͳ͍ίʔυϨϏϡʔ΁