Upgrade to Pro — share decks privately, control downloads, hide ads and more …

つらくないコードレビューの運用

Avatar for Kazuhiro Serizawa Kazuhiro Serizawa
May 25, 2016
Programming
20k
43

 つらくないコードレビューの運用

コード改善 meetup #1 発表スライドです

Avatar for Kazuhiro Serizawa

Kazuhiro Serizawa

May 25, 2016

More Decks by Kazuhiro Serizawa

See All by Kazuhiro Serizawa
Accelerating Machine Learning I/O by Overlapping Data Staging and Mini-batch Generations
Avatar for Kazuhiro Serizawa serihiro
1
360
hpc170_slide.pdf
Avatar for Kazuhiro Serizawa serihiro
0
98
画像解像度別ImageNetの100 iterationの合計処理時間比較
Avatar for Kazuhiro Serizawa serihiro
0
160
深層ニューラルネットワークにおける訓練高速化のための自動最適化
Avatar for Kazuhiro Serizawa serihiro
0
87
Introduction to Parallel Computing 2.2
Avatar for Kazuhiro Serizawa serihiro
0
85
My summer internship result at Treasure Data 2018 #td_intern
Avatar for Kazuhiro Serizawa serihiro
0
2.2k
startupでもrails使うなら これだけはやっとけ的 tips集
Avatar for Kazuhiro Serizawa serihiro
19
10k
５分で分かるかもしれないjava8 Stream API
Avatar for Kazuhiro Serizawa serihiro
1
2.3k

Other Decks in Programming

See All in Programming
The Past, Present, and Future of Enterprise Java
Avatar for ivargrimstad ivargrimstad
0
130
PHPだって関数型したい 〜できること、できないこと〜 / fp-in-php
Avatar for jsoizo jsoizo
0
200
Generative UI & AI-Assistants for Your Angular Solutions
Avatar for Manfred Steyer manfredsteyer
PRO
0
100
OS アップデート対応の取り組み方がもっと共有されてほしい
Avatar for ANDPAD inc andpad
0
110
Claude Team Plan導入・ガイド
Avatar for tk3fftk tk3fftk
0
180
【やさしく解説 設計編・中級 #6】良いアーキテクチャとは ～ 一本の登り道の、行き先 ～
Avatar for HideyukiKitao panda728
PRO
0
150
ECSアプリログをFireLensでコスト削減しようとしたけど諦めた話 in Fargate×Node.js
Avatar for アキキー | Akihisa Ikeda akihisaikeda
3
4.3k
Honoでのサプライチェーン侵害対策 〜 3つのライブラリに学ぶ
Avatar for Yusuke Wada yusukebe
7
1.8k
霧の中の代数的エフェクト
Avatar for funnycat funnyycat
1
350
【やさしく解説 設計編 #0】DDDのコード、読めるのに分からない人へ
Avatar for HideyukiKitao panda728
PRO
2
260
吝嗇家のためのAI活用 / AI development for miser - ChatGPT + Issue Driven Development
Avatar for philomagi tooppoo
0
180
act2-costs.pdf
Avatar for Sumedh Bala sumedhbala
0
110

Featured

See All Featured
More Than Pixels: Becoming A User Experience Designer
Avatar for Michelle Schulp Hunt marktimemedia
3
460
Chrome DevTools: State of the Union 2024 - Debugging React & Beyond
Avatar for Addy Osmani addyosmani
10
1.3k
The Curious Case for Waylosing
Avatar for Cassini Nazir cassininazir
1
430
"I'm Feeling Lucky" - Building Great Search Experiences for Today's Users (#IAC19)
Avatar for Dan Newman danielanewman
230
23k
[Rails World 2023 - Day 1 Closing Keynote] - The Magic of Rails
Avatar for Eileen M. Uchitelle eileencodes
38
2.9k
Optimising Largest Contentful Paint
Avatar for Harry Roberts csswizardry
37
3.8k
Scaling GitHub
Avatar for Zach Holman holman
464
140k
Amusing Abliteration
Avatar for ianozsvald ianozsvald
1
220
Ethics towards AI in product and experience design
Avatar for Skipper Chong Warson skipperchong
2
330
Build The Right Thing And Hit Your Dates
Avatar for Maggie C. maggiecrowley
39
3.3k
Practical Tips for Bootstrapping Information Extraction Pipelines
Avatar for Matthew Honnibal honnibal
25
2k
How to Get Subject Matter Experts Bought In and Actively Contributing to SEO & PR Initiatives.
Avatar for Liv Day livdayseo
0
150

Transcript

  1. ͭΒ͘ͳ͍ ίʔυϨϏϡʔͷӡ༻ ίʔυվળ meetup #1 2016.5.26

  2. About me • Kazuhiro Serizawa • github: serihiro • work

    at • serverside engineer • like %i(ruby erlang elixir)

  3. ࠓ೔࿩͞ͳ͍͜ͱ • ίʔυϨϏϡʔͷ۩ମతͳํ๏࿦ • ޮՌతͳίʔυϨϏϡʔͷ࢓ํ http://www.slideshare.net/rootmoon/7-37892729 ͓͢͢Ίʂ

  4. ࠓ೔࿩͢͜ͱ ίʔυϨϏϡʔ ΈΜͳͰ΍Ε͹ ͭΒ͘ͳ͍

  5. ίʔυϨϏϡʔ͋Δ͋Δ • ϨϏϡʔ͓͡͞Μ͕͍Δ ϨϏϡʔ͓ئ͍͠·͢ʂ ϨϏϡʔ͓ئ͍͠·͢ʂ ϨϏϡʔ͓ئ͍͠·͢ʂ ϨϏϡʔ͓ئ͍͠·͢ʂ ࠓ೔΋ϨϏϡʔͰ̍೔͕ऴΘ͓ͬͨʜ

  6. ίʔυϨϏϡʔ͋Δ͋Δ • ࢓༷ʹৄ͍͠ਓ͚͕ͩϨϏϡʔ͍ͯ͠Δ ϨϏϡʔ͓ئ͍͠·͢ʂ ͜͜෼͔Βͳ͍ΜͰ
 "͞ΜʹϨϏϡʔ͓ئ͍ͯ͠ ࠓ೔΋ϨϏϡʔָ͕͍͓͠ʜ ͡Ό͋"͞Μ͓ئ͍͠·͢ʂ

  7. ίʔυϨϏϡʔ͋Δ͋Δ • ͰɺproductionͰόά͕ݟ͔ͭΔͱ "͞Μ͕ϨϏϡʔ
 ͯ͘͠Εͨͷʹʜ ͪΐ͏ͪΐʜͪΐ͏ͪΐʜ "͞Μʜ

  8. ʮϨϏϡʔ͓͡͞Μʯ໰୊ • ʢ΄΅ʣಛఆͷਓ͚͕ͩϨϏϡʔ͍ͯ͠Δ • ʢ΄΅ʣಛఆͷਓ͚͕ͩϨϏϡʔ͢Δͱ • ಛఆͷਓͷෛ୲͕େ͖ͯͭ͘Β͍ࢥ͍Λ͢Δ • νʔϜ಺Ͱίʔυͷ஌ݟ͕ڞ༗͞Εͳ͍ •

    νʔϜϝϯόʔͷϨϏϡʔྗ͕ҭͨͳ͍ • ͍ͭ·Ͱ΋͋ΒΏΔ͜ͱ͕ଐਓతͰεέʔϧ͠ͳ͍૊৫ʹ…

  9. ͳͥʮϨϏϡʔ͓͡͞Μʯ͕
 ੜ·Εͯ͠·͏ͷ͔ • ৭ʑཧ༝͸͋Δͱࢥ͍·͢ • ௕͘ӡ༻ͯ͠ΔͷͰ৽ࢀϝϯόʔ͕͠Βͳ͍͜ͱ͕ଟ͍ • ϝϯόʔͷ࣮ྗ͕ࠩେ͖͍ • ͳΜͱͳ͘


    ̋̋͞Μ͕΍Βͳ͍ͱμϝͳؾ͕͢Δ or
 ࠷ॳʹ࡞ͬͨਓ͕ϨϏϡʔ͠ͳ͍ͱμϝͳؾ͕͢Δ or
 ͓ͬ͞Μ͕ϨϏϡʔ͠ͳ͍ͱμϝͳؾ͕͢Δ

  10. Ͱ΋͜Εͬͯ
 ͜͏͢Ε͹ղܾ͢ΔͷͰ͸ʁ • ௕͘ӡ༻ͯ͠ΔͷͰ৽ࢀϝϯόʔ͕͠Βͳ͍ ͜ͱ͕ଟ͍ • ϝϯόʔͷ࣮ྗ͕ࠩେ͖͍ • ͳΜͱͳ͘ →ֶ΂ʂ

    →஁͑Ζʂ →ཧ༝͕ͳ͍ͳΒࢭΊΑ͏ʂ

  11. ͜ΕΛղܾ͢ΔͨΊͷఏҊ νʔϜશһͰ
 ϨϏϡʔ͠Α͏

  12. ΋͠νʔϜશһͰϨϏϡʔ͢Δ Α͏ʹͳΔͱ • ୭΋͕ޓ͍ͷίʔυΛϨϏϡʔ͢Δ • ϓϩμΫτͷ੹೚͕ڞ༗͞ΕΔ • ίʔυͷ࢓༷Λ޿͘ڞ༗͢Δ • ݁Ռͱͯ͠ϨϏϡʔ͓͡͞Μ͕͍ͳ͘ͳΓɺ୭͔

    ͕ͭΒ͍ࢥ͍Λ͢Δ։ൃ͸ͳ͘ͳΔʂ
 …ͷ͔ʁ

  13. Α͋͘Δݱ࣮ ࣗ෼ͷλεΫͰखҰഋͩ ͔ΒϨϏϡʔ͢Δͷେม ࢓ࣄͰͦΜͳʹ ษڧͨ͘͠ͳ͍ ΍ͬͺΓԶ͕ϨϏϡʔ͠ͳ͍ͱෆ҆ ͪΌΜͱϨϏϡʔ
 Ͱ͖Δࣗ৴͕ͳ͍

  14. Ͱ΋ϨϏϡʔ͸΍Βͳ͍ͱ
 Ͱ͖ΔΑ͏ʹͳΔͷ͸೉͍͠ʢܦݧ্ʣ • ͷͰ΍ͬͺΓνʔϜͰϨϏϡʔΛճͤΔΑ͏ ʹͳͬͯཉ͍͠ͱݸਓతʹ͸ࢥ͏ • ͳͷͰνʔϜͰϨϏϡʔΛճ͠΍͘͢͢Δͨ Ίʹ࣮ࡍʹࢲ͕΍͍ͬͯΔtipsΛ͍͔ͭ͘঺հ

  15. ϨϏϡʔͯ͠΄͍͠಺༰ͷઆ໌Λ ৄࡉʹॻ͘Α͏ʹ࢓૊ΈԽ͢Δ • PullRequestͷDescriptionΛςϯϓϨԽ

  16. ϨϏϡΞʔ͸hubotͰ
 ެฏʹׂΓৼΔ • hubot pluginʰhubot-reviewer-lottoʱΛ࢖͏ https://github.com/sakatam/hubot-reviewer-lotto

  17. ϨϏϡΞʔΛؾݣ͏ • ʮ͜Ε΋͔ͨ͠͠Β೉͍͔͠΋ͳʙʯ
 ͱࢥͬͨΒϨϏϡΞʔʹ੠Λ͔͚ͯΈΔ • ͓ޓ͍ʹෆ໌ͳ఺Λฉ͖΍͘͢͢Δ
 งғؾͮ͘Γ͕ॏཁ

  18. ʮϨϏϡʔ=ษڧͷ৔ʯͱͯ͠ ೝࣝ͢Δ • ࢦఠ͢Δ͜ͱ͕ͳͯ͘΋࢓༷ͰΘ͔Βͳ͍ॴ͕͋ͬͨ Βੵۃతʹ࣭໰͢Δ • ࢦఠ͢Δ͜ͱ͕ͳͯ͘΋࣭໰͢Δ͚ͩͰ΋ϨϏϡΞʔɾ ϨϏϡʔΠ૒ํͷؾ͖ͮʹͭͳ͕Δࣄ͸ଟ͍ • ʮԿ͔ࢦఠ͠ͳ͍ͱ͍͚ͳ͍ʯͱ͍͏ϓϨογϟʔ͕

    ͋ΔͱϨϏϡʔͨ͘͠ͳ͘ͳΔɻੵۃతʹΈΜͳͰ࣭ ໰͋ͬͯͦ͠͏͍͏ϓϨογϟʔΛͳ͘͢͜ͱ͕ॏཁ

  19. ʮϨϏϡʔ=ษڧͷ৔ʯͱͯ͠ ೝࣝ͢Δ • ซͤͯಡΈ͍ͨ http://qiita.com/kkoide1332/items/c6ee6f007617114c8f0b

  20. ·ͱΊ • ίʔυϨϏϡʔ͓͡͞Μ͸ੜ·Ε΍͍͢ • ίʔυϨϏϡʔ͓͡͞Μ͕͍ΔνʔϜ͸͍Ζ ͍ΖͭΒ͍ • ΈΜͳͰίʔυϨϏϡʔΛճ͢͜ͱͰɺͭΒ ͍ίʔυϨϏϡʔ͔ΒϝϯόʔʹϝϦοτ͕ ͋ͬͯͭΒ͘ͳ͍ίʔυϨϏϡʔ΁