Upgrade to Pro — share decks privately, control downloads, hide ads and more …

つらくないコードレビューの運用

Sponsored · Ship Features Fearlessly Turn features on and off without deploys. Used by thousands of Ruby developers. →
Avatar for Kazuhiro Serizawa Kazuhiro Serizawa
May 25, 2016
Programming
20k
43

 つらくないコードレビューの運用

コード改善 meetup #1 発表スライドです

Avatar for Kazuhiro Serizawa

Kazuhiro Serizawa

May 25, 2016

More Decks by Kazuhiro Serizawa

See All by Kazuhiro Serizawa
Accelerating Machine Learning I/O by Overlapping Data Staging and Mini-batch Generations
Avatar for Kazuhiro Serizawa serihiro
1
360
hpc170_slide.pdf
Avatar for Kazuhiro Serizawa serihiro
0
99
画像解像度別ImageNetの100 iterationの合計処理時間比較
Avatar for Kazuhiro Serizawa serihiro
0
170
深層ニューラルネットワークにおける訓練高速化のための自動最適化
Avatar for Kazuhiro Serizawa serihiro
0
88
Introduction to Parallel Computing 2.2
Avatar for Kazuhiro Serizawa serihiro
0
86
My summer internship result at Treasure Data 2018 #td_intern
Avatar for Kazuhiro Serizawa serihiro
0
2.2k
startupでもrails使うなら これだけはやっとけ的 tips集
Avatar for Kazuhiro Serizawa serihiro
19
10k
５分で分かるかもしれないjava8 Stream API
Avatar for Kazuhiro Serizawa serihiro
1
2.3k

Other Decks in Programming

See All in Programming
2年かけて Deno に DOMMatrix を実装した話 / How I implemented DOMMatrix in Deno over two years
Avatar for petamoriken / 森建 petamoriken
0
180
5分で問診！Composer セキュリティ健康診断
Avatar for コドモン開発チーム codmoninc
0
670
[RVD26] Vibe Architecture en 2040 : Darwin a-t-il (enfin) eu raison des architectes ?
Avatar for Alexandre Touret alexandretouret
0
110
霧の中の代数的エフェクト
Avatar for funnycat funnyycat
1
440
AWS CDK を「作」ってみた 〜フルスクラッチで見えた CDK の裏側〜 / aws-cdk-from-scratch
Avatar for k.goto gotok365
3
2.6k
変わらないものが、変わるものを決める — 意図駆動開発 × イベントソーシング × イミュータブル | What Doesn't Change Decides What Can — IDD × Event Sourcing × Immutability
Avatar for Tomohisa Takaoka tomohisa
0
590
使用 Meilisearch 建立新聞搜尋工具
Avatar for johnroyer johnroyer
0
180
信頼性について考えてみる（SRE NEXT 2026 miniLT）
Avatar for hayama hayama17
0
220
そこに3びきプロダクトがいるじゃろう——生成AI時代における“価値が届かない理由”の構造
Avatar for kosuke T kosuket
0
220
琵琶湖の水は止められてもNet--HTTPのリトライは止められない / You might be able to stop the water flow of Lake Biwa but you can't stop Net::HTTP retries
Avatar for luccafort luccafort
PRO
0
460
AI Engineeringは、AIプロダクトだけのものか？ 〜AIがソフトウェアを作る時代の新しい当たり前〜 / No AI in your product. AI Engineering in your development.
Avatar for r-kagaya rkaga
2
140
JAWS-UG横浜 #102 AWSサ終供養LT会 成仏できない AWS サービスたち 〜本日、三体供養します〜
Avatar for maroon1st maroon1st
0
250

Featured

See All Featured
Fight the Zombie Pattern Library - RWD Summit 2016
Avatar for Marcelo Somers marcelosomers
234
17k
A designer walks into a library…
Avatar for Paul Jervis Heath pauljervisheath
211
24k
brightonSEO & MeasureFest 2025 - Christian Goodrich - Winning strategies for Black Friday CRO & PPC
Avatar for Christian Goodrich cargoodrich
3
760
Darren the Foodie - Storyboard
Avatar for Kevinho.art khoart
PRO
3
3.5k
Lessons Learnt from Crawling 1000+ Websites
Avatar for Charles Meaden charlesmeaden
PRO
1
1.4k
Noah Learner - AI + Me: how we built a GSC Bulk Export data pipeline
Avatar for Tech SEO Connect techseoconnect
PRO
0
340
Navigating the Design Leadership Dip - Product Design Week Design Leaders+ Conference 2024
Avatar for Andy Polaine apolaine
1
380
Pawsitive SEO: Lessons from My Dog (and Many Mistakes) on Thriving as a Consultant in the Age of AI
Avatar for David Carrasco davidcarrasco
0
200
Code Reviewing Like a Champion
Avatar for maltzj maltzj
528
40k
XXLCSS - How to scale CSS and keep your sanity
Avatar for Zaharenia Atzitzikaki sugarenia
249
1.3M
How People are Using Generative and Agentic AI to Supercharge Their Products, Projects, Services and Value Streams Today
Avatar for Helen Beal helenjbeal
1
250
Responsive Adventures: Dirty Tricks From The Dark Corners of Front-End
Avatar for Vitaly Friedman smashingmag
254
22k

Transcript

  1. ͭΒ͘ͳ͍ ίʔυϨϏϡʔͷӡ༻ ίʔυվળ meetup #1 2016.5.26

  2. About me • Kazuhiro Serizawa • github: serihiro • work

    at • serverside engineer • like %i(ruby erlang elixir)

  3. ࠓ೔࿩͞ͳ͍͜ͱ • ίʔυϨϏϡʔͷ۩ମతͳํ๏࿦ • ޮՌతͳίʔυϨϏϡʔͷ࢓ํ http://www.slideshare.net/rootmoon/7-37892729 ͓͢͢Ίʂ

  4. ࠓ೔࿩͢͜ͱ ίʔυϨϏϡʔ ΈΜͳͰ΍Ε͹ ͭΒ͘ͳ͍

  5. ίʔυϨϏϡʔ͋Δ͋Δ • ϨϏϡʔ͓͡͞Μ͕͍Δ ϨϏϡʔ͓ئ͍͠·͢ʂ ϨϏϡʔ͓ئ͍͠·͢ʂ ϨϏϡʔ͓ئ͍͠·͢ʂ ϨϏϡʔ͓ئ͍͠·͢ʂ ࠓ೔΋ϨϏϡʔͰ̍೔͕ऴΘ͓ͬͨʜ

  6. ίʔυϨϏϡʔ͋Δ͋Δ • ࢓༷ʹৄ͍͠ਓ͚͕ͩϨϏϡʔ͍ͯ͠Δ ϨϏϡʔ͓ئ͍͠·͢ʂ ͜͜෼͔Βͳ͍ΜͰ
 "͞ΜʹϨϏϡʔ͓ئ͍ͯ͠ ࠓ೔΋ϨϏϡʔָ͕͍͓͠ʜ ͡Ό͋"͞Μ͓ئ͍͠·͢ʂ

  7. ίʔυϨϏϡʔ͋Δ͋Δ • ͰɺproductionͰόά͕ݟ͔ͭΔͱ "͞Μ͕ϨϏϡʔ
 ͯ͘͠Εͨͷʹʜ ͪΐ͏ͪΐʜͪΐ͏ͪΐʜ "͞Μʜ

  8. ʮϨϏϡʔ͓͡͞Μʯ໰୊ • ʢ΄΅ʣಛఆͷਓ͚͕ͩϨϏϡʔ͍ͯ͠Δ • ʢ΄΅ʣಛఆͷਓ͚͕ͩϨϏϡʔ͢Δͱ • ಛఆͷਓͷෛ୲͕େ͖ͯͭ͘Β͍ࢥ͍Λ͢Δ • νʔϜ಺Ͱίʔυͷ஌ݟ͕ڞ༗͞Εͳ͍ •

    νʔϜϝϯόʔͷϨϏϡʔྗ͕ҭͨͳ͍ • ͍ͭ·Ͱ΋͋ΒΏΔ͜ͱ͕ଐਓతͰεέʔϧ͠ͳ͍૊৫ʹ…

  9. ͳͥʮϨϏϡʔ͓͡͞Μʯ͕
 ੜ·Εͯ͠·͏ͷ͔ • ৭ʑཧ༝͸͋Δͱࢥ͍·͢ • ௕͘ӡ༻ͯ͠ΔͷͰ৽ࢀϝϯόʔ͕͠Βͳ͍͜ͱ͕ଟ͍ • ϝϯόʔͷ࣮ྗ͕ࠩେ͖͍ • ͳΜͱͳ͘


    ̋̋͞Μ͕΍Βͳ͍ͱμϝͳؾ͕͢Δ or
 ࠷ॳʹ࡞ͬͨਓ͕ϨϏϡʔ͠ͳ͍ͱμϝͳؾ͕͢Δ or
 ͓ͬ͞Μ͕ϨϏϡʔ͠ͳ͍ͱμϝͳؾ͕͢Δ

  10. Ͱ΋͜Εͬͯ
 ͜͏͢Ε͹ղܾ͢ΔͷͰ͸ʁ • ௕͘ӡ༻ͯ͠ΔͷͰ৽ࢀϝϯόʔ͕͠Βͳ͍ ͜ͱ͕ଟ͍ • ϝϯόʔͷ࣮ྗ͕ࠩେ͖͍ • ͳΜͱͳ͘ →ֶ΂ʂ

    →஁͑Ζʂ →ཧ༝͕ͳ͍ͳΒࢭΊΑ͏ʂ

  11. ͜ΕΛղܾ͢ΔͨΊͷఏҊ νʔϜશһͰ
 ϨϏϡʔ͠Α͏

  12. ΋͠νʔϜશһͰϨϏϡʔ͢Δ Α͏ʹͳΔͱ • ୭΋͕ޓ͍ͷίʔυΛϨϏϡʔ͢Δ • ϓϩμΫτͷ੹೚͕ڞ༗͞ΕΔ • ίʔυͷ࢓༷Λ޿͘ڞ༗͢Δ • ݁Ռͱͯ͠ϨϏϡʔ͓͡͞Μ͕͍ͳ͘ͳΓɺ୭͔

    ͕ͭΒ͍ࢥ͍Λ͢Δ։ൃ͸ͳ͘ͳΔʂ
 …ͷ͔ʁ

  13. Α͋͘Δݱ࣮ ࣗ෼ͷλεΫͰखҰഋͩ ͔ΒϨϏϡʔ͢Δͷେม ࢓ࣄͰͦΜͳʹ ษڧͨ͘͠ͳ͍ ΍ͬͺΓԶ͕ϨϏϡʔ͠ͳ͍ͱෆ҆ ͪΌΜͱϨϏϡʔ
 Ͱ͖Δࣗ৴͕ͳ͍

  14. Ͱ΋ϨϏϡʔ͸΍Βͳ͍ͱ
 Ͱ͖ΔΑ͏ʹͳΔͷ͸೉͍͠ʢܦݧ্ʣ • ͷͰ΍ͬͺΓνʔϜͰϨϏϡʔΛճͤΔΑ͏ ʹͳͬͯཉ͍͠ͱݸਓతʹ͸ࢥ͏ • ͳͷͰνʔϜͰϨϏϡʔΛճ͠΍͘͢͢Δͨ Ίʹ࣮ࡍʹࢲ͕΍͍ͬͯΔtipsΛ͍͔ͭ͘঺հ

  15. ϨϏϡʔͯ͠΄͍͠಺༰ͷઆ໌Λ ৄࡉʹॻ͘Α͏ʹ࢓૊ΈԽ͢Δ • PullRequestͷDescriptionΛςϯϓϨԽ

  16. ϨϏϡΞʔ͸hubotͰ
 ެฏʹׂΓৼΔ • hubot pluginʰhubot-reviewer-lottoʱΛ࢖͏ https://github.com/sakatam/hubot-reviewer-lotto

  17. ϨϏϡΞʔΛؾݣ͏ • ʮ͜Ε΋͔ͨ͠͠Β೉͍͔͠΋ͳʙʯ
 ͱࢥͬͨΒϨϏϡΞʔʹ੠Λ͔͚ͯΈΔ • ͓ޓ͍ʹෆ໌ͳ఺Λฉ͖΍͘͢͢Δ
 งғؾͮ͘Γ͕ॏཁ

  18. ʮϨϏϡʔ=ษڧͷ৔ʯͱͯ͠ ೝࣝ͢Δ • ࢦఠ͢Δ͜ͱ͕ͳͯ͘΋࢓༷ͰΘ͔Βͳ͍ॴ͕͋ͬͨ Βੵۃతʹ࣭໰͢Δ • ࢦఠ͢Δ͜ͱ͕ͳͯ͘΋࣭໰͢Δ͚ͩͰ΋ϨϏϡΞʔɾ ϨϏϡʔΠ૒ํͷؾ͖ͮʹͭͳ͕Δࣄ͸ଟ͍ • ʮԿ͔ࢦఠ͠ͳ͍ͱ͍͚ͳ͍ʯͱ͍͏ϓϨογϟʔ͕

    ͋ΔͱϨϏϡʔͨ͘͠ͳ͘ͳΔɻੵۃతʹΈΜͳͰ࣭ ໰͋ͬͯͦ͠͏͍͏ϓϨογϟʔΛͳ͘͢͜ͱ͕ॏཁ

  19. ʮϨϏϡʔ=ษڧͷ৔ʯͱͯ͠ ೝࣝ͢Δ • ซͤͯಡΈ͍ͨ http://qiita.com/kkoide1332/items/c6ee6f007617114c8f0b

  20. ·ͱΊ • ίʔυϨϏϡʔ͓͡͞Μ͸ੜ·Ε΍͍͢ • ίʔυϨϏϡʔ͓͡͞Μ͕͍ΔνʔϜ͸͍Ζ ͍ΖͭΒ͍ • ΈΜͳͰίʔυϨϏϡʔΛճ͢͜ͱͰɺͭΒ ͍ίʔυϨϏϡʔ͔ΒϝϯόʔʹϝϦοτ͕ ͋ͬͯͭΒ͘ͳ͍ίʔυϨϏϡʔ΁