Slide 1
Slide 1 text
No content
Slide 2
Slide 2 text
No content
Slide 3
Slide 3 text
No content
Slide 4
Slide 4 text
No content
Slide 5
Slide 5 text
No content
Slide 6
Slide 6 text
No content
Slide 7
Slide 7 text
No content
Slide 8
Slide 8 text
No content
Slide 9
Slide 9 text
No content
Slide 10
Slide 10 text
No content
Slide 11
Slide 11 text
No content
Slide 12
Slide 12 text
No content
Slide 13
Slide 13 text
No content
Slide 14
Slide 14 text
No content
Slide 15
Slide 15 text
SwiftLint.lint(inline: true, directory: "Sources")
Slide 16
Slide 16 text
No content
Slide 17
Slide 17 text
build_file = File.join(ENV["CIRCLE_ARTIFACTS"], "xcode_build_raw.log")
# Sort the symbols, then grab the top 1000
most_expensive_swift_table = `…` # Some command-line stuff
# Look for statistical outliers in compile times
outliers = most_expensive_swift_table
.lines.map { |line| line.split.first.to_i }
.reject { |value| value "# 0 }
.outliers(3)
if outliers.any?
warn("Detected some Swift building time outliers")
headings = "Time | Class | Function |\n| ""$ | ----- | ----- |"
warnings = ""% # Construct a Markdown table
markdown(([headings] + warnings).join)
end
Slide 18
Slide 18 text
No content
Slide 19
Slide 19 text
No content
Slide 20
Slide 20 text
No content
Slide 21
Slide 21 text
# Ask to update Chinese docs if only English docs are updated and vice-versa.
en_docs_modified = git.modified_files.grep(%r{docs/}).empty?
cn_docs_modified = git.modified_files.grep(%r{docs_CN}).empty?
# xor operator ftw
if en_docs_modified ^ cn_docs_modified
warn("Consider "&also"& updating the "'
en_docs_modified ? "English" : "Chinese"
} docs.")
end
Slide 22
Slide 22 text
No content
Slide 23
Slide 23 text
No content
Slide 24
Slide 24 text
Webhook Events
LITERALLY
WHATEVER
YOU WANT
Slide 25
Slide 25 text
{
"settings": {
"ignored_repos": ["artsy/design", "artsy/hokusai"]
},
"rules": {
"( Jira integration
"pull_request": "org/allPRs.ts",
"pull_request.closed": ["org/closedPRs.ts", "org/jira/pr.ts"],
"pull_request.opened": "org/addPatchLabel.ts",
"( The RFC process
"issues": "org/rfc/addRFCToNewIssues.ts",
"issues.labeled": "org/rfc/scheduleRFCsForLabels.ts",
"( Merge on Green
"issue_comment": "org/markAsMergeOnGreen.ts",
"pull_request_review": "org/markAsMergeOnGreen.ts",
"status.success": "org/mergeOnGreen.ts"
},
"repos": {
"artsy/peril-settings": {
"pull_request.review_requested": "org/addReviewer.ts"
},
Slide 26
Slide 26 text
{
"settings": {
"ignored_repos": ["artsy/design", "artsy/hokusai"]
},
"rules": {
"( Jira integration
"pull_request": "org/allPRs.ts",
"pull_request.closed": ["org/closedPRs.ts", "org/jira/pr.ts"],
"pull_request.opened": "org/addPatchLabel.ts",
"( The RFC process
"issues": "org/rfc/addRFCToNewIssues.ts",
"issues.labeled": "org/rfc/scheduleRFCsForLabels.ts",
"( Merge on Green
"issue_comment": "org/markAsMergeOnGreen.ts",
"pull_request_review": "org/markAsMergeOnGreen.ts",
"status.success": "org/mergeOnGreen.ts"
},
"repos": {
"artsy/peril-settings": {
"pull_request.review_requested": "org/addReviewer.ts"
},
Slide 27
Slide 27 text
{
"settings": {
"ignored_repos": ["artsy/design", "artsy/hokusai"]
},
"rules": {
"( Jira integration
"pull_request": "org/allPRs.ts",
"pull_request.closed": ["org/closedPRs.ts", "org/jira/pr.ts"],
"pull_request.opened": "org/addPatchLabel.ts",
"( The RFC process
"issues": "org/rfc/addRFCToNewIssues.ts",
"issues.labeled": "org/rfc/scheduleRFCsForLabels.ts",
"( Merge on Green
"issue_comment": "org/markAsMergeOnGreen.ts",
"pull_request_review": "org/markAsMergeOnGreen.ts",
"status.success": "org/mergeOnGreen.ts"
},
"repos": {
"artsy/peril-settings": {
"pull_request.review_requested": "org/addReviewer.ts"
},
Slide 28
Slide 28 text
• Requires Per-repo setup
• Simpler to get started
• Ruby, JS, Swift, more…
• Setup once per GitHub Org
• Requires hosting
• Far more powerful
• TypeScript/JS
Slide 29
Slide 29 text
No content
Slide 30
Slide 30 text
export default async () ") {
const pr = danger.github.pr
if (pr.body.includes("#trivial")) {
return
}
const changelogs = ["CHANGELOG.md", "changelog.md", "CHANGELOG.yml"]
"( Some code to check if the repo has one of these files in it.
if (isPROpen "* repoHasChangelog) {
const files = [""%danger.git.modified_files, ""%danger.git.created_files]
const hasCodeChanges = files.find(file ") !file.match(/(test|spec)/i))
const hasChangelogChanges = files.find(file ") changelogs.includes(file))
if (hasCodeChanges "* !hasChangelogChanges) {
warn("…")
}
}
}
Slide 31
Slide 31 text
No content
Slide 32
Slide 32 text
import { danger, warn, fail } from "danger"
const mobileRepos = ["eigen", "emission", "eidolon", "energy", "emergence"]
export default async () ") {
const pr = danger.github.pr
const isMobileRepo = mobileRepos.filter(name ")
pr.base.repo.name.endsWith(name)
).length > 0
if (isMobileRepo "* pr.head.repo.fork) {
try {
"( Are they a member of the Artsy GitHub org? This will throw if not.
await danger.github.api.orgs.checkMembership(
{ org: "artsy", username: pr.user.login }
)
fail("…")
} catch (error) {
"( They are not.
}
}
}
Slide 33
Slide 33 text
No content
Slide 34
Slide 34 text
No content
Slide 35
Slide 35 text
No content
Slide 36
Slide 36 text
github.com/artsy/peril-settings
Slide 37
Slide 37 text
No content
Slide 38
Slide 38 text
No content
Slide 39
Slide 39 text
No content
Slide 40
Slide 40 text
React Component Primitives
Web Component Library
Artsy.net Website
Slide 41
Slide 41 text
No content
Slide 42
Slide 42 text
No content
Slide 43
Slide 43 text
No content
Slide 44
Slide 44 text
No content
Slide 45
Slide 45 text
No content
Slide 46
Slide 46 text
No content
Slide 47
Slide 47 text
No content
Slide 48
Slide 48 text
No content
Slide 49
Slide 49 text
No content
Slide 50
Slide 50 text
No content
Slide 51
Slide 51 text
No content
Slide 52
Slide 52 text
No content
Slide 53
Slide 53 text
No content
Slide 54
Slide 54 text
No content
Slide 55
Slide 55 text
No content
Slide 56
Slide 56 text
No content
Slide 57
Slide 57 text
No content
Slide 58
Slide 58 text
No content
Slide 59
Slide 59 text
No content
Slide 60
Slide 60 text
No content