Upgrade to Pro — share decks privately, control downloads, hide ads and more …

How Artsy Automates Team Culture

How Artsy Automates Team Culture

Ash Furrow

May 31, 2019
Tweet

More Decks by Ash Furrow

Other Decks in Technology

Transcript

  1. View Slide

  2. View Slide

  3. View Slide

  4. View Slide

  5. View Slide

  6. View Slide

  7. View Slide

  8. View Slide

  9. View Slide

  10. View Slide

  11. View Slide

  12. View Slide

  13. View Slide

  14. View Slide

  15. SwiftLint.lint(inline: true, directory: "Sources")

    View Slide

  16. View Slide

  17. build_file = File.join(ENV["CIRCLE_ARTIFACTS"], "xcode_build_raw.log")
    # Sort the symbols, then grab the top 1000
    most_expensive_swift_table = `…` # Some command-line stuff
    # Look for statistical outliers in compile times
    outliers = most_expensive_swift_table
    .lines.map { |line| line.split.first.to_i }
    .reject { |value| value "# 0 }
    .outliers(3)
    if outliers.any?
    warn("Detected some Swift building time outliers")
    headings = "Time | Class | Function |\n| ""$ | ----- | ----- |"
    warnings = ""% # Construct a Markdown table
    markdown(([headings] + warnings).join)
    end

    View Slide

  18. View Slide

  19. View Slide

  20. View Slide

  21. # Ask to update Chinese docs if only English docs are updated and vice-versa.
    en_docs_modified = git.modified_files.grep(%r{docs/}).empty?
    cn_docs_modified = git.modified_files.grep(%r{docs_CN}).empty?
    # xor operator ftw
    if en_docs_modified ^ cn_docs_modified
    warn("Consider "&also"& updating the "'
    en_docs_modified ? "English" : "Chinese"
    } docs.")
    end

    View Slide

  22. View Slide

  23. View Slide

  24. Webhook Events
    LITERALLY
    WHATEVER
    YOU WANT

    View Slide

  25. {
    "settings": {
    "ignored_repos": ["artsy/design", "artsy/hokusai"]
    },
    "rules": {
    "( Jira integration
    "pull_request": "org/allPRs.ts",
    "pull_request.closed": ["org/closedPRs.ts", "org/jira/pr.ts"],
    "pull_request.opened": "org/addPatchLabel.ts",
    "( The RFC process
    "issues": "org/rfc/addRFCToNewIssues.ts",
    "issues.labeled": "org/rfc/scheduleRFCsForLabels.ts",
    "( Merge on Green
    "issue_comment": "org/markAsMergeOnGreen.ts",
    "pull_request_review": "org/markAsMergeOnGreen.ts",
    "status.success": "org/mergeOnGreen.ts"
    },
    "repos": {
    "artsy/peril-settings": {
    "pull_request.review_requested": "org/addReviewer.ts"
    },

    View Slide

  26. {
    "settings": {
    "ignored_repos": ["artsy/design", "artsy/hokusai"]
    },
    "rules": {
    "( Jira integration
    "pull_request": "org/allPRs.ts",
    "pull_request.closed": ["org/closedPRs.ts", "org/jira/pr.ts"],
    "pull_request.opened": "org/addPatchLabel.ts",
    "( The RFC process
    "issues": "org/rfc/addRFCToNewIssues.ts",
    "issues.labeled": "org/rfc/scheduleRFCsForLabels.ts",
    "( Merge on Green
    "issue_comment": "org/markAsMergeOnGreen.ts",
    "pull_request_review": "org/markAsMergeOnGreen.ts",
    "status.success": "org/mergeOnGreen.ts"
    },
    "repos": {
    "artsy/peril-settings": {
    "pull_request.review_requested": "org/addReviewer.ts"
    },

    View Slide

  27. {
    "settings": {
    "ignored_repos": ["artsy/design", "artsy/hokusai"]
    },
    "rules": {
    "( Jira integration
    "pull_request": "org/allPRs.ts",
    "pull_request.closed": ["org/closedPRs.ts", "org/jira/pr.ts"],
    "pull_request.opened": "org/addPatchLabel.ts",
    "( The RFC process
    "issues": "org/rfc/addRFCToNewIssues.ts",
    "issues.labeled": "org/rfc/scheduleRFCsForLabels.ts",
    "( Merge on Green
    "issue_comment": "org/markAsMergeOnGreen.ts",
    "pull_request_review": "org/markAsMergeOnGreen.ts",
    "status.success": "org/mergeOnGreen.ts"
    },
    "repos": {
    "artsy/peril-settings": {
    "pull_request.review_requested": "org/addReviewer.ts"
    },

    View Slide

  28. • Requires Per-repo setup
    • Simpler to get started
    • Ruby, JS, Swift, more…
    • Setup once per GitHub Org
    • Requires hosting
    • Far more powerful
    • TypeScript/JS

    View Slide

  29. View Slide

  30. export default async () ") {
    const pr = danger.github.pr
    if (pr.body.includes("#trivial")) {
    return
    }
    const changelogs = ["CHANGELOG.md", "changelog.md", "CHANGELOG.yml"]
    "( Some code to check if the repo has one of these files in it.
    if (isPROpen "* repoHasChangelog) {
    const files = [""%danger.git.modified_files, ""%danger.git.created_files]
    const hasCodeChanges = files.find(file ") !file.match(/(test|spec)/i))
    const hasChangelogChanges = files.find(file ") changelogs.includes(file))
    if (hasCodeChanges "* !hasChangelogChanges) {
    warn("…")
    }
    }
    }

    View Slide

  31. View Slide

  32. import { danger, warn, fail } from "danger"
    const mobileRepos = ["eigen", "emission", "eidolon", "energy", "emergence"]
    export default async () ") {
    const pr = danger.github.pr
    const isMobileRepo = mobileRepos.filter(name ")
    pr.base.repo.name.endsWith(name)
    ).length > 0
    if (isMobileRepo "* pr.head.repo.fork) {
    try {
    "( Are they a member of the Artsy GitHub org? This will throw if not.
    await danger.github.api.orgs.checkMembership(
    { org: "artsy", username: pr.user.login }
    )
    fail("…")
    } catch (error) {
    "( They are not.
    }
    }
    }

    View Slide

  33. View Slide

  34. View Slide

  35. View Slide

  36. github.com/artsy/peril-settings

    View Slide

  37. View Slide

  38. View Slide

  39. View Slide

  40. React Component Primitives
    Web Component Library
    Artsy.net Website

    View Slide

  41. View Slide

  42. View Slide

  43. View Slide

  44. View Slide

  45. View Slide

  46. View Slide

  47. View Slide

  48. View Slide

  49. View Slide

  50. View Slide

  51. View Slide

  52. View Slide

  53. View Slide

  54. View Slide

  55. View Slide

  56. View Slide

  57. View Slide

  58. View Slide

  59. View Slide

  60. View Slide