Upgrade to Pro — share decks privately, control downloads, hide ads and more …

誰が為のPull Requestか？

Avatar for Hiroya Hinomori(KTC) Hiroya Hinomori(KTC)
May 15, 2024
0
100

誰が為のPull Requestか？

Avatar for Hiroya Hinomori(KTC)

Hiroya Hinomori(KTC)

May 15, 2024
Tweet

More Decks by Hiroya Hinomori(KTC)

See All by Hiroya Hinomori(KTC)
iOSDC初出展までにした事を共有したい
Avatar for Hiroya Hinomori(KTC) ktchiroyah
0
110
エンジニアが開発生産性を上げるためにやる最初の一歩
Avatar for Hiroya Hinomori(KTC) ktchiroyah
0
320
内製化でクルマの未来を作るぼくらの話
Avatar for Hiroya Hinomori(KTC) ktchiroyah
0
82

Featured

See All Featured
Navigating Weather and Climate Data
Avatar for Ryan Abernathey rabernat
0
73
CoffeeScript is Beautiful & I Never Want to Write Plain JavaScript Again
Avatar for Sam Stephenson sstephenson
162
16k
How to Talk to Developers About Accessibility
Avatar for Jason CranfordTeague jct
1
100
Mobile First: as difficult as doing things right
Avatar for Swwweet swwweet
225
10k
Designing Dashboards & Data Visualisations in Web Apps
Avatar for Des Traynor destraynor
231
54k
Building Applications with DynamoDB
Avatar for Matt Wood mza
96
6.9k
DevOps and Value Stream Thinking: Enabling flow, efficiency and business value
Avatar for Helen Beal helenjbeal
1
85
Principles of Awesome APIs and How to Build Them.
Avatar for Keavy McMinn keavy
127
17k
Impact Scores and Hybrid Strategies: The future of link building
Avatar for Tamara Novitovic tamaranovitovic
0
190
How to train your dragon (web standard)
Avatar for Monica Dinculescu notwaldorf
97
6.5k
A designer walks into a library…
Avatar for Paul Jervis Heath pauljervisheath
210
24k
How People are Using Generative and Agentic AI to Supercharge Their Products, Projects, Services and Value Streams Today
Avatar for Helen Beal helenjbeal
1
99

Transcript

  1. 誰が為の Pull Requestか？ モバイル開発グループ 日野森 寛也

  2. みなさん

  3. Pull Request をお願いする時

  4. 自分が書いたコードを ちゃんと説明できてますか？

  5. コード書いたんだから見てよ！ 急いでるから早くApproveくださいいい！

  6. Point 1 PRの中に入れる変更内容は そのPRに沿った内容になっているか？

  7. Point2 難しい仕様や、伝わりづらそうな実装内容に コメントを添える

  8. Point3 PRのテンプレートをうまく活用していきましょう

  9. 🍶