Upgrade to Pro — share decks privately, control downloads, hide ads and more …

誰が為のPull Requestか？

Sponsored · Your Podcast. Everywhere. Effortlessly. Share. Educate. Inspire. Entertain. You do you. We'll handle the rest. →
Avatar for Hiroya Hinomori(KTC) Hiroya Hinomori(KTC)
May 15, 2024
0
110

誰が為のPull Requestか？

Avatar for Hiroya Hinomori(KTC)

Hiroya Hinomori(KTC)

May 15, 2024
Tweet

More Decks by Hiroya Hinomori(KTC)

See All by Hiroya Hinomori(KTC)
iOSDC初出展までにした事を共有したい
Avatar for Hiroya Hinomori(KTC) ktchiroyah
0
120
エンジニアが開発生産性を上げるためにやる最初の一歩
Avatar for Hiroya Hinomori(KTC) ktchiroyah
0
320
内製化でクルマの未来を作るぼくらの話
Avatar for Hiroya Hinomori(KTC) ktchiroyah
0
82

Featured

See All Featured
Into the Great Unknown - MozCon
Avatar for Noah Learner thekraken
40
2.3k
From Legacy to Launchpad: Building Startup-Ready Communities
Avatar for Dug Song dugsong
0
140
[SF Ruby Conf 2025] Rails X
Avatar for Vladimir Dementyev palkan
1
760
Reflections from 52 weeks, 52 projects
Avatar for Jefferson Lam jeffersonlam
356
21k
Measuring Dark Social's Impact On Conversion and Attribution
Avatar for Stephen Akadiri stephenakadiri
1
130
Sharpening the Axe: The Primacy of Toolmaking
Avatar for Bryan Cantrill bcantrill
46
2.7k
Connecting the Dots Between Site Speed, User Experience & Your Business [WebExpo 2025]
Avatar for Tammy Everts tammyeverts
11
830
Being A Developer After 40
Avatar for Adrian Kosmaczewski akosma
91
590k
Visualization
Avatar for Eitan Lees eitanlees
150
17k
Breaking role norms: Why Content Design is so much more than writing copy - Taylor Woolridge
Avatar for UX Y'all uxyall
0
170
The Organizational Zoo: Understanding Human Behavior Agility Through Metaphoric Constructive Conversations (based on the works of Arthur Shelley, Ph.D)
Avatar for Dr. Kim W Petersen kimpetersen
PRO
0
240
sira's awesome portfolio website redesign presentation
Avatar for ElsiraPls elsirapls
0
150

Transcript

  1. 誰が為の Pull Requestか？ モバイル開発グループ 日野森 寛也

  2. みなさん

  3. Pull Request をお願いする時

  4. 自分が書いたコードを ちゃんと説明できてますか？

  5. コード書いたんだから見てよ！ 急いでるから早くApproveくださいいい！

  6. Point 1 PRの中に入れる変更内容は そのPRに沿った内容になっているか？

  7. Point2 難しい仕様や、伝わりづらそうな実装内容に コメントを添える

  8. Point3 PRのテンプレートをうまく活用していきましょう

  9. 🍶