Aviasales Отели - практический опыт объединения двух приложений

Transcript

1. Практический опыт объединения двух приложений Евгений Шишкин, Aviasales +
2. Hotellook — метапоиск отелей
3. 700 000 hotels 205 countries
5. Try to merge
6. +
7. Git
8. Mono-Repository
9. AS HL
10. AS HL HL Features
11. AS HL HL Features
12. AS HL HL Features
13. AS HL HL Features AS Features
14. AS HL HL Features AS Features
15. AS HL HL Features AS Features
16. AS HL HL Features HL Release AS Features
17. AS HL HL Features HL Release AS Features
18. AS HL HL Features HL Release AS Features hl_5.1.0
19. AS HL HL Features HL Release AS Features hl_5.1.0
20. AS HL HL Features HL Release AS Features hl_5.1.0
21. AS HL HL Features HL Release AS Release AS Features hl_5.1.0
22. AS HL HL Features HL Release AS Release AS Features hl_5.1.0
23. AS HL HL Features HL Release AS Release AS Features hl_5.1.0 as_3.4.0
24. AS HL HL Features HL Release AS Release AS Features hl_5.1.0 as_3.4.0
25. AS HL HL Features HL Release AS Release AS Features hl_5.1.0 as_3.4.0
26. Renaming
27. Hotellook hl_app/ hl_wear/ hl_core/ hl_base/ hl_location/ hl_maps/ hl_utils/ Modules Aviasales as_app/ as_wear/ as_core/
28. Hotellook/ res/ color/ hl_color.xml drawable/ hl_drawable.xml layout/ hl_layout.xml menu/ hl_menu.xml … Aviasales/ res/ color/ color.xml drawable/ drawable.xml layout/ layout.xml menu/ menu.xml … Resources
29. Dependencies
30. OutOfMemoryError
31. OutOfMemoryError android:largeHeap="true"
32. Mainframer
33. Mainframer Tool that allows you to move build process from a local machine to a remote one.
34. • CPU: Intel Core i7-8700K • Motherboard: MSI Z370 • Memory: DDR4 Corsair 2x16Gb 3200MHz • SSD: Samsung 970 PRO • …
35. • CPU: Intel Core i7-8700K • Motherboard: MSI Z370 • Memory: DDR4 Corsair 2x16Gb 3200MHz • SSD: Samsung 970 PRO • … ≈ 100k RUB
36. • CPU: Intel Core i7-8700K • Motherboard: MSI Z370 • Memory: DDR4 Corsair 2x16Gb 3200MHz • SSD: Samsung 970 PRO • … ≈ 100k RUB cheaper than slowest mbp 13
37. 3x faster builds
39. Insides
40. 1. Permissions
41. Check List • Base on RxJava • Singleton • Mockable • SuppoF logging
42. API
43. PermissionCheckResult PermissionGranted PermissionDenied val permission: String val permission: String val shouldShowRequestPermissionRationale: Boolean Result
44. request(Manifest.permission.ACCESS_FINE_LOCATION)
45. subscribe() request(Manifest.permission.ACCESS_FINE_LOCATION)
46. subscribe() request(Manifest.permission.ACCESS_FINE_LOCATION)
47. subscribe() false request(Manifest.permission.ACCESS_FINE_LOCATION)
48. subscribe() subscribe() false request(Manifest.permission.ACCESS_FINE_LOCATION)
49. subscribe() subscribe() false request(Manifest.permission.ACCESS_FINE_LOCATION)
50. subscribe() subscribe() false true request(Manifest.permission.ACCESS_FINE_LOCATION)
51. requestSingle(Manifest.permission.ACCESS_FINE_LOCATION) subscribe() subscribe() PermissionDenied PermissionGranted
52. requestEach( Manifest.permission.CAMERA, Manifest.permission.ACCESS_FINE_LOCATION)
53. requestEach( Manifest.permission.CAMERA, Manifest.permission.ACCESS_FINE_LOCATION) subscribe()
54. subscribe() requestEach( Manifest.permission.CAMERA, Manifest.permission.ACCESS_FINE_LOCATION)
55. requestEach( Manifest.permission.CAMERA, Manifest.permission.ACCESS_FINE_LOCATION) subscribe()
56. requestEach( Manifest.permission.CAMERA, Manifest.permission.ACCESS_FINE_LOCATION) subscribe() PermissionDenied ACCESS_FINE_LOCATION
57. requestEach( Manifest.permission.CAMERA, Manifest.permission.ACCESS_FINE_LOCATION) subscribe() PermissionDenied PermissionGranted ACCESS_FINE_LOCATION READ_CONTACTS
58. requestEach( Manifest.permission.CAMERA, Manifest.permission.ACCESS_FINE_LOCATION) subscribe() PermissionDenied PermissionGranted ACCESS_FINE_LOCATION READ_CONTACTS
59. require(Manifest.permission.ACCESS_FINE_LOCATION)
60. require(Manifest.permission.ACCESS_FINE_LOCATION) subscribe()
61. require(Manifest.permission.ACCESS_FINE_LOCATION) subscribe()
62. require(Manifest.permission.ACCESS_FINE_LOCATION) subscribe() PermissionsDeniedException
63. require(Manifest.permission.ACCESS_FINE_LOCATION) subscribe() subscribe() PermissionsDeniedException
64. require(Manifest.permission.ACCESS_FINE_LOCATION) subscribe() subscribe() PermissionsDeniedException
65. require(Manifest.permission.ACCESS_FINE_LOCATION) subscribe() subscribe() PermissionsDeniedException
66. Mockable class Permissions( private val permissionsHandler: PermissionsHandler, private val logger: ((message: String) -> Unit)? = null )
67. Mockable interface PermissionsHandler { fun checkPermissions(vararg permissions: String): Observable<PermissionCheckResult> fun requestPermissions(vararg permissions: String): Observable<PermissionCheckResult> }
68. Singleton abstract class PermissionsDelegate<in T : Any> : PermissionsHandler { fun attach(component: T) {…} fun detach() {…} fun onRequestPermissionsResult(requestCode: Int, permissions: Array<out String>, grantResults: IntArray) {…} PermissionsActivityDelegate PermissionsFragmentDelegate
69. Logging class Permissions( private val permissionsHandler: PermissionsHandler, private val logger: ((message: String) -> Unit)? = null ) Permissions: Request android.permission.CAMERA, android.permission.ACCESS_FINE_LOCATION Permissions: PermissionDenied(permission=android.permission.CAMERA, shouldShowRequestPermissionRationale=false) Permissions: PermissionGranted(permission=android.permission.ACCESS_FINE_LOCATION)
70. hips://github.com/JetradarMobile/mrbutler
71. 2. Navigation
73. Navigation Navigation #1 Navigation #2 Navigation #3 Navigation #4 Navigator Router Activity Application * Command 1_1 * Command 1_2 * Command 1_3 * Command 2_1 * Command 2_2 * Command 2_3 * Command 3_1 * Command 3_2 * Command 3_3 * Command 4_1 * Command 4_2 * Command 4_3
74. hips://github.com/JetradarMobile/nautilus
75. Thank you @johnkill