Code Review-Review is the Manager's Job

Expanded version of https://hecate.co/blog/code-review-review-is-the-managers-job prepared for YOW CTO Summit Melbourne 2018

Transcript

1. Code review-review is the manager’s job @johnbarton
2. Make time (nearly) every day to systematically review (nearly) all your team’s pull requests
3. Standard Disclaimers • This is all post hoc rationalisation of me doing what I wanted while luck played its always critical role • There is a smoothing of narrative and an aspirational high water mark I never reached anyway
6. Code review is an engineering task
9. Building Healthy Organisational Incentives https://medium.com/@kswanson/bu ilding-healthy-organizational-incenti ves-91b051c57b76 Culture is the Behavior You Reward and Punish https://jocelyngoldfein.com/culture-i s-the-behavior-you-reward-and-punis h-7e8e75c6543e
10. 現場 [Gemba]
14. Process & Collaboration Technical Outcome
15. Process & Collaboration Technical Outcome What are Rockstars Doing Today? The Downward Spiral Gold Comfort Eagle
22. if (convinced) { days.map((day) => { let thoughts = reviewPRs(day); saveToDiary(thoughts); nudgeTeam(thoughts); } }
23. visit(“hecate.co”); follow(“@johnbarton”);