Reviewing Kotlin Code

Reviewing Kotlin Code

The talk is about looking into the kotlin language features and their right usage in feature development

Transcript

1. Reviewing Kotlin Code How we do it @rachitkmishra
2. Rachit Mishra @rachitkmishra Topics Why code reviews? The Context The Review
3. Why Code Reviews Provide Positive Feedback Make sure code design and quality is consistent and performant Knowledge Sharing
4. Code Reviews The Good Understand the context Looks for edge cases and test coverage Suggests changes along with code samples Provides suggestions with external sources Maintains empathy in conversation Inspires Encourages good code
5. The Context (Before PR) New Feature Github issue Team onboard Assign Pair Code
6. The Process (After PR)... CI Danger, Ktlint, Errorprone Unit Tests Self Review Peer Review Merge to dev New PR
7. The code review Top down approach High Immutability Low Complexity Pure functions Simpler classes SOLID Principles DRY, YAGNI Low Coupling Single Responsibility
8. Basics & Functions Platform types Using conditionals as expressions Default values Pure functions Lesser branches Single level of Abstraction (SLAP functions)
9. Functions ... Using local functions Using extension functions Using lambda functions Inline functions Top level functions Higher order functions (with, apply, let) Function References vs Lambda functions
10. Classes Prefer DI Delegation with property delegation Delegation with lateinit Delegation with interface delegation Data classes Objects
11. Classes ... Lambda calls in place of SAM Default implementation in Interface Hiding abstractions Enum classes Sealed classes
12. The std library ... Immutable collections Property delegates Standard functions (with, apply, let) Extension functions on collections, types Ex. subscriptions.map { it.expiredOn }.any { it != null }
13. Questions
14. Thank you Rachit Mishra @rachitkmishra Practo Engineering @practodev
15. References https://github.com/shyiko/ktlint Core Design Principles https://www.youtube.com/watch?v=llGgO74uXMI Effective Kotlin https://www.youtube.com/watch?v=lU8kafFjUJM Code Reviews: Honesty, Kindness, Inspiration https://www.youtube.com/watch?v=hP_2XKYia9I http://www.bettercode.reviews/