JUnitで学ぶTest smells撃退法 / How to resolve Test smells using JUnit5

スクラムフェス新潟2023で発表した際に使用した資料です！
https://confengine.com/conferences/scrum-fest-niigata-2023/proposal/18389/junittest-smells

Transcript

1. 
   εΫϥϜϑΣε৽ׁ
   BLJN !"LJ@.PPO@
   
   +6OJUͰֶͿ5FTUTNFMMTܸୀ๏
   

   View Slide

2. ࣗݾ঺հ
   w ໊લBLJN !"LJ@.PPO@
   
   w
   w झຯίϛϡχςΟ׆ಈ ճ೥
   
   w ΦϯϥΠϯᷤ০۠ຽ
   

   View Slide

3. 5FTU4NFMMT
   

   View Slide

4. 5FTU4NFMMT
   w .BSUJO'PXMFSͷʮϦϑΝΫλϦϯάʙطଘͷίʔυΛ҆શʹվળ͢Δʙʯ͔ΒΠϯεύΠΞ
   ͞Εͨ5FTU$PEFͷʮෆ٢ͳष͍ʯ
   w l3FGBDUPSJOH5FTU$PEFz ࿦จ
   ͕ॳग़
   w l3FGBDUPSJOH5FTU$PEFzͷ಺༰ΛʮY6OJU5FTU1BUUFSOT3FGBDUPSJOH5FTU$PEFʯͰମܥ
   తʹ੔ཧ
   w $PEF4NFMMT#FIBWJPS4NFMMT1SPKFDU4NFMMTͷΧςΰϦ͔Βߏ੒͞ΕΔ
   

   View Slide

5. 5FTU4NFMMT
   w $PEF4NFMMT
   w 0CTDVSF5FTU
   w $POEJUJPOBM5FTU-PHJD
   w )BSEUP5FTU$PEF
   w 5FTU$PEF%VQMJDBUJPO
   w 5FTU-PHJDJO1SPEVDUJPO
   w #FIBWJPS4NFMMT
   w "TTFSUJPO3PVMFUUF
   w &SSBUJD5FTU
   w 'SBHJMF5FTU
   w 'SFRVFOU%FCVHHJOH
   w .BOVBM*OUFSWFOUJPO
   w 4MPX5FTUT
   w 1SPKFDU4NFMMT
   w #VHHZ5FTUT
   w %FWFMPQFST/PU8SJUJOH5FTUT
   w )JHI5FTU.BJOUFOBODF$PTU
   w 1SPEVDUJPO#VHT
   IUUQYVOJUQBUUFSOTDPN5FTU4NFMMTIUNM
   

   View Slide

6. 5FTU4NFMMTʹ·ͭΘΔ4VSWFZ
   w 5FTU4NFMMTͷ਺͕ଟ͍ίʔυ͸ίʔυͷมߋ༰қੑ͕௿ܽؕ͘཰͕ߴ͍
   )BJUBP8V 3VJEJ:JO +JBOIVB(BP ;JKJF)VBOH )VBKVO)VBOHl5P8IBU&YUFOU$BO$PEF2VBMJUZCF*NQSPWFECZ&MJNJOBUJOH5FTU4NFMMT z
   w 5FTU4NFMMTͷൃੜ཰͸ΞϓϦέʔγϣϯͷυϝΠϯ΍छผʹґଘ͠ͳ͍
   "1FSVNB ,"MNBMLJ $%/FXNBO .8.LBPVFS "0VOJ BOE'1BMPNCB l0OUIFEJTUSJCVUJPOPGUFTUTNFMMTJOPQFOTPVSDF"OESPJEBQQMJDBUJPOT"OFYQMPSBUPSZTUVEZ z
   /4+VOJPS -34PBSFT -".BSUJOT BOE*.BDIBEP l"TVSWFZPOUFTUQSBDUJUJPOFST`BXBSFOFTTPGUFTUTNFMMT z
   w 5FTU4NFMMT͕͋ΔίʔυΛݟͨ։ൃऀͷ͕ʮςετίʔυͷՄಡੑ͕௿͍ʯͱճ౴
   4PBSFT &MWZT3JCFJSP .ÂSDJP"NBSBM (VJMIFSNF(IFZJ 3PIJU'FSOBOEFT -FP(BSDJB "MFTTBOESP'POTFDB #BMEPJOP4BOUPT "OESÉl3FGBDUPSJOH5FTU4NFMMT"1FSTQFDUJWFGSPN0QFO4PVSDF
   %FWFMPQFSTz
   w ଟ͘ͷ։ൃऀ͸5FTU4NFMMT͕͋Δίʔυʹʮ໰୊͕͋Δʯͱճ౴͢Δ͕໰୊ͷཧ༝͸ݴ͑ͳ͍
   +%F#MFTFS %%J/VDDJ BOE$%F3PPWFS l"TTFTTJOHEJ
   ff
   VTJPOBOEQFSDFQUJPOPGUFTUTNFMMTJO4DBMBQSPKFDUTz
   

   View Slide

7. 5FTU4NFMMT͕ຒΊࠐ·ΕΔഎܠ
   

   View Slide

8. 5FTU4NFMMT͕ຒΊࠐ·ΕΔഎܠ
   w ςετίʔυͷࣗಈੜ੒πʔϧ
   /4+VOJPS -34PBSFT -".BSUJOT BOE*.BDIBEP l"TVSWFZPOUFTUQSBDUJUJPOFST`BXBSFOFTTPGUFTUTNFMMTz
   w ձࣾͷzඪ४Խzࢪࡦ
   /4+VOJPS -34PBSFT -".BSUJOT BOE*.BDIBEP l"TVSWFZPOUFTUQSBDUJUJPOFST`BXBSFOFTTPGUFTUTNFMMTz
   w 5FTU4NFMMT͕͋ͬͯ΋ॆ෼ಡΈ΍͍ͩ͢Ζ͏ͱ͍͏
   ݸਓͷࢥ͍ࠐΈ
   /4+VOJPS -34PBSFT -".BSUJOT BOE*.BDIBEP l"TVSWFZPOUFTUQSBDUJUJPOFST`BXBSFOFTTPGUFTUTNFMMT z
   w ΞʔΩςΫνϟ্ͷ౎߹ ॥؀ࢀর΍ΞΫηεϏϦςΟͳͲ
   
   .BOVFM%F4UFGBOP 'BCJBOP1FDPSFMMJ %BSJP%J/VDDJ BOE"OESFB%F-VDJB l"QSFMJNJOBSZFWBMVBUJPOPOUIFSFMBUJPOTIJQBNPOHBSDIJUFDUVSBMBOEUFTUTNFMMTz
   w ςεςΟϯάϑϨʔϜϫʔΫͷ౎߹্5FTU4NFMMT͕ൃੜ͢Δͱߟ͍͑ͯΔ
   %POH+BF,JN /JLPMBPT5TBOUBMJT 5TFTVO 1FUFS
   $IFO BOE+JORJV:BOH l4UVEZJOH5FTU"OOPUBUJPO.BJOUFOBODFJOUIF8JMEz
   

   View Slide

9. 5FTU4NFMMT͕ຒΊࠐ·ΕΔഎܠ
   w ςετίʔυͷࣗಈੜ੒πʔϧ
   /4+VOJPS -34PBSFT -".BSUJOT BOE*.BDIBEP l"TVSWFZPOUFTUQSBDUJUJPOFST`BXBSFOFTTPGUFTUTNFMMTz
   w ձࣾͷzඪ४Խzࢪࡦ
   /4+VOJPS -34PBSFT -".BSUJOT BOE*.BDIBEP l"TVSWFZPOUFTUQSBDUJUJPOFST`BXBSFOFTTPGUFTUTNFMMTz
   w 5FTU4NFMMT͕͋ͬͯ΋ॆ෼ಡΈ΍͍ͩ͢Ζ͏ͱ͍͏
   ݸਓͷࢥ͍ࠐΈ
   /4+VOJPS -34PBSFT -".BSUJOT BOE*.BDIBEP l"TVSWFZPOUFTUQSBDUJUJPOFST`BXBSFOFTTPGUFTUTNFMMT z
   w ΞʔΩςΫνϟ্ͷ౎߹ ॥؀ࢀর΍ΞΫηεϏϦςΟͳͲ
   
   .BOVFM%F4UFGBOP 'BCJBOP1FDPSFMMJ %BSJP%J/VDDJ BOE"OESFB%F-VDJB l"QSFMJNJOBSZFWBMVBUJPOPOUIFSFMBUJPOTIJQBNPOHBSDIJUFDUVSBMBOEUFTUTNFMMTz
   w ςεςΟϯάϑϨʔϜϫʔΫͷ౎߹্5FTU4NFMMT͕ൃੜ͢Δͱߟ͍͑ͯΔ
   %POH+BF,JN /JLPMBPT5TBOUBMJT 5TF)TVO 1FUFS
   $IFO BOE+JORJV:BOH l4UVEZJOH5FTU"OOPUBUJPO.BJOUFOBODFJOUIF8JMEz
   ຊൃදͷείʔϓ
   

   View Slide

10. 5FTUJOH'SBNFXPSL +6OJU
    ͱ5FTU4NFMMT
    

    View Slide

11. 5FTUJOH'SBNFXPSL +6OJU
    ͱ5FTU4NFMMT
    w +BWBͷࣗಈςετϑϨʔϜϫʔΫͷσϑΝΫτελϯμʔυ
    w ʹ+6OJU͕ϦϦʔε
    IUUQTHJUIVCDPNKVOJUUFBNKVOJUSFMFBTFTUBHS
    w ܧଓతϦϦʔε͕͞Ε͓ͯΓɺݱࡏͷ࠷৽൛͸
    IUUQTKVOJUPSHKVOJUEPDTDVSSFOUVTFSHVJEF
    w +6OJU΍+6OJUͰ͸ϑϨʔϜϫʔΫ౎߹Ͱ5FTU4NFMMT͕ൃੜ͢Δέʔε΋͋
    ͕ͬͨɺ+6OJUͰͦΕ͕ղফ͞Ε͍ͯΔ৔߹͕ଟ͍
    

    View Slide

12. 5FTUJOH'SBNFXPSL +6OJU
    ͱ5FTU4NFMMT
    w +BWBͰॻ͔Εͨ044Λௐࠪͨ݁͠Ռɺ೥࣌఺ͰͷϓϩδΣΫτ
    Ͱ͔͠+6OJU͕ར༻͞Ε͍ͯͳ͍
    &MWZT4PBSFT .BSDJP3JCFJSP 3PIJU(IFZJ (VJMIFSNF"NBSBM BOE"OESF4BOUPT 3FGBDUPSJOH5FTU4NFMMT8JUI+6OJU8IZ4IPVME%FWFMPQFST,FFQ6QUP%BUF
    
    
    +6OJU +6OJU
    

    View Slide

13. 5FTUJOH'SBNFXPSL +6OJU
    ͱ5FTU4NFMMT
    w +6OJUͰ௥Ճ͞Εͨ৽ػೳͷग़ݱ཰ʹ͸ภΓ͕͋Δ
    &MWZT4PBSFT .BSDJP3JCFJSP 3PIJU(IFZJ (VJMIFSNF"NBSBM BOE"OESF4BOUPT 3FGBDUPSJOH5FTU4NFMMT8JUI+6OJU8IZ4IPVME%FWFMPQFST,FFQ6QUP%BUF
    
    
    
    
    $VTUPN&YUFOTJPOT
    &YDFQUJPO5FTUJOH
    1BSBNFUFSJ[FEUFTUT
    0UIFS
    

    View Slide

14. +6OJUΛ׆༻ͨ͠5FTU4NFMMTܸୀ๏
    

    View Slide

15. "TTFSUJPO3PVMFUUF
    ʙ+6OJUΛ׆༻ͨ͠5FTU4NFMMTܸୀ๏ʙ
    Ұͭ'BJMͯ͠΋·ͱΊͯΞαʔγϣϯͯ͘͠ΕΔ
    "TTFSU&RVBMT
    ΛผςετͰߦ͏ܗͰରॲ͢΂͖৔߹΋͋ΔͨΊɺཚ༻ʹ͸஫ҙ
    

    View Slide

16. &SSBUJD5FTU 5FTU3VO8BS
    
    ʙ+6OJUΛ׆༻ͨ͠5FTU4NFMMTܸୀ๏ʙ
    !3FQFBUFE5FTUΛ׆༻͢Δͱςετͷ੒ޭ཰͕Θ͔Δ͜ͱͰɺ1SPCBCMZ/PO
    EFUFSNJOJTUJD5FTU͕ղফ͍ͯ͠Δ
    

    View Slide

17. &SSBUJD5FTU 5FTU3VO8BS
    
    ʙ+6OJUΛ׆༻ͨ͠5FTU4NFMMTܸୀ๏ʙ
    IUUQTKVOJUPSHKVOJUEPDTDVSSFOUVTFSHVJEF
    !3FTPVSDF-PDLΛ͚ͭΔ͜ͱͰಉظԽΛ
    ࣮ݱ͠ɺ'MBLZͳςετΛղফ
    

    View Slide

18. 0CTDVSF5FTU .ZTUFSZ(VFTU
    
    ʙ+6OJUΛ׆༻ͨ͠5FTU4NFMMTܸୀ๏ʙ
    !5FNQ%JSΛ׆༻͢Δ͜ͱͰલճͷςετ݁Ռʹґଘ͢Δ͜ͱͳ͘UNQ%JSΛ࡞੒
    

    View Slide

19. ͦͷଞ ࣌ؒͷ౎߹্ৄࡉͳ঺հΛল͍ͨ΋ͷ
    
    w 0CTDVSF5FTU &YDFQUJPO)BOEMJOH
    
    w +6OJUͰ͸KVQJUFSBQJ"TTFSUJPOTBTTFSU5ISPXT
    ͰղফՄೳ +6OJU͸
    FYQFDUFEͰղফՄೳ
    
    w +6OJU·Ͱ͸ςετதʹҙਤతʹ'BJMͤ͞Δඞཁ͕͋ͬͨͨΊɺ&YDFQUJPO
    )BOEMJOHΛຒΊࠐΜͰ͠·͍ͬͯͨ
    w 'SBHJMF5FTU 5FTU$PEF%VQMJDBUJPO
    
    w !1BSBNFUFSJ[FE5FTU!7BMVF4PVSDFͰՄಡੑߴ͘5FTU$PEF%VQMJDBUJPO
    ΛഉআՄೳ
    w ͨͩ͠ɺύϥϝʔλ͕JOU JOU JOU JOUͱ͔ͩͱޡೝ஌ͷԹচʹͳΔͷͰ஫ҙ
    

    View Slide

20. ·ͱΊ
    w 5FTU4NFMMT͕ຒΊࠐ·ΕΔഎܠͷҰͭʹ͸࠷৽൛ͷ5FTUJOH'SBNFXPSLΛ
    ࢖༻͍ͯ͠ͳ͍͜ͱ͕ڍ͛ΒΕΔ
    w 044ͱ͍͏ίϯςΩετͰ͸͋Δ͕
    ࠷৽൛ͷ5FTUJOH'SBNFXPSLʹҠߦ͠
    ͍ͯͳ͍1+͸ҙ֎ͱଟ͍
    w +6OJUͷ৔߹ɺ"TTFSUJPO3PVMFUUF΍$POEJUJPOBM5FTU-PHJDɺ&SSBUJD
    5FTUɺ0CTDVSF5FTUͱ͍ͬͨ5FTU4NFMMTΛղফ͢ΔͨΊͷػೳ͕ೖ͍ͬͯ
    Δ
    

    View Slide