The Biggest WP Core Patch Ever

Presented on September 2, 2017 at WordCamp Nijmegen, Nijmegen, The Netherlands.
https://2017.nijmegen.wordcamp.org/
---------------------------------------------------------------
If you’re looking at the WordPress core code, you wouldn’t easily believe that WordPress actually has clear and consistent coding standards.
While the standards are in the Core developers handbook, most of the WordPress code base does not comply and patches to fix this were not being accepted.

Until now.

So let me tell you a little story about trac ticket 41057 and how we created the biggest patch to go into WordPress core ever. …

Transcript

1. The Biggest WordPress Core Patch Ever * Juliette Reinders Folmer * Probably Patrick Willems
3. Coding Standards Compliance https://core.trac.wordpress.org/ticket/41057
4. Why is Code Style Important ? Easier to maintain & debug Easier to start contributing Easier to comprehend
5. Evolution of the WordPress Code Base 0 50 100 150 200 250 300 350 400 25-7-2012 1-7-2013 1-7-2014 1-7-2015 1-7-2016 1-7-2017 x 1.000 Lines of Code (ex comments) Clean Code
6. Tooling  https://github.com/squizlabs/PHP_CodeSniffer  https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards PHP CodeSniffer by WordPress Coding Standards for PHPCS
7. Tooling PHP CodeSniffer WordPress Coding Standards phpcs phpcbf rulesets sniffs checks + fixers
8. Code Style Error Prevention Documentation Bug Prevention Best Practices Type of Sniffs
9. 52 SNIFFS in the WordPress-Core ruleset
10. 68.061 errors 64.314 auto-fixable 1.062 warnings in 1122 files
11. 179 Unique Error Codes Top 10 Error Sources: 1. PEAR.Functions.FunctionCallSignature 2. Generic.ControlStructures.InlineControl Structure 3. Generic.WhiteSpace.ScopeIndent 4. WordPress.Arrays.ArrayDeclarationSpacing 5. WordPress.WhiteSpace.OperatorSpacing 6. WordPress.Arrays.ArrayKeySpacing Restrictions 7. WordPress.Arrays.CommaAfterArrayItem 8. Squiz.Strings.DoubleQuoteUsage 9. WordPress.Arrays.ArrayIndentation 10.Squiz.PHP.DisallowMultipleAssignments
12. Here Be Dragons Fixer Conflicts Badly set up Sniffs Bugs in Sniffs and Fixers Missing Sniffs
13. Wins  More comprehensive WP Coding Standards  Better sniffs in both WPCS + PHPCS  Better code Steven Lilley
14. The Biggest WordPress Core Patch Ever ?
15. +90,073* -61,932* 73.511 fixes in 1,059 files * Estimates based on current status of the ticket
16. > 15 % of all lines of codes changed ozgary
17. The Team Stephen Edgar Gary Pendergast Juliette Reinders Folmer Weston Ruter J.D. Grimes Gary Jones Core Team WPCS team Maybe you ?
18. Thanks! Any questions ? Slides: https://speakerdeck.com/jrf Feedback: https://joind.in/talk/dafa1 @jrf_nl @jrfnl @jrf