Creating an Inclusive Code Review Culture

All developers have probably experienced the familiar dread surrounding code reviews–having to context switch to unblock someone’s pull request or deciding how to move forward after a comment with which you disagreed. Transform the code review culture of your team with these tips and techniques, improving code quality and working relationships simultaneously.

Transcript

1. @kaylakasprak #GHC19
2. @kaylakasprak ABOUT ME #GHC19 Kayla Kasprak Software Engineer, iOS
3. @kaylakasprak ABOUT ME #GHC19 Kayla Kasprak Software Engineer, iOS
4. @kaylakasprak ABOUT ME #GHC19 Kayla Kasprak Software Engineer, iOS
5. @kaylakasprak ABOUT ME #GHC19 Kayla Kasprak Software Engineer, iOS
6. @kaylakasprak ABOUT ME #GHC19 Kayla Kasprak Software Engineer, iOS Luna Tuna Hider of Bones
7. @kaylakasprak #GHC19
8. @kaylakasprak #GHC19
9. @kaylakasprak #GHC19
10. @kaylakasprak #GHC19
11. @kaylakasprak #GHC19 CODE REVIEWS
12. @kaylakasprak #GHC19 CREATING AN INCLUSIVE CODE REVIEW CULTURE
13. @kaylakasprak #GHC19 CODE REVIEWS https://github.com/octocat/linguist/compare/master...octocat:an-example-comparison-for-docs
14. @kaylakasprak #GHC19 TYPICAL CODE REVIEW PROCESS 1. Jira 2. Swift 3. GitHub 4. Slack
15. @kaylakasprak #GHC19 BENEFITS OF EFFECTIVE CODE REVIEWS BETTER CODE QUALITY LESS CHANCE OF BREAKING THE BUILD AWARENESS RELATIONSHIP BUILDING KNOWLEDGE TRANSFER
16. @kaylakasprak #GHC19 Is everyone on your team invited (and expected) to contribute to code reviews?
17. @kaylakasprak #GHC19 Is everyone on your team invited (and expected) to contribute to code reviews? It is proven that diverse teams create better products.
18. @kaylakasprak #GHC19 CHALLENGES TIME AND EFFORT CONTEXT SWITCHING MAINTAINABLE CODE COMMUNICATION
19. @kaylakasprak #GHC19 AS A TEAM REVIEWERS SUBMITTERS 1. 2. 3.
20. @kaylakasprak #GHC19 AS A TEAM 1.
21. @kaylakasprak #GHC19 AS A TEAM Agree on a set of standards.
22. @kaylakasprak #GHC19 AS A TEAM Establish a Service Level Agreement.
23. @kaylakasprak #GHC19 AS A TEAM Automate.
24. @kaylakasprak #GHC19
25. @kaylakasprak #GHC19 REVIEWERS 2.
26. @kaylakasprak #GHC19 TIPS FOR REVIEWERS Anyone can and should review.
27. @kaylakasprak #GHC19 Highest academic degree and years of experience are not statistically significant in determining the quality of a code review. https://giphy.com/gifs/dog-confused-i-have-no-idea-what-im-doing-xDQ3Oql1BN54c
28. @kaylakasprak #GHC19 TIPS FOR REVIEWERS Questions can be more powerful than statements.
29. @kaylakasprak #GHC19
30. @kaylakasprak #GHC19
31. @kaylakasprak #GHC19
32. @kaylakasprak #GHC19
33. @kaylakasprak Language and tone matter. TIPS FOR REVIEWERS
34. @kaylakasprak #GHC19 Alternative: Have you tried using PLD? It may make this more concise.
35. @kaylakasprak #GHC19 Alternative: The code should be self documenting wherever possible, and this comment doesn’t add much context. Please remove.
36. @kaylakasprak #GHC19 Alternative: Do we have a plan in place to move all instances of this over to the new pattern?
37. @kaylakasprak #GHC19 Alternative: Putting this into a function named adjustNavBar would make this a bit more readable.
38. @kaylakasprak #GHC19 Honestly, chill. Alternative: This exposes implementation details and is a violation of the open/close principle. Happy to chat more about how to resolve this if you’d like.
39. @kaylakasprak #GHC19
40. @kaylakasprak #GHC19 TIPS FOR REVIEWERS Consider the scope of the changes first.
41. @kaylakasprak #GHC19 TIPS FOR REVIEWERS Be proactive about complex changes.
42. @kaylakasprak #GHC19 Link to supporting documentation/resources. TIPS FOR REVIEWERS
43. @kaylakasprak #GHC19 Give compliments. TIPS FOR REVIEWERS
44. @kaylakasprak #GHC19
45. @kaylakasprak #GHC19 SUBMITTERS 3.
46. @kaylakasprak #GHC19 Aim to write code that is easy to read, review, and maintain. TIPS FOR SUBMITTERS
47. @kaylakasprak #GHC19 Respond clearly. TIPS FOR SUBMITTERS
48. @kaylakasprak #GHC19
49. @kaylakasprak #GHC19
50. @kaylakasprak #GHC19 https://giphy.com/gifs/reaction-iHe7mA9M9SsyQ
51. @kaylakasprak #GHC19
52. @kaylakasprak #GHC19 Avoid huge commits by submitting incremental changes. TIPS FOR SUBMITTERS
53. @kaylakasprak #GHC19 Tips for Submitters https://twitter.com/iamdevloper/status/397664295875805184
54. @kaylakasprak #GHC19 Add your own comments to your PR before requesting reviews. TIPS FOR SUBMITTERS
55. @kaylakasprak #GHC19 Consider a face-to-face review. TIPS FOR SUBMITTERS
56. @kaylakasprak #GHC19 Get buy-in early. TIPS FOR SUBMITTERS
57. @kaylakasprak #GHC19 IN SUMMARY…
58. @kaylakasprak #GHC19 Code reviews shouldn’t be painful!
59. @kaylakasprak #GHC19 REFERENCES [1] Hunt, V., Layton, D., & Prince, S. (2015, Feb. 2). Diversity Matters. McKinsey & Company. https://www.mckinsey.com/~/media/mckinsey/business %20functions/organization/our%20insights/why%20diver dive%20matters/diversity%20matters.ashx [2] Intent HQ (2015, Feb. 3). What is Good Code? A Scientific Definition. https://blog.intenthq.com/blog/what-is- good-code-a- scientific-definition [3] Kemerer, C. F., & Paulk, M.C. (2009). The Impact of Design and Code Reviews on Software Quality: An Empirical Study Based on PSP Data. IEEE Transactions on Software Engineering. [4] Lynch, M. (2017, Oct. 12). How to Do Code Reviews Like a Human (Part One). https://mtlynch.io/human-code- reviews-1/ [5] Rigby, P.C., & Bird, C. (2016). Convergent Contemporary Software Peer Review Practices. [6] Sankarram, S. (2018, Jan. 19). Unlearning Toxic Behaviors in a Code Review Culture. https://medium.freecodecamp.org/unlearning-toxic- behaviors-in-a-code-review-culture-b7c295452a3c
60. @kaylakasprak THANK YOU! Please remember to complete the session survey in the GHC19 mobile app. #GHC19 kkasprak kaylakasprak kkasprak
61. @kaylakasprak #GHC19