rubocop-headquarters-2018.pdf

4BU 3VCP$PQ )FBERVBSUFST 3BJMT%FWFMPQFST.FFUVQ%BZ&YUSFNF %3&$0.$P -UE The road to
RuboCop 1.0 after RubyKaigi 2018 ,PJDIJ*50FTN

!LPJD w 3VCP$PQDPNNJUUFS w "30SBDMFFOIBODFE BEBQUFSDPNNJUUFS w &JXB4ZTUFN .BOBHFNFOU *OD

!FTNJOD -VODI4QPOTPS )FSF

3BJMTENBOENF

3BJMTEN

3BJMTENEBZ

3BJMTίϛϡχςΟҭͪͷࢹ఺

4BU 3VCP$PQ )FBERVBSUFST 3BJMT%FWFMPQFST.FFUVQ%BZ&YUSFNF %3&$0.$P -UE The road to
RuboCop 1.0 after RubyKaigi 2018 ,PJDIJ*50FTN

ࠓ೔ͷ࿩

IUUQTTQFBLFSEFDLDPNLBLVUBOJBHJMFNBOJGFTUPEFDBEF TMJEF !LBLVUBOJ

w"CPVU3VCP$PQ)2 w5IFSPBEUP 3VCP$PQBGUFS 3VCZ,BJHJ "HFOEB

1FPQMF 1SPEVDU

1FPQMF

w ೥݄೔ʹདྷ೔͍ͯͨ͠ !CCBUTPWʹΑͬͯެ։͞ΕΔ w (JU)VC্ʹ෼ࢄ͍ͯͨ͠(BOH PG3VCP$PQΛ౷ׅ͍ͯ͠Δ (JU)VCPSHBOJ[BUJPO w "OFX044DPNNVOJUZ 3VCP$PQ)FBERVBSUFST

HJUIVCDPNSVCPDPQIR

w 3VCP$PQ$PSF w 3VCP$PQ1FSGPSNBODF w 3VCP$PQ3BJMT w 3VCP$PQ34QFD w 3VCZ4UZMF(VJEF
w 3BJMT4UZMF(VJEF w 3VCP$PQ+1 w FUD 3VCP$PQ)2ͷSFQP

w ෼ࢄͨ͠ෳ਺ͷݸਓϦϙδτϦ͔Β ͍ͪίϛϡχςΟͷϦϙδτϦ΁ w ݸਓϦϙδτϦͷਓ͕ͨͪ)2ʹू ·͖ͬͯͨ 044ίϛϡχςΟͷৢ଄

w 3VCP$PQ$PSFΛத৺ʹؔ৺ͷ͋ Δϝϯόʔɺ3VCP$PQ34QFDΛ த৺ʹ׆ಈ͍ͯ͠Δϝϯόʔ w ͢΂ͯͷϦϙδτϦʹίϛοτݖ͕͋ ΔΘ͚Ͱ͸ͳ͍ w ྫ͑͹ࢲ͸$PSF1FSGPSNBODF 3BJMT+1
ϝϯόʔ͝ͱͷྖҬͷҧ͍

w $PSF͸CCBUTPWSVCPDPQͩͬ ͨ΋ͷͰɺ͍ΘΏΔ3VCP$PQͱݺ ͹Ε͍ͯΔ΋ͷͷத৺ w 3VCP$PQ34QFDͳͲ֦ு$PQ͕ ґଘ͍ͯ͠Δ֦ுݩ(FNͷଆ໘ w $PSFͰܧঝʹؔ͢ΔΠϯλϑΣʔε ͕มΘΔͱ֦ு$PQ͸ӨڹΛड͚Δ
֦ுݩ$PQͱͯ͠ͷ$PSF

w ͜͜Ұ೥ͷഁյతมߋͱͯ͠͸ /PEF1BUUFSOͷOJM ΁ͷมߋ΍ 3VCP$PQ$PQ͔Βͷ 3BOHF)FMQϞδϡʔϧ੾Γग़͠ ͕͋Δ ֤֦ு(FN͸௥ਵ͕ඞཁ w
ؔ৺ͷ͋Δϝϯόʔ͕)2ʹू·ͬ ͨͷ͸ྑ͍࿩ ҟͳΔϓϩδΣΫτؒͰͷಉظ

w ίϯτϦϏϡʔλʹൺ΂ͯ΍ΕΔ͜ ͱ͕૿͑Δ w ίϛολʔʹͳͬͯվΊͯࢥͬͨ͜ Ε·Ͱͱ͜Ε͔Β w (JU)VCϕʔεͷ3BJMTίϛϡχ ςΟͱൺֱ )2ઃཱͱಉ࣌ʹίϛολʔʹͳͬͨ

044ίϛϡχςΟʹΑΔҧ͍ SBJMTSBJMT CCBUTPWSVCPDPQ 3FWJFX ؔ৺Λ࣋ͬͨਓ ؔ৺Λ࣋ͬͨਓ $MPTF JTTVF *TTVFνʔϜɺίϛολʔɺί Ξϝϯόʔ
ίϛολʔ .FSHF13 ίϛολʔɺίΞϝϯόʔ ΄΅ϦϙδτϦΦʔφʔ NBTUFS QVTI ίϛολʔɺίΞϝϯόʔ ϦϙδτϦΦʔφʔͷΈ ؍ଌൣғ 3FMFBTF ϦϦʔεϚωʔδϟ ϦϙδτϦΦʔφʔ

ࢲ͕ۙະདྷʹඳ͘3VCP$PQ)2ͷੈք؍ SBJMTSBJMT SVCPDPQIRSVCPDPQ 3FWJFX ؔ৺Λ࣋ͬͨਓ ؔ৺Λ࣋ͬͨਓ $MPTF JTTVF *TTVFνʔϜɺίϛολʔɺί Ξϝϯόʔ
ίϛολʔ .FSHF13 ίϛολʔɺίΞϝϯόʔ ίϛολʔ NBTUFS QVTI ίϛολʔɺίΞϝϯόʔ ίϛολʔ 3FMFBTF ϦϦʔεϚωʔδϟ ϔουϝϯςφʔ 0S

SVCPDPQIRSVCPDPQ %SPQTVQQPSUGPS.3*

w HJUQVTIPSJHJONBTUFSʹͭ ͍ͯ w جຊ͸1VMM3FRVFTUΛ։͘ w ໌നͳ$PTNFUJDDIBOHF͸ NBTUFSQVTIͰྑ͍ͷͰ͸ʁ ίϛολʔͷݖརͱن཯

w ΍ͬͯΈͤ HJUQVTIPSJHJONBTUFS git push origin master

SVCPDPQIRSVCPDPQ!GGBF 'JY$)"/(-0(NE

IUUQTUXJUUFSDPNLPJDTUBUVT

w lNBTUFSQVTI͢Δͱ͖͸13Λ ૹΔͱ͖ΑΓ΋৻ॏʹ΍͍ͬͯΔz w l࣌ؒʹ௥ΘΕͯΔͱ͖͸΍Βͳ͍z w l ϛεͨ͋͠ͱ NBTUFSQVTIͷ จԽΛ࡞ΔͳΒઆ໌͸͏·͍͜ͱ͢
Δඞཁ͕͋Δz 3BJMTίϛολʔ͔Βͷॿݴ

͔͜͜Βগ͠ ৽ͨͳࢀೖ΁ͷώϯτ

ਓࡐ͸༗ݶͰ ͋Γྲྀಈ͢Δ IUUQTHJUIVCDPNSVCPDPQIRSVCPDPQJTTVFTJTTVFDPNNFOU

w 5IF3BJMT%PDUSJOF w ҟͳΔࢹ఺ɺ৽ͨͳίϛϡχςΟϝ ϯόʔΛܴ͑ೖΕΔ w HPPEpSTUJTTVF w 3VCP$PQ+1 l1VTIVQBCJHUFOUz

HPPEpSTUJTTVF

lHPPEpSTUJTTVFz

3VCP$PQ+1

w ͍͖ͳΓ೉͍͠໰୊Λղ͜͏ͱ͠ͳ͍ w lHPPEpSTUTUFQz͸͸͡ΊͷҰา΁ ͷΦεεϝͷϥϕϧ w ِཅੑ΍Τϥʔʹ͍ͭͯΠγϡʔΛ։͘ ͜ͱʹΑͬͯࢀՃ͢Δͱ͍͏Ұา໨ w ΠγϡʔςϯϓϨʔτʹ४͡Δͱ(PPE
044ίϛϡχςΟ΁ͷࢀՃͷҰา

QPDLF .ZHPBMGPSUIJTPSHBOJ[BUJPOJTUPCFDPNFUIF DFOUSBMIVCGPSBMMUIFDPSF3VCP$PQSFMBUFE BDUJWJUJFT*XBOUVTUPCVJMEBCJHHFSDPSFUFBN TOJQ *UIBTO`UCFFOBQFSTPOBMQSPKFDUPGNJOFGPSRVJUF BXIJMF*GTPNBOZQFPQMFBSFVTJOHJU JGTPNBOZ UIJOHTBSFOFFEFEUPCFEPOF
UIJTCFMPOHTUPUIF DPNNVOJUZ IUUQTCMPHTJEFDJDPNJOUFSWJFXXJUICP[IJEBSCBUTPWCCGEB :FTUFSEBZ ZPVNPWFE3VCP$PQSFQPTJUPSZGSPN VOEFSCCBUPTWUPSVCPDPQIR TOJQ $BOZPVUFMMVTPUIFSQMBOTGPSUIFPSHBOJ[BUJPO CCBUTPW *OUFSWJFXXJUI#P[IJEBS#BUTPW 1SFTFOUFECZ4JEFS5FBN

1SPEVDU

IUUQTXXXZPVUVCFDPNXBUDI WOS)K7$V7T("

&YUSBDU3BJMT$PQTJOBTFQBSBUF &YUSBDU1FSGPSNBODF$PQTJOUPB TFQBSBUFHFN &YUFOEDPQNFUBEBUB *OUSPEVDFOFXDPQTXJUIBTQFDJBMTUBUVT JOTUFBEPGFOBCMFEEJTBCMFE
*NQMFNFOUPQUJPOTUPSVOPOMZTBGFDPQT BOETBGFBVUPDPSSFDUT #JHNJMFTUPOFUP3VCP$PQ

SVCPDPQIRSVCPDPQ &YUSBDU3BJMT$PQTJOBTFQBSBUF

w 3VCP$PQࣗମ͸ϑϨʔϜϫʔΫ ϥΠϒϥϦϥϯλΠϜʹґଘͤͣ 3VCZʹϑΥʔΧε͍ͨ͠ w ࡞ऀͱͯ͠ɺ͍·͸3BJMTΛ͋·Γ ΍͍ͬͯͳ͍Β͍͠ w ͨͷ·Ε·ͨ͠ 5-%3

w SVCPDPQSBJMTͱ͍͏HFN͸ طʹଘࡏ͍ͯ͠Δ ΤίγεςϜ্ͷ՝୊

w SBJMTSBJMTͷSVCPDPQZNMΛ൓ө͠ ͨSEQBSUZDPQ w 3VCZ,BJHJͰCCBUTPW͞Μʹ ZBIPOEB͞Μ͕࿩Λͯ͘͠Εͨ w 3VCZ,BJHJޙʹ%SFONJ͞ΜΒ͔Βϝ ϯγϣϯ͕͋Δ w
13Λૹ͍ͬͯͨࢲʹҾ͖ܧ͗ ྲྀΕ

!UPTIJNBSV͞Μ͋Γ͕ͱ͏͍͟͝·͢ʂ

w 3VCP$PQͷ3BJMT෦ॺʹ͍ͭͯ ελϒʹͯ͠ɺSVCPDPQSBJMT HFNͷ௥ՃΛଅ͢ϩάΛग़ྗ͢Δ w ͋Δ͍͸3VCP$PQ3BJMTʹ ϑΥʔϧόοΫ͢Δ 3VCP$PQ3BJMT΁ͷҠߦ

SVCPDPQIRSVCPDPQ &YUSBDU1FSGPSNBODF$PQTJOUPBTFQBSBUFHFN

w ύϑΥʔϚϯεޮ཰ʹ͍ͭͯ.3* ʹಛԽͨ͠಺༰ʹͳ͍ͬͯΔ w 3VCP$PQ͸+3VCZ΋αϙʔτ ͍ͯ͠Δ w 3VCP$PQ$PSFͱͯ͠͸ॲཧܥ ʹґଘ͠ͳ͍ܗΛࢦ޲͍ͯ͠Δ 5-%3

w ࣮ࡍͷޮՌʹ͍ͭͯ͸ɺެࣜυΩϡ ϝϯτͷϦϑΝϨϯεʹه͞Ε͍ͯ Δ৔߹͕͋Δ w ࠾୒Λ೰Μͩ࣌͸Ұಡ͔ͯ͠Β࣮ߦ ΛࢼΈͯ΋ྑͦ͞͏ 5JQTPG1FSGPSNBODFDPQ

1FSGPSNBODF4BNQMF

+VBOJUP'BUBTGBTUSVCZ

SBJMTSBJMT

CFODINBSLJQT

$PNQBSJTPO % ruby -v shuffle-first-vs-sample.rb ruby 2.5.1p57 (2018-03-29 revision 63029)
[x86_64- darwin17] Warming up -------------------------------------- Array#shuffle.first 35.171k i/100ms Array#sample 229.945k i/100ms Calculating ------------------------------------- Array#shuffle.first 400.180k (± 5.9%) i/s - 2.005M in 5.026934s Array#sample 6.407M (± 6.4%) i/s - 31.962M in 5.010117s Comparison: Array#sample: 6407183.3 i/s Array#shuffle.first: 400180.2 i/s - 16.01x slower

w !DPNQPTFSJOUFSBMJB͕ਐΊͯ ͘Ε͍ͯΔ w 3VCP$PQʹ޲͚ͯ 3VCP$PQ3BJMTಉ༷ਐḿ͍ͯ͠Δ w ͠͹Β͘3VCP$PQ$PSFͱͷಉ ظ͕৬ਓͷԹ͔ͳख࡞ۀ 1FSGPSNBODFDPQTͷநग़ঢ়گ

SVCPDPQIRSVCPDPQ &YUFOEDPQNFUBEBUB

w ͓ͦΒ͘3VCP$PQͷ໨ۄ w 3VCP$PQΛΞοϓάϨʔυͨ͠ࡍʹ ރΕ͍ͯͳ͍$PQͰͷ໰୊͕͋ͬͨΓ CSFBLJOHDIBOHFͨ͠Γͷ൵͠Έ ͷ͓ศΓ΁ͷػೳ w SVCPDPQZNM EFGBVMUZNM
΁ͷ ϝλσʔλͷ௥Ճ 5-%3

w 7FSTJPO"EEFEʜ$PQ͕௥Ճ͞Εͨόʔδϣ ϯ w 7FSTJPO$IBOHFEʜϢʔβʔʹӨڹͷ͋Δόʔ δϣϯ ৽͍͠ઃఆɺσϑΥϧτͷมߋ w 7FSTJPO3FNPWFEʜ࡟আ͞Εͨόʔδϣϯ
w 4BGFʜِཅੑͳͲͳ͘ઃܭͲ͓Γʹ৴པͰ͖Δ w 4BGF"VUP$PSSFDUʜࣗಈमਖ਼ͰյΕ͍ͯͳ͍ ͭͷϝλσʔλ

w 4BGFΦϓγϣϯͷΈ࣮ߦ͢Δ w 4BGF"VUP$PSSFDUͷΈ࣮ߦ͢Δ w σϑΥϧτͰ͸͢΂ͯ4BGFѻ͍ w ࠷৽όʔδϣϯͷ$PQΛআ֎ͯ͠ ࣮ߦ͢Δ ࣮ߦΦϓγϣϯͷީิ

w 4BGFͱ4BGF"VUP$PSSFDUͷ൑ ఆʹ͍ͭͯͲ͏͢Δ͔ w طଘΠγϡʔ͕͋Δ͔͕ͻͱͭͷࢦඪ ʹͳΓͦ͏ ެ։͞Εͨ۩ମతඪຊ w ໰୊͕͋Ε͹3VCP$PQ$PSF͔
3VCP$PQ+1·Ͱ͓ศΓΛ ݒ೦఺

w HPPEpSTUJTTVFͱͯ͠ਐΜͰ ͍Δ ঢ়گ

SVCPDPQIRSVCPDPQ *OUSPEVDFOFXDPQTXJUIBTQFDJBMTUBUVT JOTUFBEPGFOBCMFEEJTBCMFE

w طଘͷFOBCMFEEJTBCMFE΁ ͷ֦ுͱղऍͰ͖Δ w ৽ͨʹ/FX ͋Δ͍͸OJM Λ༻ҙ ͯ͠ɺͦͷ஋ͷ৔߹͸৽ͨͳ$PQ Λ࢖͏͔Ϣʔβʔʹ༗ޮແޮΛΏ ͩͶΔܯࠂΛදࣔ͢Δ
5-%3

w ΞοϓάϨʔυ࣌ʹ໰୊ʹͳΔͷ͸ރ Ε͍ͯͳ͍৽͍͠$PQͷέʔε͕ଟ ͍ ϦάϨογϣϯΑΓͪ͜Β͕ଟ͍ w ϝλσʔλͷ7FSTJPO"EEFEɺ͋ Δ͍͸&OBCMFEͷ/FXΛݩʹͯ͠ ࠷৽ͷόʔδϣϯͰ௥Ճ͞Εͨ$PQ
Λআ֎͢Ε͹ޡݕ஌ΛݮΒͤͦ͏ *.0ΞοϓάϨʔυ΁ͷ҆৺ͷ޲্

w ݱঢ়ͷ3VCP$PQͰແޮʹ͍ͨ͠ $PQ͸Enabled: falseͱͯ͠ ରॲͰ͖Δ͕ɺԿ͔ͷҙਤ͕͋ͬͯ EJTBCMFEʹͨ͠ͷ͔ɺόʔδϣ ϯΞοϓ࣌ͷރΕ͍ͯͳ͍$PQͩ ͔Βແޮʹ͍ͯ͠Δͷ͔ͷঢ়ଶ۠ผ ͕͔ͭͳ͍ ৽ͨͳϥϕϦϯά

SVCPDPQIRSVCPDPQ *NQMFNFOUPQUJPOTUPSVOPOMZTBGFDPQT BOETBGFBVUPDPSSFDUT

w SVCPDPQίϚϯυ΁ͷΦϓγϣ ϯΛ௥Ճ͢Δ 5-%3

w --safeΦϓγϣϯʜ4BGFͷ$PQ ͷΈ࣮ߦ͢Δ w --safe-auto-correctΦϓγϣϯʜ 4BGF"VUP$PSSFDUͷ$PQͷΈ࣮ߦ ͢Δ w ͜ΕΒΛSVCPDPQZNMͰઃఆ΋Ͱ͖ ΔΑ͏ʹ͢Δ
৽ͨͳ࣮ߦΦϓγϣϯ

QPDLF *UIJOLUIBUUIPTFBSFUIFLFZQPJOUT*EPO`UXBOU VTUPIBWFTPNFIVHFSPBENBQGPS*XBOUVT UPIBWFTPNFUIJOHUIBUXFDBOBDUVBMMZSFBDIJOB GFXNPOUIT IUUQTCMPHTJEFDJDPNJOUFSWJFXXJUICP[IJEBSCBUTPWCCGEB $BOZPVUFMMVTUIFSPBENBQPG3VCP$PQJO NPSFEFUBJMT CCBUTPW *OUFSWJFXXJUI#P[IJEBS#BUTPW
1SFTFOUFECZ4JEFS5FBN

͓ΘΓʹ

w 3BJMTͱ1FSGPSNBODF͸$PSF͔ Β֎ΕΔ $PSFͷϝϯςφϯεੑ w 3VCP$PQ͸ϝλσʔλΛ࢖ͬͯ ҆৺͕͓͚ͦ͏ͳ$PQͱͦ͏Ͱͳ͍ $PQΛ৭෇͚Δ ར༻ऀ΁ͷ҆શੑ
w ։ൃ͕͸͡·ͬͨ͹͔ΓͳͷͰ࠷৽ͷಈ ޲͸ϦϙδτϦΛݟ͍ͯͩ͘͞ ࠓޙͷ3VCP$PQ

wSVCPDPQIRSVCPDPQ wSVCPDPQIRSVCPDPQKQ wFTNJODBHJMF QSJWBUF wҙຯ͸Θ͔Γ·͢Ͷʁ 3VCP$PQ΁ͷJTTVF

One more thing…

3BJMT044ύονձ ΄΅݄࣍։࠵

4PDJBMDPEJOHTUBSUTXJUIZPV :PV

!LPJD 5IBOLT .*/"48"/

IUUQTTQFBLFSEFDLDPNLBLVUBOJBHJMFNBOJGFTUPEFDBEF TMJEF !LBLVUBOJ

rubocop-headquarters-2018.pdf

rubocop-headquarters-2018.pdf

More Decks by Koichi ITO

Other Decks in Programming

Featured

Transcript