Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Extremely Defensive Coding
Search
Penelope Phippen
October 08, 2015
0
100
Extremely Defensive Coding
Penelope Phippen
October 08, 2015
Tweet
Share
More Decks by Penelope Phippen
See All by Penelope Phippen
Introducing Rubyfmt
penelope_zone
0
570
How RSpec Works
penelope_zone
0
6.6k
Quick and easy browser testing using RSpec and Rails 5.1
penelope_zone
1
85
Teaching RSpec to play nice with Rails
penelope_zone
2
140
Little machines that eat strings
penelope_zone
1
110
What is processor (brighton ruby edition)
penelope_zone
0
120
What is processor?
penelope_zone
1
360
extremely defensive coding - rubyconf edition
penelope_zone
0
270
Agile, etc.
penelope_zone
2
230
Featured
See All Featured
[Rails World 2023 - Day 1 Closing Keynote] - The Magic of Rails
eileencodes
36
2.5k
Exploring the Power of Turbo Streams & Action Cable | RailsConf2023
kevinliebholz
34
6.1k
Visualization
eitanlees
148
16k
Evolution of real-time – Irina Nazarova, EuRuKo, 2024
irinanazarova
9
960
Save Time (by Creating Custom Rails Generators)
garrettdimon
PRO
32
1.6k
The Art of Delivering Value - GDevCon NA Keynote
reverentgeek
15
1.7k
Raft: Consensus for Rubyists
vanstee
139
7.1k
Improving Core Web Vitals using Speculation Rules API
sergeychernyshev
19
1.2k
Building Better People: How to give real-time feedback that sticks.
wjessup
368
20k
How to Ace a Technical Interview
jacobian
280
23k
Why You Should Never Use an ORM
jnunemaker
PRO
59
9.5k
CoffeeScript is Beautiful & I Never Want to Write Plain JavaScript Again
sstephenson
162
15k
Transcript
Extremely Defensive Coding
a!/samphippen
I want to start with a story
“When is it OK to override the methods on object?”
I umm’d and ahh’d for a bit
I gave a half explanation and then asked them if
they understood
I eventually came to an answer to do with consistency
Do it when it makes your object more consistent with
Ruby, not less
e.g. an == on a data object
What makes a gem good?
Internals?
Internals?
Interface?
Interface? ✅
More convenient than if I did it myself
And it stays convenient
And it can be used by everyone on a team
And it works with a wide range of Ruby codebases
I don’t want much do I?
RSpec
RSpec Definitely always convenient
RSpec Definitely always convenient
User story
As an RSpec user
When I stub an object
I want the original method to be on that object
after the example
So that my objects aren’t broken by my test suite
As an RSpec user
When I stub an object
I want the original method to be on that object
after the example
So that my objects aren’t broken by my test suite
How does that work?
allow(cat).to receive(:meow)
Takes the meow method off cat
Saves it
Executes test
Puts the method back on the original object
How do you save a method?
None
Method object
Put it somewhere else
Put it back at end of test
The end
The end
Defensive coding
RSpec::Support .method_handle_for
Simply invoking the method method is not good enough
Some scenes may have been altered/accelerated for your viewing pleasure
Let’s have some questions !!/samphippen
[email protected]
Users Lie
def method ‘get’ end
Users can redefine anything at any time in Ruby
Let’s have some questions !!/samphippen
[email protected]
Let’s have some questions !!/samphippen
[email protected]
Instance method object Method without a target object
Comes from a class/module not an instance
Grab the Kernel implementation of #method
Let’s have some questions !!/samphippen
[email protected]
Let’s have some questions !!/samphippen
[email protected]
Users can and will redefine core methods at any time
Instead we use Kernel’s implementation
Nobody screws with Kernel
Ruby interpreters lie
Some objects do not have Kernel in their inheritance chain
None
Let’s have some questions !!/samphippen
[email protected]
Let’s have some questions !!/samphippen
[email protected]
Let’s have some questions !!/samphippen
[email protected]
Rebinding module methods
c
c
RSpec does not support Rubinius
None
We tried, we really really tried
So anyway, dealing with module methods
Let’s have some questions !!/samphippen
[email protected]
Let’s have some questions !!/samphippen
[email protected]
Let’s have some questions !!/samphippen
[email protected]
Let’s have some questions !!/samphippen
[email protected]
Let’s have some questions !!/samphippen
[email protected]
Let’s have some questions !!/samphippen
[email protected]
Let’s have some questions !!/samphippen
[email protected]
Let’s have some questions !!/samphippen
[email protected]
Let’s have some questions !!/samphippen
[email protected]
Let’s have some questions !!/samphippen
[email protected]
Ruby interpreters behave differently.
Let’s have some questions !!/samphippen
[email protected]
Sometimes users don’t lie
None
None
None
None
`method': undefined method `foo' for class `Foo' (NameError)
This is a catch 22
Solution: trust but verify
None
None
None
Let’s put it all together
None
Wrapping up
This is why I love RSpec
Please file bugs
Your gem should be defensive
Users lie Redefinitions come from anywhere, expect them
Ruby interpreters lie Your code will run on non-MRI, old
MRI, etc
Sometimes users don’t lie Users are weird, trust but verify
What makes a gem good?
Internals?
That explanation made no sense
Internals?
Interface?
allow(cat).to receive(:meow)
You get the complexity of RSpec working with any object
for free
You probably didn’t even know it was there until I
just told you
Interface? ✅
Gems
Gems are like super objects
Done badly they cause an even more extreme mess
Done correctly they hide huge complexity behind well defined barriers
Defending against users helps your gem be convenient
Write defensively, and your users will never know what’s inside
the box
Remember the story?
This talk is born out of Ruby’s power
We need our code to defend today, against the mistakes
of our tomorrow
None
Let’s have some questions a!/samphippen
[email protected]