Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
extremely defensive coding - rubyconf edition
Search
Penelope Phippen
November 16, 2015
Technology
0
230
extremely defensive coding - rubyconf edition
Penelope Phippen
November 16, 2015
Tweet
Share
More Decks by Penelope Phippen
See All by Penelope Phippen
Introducing Rubyfmt
penelope_zone
0
500
How RSpec Works
penelope_zone
0
6.3k
Quick and easy browser testing using RSpec and Rails 5.1
penelope_zone
1
75
Teaching RSpec to play nice with Rails
penelope_zone
2
120
Little machines that eat strings
penelope_zone
1
79
What is processor (brighton ruby edition)
penelope_zone
0
92
What is processor?
penelope_zone
1
340
Agile, etc.
penelope_zone
2
200
Extremely Defensive Coding
penelope_zone
0
75
Other Decks in Technology
See All in Technology
Tellus の衛星データを見てみよう #mf_fukuoka
kongmingstrap
0
180
コードを書く隙間を見つけて生きていく技術/Findy 思考の現在地
fujiwara3
27
5.9k
KubeConにproposalを送りたい人へのアドバイス
sat
PRO
3
240
マルチアカウント環境への発見的統制の導入
ch1aki
1
1.3k
Azureの基本的な権限管理の勉強会
yhana
0
220
生産性向上チームの紹介
cybozuinsideout
PRO
1
870
長期間TiDBを使ってきた話 @ 私たちはなぜNewSQLを使うのかTiDB選定5社が語る選定理由と活用LT / Experiences with TiDB Over Time
chibiegg
2
890
FrontDoorとWebAppsを組み合わせた際のリダイレクト処理の注意点
kenichirokimura
1
510
障害対応をちょっとずつよくしていくための 演習の作りかた
heleeen
0
140
NgRx Signal Store
rainerhahnekamp
0
150
ChatworkのSRE部って実は 半分くらいPlatform Engineering部かもしれない
saramune
0
160
DevOpsDays History and my DevOps story
kawaguti
PRO
9
2.5k
Featured
See All Featured
WebSockets: Embracing the real-time Web
robhawkes
59
7k
YesSQL, Process and Tooling at Scale
rocio
164
13k
5 minutes of I Can Smell Your CMS
philhawksworth
199
19k
Into the Great Unknown - MozCon
thekraken
10
990
Designing with Data
zakiwarfel
96
4.8k
Visualizing Your Data: Incorporating Mongo into Loggly Infrastructure
mongodb
34
8.9k
Building a Scalable Design System with Sketch
lauravandoore
456
32k
Designing Dashboards & Data Visualisations in Web Apps
destraynor
226
51k
ParisWeb 2013: Learning to Love: Crash Course in Emotional UX Design
dotmariusz
104
6.6k
What's new in Ruby 2.0
geeforr
337
31k
Unsuck your backbone
ammeep
663
57k
We Have a Design System, Now What?
morganepeng
43
6.7k
Transcript
Extremely Defensive Coding
a!/samphippen
Who is having fun?
Who is here for their first time?
I want to start with a story
“When is it OK to override the methods on object?”
I umm’d and ahh’d for a bit
I gave a half explanation and then asked them if
they understood
I eventually came to an answer to do with consistency
Do it when it makes your object more consistent with
Ruby, not less
e.g. an == on a data object
What makes a gem good?
Internals?
Internals?
Interface?
Interface? ✅
More convenient than if I did it myself
And it stays convenient
And it can be used by everyone on a team
And it works with a wide range of Ruby codebases
RSpec
RSpec Definitely always convenient
RSpec Definitely always convenient
User story
As an RSpec user
When I stub an object
I want the original method to be on that object
after the example
So that my objects aren’t broken by my test suite
As an RSpec user
When I stub an object
I want the original method to be on that object
after the example
So that my objects aren’t broken by my test suite
How does that work?
allow(cat).to receive(:meow)
Takes the meow method off cat
Saves it
Executes test
Puts the method back on the original object
How do you save a method?
None
Method object
Put it somewhere else
Put it back at end of test
The end
The end
Defensive coding
RSpec::Support .method_handle_for
Simply invoking the method method is not good enough
Some scenes may have been altered/accelerated for your viewing pleasure
Let’s have some questions !/samphippen
[email protected]
Users Lie
def method ‘get’ end
Users can redefine anything at any time in Ruby
and that’s fine
Let’s have some questions !/samphippen
[email protected]
Let’s have some questions !/samphippen
[email protected]
Instance method object Method without a target object
Comes from a class/module not an instance
Grab the Kernel implementation of #method
Let’s have some questions !/samphippen
[email protected]
Let’s have some questions !/samphippen
[email protected]
Users can and will redefine core methods at any time
Instead we use Kernel’s implementation
Nobody screws with Kernel
Ruby interpreters lie
Some objects do not have Kernel in their inheritance chain
None
Let’s have some questions !/samphippen
[email protected]
Let’s have some questions !/samphippen
[email protected]
Let’s have some questions !/samphippen
[email protected]
Rebinding module methods
c
c
RSpec does not support Rubinius
None
We tried, we really really tried
So anyway, dealing with module methods
Let’s have some questions !/samphippen
[email protected]
Let’s have some questions !/samphippen
[email protected]
Let’s have some questions !/samphippen
[email protected]
Let’s have some questions !/samphippen
[email protected]
Let’s have some questions !/samphippen
[email protected]
Let’s have some questions !/samphippen
[email protected]
Let’s have some questions !/samphippen
[email protected]
Let’s have some questions !/samphippen
[email protected]
Let’s have some questions !/samphippen
[email protected]
Let’s have some questions !/samphippen
[email protected]
Ruby interpreters behave differently.
Let’s have some questions !/samphippen
[email protected]
Sometimes users don’t lie
None
None
None
None
`method': undefined method `foo' for class `Foo' (NameError)
This is a catch 22
Solution: trust but verify
None
None
None
Let’s put it all together
None
Wrapping up
This is why I love RSpec
Please file bugs
Your gem should be defensive
Users lie Redefinitions come from anywhere, expect them
Ruby interpreters lie Your code will run on non-MRI, old
MRI, etc
Sometimes users don’t lie Users are weird, trust but verify
What makes a gem good?
Internals?
That explanation made no sense
Internals?
Interface?
allow(cat).to receive(:meow)
You get the complexity of RSpec working with any object
for free
You probably didn’t even know it was there until I
just told you
Interface? ✅
Gems
Gems provide strong abstraction boundaries
Done badly they cause an even more extreme mess
Done correctly they hide huge complexity behind well defined barriers
Defending against users helps your gem be convenient
Write defensively, and your users will never know what’s inside
the box
Remember the story?
This talk is born out of Ruby’s power
We need our code to defend today, against the mistakes
of our tomorrow
Let’s have some questions !/samphippen
[email protected]
Let’s have some questions !/samphippen
[email protected]
Minitest Mock is 169 lines of code
I just showed you more code than that
For a tiny feature that isn’t a complete mocking library
and that’s fine
Please check out https://browserpath.co
None
Let’s have some questions a!/samphippen
[email protected]