Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Pull Requests - And why they're so awesome!

Pull Requests - And why they're so awesome!

An explanation about Pull Requests used at Oi Internet for all projects (Development/Infraestructure) and what advantages we'll have by using them.

Rafaell Lycan

March 04, 2016
Tweet

More Decks by Rafaell Lycan

Other Decks in Programming

Transcript

  1. Golden Rules: - New branch must be created from master.!

    - Don’t merge the feature until is complete. - When you finish your feature, delete the branch.
  2. - Must tell us a history about the code. -

    The message must make sense. - The message must be clear. Commit Messages
  3. • Why is this change necessary? • How does it

    address the issue? • What side effects does this change have?
  4. ## What's this PR do?! A few sentences describing the

    overall goals of the pull request's commits.! ## What are the relevant tickets? (if exists)! [A1534](http://example.com/tickets/A1534)! ## Main changes:! - Some change which is important to cite here.! - Another change which is important to cite too.! ! A big and long description or explanation about some change, 
 like database schema, or other stuff which is very important 
 to describe as a documentation of software it shoudn't be as technical debit.! ! ## CC Trust (if necessary)! @username, @otherename https://confluence.oiinternet.corp/display/DEV/Pull+Request+Template