Engineer's Work/Pull Request Review(JP)

I have talked about what pull request review is about, how engineers review others' source codes, and why it is important for us to review others' pull requests and read others' source codes, which is a very ordinal and common ideology for most engineers I suppose.

Transcript

2. ΤϯδχΞͷγΰτͷ1ͭ
3. ࢓༷ܾΊ ࣮૷ ϨϏϡʔ ςετ ϦϦʔε ͜ΓΜ͞Μൃදࢿྉ ʮϚδςοΫτʔΫ - 20180509ʯ ΑΓ
4. ࢓༷ܾΊ ࣮૷ ϨϏϡʔ ςετ ϦϦʔε ͜ΓΜ͞Μൃදࢿྉ ʮϚδςοΫτʔΫ - 20180509ʯ ΑΓ
5. ʰϨϏϡʔʱ
6. ʰϨϏϡʔʱͬͯʁ
7. ଞͷਓ͕ॻ͍ͨίʔυΛಡΜͰɺ ʮςετɾϦϦʔεͰ͖ΔΑʂʯ ͱ͍͏֬ೝΛ͢Δ͜ͱ
8. ϨϏϡʔ͢Δͱྑ͍͜ͱ͕ ͨ͘͞Μʂʂ
9. ࡞ۀʹΑͬͯ”ࠩ෼”͸େ͖͔ͬͨΓখ͔͞ ͔ͬͨΓ͠·͢
10. ϨϏϡʔΛ௨ͯ͠ίϛϡχέʔγϣϯ
11. ʰϨϏϡʔʱ
12. ΘΓͱूத͢Δඞཁ͕͋Δ
13. ଟ͘ͳΔͱ͠ΜͲ͍
14. Ͱ͖Δ͚ͩཷΊͳ͍Α͏ʹʂ
15. ϨϏϡʔ͢Δཧ༝ᶃ
16. όάɾೝࣝͷҧ͍Λࣄલʹݟ͚ͭΔ
 ʢ֬཰Λ͋͛Δʣ
17. Ͳ͔͜Βͱ΋ͳ͘ݱΕΔ ༧ظͤͣݱΕΔ
18. ͳΔૣͰݟ͚͍ͭͨ
19. ϨϏϡʔ͸ଟ͚Ε͹ଟ͍΄Ͳ͍͍
20. ·ͣ͸ϨϏϡʔ͢ΔྔΛ૿΍͢ ؾʹͳΔͱ͜ Ζ͸ॏ఺తʹ ΏΔΊʹશମ ΛݟͯΔ શମΛ͔ͬ͠Γ ϨϕϧϚοΫε (·ͣ͸ແཧͷͳ͍ൣғͰ)
21. ϨϏϡʔ͢Δཧ༝ᶄ
22. ୭͕ͲΜͳ࡞ۀ͍ͯ͠Δͷ͔ཧղͰ͖Δ
23. • ։ൃ͸ڞಉ࡞ۀ
    • ࡞ۀͷόοςΟϯά͕ى͜Βͳ͍Α͏ʹ͢Δ
    • ͷʹࣗ෼͕ಉ͡ͱ͜ΖΛվम͢Δࡍʹ૬ஊ͠΍͍͢
    
24. ҰਓδΣϯΨ͸ऐ͍͠(´ɾωɾʆ)
25. ϨϏϡʔ͢Δཧ༝ᶅ
26. ଞͷਓͷίʔυ͔ΒֶͿ͜ͱ͕Ͱ͖Δ (ϓϥϯφʔɾϓϩσϡʔαʔ͕ଞͷਓͷ࢓༷ॻ͔ΒֶͿͱ͔΋͋Δʁ) (σβΠφʔ͕ଞͷਓͷσβΠϯϨϏϡʔ͔ΒֶͿͱ͔΋͋Δʁ)
27. ϨϏϡʔ͢Δͱྑ͍͜ͱ͕ ͨ͘͞Μʂʂ
28. ·ͱΊ
    • ϨϏϡʔ͸ΤϯδχΞͷେࣄͳγΰτͷͭ
    • ϨϏϡʔ͸ཷ·Δલʹ͢Δͷ͕ྑͦ͞͏ɻܾ࣌ؒΊ ͯ΍Δͱ͔ɻ
    ੵۃతʹϨϏϡʔΛͯ͠ɺ
    ྑ͍ΞϓϦΛ࡞͍͖ͬͯ·͠ΐ͏ʂ