Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code review beyond code style - PHP Antwerp

Code review beyond code style - PHP Antwerp

Reviewing code can feel like a secondary task. Discussing code can be easy though,
if you leave out syntax details. Following a couple of guide lines for pull requests can make code reviewing much easier.

Some code style rules can drastically reduce the mental overhead needed to understand code changes. Furthermore this talk will give some general guidelines on how to give feedback on PRs as a peer developer or coworker. These rules are not to keep for yourself, share them with your peers and your life will get easier.

Hannes Van De Vreken

October 25, 2017

More Decks by Hannes Van De Vreken

Other Decks in Technology


  1. !

  2. git

  3. $ git add -p diff --git a/composer.json b/composer.json index 55f40d7..c2cdaa7

    100644 --- a/composer.json +++ b/composer.json @@ -1,7 +1,7 @@ { "name": "get-stream/stream", "description": "A PHP client for Stream (https://getstream.io)", - "keywords": ["stream", "newsfeed", "feedly"], + "keywords": ["stream", "newsfeed", "feedly", "activity", "feed"], "homepage": “https://getstream.io", Stage this hunk [y,n,q,a,d,/,e,?]? WHAT MAKES A CODE REVIEW?
  4. BRO, what iz up with dis? Ma mom cud v

    written bettr code LANGUAGE