Code review beyond code style - PHP Unicorn

Reviewing code can feel like a secondary task. Discussing code can be easy though,
if you leave out syntax details. Following a couple of guide lines for pull requests can make code reviewing much easier.

Some code style rules can drastically reduce the mental overhead needed to understand code changes. Furthermore this talk will give some general guidelines on how to give feedback on PRs as a peer developer or coworker. These rules are not to keep for yourself, share them with your peers and your life will get easier.

Transcript

1. Code reviews @hannesvdvreken @phpunicornconf
2. Hi, my name is Hannes.
3. !
4. madewithlove.be
5. Code reviews
6. What’s a code review?
7. push commits review commits reply approve
8. push commits review commits reply approve
9. git add -p WHAT MAKES A CODE REVIEW?
10. Why spend time on that?
11. Submitter WHY SPEND TIME ON THAT?
12. Reviewer WHY SPEND TIME ON THAT?
13. Management WHY SPEND TIME ON THAT?
14. @PHP_CEO YOU THINK DEPLOYING HUNDREDS OF TIMES A DAY IS COOL? WE DEPLOY *INFINITY* TIMES A DAY BY CUTTING OUT THE MIDDLEMAN AND EDITING LIVE CODE
15. What should a submitter do?
17. Intermezzo: code style
18. PSR-2 (soon PSR-12) Symfony code style
20. multiline_array_trailing_comma
22. phpdoc_params align_double_arrow align_equals
23. Braces
26. new_with_braces
29. What should a reviewer do?
30. don’ts ❌ WHAT SHOULD A REVIEWER DO?
31. do ✓ WHAT SHOULD A REVIEWER DO?
33. Language
34. LANGUAGE
37. OMG I'M A BIG FAN OF UR CODES LANGUAGE
38. LANGUAGE
39. LANGUAGE
40. LANGUAGE
42. Wrapping up
43. Thank you! @hannesvdvreken @phpunicornconf
44. Time for questions. @hannesvdvreken @phpunicornconf