Refactoring legacy PHP app

Transcript

1. Refactoring legacy PHP app Nemanja Marić maki10
2. About me • PHP Developer at Orange Hill Development • Member of PHP Serbia Community • Co-organizer Laravel Serbia Meetup’s and PHP Serbia Meetup’s • Working with PHP since 2014 • In Laravel world from 2016 • Open source contributor • Contributing to the Laravel Framework • And most !important: Husband and father of two little angels
3. Interesting part Share your knowledge with others to get some knowledge.
4. Over the years
5. Covid years
6. What will be refactored?
7. It’s an old Laravel project started on Laravel 5.4 and PHP 5.6, upgraded to Laravel 6 (migrated 3 times) and PHP 7.3 Our goal is to run it on Laravel 9 (Up 3 major version) and PHP 8.1
8. Which tools we will use?
9. Rector 1. Instant Upgrades Rector now supports upgrades from PHP 5.3 to 8.0 and major open-source projects like Symfony, PHPUnit, Nette, Laravel, CakePHP, Doctrine, PHPOffice and TYPO3 out of the box. Do you want to be constantly on the latest PHP/framework version without effort? Use Rector to handle instant upgrades for you. 2. Automated Refactoring Do you have code quality you need, but struggle to keep it with new developers in your team? Do you want to see smart code-reviews even when every senior developers sleeps? Add Rector to your CI and let it continuously refactor your code and keep the code quality high.
11. Simple rule
13. Ok, stop.. Do you trust automated tools to change your code?
15. Ok, but what about a big ball of mud?
20. We don’t have time to refactor whole application, so let’s start one by one
21. Big complexity Poorly designed code is often complex and architecturally all off. Like it or not, that is only and only our mistake as developers. This is something that no tool can help you with, so let's dig in.
22. With the power of a “phpinsights” we can spot issues, let’s warm up
23. [Code] Useless parentheses: Line:149
24. [Code] Nullable type for null default value: Line:82
25. Cyclomatic Complexity
26. Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
27. Lower complexity = less issues [Complexity] Having `classes` with more than 5 cyclomatic complexity is prohibited - Consider refactoring: TransformationController.php: 17 cyclomatic complexity
32. Strategy pattern
33. Rector rule php@8.1 | Strategy pattern
34. Model Transformer
35. Model Transformer | Can be better?
36. Yes of course | Can be better?
37. How about to concat arrays and search both params to see if exist and to get the first one?!?
39. Let’s see whole refactor score
40. [COMPLEXITY] 60.6 pts with average of 1.82 from 17 cyclomatic complexity
41. What is left to do with this?
42. The new colleague will easily join when refactor is good
43. Change from instanceof to class_implements
44. [COMPLEXITY] 60.6 pts with average of 1.45 from 17 cyclomatic complexity
45. Ok, and last, how to stop new shitty code, and set some rules for it?
47. Questions? Slides: https://speakerdeck.com/maki10 Twitter: https://twitter.com/NemanjaMaki10 https://github.com/rectorphp/rector https://github.com/phpstan/phpstan https://github.com/nunomaduro/phpinsights