Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code Reviewing Like a Champion - DevopsDays Nashville

Code Reviewing Like a Champion - DevopsDays Nashville

These are the slides from my Devops Days Nashville presentation on code review.

External Links:

Yelp's Code Review Guidelines: https://engineeringblog.yelp.com/2017/11/code-review-guidelines.html
How to Use Code Review To Execute Someone's Soul: https://www.daedtech.com/how-to-use-a-code-review-to-execute-someones-soul/
Creating a Strong Code Review Culture: https://www.youtube.com/watch?v=PJjmw9TRB7s
Honesty, Kindness, Inspiration: Pick Three: https://www.youtube.com/watch?v=hP_2XKYia9I
bettercode.reviews: http://www.bettercode.reviews/
Giving and Getting Technical Help: https://www.youtube.com/watch?v=hY14Er6JX2s
Crucial Conversations: https://www.amazon.com/Crucial-Conversations-Talking-Stakes-Second/dp/0071771328/ref=sr_1_3?ie=UTF8&qid=1521932464&sr=8-3&keywords=crucial+conversations

C7393b7ba7ec9c8890dd77d209fbb3c9?s=128

maltzj

May 09, 2019
Tweet

Transcript

  1. Nuna | Confidential @maltzj Code Reviewing Like A Champion Jonathan

    Maltz @maltzj 5-10-19 AUTHOR DATE
  2. Nuna | Confidential @maltzj Why do code review?

  3. Nuna | Confidential @maltzj 3 Ensure Correctness

  4. Nuna | Confidential @maltzj 4 Improve Design

  5. Nuna | Confidential @maltzj 5 Share Knowledge

  6. Nuna | Confidential @maltzj How to do that?

  7. Nuna | Confidential @maltzj 7 Psychological Safety

  8. Nuna | Confidential @maltzj 8 Psychological safety is a shared

    belief that the team is safe for interpersonal risk taking. It can be defined as "being able to show and employ one's self without fear of negative consequences of self-image, status or career" (Kahn 1990, p. 708). In psychologically safe teams, team members feel accepted and respected.
  9. Nuna | Confidential @maltzj 9 Make People Feel Worse

  10. Nuna | Confidential @maltzj • "Your code style here is

    inconsistent. Bring your code in line with our style guidelines." • "This Dockerfile will take forever to build. Re-order it to make it faster" • "Why did you do this refactor? The code was better in its previous form" How does that Manifest? 10
  11. Nuna | Confidential @maltzj 11

  12. Nuna | Confidential @maltzj 12 "This code is good, let's

    make it even better"
  13. Nuna | Confidential @maltzj 3 Step Process

  14. Nuna | Confidential @maltzj 14 1. Start with Neutral Facts

  15. Nuna | Confidential @maltzj 15 This change uses Jenkins' scripted

    syntax rather than it's declarative syntax, which is being more widely adopted. Change it to use the declarative syntax.
  16. Nuna | Confidential @maltzj 16 Link to External Resources

  17. Nuna | Confidential @maltzj 17

  18. Nuna | Confidential @maltzj 18 Opinions == Facts

  19. Nuna | Confidential @maltzj 19 ✅ You can do blue-green

    deploys using Docker containers and an ELB.
  20. Nuna | Confidential @maltzj 20 Docker containers and an ELB

    are the best way to do blue-green deploys.
  21. Nuna | Confidential @maltzj 21 2. Invite a Discussion

  22. Nuna | Confidential @maltzj 22 This change uses Jenkins' scripted

    syntax rather than it's declarative syntax, which is being more widely adopted. Can you change it to use the declarative syntax?
  23. Nuna | Confidential @maltzj 23 3. Replace "you" with "we"

    or "us"
  24. Nuna | Confidential @maltzj 24 This change uses Jenkins' scripted

    syntax rather than it's declarative syntax, which is being more widely adopted. Can we change it to use the declarative syntax?
  25. Nuna | Confidential @maltzj 25

  26. Nuna | Confidential @maltzj 26

  27. Nuna | Confidential @maltzj 27 Rule of 3

  28. Nuna | Confidential @maltzj • Start with neutral facts •

    Invite a discussion • Replace "You" with "We" or "Us" • Rule of 3 Summary 28
  29. Nuna | Confidential @maltzj • Yelp's Code Review Guidelines •

    How to Use Code Review To Execute Someone's Soul • Creating a Strong Code Review Culture • Honesty, Kindness, Inspiration: Pick Three • Bettercode.reviews • Giving and Getting Technical Help • Crucial Conversations External Links 29
  30. @maltzj @maltzj https://boards.greenhouse.io/nuna/ https://boards.greenhouse.io/nuna/