Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Test Your Legacy Code
Search
Noel Rappin
November 07, 2011
Technology
3
210
Test Your Legacy Code
Presented at RubyMidwest, November 2011
Noel Rappin
November 07, 2011
Tweet
Share
More Decks by Noel Rappin
See All by Noel Rappin
Rails on Ruby: How Ruby Makes Rails Great
noelrap
0
370
In Defense of Metaprogramming
noelrap
0
480
Rails 7 Front End Tooling
noelrap
1
590
More Engineers, More Problems: Solutions for Big Teams
noelrap
0
210
The Rails 6 Front End: Building with Webpacker and Stimulus
noelrap
3
1.2k
The Developer's Toolkit
noelrap
0
190
High Cost Tests and High Value Tests: GOTO Chicago 2018
noelrap
2
150
High Cost Tests and High Value Tests
noelrap
1
190
The Road To Legacy is Paved With Good Intentions
noelrap
1
190
Other Decks in Technology
See All in Technology
Exadata Database Service on Dedicated Infrastructure(ExaDB-D) UI スクリーン・キャプチャ集
oracle4engineer
PRO
3
5.5k
やる気のない自分との向き合い方/How to Deal with Your Unmotivated Self
sanogemaru
0
470
自動テストのコストと向き合ってみた
qa
0
220
Adapty_東京AI祭ハッカソン2025ピッチスライド
shinoyamada
0
270
from Sakichi Toyoda to Agile
kawaguti
PRO
1
110
How to achieve interoperable digital identity across Asian countries
fujie
0
140
ユーザーの声とAI検証で進める、プロダクトディスカバリー
sansantech
PRO
1
130
リセラー企業のテクサポ担当が考える、生成 AI 時代のトラブルシュート 2025
kazzpapa3
1
150
速習AGENTS.md:5分で精度を上げる "3ブロック" テンプレ
ismk
3
620
『バイトル』CTOが語る! AIネイティブ世代と切り拓くモノづくり組織
dip_tech
PRO
1
110
社内お問い合わせBotの仕組みと学び
nish01
1
560
許しとアジャイル
jnuank
1
140
Featured
See All Featured
Facilitating Awesome Meetings
lara
56
6.6k
The Art of Programming - Codeland 2020
erikaheidi
56
14k
The Pragmatic Product Professional
lauravandoore
36
6.9k
Stop Working from a Prison Cell
hatefulcrawdad
271
21k
GraphQLとの向き合い方2022年版
quramy
49
14k
Evolution of real-time – Irina Nazarova, EuRuKo, 2024
irinanazarova
9
970
Code Review Best Practice
trishagee
72
19k
Build The Right Thing And Hit Your Dates
maggiecrowley
37
2.9k
Connecting the Dots Between Site Speed, User Experience & Your Business [WebExpo 2025]
tammyeverts
9
590
Making the Leap to Tech Lead
cromwellryan
135
9.6k
4 Signs Your Business is Dying
shpigford
185
22k
Done Done
chrislema
185
16k
Transcript
Test Your Legacy Code Noel Rappin @noelrap Monday, November 7,
11
You are handed a “rescue” project Monday, November 7, 11
Oh. My. God. The last person to work on this
was an idiot Monday, November 7, 11
Now what? Monday, November 7, 11
Shake your fists at the heavens for one minute. Photo
by Sha Sha Chu http://www.flickr.com/photos/shashachu/88654315/ Monday, November 7, 11
Get back to work. Monday, November 7, 11
What is a legacy application? Monday, November 7, 11
Code without tests Monday, November 7, 11
Code based on lost requirements Monday, November 7, 11
You don’t know what “correct” means Monday, November 7, 11
What’s your goal? Monday, November 7, 11
Respect working code. Do no harm. Monday, November 7, 11
Deliver features Monday, November 7, 11
At a sustainable pace Monday, November 7, 11
Improve code quality Monday, November 7, 11
The Boy Scout Rule Monday, November 7, 11
Our rescue project needs to change Monday, November 7, 11
Goofus and Gallant Monday, November 7, 11
“First, let’s write tests and cover the whole app” Monday,
November 7, 11
“That change is easy, I’ll just drop that in” Monday,
November 7, 11
They are both Goofus Monday, November 7, 11
Why not cover the whole app in tests? Monday, November
7, 11
“It’s a small world, but I wouldn’t want to paint
it” Monday, November 7, 11
It’s not a quick win Monday, November 7, 11
You can introduce bugs Monday, November 7, 11
Why not just drop something in? Monday, November 7, 11
It sets a bad precedent Monday, November 7, 11
It doesn’t make anything better Monday, November 7, 11
What’s a Gallant Software Craftsman to do? Monday, November 7,
11
The basic TDD process... Monday, November 7, 11
...applied to new changes only Monday, November 7, 11
Red. Green. Refactor. Monday, November 7, 11
Over time, coverage and quality grow organically Monday, November 7,
11
Okay, it’s not that easy Monday, November 7, 11
Why not? Monday, November 7, 11
You don’t know what to test Monday, November 7, 11
It’s hard to isolate objects under test Monday, November 7,
11
A friendly reminder: git is your friend Monday, November 7,
11
Cucumber Photo by karenandbradmerson http://www.flickr.com/photos/karenandbrademerson/492770419 Monday, November 7, 11
Cucumber is independent of the code Monday, November 7, 11
Cucumber can cover a lot of the app quickly Monday,
November 7, 11
But... Monday, November 7, 11
Cucumber is slow Photo by matley0 http://www.flickr.com/photos/matley0/2973398121/ Monday, November 7,
11
And it’s not great at isolating where a problem is
Monday, November 7, 11
Test-Driven Exploration Monday, November 7, 11
It’s like TDD... with cheating Monday, November 7, 11
Red. Make it green. Refactor. Monday, November 7, 11
The code is source of truth Monday, November 7, 11
Mock Testing Monday, November 7, 11
Mocks are fast and allow unit testing Monday, November 7,
11
But they can be hard to set up Monday, November
7, 11
Isolation Monday, November 7, 11
Only touch existing methods to call your new methods Monday,
November 7, 11
def crazy_insane_method return clean_new_method if new_condition # all the old
ugly stuff end Monday, November 7, 11
Seams Photo by boogah http://www.flickr.com/photos/boogah/4541496/ Monday, November 7, 11
Default method arguments Monday, November 7, 11
def crazy_insane_method(arg, arg, new_arg = nil) # crazy insane stuff
# now with new stuff end Monday, November 7, 11
Changing behavior without touching code Monday, November 7, 11
Monday, November 7, 11
class TestPurchase < Purchase def bang # no-op end end
user.purchase << TestPurchase.new Monday, November 7, 11
class Purchase def bang # no-op end end Monday, November
7, 11
Singleton classes Monday, November 7, 11
x = Purchase.new x.def bang # no-op end Monday, November
7, 11
Duck Typing Photo by Andyofne http://www.flickr.com/photos/andyofne/3757051334/ Monday, November 7, 11
class TestPurchase def bang # no-op end end user.purchase <<
TestPurchase.new Monday, November 7, 11
Use a pebble Photo by Slideshow Bruce http://www.flickr.com/photos/springfieldhomer/39079430/ Monday, November
7, 11
class Pebble def initialize(name) @name = name end def method_missing(method_name,
*args) p "#{method_name}(#{args.join(", ")}) from #{caller_method}" self end end Monday, November 7, 11
def caller_method(depth = 1) parse_caller(caller(depth+1).first).last end def parse_caller(at) if /^(.+?):(\d+)(?::in
`(.*)')?/ =~ at file = Regexp.last_match[1] line = Regexp.last_match[2].to_i method = Regexp.last_match[3] [file, line, method] end Monday, November 7, 11
What about bad tests? Monday, November 7, 11
Make sure the suite runs Monday, November 7, 11
Tests are also code Monday, November 7, 11
The 5-minute rule Monday, November 7, 11
When to refactor Monday, November 7, 11
Simple refactors can be done at any time... Monday, November
7, 11
...as long as the tests are green Monday, November 7,
11
Especially if you can’t test without refactoring Monday, November 7,
11
More complex refactors should be tied to actual new requests
Monday, November 7, 11
And in conclusion... Monday, November 7, 11
Respect working code Monday, November 7, 11
Test at as high a level as you can Monday,
November 7, 11
Leave things better than you found them Monday, November 7,
11
Isolate code under test Monday, November 7, 11
Consider the cost of change against the cost of no
change Monday, November 7, 11
railsrx.com @noelrap Rails Test Prescriptions Rate: http://bit.ly/nrmwtest Monday, November 7,
11