Code Review And Why Are We Wrong About It And How To Use It To Our Advantage

In this talk I take a look at code review as a tool in tech and how we can get the most out of this.

1. Why Are We Wrong About It And How To Use It To Our Advantage
4. asendecka coding is for girls !
5. http://gph.is/1Ef5qYi via Giphy
7. What is a code review?
8. What is a code review? Goals of code review.
9. What is a code review? Goals of code review. What we can catch in code review?
10. What is a code review? Goals of code review. What we can catch in code review? How wrong we are about code reviews?
11. What is a code review? Goals of code review. What we can catch in code review? How wrong we are about code reviews? What we can do about this?
12. What is a code review? Goals of code review. What we can catch in code review? How wrong we are about code reviews? What we can do about this? Ways to get the most out of code review.
14. Formal Code Review Fagan Code Review (
15. Modern Code Review
16. Modern Code Review a process that takes as input original source code and outputs accepted source code. “ ” Moritz Beller, Elmar Juergens
17. Moritz Beller, Elmar Juergens Modern Code Review the original source code is a work that stemmed solely from the author, “
18. Moritz Beller, Elmar Juergens Modern Code Review the original source code is a work that stemmed solely from the author, whereas in the accepted source code the author incorporated the reviewers’ suggestions “
19. Moritz Beller, Elmar Juergens Modern Code Review the original source code is a work that stemmed solely from the author, whereas in the accepted source code the author incorporated the reviewers’ suggestions so that everybody is satisfied with the result. “ ”
20. Moritz Beller, Elmar Juergens Modern Code Review the original source code is a work that stemmed solely from the author, whereas in the accepted source code the author incorporated the reviewers’ suggestions so that everybody is satisfied with the result. “ ”
22. https://gph.is/16rgOrE via Giphy
23. Alberto Bacchelli, Christian Bird Goals of Code Review
24. Alberto Bacchelli, Christian Bird Goals of Code Review Finding defects. s. Team awareness. ss.
25. Alberto Bacchelli, Christian Bird Goals of Code Review Finding defects. Code improvements. s. Team awareness. ss.
26. Alberto Bacchelli, Christian Bird Goals of Code Review Finding defects. Code improvements. Finding alternative solutions.
27. Alberto Bacchelli, Christian Bird Goals of Code Review Finding defects. Code improvements. Finding alternative solutions. Knowledge transfer.
28. Alberto Bacchelli, Christian Bird Goals of Code Review Finding defects. Code improvements. Finding alternative solutions. Knowledge transfer. Team awareness.
29. Alberto Bacchelli, Christian Bird Goals of Code Review Finding defects. Code improvements. Finding alternative solutions. Knowledge transfer. Team awareness. Improving dev process.
31. https://gph.is/1Ua1p11 via Giphy
32. Code “Hygiene”
33. Code “Hygiene” Does the code pass linting and has consistent code formatting?
34. +def get_service_yaml(repo, service_name):
 + response = requests.get(makeServiceYamlUrl(repo, service_name), headers={'Accept': 'application/ vnd.github.v3.raw', 'Authorization': 'token {}'.format(settings.get('github_token'))})
 + return response 21 22 23
35. +def get_service_yaml(repo, service_name):
 + response = requests.get(makeServiceYamlUrl(repo, service_name), headers={'Accept': 'application/ vnd.github.v3.raw', 'Authorization': 'token {}'.format(settings.get('github_token'))})
 + return response 21 22 23 + response = requests.get(makeServiceYamlUrl(repo, service_name), headers={'Accept': 'application/ vnd.github.v3.raw', 'Authorization': 'token {}'.format(settings.get('github_token'))})
36. +def get_service_yaml(repo, service_name):
 + response = requests.get(makeServiceYamlUrl(repo, service_name), headers={'Accept': 'application/ vnd.github.v3.raw', 'Authorization': 'token {}'.format(settings.get('github_token'))})
 + return response 21 22 23 makeServiceYamlUrl
37. Linters: pylint, flake8
38. Linters: pylint, flake8 Automate!
39. Linters: pylint, flake8 Formatters: black Automate!
40. Code “Hygiene” Does the code pass linting and has consistent code formatting? Is it clear what given function/class/method does?
41. Code “Hygiene” Does the code pass linting and has consistent code formatting? Is it clear what given function/class/method does? Do names reflect what code does?
42. Makes a request to API.
43. Makes a request to API. Extracts and formats results.
44. Makes a request to API. Extracts and formats results. Builds attachments out of results.
45. Makes a request to API. Extracts and formats results. Builds attachments out of results. Sets the value of the attachments on the object…
46. Code “Hygiene” Does the code pass linting and has consistent code formatting? Is it clear what given function/class/method does? Do names reflect what code does?
47. Code “Hygiene” Does the code pass linting and has consistent code formatting? Is it clear what given function/class/method does? Do names reflect what code does? ⛳ Do functions have one responsibility?
48. Code “Hygiene” Does the code pass linting and has consistent code formatting? Is it clear what given function/class/method does? Do names reflect what code does? ⛳ Do functions have one responsibility? ✂ Could we split functions into smaller steps?
49. Code “Hygiene” Does the code pass linting and has consistent code formatting? Is it clear what given function/class/method does? Do names reflect what code does? ⛳ Do functions have one responsibility? ✂ Could we split functions into smaller steps? Does code have unexpected side effects?
50. get_last_element(queue)
51. get_last_element(queue) returns last element of the queue
52. get_last_element(queue) returns last element of the queue but also removes this element form the queue!
53. get_last_element(queue) returns last element of the queue but also removes this element form the queue ⁉
54. ⁉ https://gph.is/15q4J0g via Giphy
55. Code “Hygiene” Does the code pass linting and has consistent code formatting? Is it clear what given function/class/method does? Do names reflect what code does? ⛳ Do functions have one responsibility? ✂ Could we split functions into smaller steps? Does code have unexpected side effects?
56. Edge Cases & Broken Logic
57. Edge Cases & Broken Logic Edge cases for ifs, fors, whiles and dates.
58. +def can_be_displayed(publish_start_date): + today = datetime.date.today() + if today > publish_start_date: + return True + return False 51 52 53 54 55
59. +def can_be_displayed(publish_start_date): + today = datetime.date.today() + if today > publish_start_date: + return True + return False 51 52 53 54 55 + if today > publish_start_date:
60. 10th of February +def can_be_displayed(publish_start_date): + today = datetime.date.today() + if today > publish_start_date: + return True + return False 51 52 53 54 55 + if today > publish_start_date:
61. 10th of February publish_start_date = date(2019, 2, 10) +def can_be_displayed(publish_start_date): + today = datetime.date.today() + if today > publish_start_date: + return True + return False 51 52 53 54 55 + if today > publish_start_date:
62. 10th of February publish_start_date = date(2019, 2, 10) today > publish_start_date +def can_be_displayed(publish_start_date): + today = datetime.date.today() + if today > publish_start_date: + return True + return False 51 52 53 54 55 + if today > publish_start_date:
63. 10th of February publish_start_date = date(2019, 2, 10) today > publish_start_date False +def can_be_displayed(publish_start_date): + today = datetime.date.today() + if today > publish_start_date: + return True + return False 51 52 53 54 55 + if today > publish_start_date:
64. +def can_be_displayed(publish_start_date): + today = datetime.date.today() + if today > publish_start_date: + return True + return False 51 52 53 54 55 + if today >= publish_start_date: True 10th of February publish_start_date = date(2019, 2, 10) today > publish_start_date
65. Edge Cases & Broken Logic Edge cases for ifs, fors, whiles and dates. Check Python gotchas.
67. https://gph.is/Vxbx8J via Giphy
68. HTTP 414 URI Too Long
69. HTTP 414 URI Too Long https://our-internal-api.com/endpoint? fields=url,title,published_at,author, published_at,author,published_at,author, published_at,author,published_at,author, published_at,author,published_at,author, published_at,author,published_at,author, published_at,author,published_at,author, published_at,author,published_at,author, published_at,author,published_at,author, published_at,author,published_at,author, published_at,author,published_at,author, published_at,author,published_at,author, published_at,author,published_at,author…
70. 17 18 19 20 21 22 23 24 25 26 +DEFAULT_FIELDS = [‘url','title'] + +def get_url(path, fields=()): + query_fields = DEFAULT_FIELDS + query_fields.extend(fields) + params = { + 'fields': ','.join(query_fields) + } + url = url_concat(path, params) + return url
71. 17 18 19 20 21 22 23 24 25 26 +DEFAULT_FIELDS = [‘url','title'] + +def get_url(path, fields=()): + query_fields = DEFAULT_FIELDS + query_fields.extend(fields) + params = { + 'fields': ','.join(query_fields) + } + url = url_concat(path, params) + return url + url = url_concat(path, params)
72. 17 18 19 20 21 22 23 24 25 26 + query_fields = DEFAULT_FIELDS +DEFAULT_FIELDS = [‘url','title'] + +def get_url(path, fields=()): + query_fields = DEFAULT_FIELDS + query_fields.extend(fields) + params = { + 'fields': ','.join(query_fields) + } + url = url_concat(path, params) + return url
73. 17 18 19 20 21 22 23 24 25 26 + query_fields.extend(fields) +DEFAULT_FIELDS = [‘url','title'] + +def get_url(path, fields=()): + query_fields = DEFAULT_FIELDS + query_fields.extend(fields) + params = { + 'fields': ','.join(query_fields) + } + url = url_concat(path, params) + return url
74. 17 18 19 20 21 22 23 24 25 26 + query_fields = DEFAULT_FIELDS +DEFAULT_FIELDS = [‘url','title'] + +def get_url(path, fields=()): + query_fields = DEFAULT_FIELDS + query_fields.extend(fields) + params = { + 'fields': ','.join(query_fields) + } + url = url_concat(path, params) + return url
75. id(DEFAULT_FIELDS) 4339573384 17 18 19 20 21 22 23 24 25 26 + query_fields = DEFAULT_FIELDS +DEFAULT_FIELDS = [‘url','title'] + +def get_url(path, fields=()): + query_fields = DEFAULT_FIELDS + query_fields.extend(fields) + params = { + 'fields': ','.join(query_fields) + } + url = url_concat(path, params) + return url id(query_fields) 4339573384
76. 17 18 19 20 21 22 23 24 25 26 +DEFAULT_FIELDS = [‘url','title'] + +def get_url(path, fields=()): + query_fields = DEFAULT_FIELDS + query_fields.extend(fields) + params = { + 'fields': ','.join(query_fields) + } + url = url_concat(path, params) + return url +DEFAULT_FIELDS = [‘url','title'] Make it immutable!
77. 17 18 19 20 21 22 23 24 25 26 +DEFAULT_FIELDS = (‘url’,’title') + +def get_url(path, fields=()): + query_fields = DEFAULT_FIELDS + query_fields.extend(fields) + params = { + 'fields': ','.join(query_fields) + } + url = url_concat(path, params) + return url +DEFAULT_FIELDS = (‘url’,’title') Make it immutable!
78. 17 18 19 20 21 22 23 24 25 26 +DEFAULT_FIELDS = (‘url’,’title') + +def get_url(path, fields=()): + query_fields = DEFAULT_FIELDS + query_fields.extend(fields) + params = { + 'fields': ','.join(query_fields) + } + url = url_concat(path, params) + return url AttributeError: 'tuple' object has no attribute 'extend' + query_fields.extend(fields)
79. https://gph.is/1LhNFLX via Giphy
80. Hitchhiker’s Guide To Python: Common Gotchas https://docs.python-guide.org/writing/gotchas/
81. Edge Cases & Broken Logic Edge cases for ifs, fors, whiles and dates. Check Python gotchas. Are exceptions handled correctly?
82. 250 251 252 253 254 255 256 +try: + data = fetch_video_data(video_id) +except Exception as err: + if err.code == 404: + handle_not_found() + else: + handle_http_error(err)
83. +except Exception as err: 250 251 252 253 254 255 256 +try: + data = fetch_video_data(video_id) +except Exception as err: + if err.code == 404: + handle_not_found() + else: + handle_http_error(err)
84. 250 251 252 253 254 255 256 +try: + data = fetch_video_data(video_id) +except Exception as err: + if err.code == 404: + handle_not_found() + else: + handle_http_error(err) + if err.code == 404: + handle_not_found() + else: + handle_http_error(err)
85. 250 251 252 253 254 255 256 +try: + data = fetch_video_data(video_id) +except HTTPError as err: + if err.code == 404: + handle_not_found() + else: + handle_http_error(err) +except HTTPError as err:
86. try: ... except Exception as err: pass
87. try: ... except Exception as err: [LOGGING]
88. Edge Cases & Broken Logic Edge cases for ifs, fors, whiles and dates. Check Python gotchas. Are exceptions handled correctly?
89. Edge Cases & Broken Logic Edge cases for ifs, fors, whiles and dates. Check Python gotchas. Are exceptions handled correctly? ➰ Are there unnecessary while loops?
90. +day = datetime.date.today() +while not is_working_day(day):
 + day = day + datetime.timedelta(day=1) 43 44 45
91. +day = datetime.date.today() +while not is_working_day(day):
 + day = day + datetime.timedelta(day=1) 43 44 45 +day = datetime.date.today()
92. +day = datetime.date.today() +while not is_working_day(day):
 + day = day + datetime.timedelta(day=1) 43 44 45 +while not is_working_day(day):
93. +day = datetime.date.today() +while not is_working_day(day):
 + day = day + datetime.timedelta(day=1) 43 44 45 + day = day + datetime.timedelta(day=1)
94. +day = datetime.date.today() +while not is_working_day(day):
 + day = day + datetime.timedelta(day=1) 43 44 45 +while not is_working_day(day):
95. 43 44 45 46 47 +day = datetime.date.today() +for offset in range(31): + day = day + datetime.timedelta(day=offset) + if is_working_day(day): + break +for offset in range(31):
96. Edge Cases & Broken Logic Edge cases for ifs, fors, whiles and dates. Check Python gotchas. Are exceptions handled correctly? ➰ Are there unnecessary while loops?
97. “Future-Self” Will Thank Me
98. “Future-Self” Will Thank Me ♻ Is every line of code used?
99. services |_facebook.py |_twitter.py |_instagram.py
100. services |_facebook.py |_twitter.py |_instagram.py ✅
101. services |_facebook.py |_twitter.py |_instagram.py ✅ https://gph.is/1bbfB39 via Giphy
102. “Future-Self” Will Thank Me ♻ Is every line of code used? Check usage of third party libraries.
103. Third Party Libraries Check library documentation.
104. Third Party Libraries Check library documentation. Check if library choice is consistent with the rest of the codebase.
105. Third Party Libraries Check library documentation. Check if library choice is consistent with the rest of the codebase. What’s the licence of the library?
106. Third Party Libraries Check library documentation. Check if library choice is consistent with the rest of the codebase. What’s the licence of the library? Is it actively maintained?
107. “Future-Self” Will Thank Me ♻ Is every line of code used? Check usage of third party libraries.
108. “Future-Self” Will Thank Me ♻ Is every line of code used? Check usage of third party libraries. E Is solution performant?
109. “Future-Self” Will Thank Me ♻ Is every line of code used? Check usage of third party libraries. E Is solution performant? Does optimisation hurt code readability?
110. “Future-Self” Will Thank Me ♻ Is every line of code used? Check usage of third party libraries. E Is solution performant? Does optimisation hurt code readability? Look for security vulnerabilities.
111. OWASP Top 10 Application Security Risks https://www.owasp.org/index.php/Top_10-2017_Top_10
112. OWASP Top 10 Application Security Risks https://www.owasp.org/index.php/Top_10-2017_Top_10
113. “Future-Self” Will Thank Me ♻ Is every line of code used? Check usage of third party libraries. E Is solution performant? Does optimisation hurt code readability? Look for security vulnerabilities. What is missing (tests, docs, metrics, logs, etc.)?
114. Tests
115. Tests Cache
116. Tests Cache Metrics
117. Tests Cache Metrics Logging
118. Tests Cache Metrics Logging Documentation
119. Code Review Code “Hygiene” Edge Cases & Broken Logic “Future-Self” Will Thank Me
120. http://gph.is/1eVNKwC via Giphy
121. Alberto Bacchelli, Christian Bird Goals of Code Review Finding defects. Code improvements. Finding alternative solutions. Knowledge transfer. Team awareness. Improving dev process.
122. Alberto Bacchelli, Christian Bird Goals of Code Review Finding defects. Code improvements. Finding alternative solutions. Knowledge transfer. Team awareness. Improving dev process. Finding defects.
123. Alberto Bacchelli, Christian Bird Goals of Code Review Finding defects. Code improvements. Finding alternative solutions. Knowledge transfer. Team awareness. Improving dev process. Finding defects. edge cases
124. Alberto Bacchelli, Christian Bird Goals of Code Review Finding defects. Code improvements. Finding alternative solutions. Knowledge transfer. Team awareness. Improving dev process. Finding defects. edge cases programmatic errors
125. Alberto Bacchelli, Christian Bird Goals of Code Review Finding defects. Code improvements. Finding alternative solutions. Knowledge transfer. Team awareness. Improving dev process. Finding defects. edge cases programmatic errors simple logic issues
126. Alberto Bacchelli, Christian Bird Goals of Code Review Finding defects. Code improvements. Finding alternative solutions. Knowledge transfer. Team awareness. Improving dev process. Code improvements. edge cases programmatic errors simple logic issues
127. Alberto Bacchelli, Christian Bird Goals of Code Review Finding defects. Code improvements. Finding alternative solutions. Knowledge transfer. Team awareness. Improving dev process. Code improvements. smaller functions edge cases programmatic errors simple logic issues
128. Alberto Bacchelli, Christian Bird Goals of Code Review Finding defects. Code improvements. Finding alternative solutions. Knowledge transfer. Team awareness. Improving dev process. Code improvements. smaller functions naming edge cases programmatic errors simple logic issues
129. Alberto Bacchelli, Christian Bird Goals of Code Review Finding defects. Code improvements. Finding alternative solutions. Knowledge transfer. Team awareness. Improving dev process. Finding alternative solutions. smaller functions naming edge cases programmatic errors simple logic issues
130. Alberto Bacchelli, Christian Bird Goals of Code Review Finding defects. Code improvements. Finding alternative solutions. Knowledge transfer. Team awareness. Improving dev process. Finding alternative solutions. smaller functions naming edge cases programmatic errors simple logic issues
131. Alberto Bacchelli, Christian Bird Goals of Code Review Finding defects. Code improvements. Finding alternative solutions. Knowledge transfer. Team awareness. Improving dev process. Knowledge transfer. smaller functions naming edge cases programmatic errors simple logic issues
132. Alberto Bacchelli, Christian Bird Goals of Code Review Finding defects. Code improvements. Finding alternative solutions. Knowledge transfer. Team awareness. Improving dev process. Knowledge transfer. reviewers see the code smaller functions naming edge cases programmatic errors simple logic issues
133. Alberto Bacchelli, Christian Bird Goals of Code Review Finding defects. Code improvements. Finding alternative solutions. Knowledge transfer. Team awareness. Improving dev process. Team awareness. reviewers see the code smaller functions naming edge cases programmatic errors simple logic issues
134. Alberto Bacchelli, Christian Bird Goals of Code Review Finding defects. Code improvements. Finding alternative solutions. Knowledge transfer. Team awareness. Improving dev process. Team awareness. reviewers see the code smaller functions naming edge cases programmatic errors simple logic issues
135. Alberto Bacchelli, Christian Bird Goals of Code Review Finding defects. Code improvements. Finding alternative solutions. Knowledge transfer. Team awareness. Improving dev process. Improving dev process. reviewers see the code smaller functions naming edge cases programmatic errors simple logic issues mandatory linting
136. Alberto Bacchelli, Christian Bird Goals of Code Review Finding defects. Code improvements. Finding alternative solutions. Knowledge transfer. Team awareness. Improving dev process. Improving dev process. reviewers see the code smaller functions naming edge cases programmatic errors simple logic issues mandatory linting
137. Alberto Bacchelli, Christian Bird Goals of Code Review Finding defects. Code improvements. Finding alternative solutions. Knowledge transfer. Team awareness. Improving dev process. smaller functions naming edge cases programmatic errors simple logic issues
138. http://gph.is/19YXeBF via Giphy
140. http://gph.is/19YXeBF via Giphy
141. https://gph.is/19YpuQK via Giphy
143. 75% code maintainability M. Mäntylä and C. Lassenius. What Types of Defects Are Really Discovered in Code Reviews?
144. 25% improve functionality M. Mäntylä and C. Lassenius. What Types of Defects Are Really Discovered in Code Reviews?
145. 25% improve functionality M. Mäntylä and C. Lassenius. What Types of Defects Are Really Discovered in Code Reviews?
146. A. Bacchelli, C. Bird, Modern Code Reviews in Open-Source Projects: Which Problems Do They Fix? There is a mismatch between the expectations and the actual outcomes of code reviews. “
147. A. Bacchelli, C. Bird, Modern Code Reviews in Open-Source Projects: Which Problems Do They Fix? There is a mismatch between the expectations and the actual outcomes of code reviews. [...] review does not result in identifying defects as often as project members would like “
148. A. Bacchelli, C. Bird, Modern Code Reviews in Open-Source Projects: Which Problems Do They Fix? There is a mismatch between the expectations and the actual outcomes of code reviews. [...] review does not result in identifying defects as often as project members would like “ and even more rarely detects deep, subtle, or “macro” level issues.
149. A. Bacchelli, C. Bird, Modern Code Reviews in Open-Source Projects: Which Problems Do They Fix? Relying on code review in this way for quality assurance may be fraught. There is a mismatch between the expectations and the actual outcomes of code reviews. [...] review does not result in identifying defects as often as project members would like “ ” and even more rarely detects deep, subtle, or “macro” level issues.
150. A. Bacchelli, C. Bird, Modern Code Reviews in Open-Source Projects: Which Problems Do They Fix? Modern code reviews provide benefits beyond finding defects. “
151. A. Bacchelli, C. Bird, Modern Code Reviews in Open-Source Projects: Which Problems Do They Fix? Modern code reviews provide benefits beyond finding defects. “ Code review can be used to improve code style, find alternative solutions, increase learning, share code ownership, etc..
152. A. Bacchelli, C. Bird, Modern Code Reviews in Open-Source Projects: Which Problems Do They Fix? Modern code reviews provide benefits beyond finding defects. “ ” Code review can be used to improve code style, find alternative solutions, increase learning, share code ownership, etc.. This should guide code review policies.
154. Finding defects. Code improvements. Finding alternative solutions.
155. https://gph.is/2xa1HDw via Giphy
156. ✍ Write an architecture proposal.
157. ✍ Write an architecture proposal. Organize a critique meeting for bigger projects.
158. https://gph.is/1sDy9by via Giphy
159. ✍ Write an architecture proposal. Organize a critique meeting for bigger projects. Discuss (Slack, JIRA cards, GitHub issues) smaller tasks.
160. Architecture Proposals
161. If you involve people at the beginning, they are more likely to provide help as during implementation process. Architecture Proposals
162. Move responsibility from a single individual to a team. If you involve people at the beginning, they are more likely to provide help as during implementation process. Architecture Proposals
163. ✍ Write an architecture proposal. Organize a critique meeting for bigger projects. Discuss (Slack, JIRA cards, GitHub issues) smaller tasks.
165. Improving code maintainability. What code review really can help us with?
166. Improving code maintainability. Understanding and sharing best practices. What code review really can help us with?
167. Improving code maintainability. Understanding and sharing best practices. Knowledge sharing/education. What code review really can help us with?
168. Review code of people more experienced than you!
169. Two reviewers
170. Two reviewers Less experienced who will learn something new.
171. Two reviewers Less experienced who will learn something new. Expert that will catch deeper issues.
172. Improving code maintainability. Understanding and sharing best practices. Knowledge sharing/education. Building blameless culture. What code review really can help us with?
173. How to promote blameless culture with code reviews?
174. How to promote blameless culture with code reviews? Let the author fix all the issues in their pull request.
175. How to promote blameless culture with code reviews? Let the author fix all the issues in their pull request. ⏰ Get involved earlier in a process. Not when code is ready.
176. Let the author fix all the issues in their pull request. ⏰ Get involved earlier in a process. Not when code is ready. Take time to explain suggested improvements. How to promote blameless culture with code reviews?
177. Let the author fix all the issues in their pull request. ⏰ Get involved earlier in a process. Not when code is ready. Take time to explain suggested improvements. Require documentation. How to promote blameless culture with code reviews?
178. README.md # _name of the service_ ## Point of contact and Slack channel ## Usage ## Running the service ## System ## Runbook ## Monitoring ## Documentation https://tinyurl.com/better-docs
179. Let the author fix all the issues in their pull request. ⏰ Get involved earlier in a process. Not when code is ready. Take time to explain suggested improvements. Require documentation. Mind your language! How to promote blameless culture with code reviews?
180. You don’t point something, because you are worried that author will feel horrible about it. Two dangers
181. You don’t point something, because you are worried that author will feel horrible about it. You deliver your feedback in unhelpful and blunt way that make an author angry. Two dangers
182. You don’t point something, because you are worried that author will feel horrible about it. You deliver your feedback in unhelpful and blunt way that make an author angry. Two dangers
183. Radical Candor: Be a Kick-Ass Boss Without Losing Your Humanity by Kim Scott
184. You don’t point something, because you are worried that author will feel horrible about it. You deliver your feedback in unhelpful and blunt way that make an author angry. Two dangers
185. Nonviolent Communication by Marshall B. Rosenberg
186. Use Emojis! ✨
187. Improving code maintainability. Understanding and sharing best practices. Knowledge sharing/education. Building blameless culture. a Preventing knowledge silos. What code review really can help us with?
188. Improving code maintainability. Understanding and sharing best practices. Knowledge sharing/education. Building blameless culture. a Preventing knowledge silos. Encouraging shared ownership & responsibility. What code review really can help us with?
189. CODEOWNERS
191. There is a surprising disparity between our expectations about code reviews and what they can actually achieve.
192. Code review is an art.
193. Code review is not a competition. It’s a team activity.
195. @asendecka http://gph.is/2EyehB5 via Giphy