Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code-reviews: a team tool (DevConf '16)
Search
Danny Kopping
March 08, 2016
Technology
1
140
Code-reviews: a team tool (DevConf '16)
Danny Kopping
March 08, 2016
Tweet
Share
More Decks by Danny Kopping
See All by Danny Kopping
Code-review: a team tool
dannykopping
1
140
High-Speed Modern Web Apps with PHP & AMF
dannykopping
1
520
The Debugging Checklist
dannykopping
2
640
Other Decks in Technology
See All in Technology
MobileActOsaka_250704.pdf
akaitadaaki
0
120
Delta airlines Customer®️ USA Contact Numbers: Complete 2025 Support Guide
deltahelp
0
680
American airlines ®️ USA Contact Numbers: Complete 2025 Support Guide
airhelpsupport
0
380
AIの全社活用を推進するための安全なレールを敷いた話
shoheimitani
2
510
fukabori.fm 出張版: 売上高617億円と高稼働率を陰で支えた社内ツール開発のあれこれ話 / 20250704 Yoshimasa Iwase & Tomoo Morikawa
shift_evolve
PRO
2
7.6k
OSSのSNSツール「Misskey」をさわってみよう(右下ワイプで私のOSCの20年を振り返ります) / 20250705-osc2025-do
akkiesoft
0
160
DBのスキルで生き残る技術 - AI時代におけるテーブル設計の勘所
soudai
PRO
47
19k
AWS Organizations 新機能!マルチパーティ承認の紹介
yhana
1
280
OPENLOGI Company Profile
hr01
0
67k
生まれ変わった AWS Security Hub (Preview) を紹介 #reInforce_osaka / reInforce New Security Hub
masahirokawahara
0
470
2025-07-06 QGIS初級ハンズオン「はじめてのQGIS」
kou_kita
0
170
AI時代の開発生産性を加速させるアーキテクチャ設計
plaidtech
PRO
3
150
Featured
See All Featured
How to train your dragon (web standard)
notwaldorf
95
6.1k
Producing Creativity
orderedlist
PRO
346
40k
ReactJS: Keep Simple. Everything can be a component!
pedronauck
667
120k
Balancing Empowerment & Direction
lara
1
430
Build The Right Thing And Hit Your Dates
maggiecrowley
36
2.8k
Agile that works and the tools we love
rasmusluckow
329
21k
Optimizing for Happiness
mojombo
379
70k
VelocityConf: Rendering Performance Case Studies
addyosmani
332
24k
Unsuck your backbone
ammeep
671
58k
A Modern Web Designer's Workflow
chriscoyier
695
190k
Evolution of real-time – Irina Nazarova, EuRuKo, 2024
irinanazarova
8
820
It's Worth the Effort
3n
185
28k
Transcript
DANNY KOPPING Code-reviews: a team tool Teams & People
Who’s the loudmouth? Danny Kopping - Lead Developer @ Zando
@dannykopping http://lanyrd.com/cfydfp
Main Challenges in producing software
• defects in production • adherence to style-guides • technical
debt • silos • inconsistency • inefficiency • incomprehensibility • duplication • lack of tests • inability to test • rigidity • tight coupling • best-practice violations • anti-patterns • …etc
Who cares? When we break something, we’ll fix it #YOLO
http://bit.ly/1RuSIBr Bugs cost money
“Sunlight is the best disinfectant” * * better options now
available - yay science - Louis D. Brandeis
Code-review should be a collaborative, cumulative & critical process
Code-review Culture the how-to guide
Purpose it’s not just for finding bugs
Outcome better developers with a broader understanding
Everything as a PR every line of code is just
as important
Reduce the noise small, digestible changes
None
None
Discussion not dictation
Reinforce good work highlight and improve bad work
All of us are better than one of us
Feedback. Fast. dedicate time to code-reviews
Horizontal interrogation challenge, learn, share
Vertical guidance direct, mentor, question
Quorum for large PRs
Agree on a baseline Style-guides, clean code, avoid smells
Don’t just tell Provide links to bolster argument, increase learning
Code is all there is and all there should be
The Bus Factor aim for 3+
Logical fallacies to avoid when reviewing code
None
None
None
None
None
None
None
None
Get off your tuchus
Soft stuff • Diplomacy • Professional, but light • Questions,
not statements • Humility • Politeness • Consistency • Sweat the small stuff! • Have fun
Brown-fields vs green-fields the consistency vs. correctness challenge
Tools
None
Why we use Upsource • integration with Git/GitHub • self-hosted,
easy setup • fast! • incremental reviews • multiple reviewers / watchers • direct integration into PHPStorm • discussion threads (with resolve, @mentions)
Reviews
Analytics
Questions? http://www.devconf.co.za/rate
Questions? /* THANK YOU*/ DANNY KOPPING www.zando.co.za
[email protected]
@dannykopping http://lanyrd.com/cfydfp