Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code-reviews: a team tool (DevConf '16)
Search
Danny Kopping
March 08, 2016
Technology
1
130
Code-reviews: a team tool (DevConf '16)
Danny Kopping
March 08, 2016
Tweet
Share
More Decks by Danny Kopping
See All by Danny Kopping
Code-review: a team tool
dannykopping
1
140
High-Speed Modern Web Apps with PHP & AMF
dannykopping
1
490
The Debugging Checklist
dannykopping
2
580
Other Decks in Technology
See All in Technology
7日間でハッキングをはじめる本をはじめてみませんか?_ITエンジニア本大賞2025
nomizone
2
1.8k
インフラをつくるとはどういうことなのか、 あるいはPlatform Engineeringについて
nwiizo
5
2.6k
2/18/25: Java meets AI: Build LLM-Powered Apps with LangChain4j
edeandrea
PRO
0
110
【Developers Summit 2025】プロダクトエンジニアから学ぶ、 ユーザーにより高い価値を届ける技術
niwatakeru
2
1.4k
滅・サービスクラス🔥 / Destruction Service Class
sinsoku
6
1.6k
リーダブルテストコード 〜メンテナンスしやすい テストコードを作成する方法を考える〜 #DevSumi #DevSumiB / Readable test code
nihonbuson
11
7.2k
Goで作って学ぶWebSocket
ryuichi1208
0
190
目の前の仕事と向き合うことで成長できる - 仕事とスキルを広げる / Every little bit counts
soudai
24
7.1k
データ資産をシームレスに伝達するためのイベント駆動型アーキテクチャ
kakehashi
PRO
2
530
データマネジメントのトレードオフに立ち向かう
ikkimiyazaki
6
960
室長と気ままに学ぶマイクロソフトのビジネスアプリケーションとビジネスプロセス
ryoheig0405
0
360
Oracle Cloud Infrastructure:2025年2月度サービス・アップデート
oracle4engineer
PRO
1
210
Featured
See All Featured
Stop Working from a Prison Cell
hatefulcrawdad
267
20k
個人開発の失敗を避けるイケてる考え方 / tips for indie hackers
panda_program
100
18k
Rebuilding a faster, lazier Slack
samanthasiow
80
8.8k
The Language of Interfaces
destraynor
156
24k
I Don’t Have Time: Getting Over the Fear to Launch Your Podcast
jcasabona
32
2.1k
How to train your dragon (web standard)
notwaldorf
91
5.8k
Fontdeck: Realign not Redesign
paulrobertlloyd
83
5.4k
Chrome DevTools: State of the Union 2024 - Debugging React & Beyond
addyosmani
4
330
Let's Do A Bunch of Simple Stuff to Make Websites Faster
chriscoyier
507
140k
Become a Pro
speakerdeck
PRO
26
5.1k
Practical Orchestrator
shlominoach
186
10k
Documentation Writing (for coders)
carmenintech
67
4.6k
Transcript
DANNY KOPPING Code-reviews: a team tool Teams & People
Who’s the loudmouth? Danny Kopping - Lead Developer @ Zando
@dannykopping http://lanyrd.com/cfydfp
Main Challenges in producing software
• defects in production • adherence to style-guides • technical
debt • silos • inconsistency • inefficiency • incomprehensibility • duplication • lack of tests • inability to test • rigidity • tight coupling • best-practice violations • anti-patterns • …etc
Who cares? When we break something, we’ll fix it #YOLO
http://bit.ly/1RuSIBr Bugs cost money
“Sunlight is the best disinfectant” * * better options now
available - yay science - Louis D. Brandeis
Code-review should be a collaborative, cumulative & critical process
Code-review Culture the how-to guide
Purpose it’s not just for finding bugs
Outcome better developers with a broader understanding
Everything as a PR every line of code is just
as important
Reduce the noise small, digestible changes
None
None
Discussion not dictation
Reinforce good work highlight and improve bad work
All of us are better than one of us
Feedback. Fast. dedicate time to code-reviews
Horizontal interrogation challenge, learn, share
Vertical guidance direct, mentor, question
Quorum for large PRs
Agree on a baseline Style-guides, clean code, avoid smells
Don’t just tell Provide links to bolster argument, increase learning
Code is all there is and all there should be
The Bus Factor aim for 3+
Logical fallacies to avoid when reviewing code
None
None
None
None
None
None
None
None
Get off your tuchus
Soft stuff • Diplomacy • Professional, but light • Questions,
not statements • Humility • Politeness • Consistency • Sweat the small stuff! • Have fun
Brown-fields vs green-fields the consistency vs. correctness challenge
Tools
None
Why we use Upsource • integration with Git/GitHub • self-hosted,
easy setup • fast! • incremental reviews • multiple reviewers / watchers • direct integration into PHPStorm • discussion threads (with resolve, @mentions)
Reviews
Analytics
Questions? http://www.devconf.co.za/rate
Questions? /* THANK YOU*/ DANNY KOPPING www.zando.co.za
[email protected]
@dannykopping http://lanyrd.com/cfydfp