Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code-reviews: a team tool (DevConf '16)
Search
Danny Kopping
March 08, 2016
Technology
1
130
Code-reviews: a team tool (DevConf '16)
Danny Kopping
March 08, 2016
Tweet
Share
More Decks by Danny Kopping
See All by Danny Kopping
Code-review: a team tool
dannykopping
1
130
High-Speed Modern Web Apps with PHP & AMF
dannykopping
1
460
The Debugging Checklist
dannykopping
2
520
Other Decks in Technology
See All in Technology
[NIKKEI Tech Talk]Bias for Action!! 実践から学ぶための仕組とコミュニティ / Community for Practice and Learning
kanamasa
0
280
【基調講演】変える、今ここから ― IoTとAIで紡ぐ未来
soracom
PRO
0
320
エンジニアリングマネージャーはどう学んでいくのか #devsumi / How Do Engineering Managers Continue to Learn and Grow?
expajp
4
1.3k
E2Eテスト自動化プラットフォームにおけるAIの活用
shift_evolve
0
190
RAGのサービスをリリースして1年3ヶ月が経ちました
segavvy
4
950
[NIKKEI Tech Talk] KDDI/KAG Scrum & Community for Engineering Training
curanosuke
2
220
How to Think Like a Performance Engineer
csswizardry
4
590
スレットハンティングについて知っておきたいこと
hacket
0
130
大規模ドラレコデータ収集・機械学習基盤を支える AWS CDK 〜導入・運用事例紹介〜
pemugi
0
110
可視化プラットフォームGrafanaの基本と活用方法の全て
hamadakoji
0
230
コンテナ・K8s研修 - 後半 Kubernetes 基礎&ハンズオン【MIXI 24新卒技術研修】
mixi_engineers
PRO
1
120
AWSでRAGを作る法方
sonoda_mj
1
140
Featured
See All Featured
ParisWeb 2013: Learning to Love: Crash Course in Emotional UX Design
dotmariusz
105
6.8k
Writing Fast Ruby
sferik
623
60k
ピンチをチャンスに:未来をつくるプロダクトロードマップ #pmconf2020
aki_iinuma
90
47k
Visualizing Your Data: Incorporating Mongo into Loggly Infrastructure
mongodb
36
9.1k
Building an army of robots
kneath
301
42k
Facilitating Awesome Meetings
lara
46
5.8k
What the flash - Photography Introduction
edds
65
11k
Teambox: Starting and Learning
jrom
130
8.6k
JavaScript: Past, Present, and Future - NDC Porto 2020
reverentgeek
44
4.7k
Gamification - CAS2011
davidbonilla
78
4.9k
Fashionably flexible responsive web design (full day workshop)
malarkey
399
65k
Sharpening the Axe: The Primacy of Toolmaking
bcantrill
26
1.6k
Transcript
DANNY KOPPING Code-reviews: a team tool Teams & People
Who’s the loudmouth? Danny Kopping - Lead Developer @ Zando
@dannykopping http://lanyrd.com/cfydfp
Main Challenges in producing software
• defects in production • adherence to style-guides • technical
debt • silos • inconsistency • inefficiency • incomprehensibility • duplication • lack of tests • inability to test • rigidity • tight coupling • best-practice violations • anti-patterns • …etc
Who cares? When we break something, we’ll fix it #YOLO
http://bit.ly/1RuSIBr Bugs cost money
“Sunlight is the best disinfectant” * * better options now
available - yay science - Louis D. Brandeis
Code-review should be a collaborative, cumulative & critical process
Code-review Culture the how-to guide
Purpose it’s not just for finding bugs
Outcome better developers with a broader understanding
Everything as a PR every line of code is just
as important
Reduce the noise small, digestible changes
None
None
Discussion not dictation
Reinforce good work highlight and improve bad work
All of us are better than one of us
Feedback. Fast. dedicate time to code-reviews
Horizontal interrogation challenge, learn, share
Vertical guidance direct, mentor, question
Quorum for large PRs
Agree on a baseline Style-guides, clean code, avoid smells
Don’t just tell Provide links to bolster argument, increase learning
Code is all there is and all there should be
The Bus Factor aim for 3+
Logical fallacies to avoid when reviewing code
None
None
None
None
None
None
None
None
Get off your tuchus
Soft stuff • Diplomacy • Professional, but light • Questions,
not statements • Humility • Politeness • Consistency • Sweat the small stuff! • Have fun
Brown-fields vs green-fields the consistency vs. correctness challenge
Tools
None
Why we use Upsource • integration with Git/GitHub • self-hosted,
easy setup • fast! • incremental reviews • multiple reviewers / watchers • direct integration into PHPStorm • discussion threads (with resolve, @mentions)
Reviews
Analytics
Questions? http://www.devconf.co.za/rate
Questions? /* THANK YOU*/ DANNY KOPPING www.zando.co.za
[email protected]
@dannykopping http://lanyrd.com/cfydfp