Code-reviews: a team tool (DevConf '16)

Transcript

1. DANNY KOPPING Code-reviews: a team tool Teams & People
2. Who’s the loudmouth? Danny Kopping - Lead Developer @ Zando @dannykopping http://lanyrd.com/cfydfp
3. Main Challenges in producing software
4. • defects in production • adherence to style-guides • technical debt • silos • inconsistency • inefficiency • incomprehensibility • duplication • lack of tests • inability to test • rigidity • tight coupling • best-practice violations • anti-patterns • …etc
5. Who cares? When we break something, we’ll fix it #YOLO
6. http://bit.ly/1RuSIBr Bugs cost money
7. “Sunlight is the
 best disinfectant” * * better options now available - yay science - Louis D. Brandeis
8. Code-review should be a collaborative, cumulative & critical process
9. Code-review Culture the how-to guide
10. Purpose it’s not just for finding bugs
11. Outcome better developers with a broader understanding
12. Everything as a PR every line of code is just as important
13. Reduce the noise small, digestible changes
16. Discussion not dictation
17. Reinforce good work highlight and improve bad work
18. All of us are better than one of us
19. Feedback. Fast. dedicate time to code-reviews
20. Horizontal interrogation challenge, learn, share
21. Vertical guidance direct, mentor, question
22. Quorum for large PRs
23. Agree on a baseline Style-guides, clean code, avoid smells
24. Don’t just tell Provide links to bolster argument, increase learning
25. Code is all there is and all there should be
26. The Bus Factor aim for 3+
27. Logical fallacies to avoid when reviewing code
36. Get off your tuchus
37. Soft stuff • Diplomacy • Professional, but light • Questions, not statements • Humility • Politeness • Consistency • Sweat the small stuff! • Have fun
38. Brown-fields 
 vs 
 green-fields the consistency vs. correctness challenge
39. Tools
41. Why we use Upsource • integration with Git/GitHub • self-hosted, easy setup • fast! • incremental reviews • multiple reviewers / watchers • direct integration into PHPStorm • discussion threads (with resolve, @mentions)
42. Reviews
43. Analytics
44. Questions? http://www.devconf.co.za/rate
45. Questions? /* THANK YOU*/ DANNY KOPPING www.zando.co.za dannykopping@gmail.com @dannykopping http://lanyrd.com/cfydfp