Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code-reviews: a team tool (DevConf '16)
Search
Danny Kopping
March 08, 2016
Technology
1
140
Code-reviews: a team tool (DevConf '16)
Danny Kopping
March 08, 2016
Tweet
Share
More Decks by Danny Kopping
See All by Danny Kopping
Code-review: a team tool
dannykopping
1
140
High-Speed Modern Web Apps with PHP & AMF
dannykopping
1
520
The Debugging Checklist
dannykopping
2
640
Other Decks in Technology
See All in Technology
AIの全社活用を推進するための安全なレールを敷いた話
shoheimitani
2
510
AWS認定を取る中で感じたこと
siromi
1
190
AWS Organizations 新機能!マルチパーティ承認の紹介
yhana
1
280
CDKTFについてざっくり理解する!!~CloudFormationからCDKTFへ変換するツールも作ってみた~
masakiokuda
1
140
関数型プログラミングで 「脳がバグる」を乗り越える
manabeai
1
190
Delegating the chores of authenticating users to Keycloak
ahus1
0
140
MobileActOsaka_250704.pdf
akaitadaaki
0
120
OPENLOGI Company Profile for engineer
hr01
1
34k
Enhancing SaaS Product Reliability and Release Velocity through Optimized Testing Approach
ropqa
1
230
生成AI時代の開発組織・技術・プロセス 〜 ログラスの挑戦と考察 〜
itohiro73
1
460
オーティファイ会社紹介資料 / Autify Company Deck
autifyhq
10
130k
生成AI活用の組織格差を解消する 〜ビジネス職のCursor導入が開発効率に与えた好循環〜 / Closing the Organizational Gap in AI Adoption
upamune
7
5.2k
Featured
See All Featured
How To Stay Up To Date on Web Technology
chriscoyier
790
250k
Practical Orchestrator
shlominoach
189
11k
Speed Design
sergeychernyshev
32
1k
Optimising Largest Contentful Paint
csswizardry
37
3.3k
The Straight Up "How To Draw Better" Workshop
denniskardys
234
140k
10 Git Anti Patterns You Should be Aware of
lemiorhan
PRO
656
60k
Performance Is Good for Brains [We Love Speed 2024]
tammyeverts
10
950
A Tale of Four Properties
chriscoyier
160
23k
How GitHub (no longer) Works
holman
314
140k
I Don’t Have Time: Getting Over the Fear to Launch Your Podcast
jcasabona
32
2.4k
Documentation Writing (for coders)
carmenintech
72
4.9k
Fashionably flexible responsive web design (full day workshop)
malarkey
407
66k
Transcript
DANNY KOPPING Code-reviews: a team tool Teams & People
Who’s the loudmouth? Danny Kopping - Lead Developer @ Zando
@dannykopping http://lanyrd.com/cfydfp
Main Challenges in producing software
• defects in production • adherence to style-guides • technical
debt • silos • inconsistency • inefficiency • incomprehensibility • duplication • lack of tests • inability to test • rigidity • tight coupling • best-practice violations • anti-patterns • …etc
Who cares? When we break something, we’ll fix it #YOLO
http://bit.ly/1RuSIBr Bugs cost money
“Sunlight is the best disinfectant” * * better options now
available - yay science - Louis D. Brandeis
Code-review should be a collaborative, cumulative & critical process
Code-review Culture the how-to guide
Purpose it’s not just for finding bugs
Outcome better developers with a broader understanding
Everything as a PR every line of code is just
as important
Reduce the noise small, digestible changes
None
None
Discussion not dictation
Reinforce good work highlight and improve bad work
All of us are better than one of us
Feedback. Fast. dedicate time to code-reviews
Horizontal interrogation challenge, learn, share
Vertical guidance direct, mentor, question
Quorum for large PRs
Agree on a baseline Style-guides, clean code, avoid smells
Don’t just tell Provide links to bolster argument, increase learning
Code is all there is and all there should be
The Bus Factor aim for 3+
Logical fallacies to avoid when reviewing code
None
None
None
None
None
None
None
None
Get off your tuchus
Soft stuff • Diplomacy • Professional, but light • Questions,
not statements • Humility • Politeness • Consistency • Sweat the small stuff! • Have fun
Brown-fields vs green-fields the consistency vs. correctness challenge
Tools
None
Why we use Upsource • integration with Git/GitHub • self-hosted,
easy setup • fast! • incremental reviews • multiple reviewers / watchers • direct integration into PHPStorm • discussion threads (with resolve, @mentions)
Reviews
Analytics
Questions? http://www.devconf.co.za/rate
Questions? /* THANK YOU*/ DANNY KOPPING www.zando.co.za
[email protected]
@dannykopping http://lanyrd.com/cfydfp