Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code-reviews: a team tool (DevConf '16)
Search
Danny Kopping
March 08, 2016
Technology
1
140
Code-reviews: a team tool (DevConf '16)
Danny Kopping
March 08, 2016
Tweet
Share
More Decks by Danny Kopping
See All by Danny Kopping
Code-review: a team tool
dannykopping
1
140
High-Speed Modern Web Apps with PHP & AMF
dannykopping
1
520
The Debugging Checklist
dannykopping
2
640
Other Decks in Technology
See All in Technology
AI時代にも変わらぬ価値を発揮したい: インフラ・クラウドを切り口にユーザー価値と非機能要件に向き合ってエンジニアとしての地力を培う
netmarkjp
0
130
ゼロから始めるSREの事業貢献 - 生成AI時代のSRE成長戦略と実践 / Starting SRE from Day One
shinyorke
PRO
0
110
助けて! XからWaylandに移行しないと新しいGNOMEが使えなくなっちゃう 2025-07-12
nobutomurata
2
200
マルチプロダクト環境におけるSREの役割 / SRE NEXT 2025 lunch session
sugamasao
1
730
Introduction to Sansan, inc / Sansan Global Development Center, Inc.
sansan33
PRO
0
2.7k
〜『世界中の家族のこころのインフラ』を目指して”次の10年”へ〜 SREが導いたグローバルサービスの信頼性向上戦略とその舞台裏 / Towards the Next Decade: Enhancing Global Service Reliability
kohbis
3
1.5k
Amplify Gen2から知るAWS CDK Toolkit Libraryの使い方/How to use the AWS CDK Toolkit Library as known from Amplify Gen2
fossamagna
1
350
OpenTelemetryセマンティック規約の恩恵とMackerel APMにおける活用例 / SRE NEXT 2025
mackerelio
3
2k
CDK Vibe Coding Fes
tomoki10
1
630
Autify Company Deck
autifyhq
2
44k
Data Engineering Study#30 LT資料
tetsuroito
1
180
cdk initで生成されるあのファイル達は何なのか/cdk-init-generated-files
tomoki10
1
670
Featured
See All Featured
Being A Developer After 40
akosma
90
590k
実際に使うSQLの書き方 徹底解説 / pgcon21j-tutorial
soudai
PRO
181
54k
Principles of Awesome APIs and How to Build Them.
keavy
126
17k
No one is an island. Learnings from fostering a developers community.
thoeni
21
3.4k
Practical Tips for Bootstrapping Information Extraction Pipelines
honnibal
PRO
21
1.3k
JavaScript: Past, Present, and Future - NDC Porto 2020
reverentgeek
50
5.5k
BBQ
matthewcrist
89
9.7k
Done Done
chrislema
184
16k
Making Projects Easy
brettharned
116
6.3k
Unsuck your backbone
ammeep
671
58k
Evolution of real-time – Irina Nazarova, EuRuKo, 2024
irinanazarova
8
830
XXLCSS - How to scale CSS and keep your sanity
sugarenia
248
1.3M
Transcript
DANNY KOPPING Code-reviews: a team tool Teams & People
Who’s the loudmouth? Danny Kopping - Lead Developer @ Zando
@dannykopping http://lanyrd.com/cfydfp
Main Challenges in producing software
• defects in production • adherence to style-guides • technical
debt • silos • inconsistency • inefficiency • incomprehensibility • duplication • lack of tests • inability to test • rigidity • tight coupling • best-practice violations • anti-patterns • …etc
Who cares? When we break something, we’ll fix it #YOLO
http://bit.ly/1RuSIBr Bugs cost money
“Sunlight is the best disinfectant” * * better options now
available - yay science - Louis D. Brandeis
Code-review should be a collaborative, cumulative & critical process
Code-review Culture the how-to guide
Purpose it’s not just for finding bugs
Outcome better developers with a broader understanding
Everything as a PR every line of code is just
as important
Reduce the noise small, digestible changes
None
None
Discussion not dictation
Reinforce good work highlight and improve bad work
All of us are better than one of us
Feedback. Fast. dedicate time to code-reviews
Horizontal interrogation challenge, learn, share
Vertical guidance direct, mentor, question
Quorum for large PRs
Agree on a baseline Style-guides, clean code, avoid smells
Don’t just tell Provide links to bolster argument, increase learning
Code is all there is and all there should be
The Bus Factor aim for 3+
Logical fallacies to avoid when reviewing code
None
None
None
None
None
None
None
None
Get off your tuchus
Soft stuff • Diplomacy • Professional, but light • Questions,
not statements • Humility • Politeness • Consistency • Sweat the small stuff! • Have fun
Brown-fields vs green-fields the consistency vs. correctness challenge
Tools
None
Why we use Upsource • integration with Git/GitHub • self-hosted,
easy setup • fast! • incremental reviews • multiple reviewers / watchers • direct integration into PHPStorm • discussion threads (with resolve, @mentions)
Reviews
Analytics
Questions? http://www.devconf.co.za/rate
Questions? /* THANK YOU*/ DANNY KOPPING www.zando.co.za
[email protected]
@dannykopping http://lanyrd.com/cfydfp