Upgrade to Pro — share decks privately, control downloads, hide ads and more …
Sign up for free

Code-reviews: a team tool (DevConf '16)

Sponsored · SiteGround - Reliable hosting with speed, security, and support you can count on. →
Avatar for Danny Kopping Danny Kopping
March 08, 2016
Technology
150
1

Code-reviews: a team tool (DevConf '16)

Avatar for Danny Kopping

Danny Kopping

March 08, 2016

More Decks by Danny Kopping

See All by Danny Kopping
Code-review: a team tool
Avatar for Danny Kopping dannykopping
1
180
High-Speed Modern Web Apps with PHP & AMF
Avatar for Danny Kopping dannykopping
1
600
The Debugging Checklist
Avatar for Danny Kopping dannykopping
2
770

Other Decks in Technology

See All in Technology
V8のArray.prototype.flatを最大約20倍速くするまでと、巨大OSSへの大規模コミットの道のり
Avatar for Riya Amemiya riyaamemiya
0
280
しろおびから始める！ログ活用の第一歩
Avatar for Shumei Ito shumei_ito
0
920
組み立てて楽しむ AWS Blocks 入門
Avatar for たけのこ kmiya84377
0
230
アウトプット初心者、半年間のふりかえり
Avatar for aoi 4o1sobblue
0
190
Cognition AI Japan - ウェビナー2_テストQA_運用監視
Avatar for Akira Shibata cogakira
0
140
How to Design Configuration for Rails Applications
Avatar for Shinichi Maeshima willnet
0
160
Loop Engineering, beyond prompt, context, and harness engineering
Avatar for Guillaume Laforge glaforge
0
100
Loop Engineering これくらいでいい
Avatar for mikan mikanichinose
0
230
⾮構造化データを価値に変える AI エージェント基盤とその組織
Avatar for 株式会社IVRy（社員登壇資料） ivry_presentationmaterials
0
150
AI時代に必要な脅威モデリング― 変化の速度に負けない理解とリスク判断
Avatar for masakane55 masakane55
5
1.3k
10年後、Engineering 行為を剥奪されるとして、わたしたちは、どう、何を創ればいいだろうか。 / If Engineering Is Taken Away in 10 Years, How and What Should We Create?
Avatar for 株式会社ビットキー / Bitkey Inc. bitkey
PRO
1
140
会社説明資料
Avatar for パーソル＆サーバーワークス株式会社 persolserverworks
0
9.7k

Featured

See All Featured
The World Runs on Bad Software
Avatar for Brandon Keepers bkeepers
PRO
72
12k
Claude Code どこまでも/ Claude Code Everywhere
Avatar for nwiizo nwiizo
68
59k
Ethics towards AI in product and experience design
Avatar for Skipper Chong Warson skipperchong
2
420
A brief & incomplete history of 
UX Design for the World Wide Web: 1989–2019
Avatar for Jason CranfordTeague jct
2
530
For a Future-Friendly Web
Avatar for Brad Frost brad_frost
184
10k
The State of eCommerce SEO: How to Win in Today's Products SERPs - #SEOweek
Avatar for Aleyda Solis aleyda
2
12k
Design and Strategy: How to Deal with People Who Don’t "Get" Design
Avatar for Morgane Peng morganepeng
133
20k
Visualizing Your Data: Incorporating Mongo into Loggly Infrastructure
Avatar for mongodb mongodb
50
10k
B2B Lead Gen: Tactics, Traps & Triumph
Avatar for Sophie Logan marketingsoph
1
280
Marketing Yourself as an Engineer | Alaka | Gurzu
Avatar for Gurzu gurzu
0
330
How Software Deployment tools have changed in the past 20 years
Avatar for Geshan Manandhar geshan
2
35k
We Are The Robots
Avatar for Honza Javorek honzajavorek
0
400

Transcript

  1. DANNY KOPPING Code-reviews: a team tool Teams & People

  2. Who’s the loudmouth? Danny Kopping - Lead Developer @ Zando

    @dannykopping http://lanyrd.com/cfydfp

  3. Main Challenges in producing software

  4. • defects in production • adherence to style-guides • technical

    debt • silos • inconsistency • inefficiency • incomprehensibility • duplication • lack of tests • inability to test • rigidity • tight coupling • best-practice violations • anti-patterns • …etc

  5. Who cares? When we break something, we’ll fix it #YOLO

  6. http://bit.ly/1RuSIBr Bugs cost money

  7. “Sunlight is the
 best disinfectant” * * better options now

    available - yay science - Louis D. Brandeis

  8. Code-review should be a collaborative, cumulative & critical process

  9. Code-review Culture the how-to guide

  10. Purpose it’s not just for finding bugs

  11. Outcome better developers with a broader understanding

  12. Everything as a PR every line of code is just

    as important

  13. Reduce the noise small, digestible changes

  14. None
  15. None

  16. Discussion not dictation

  17. Reinforce good work highlight and improve bad work

  18. All of us are better than one of us

  19. Feedback. Fast. dedicate time to code-reviews

  20. Horizontal interrogation challenge, learn, share

  21. Vertical guidance direct, mentor, question

  22. Quorum for large PRs

  23. Agree on a baseline Style-guides, clean code, avoid smells

  24. Don’t just tell Provide links to bolster argument, increase learning

  25. Code is all there is and all there should be

  26. The Bus Factor aim for 3+

  27. Logical fallacies to avoid when reviewing code

  28. None
  29. None
  30. None
  31. None
  32. None
  33. None
  34. None
  35. None

  36. Get off your tuchus

  37. Soft stuff • Diplomacy • Professional, but light • Questions,

    not statements • Humility • Politeness • Consistency • Sweat the small stuff! • Have fun

  38. Brown-fields 
 vs 
 green-fields the consistency vs. correctness challenge

  39. Tools

  40. None

  41. Why we use Upsource • integration with Git/GitHub • self-hosted,

    easy setup • fast! • incremental reviews • multiple reviewers / watchers • direct integration into PHPStorm • discussion threads (with resolve, @mentions)

  42. Reviews

  43. Analytics

  44. Questions? http://www.devconf.co.za/rate

  45. Questions? /* THANK YOU*/ DANNY KOPPING www.zando.co.za [email protected] @dannykopping http://lanyrd.com/cfydfp