Code-review: a team tool

When working in a team environment, code-reviews are an essential step in the process of producing code. Reviewing code decreases “silos” by increasing mutual understanding, exposes bugs/pitfalls and allows you to maintain consistency and quality. I’ll be sharing some of my experiences with the Zando team, how we work and the tools we use.

Transcript

1. Cape Town PHP July 2015 Code-reviews a team tool
2. Cape Town PHP July 2015 Who’s the loudmouth? Danny Kopping - Lead Developer @ Zando
3. Cape Town PHP July 2015 Main Challenges in producing software
4. Cape Town PHP July 2015 • defects in production • adherence to style-guides • technical debt • silos • inconsistency • inefficiency • incomprehensibility • duplication • lack of tests • inability to test • rigidity • tight coupling • best-practice violations • anti-patterns • …etc
5. Cape Town PHP July 2015 Who cares? When we break something, we’ll fix it #YOLO
6. Cape Town PHP July 2015 http://bit.ly/1RuSIBr Bugs cost money
7. Cape Town PHP July 2015 What about QA? Isn’t this their job?
8. Cape Town PHP July 2015 “Sunlight is the
 best disinfectant” * * not really - Louis D. Brandeis
9. Cape Town PHP July 2015 Code-review should be a collaborative, cumulative & critical process
10. Cape Town PHP July 2015 Code-review Culture the how-to guide
11. Cape Town PHP July 2015 Purpose it’s not just for finding bugs
12. Cape Town PHP July 2015 Outcome better developers with a broader understanding
13. Cape Town PHP July 2015 Everything as a PR every line of code is just as important
14. Cape Town PHP July 2015 Reduce the noise small, digestible changes
15. Cape Town PHP July 2015
16. Cape Town PHP July 2015
17. Cape Town PHP July 2015 Discussion not dictation
18. Cape Town PHP July 2015 Reinforce good work highlight and improve bad work
19. Cape Town PHP July 2015 All of us are better than one of us
20. Cape Town PHP July 2015 Feedback. Fast. dedicate time to code-reviews
21. Cape Town PHP July 2015 Horizontal interrogation challenge, learn, share
22. Cape Town PHP July 2015 Vertical guidance direct, mentor, question
23. Cape Town PHP July 2015 Quorum for large PRs
24. Cape Town PHP July 2015 Agree on a baseline Style-guides, clean code, avoid smells
25. Cape Town PHP July 2015 Don’t just tell Provide links to bolster argument, increase learning
26. Cape Town PHP July 2015 Code is all there is and all there should be
27. Cape Town PHP July 2015 The Bus Factor
28. Cape Town PHP July 2015 Logical fallacies to avoid when reviewing code
29. Cape Town PHP July 2015
30. Cape Town PHP July 2015
31. Cape Town PHP July 2015
32. Cape Town PHP July 2015
33. Cape Town PHP July 2015
34. Cape Town PHP July 2015
35. Cape Town PHP July 2015
36. Cape Town PHP July 2015
37. Cape Town PHP July 2015 Get off your tuchus
38. Cape Town PHP July 2015 Soft stuff • Diplomacy • Professional, but light • Questions, not statements • Humility • Politeness • Consistency • Sweat the small stuff! • Have fun
39. Cape Town PHP July 2015 Brown-fields 
 vs 
 green-fields
40. Cape Town PHP July 2015 Tools
41. Cape Town PHP July 2015
42. Cape Town PHP July 2015 Why we use Upsource • integration with Git/GitHub • self-hosted, easy setup • fast! • incremental reviews • multiple reviewers / watchers • direct integration into PHPStorm • discussion threads (with resolve, @mentions)
43. Cape Town PHP July 2015 Reviews
44. Cape Town PHP July 2015 Analytics
45. Cape Town PHP July 2015 Automated code-reviews
46. Cape Town PHP July 2015
47. Cape Town PHP July 2015 Questions?