$30 off During Our Annual Pro Sale. View Details »

Code review beyond code style - WebCamp Zagreb

Code review beyond code style - WebCamp Zagreb

Reviewing code can feel like a secondary task. Discussing code can be easy though,
if you leave out syntax details. Following a couple of guide lines for pull requests can make code reviewing much easier.

Some code style rules can drastically reduce the mental overhead needed to understand code changes. Furthermore this talk will give some general guidelines on how to give feedback on PRs as a peer developer or coworker. These rules are not to keep for yourself, share them with your peers and your life will get easier.

Hannes Van De Vreken

October 28, 2016
Tweet

More Decks by Hannes Van De Vreken

Other Decks in Technology

Transcript

  1. Code reviews
    @hannesvdvreken
    @webcampzg

    View Slide

  2. Hi, my name is Hannes.

    View Slide

  3. !

    View Slide

  4. madewithlove.be

    View Slide

  5. Code reviews

    View Slide

  6. What makes a code
    review?

    View Slide

  7. git add -p
    WHAT MAKES A CODE REVIEW?

    View Slide

  8. Why spend time on that?

    View Slide

  9. Submitter
    WHY SPEND TIME ON THAT?

    View Slide

  10. Reviewer
    WHY SPEND TIME ON THAT?

    View Slide

  11. Management
    WHY SPEND TIME ON THAT?

    View Slide

  12. What should a submitter do?

    View Slide

  13. What should a reviewer do?

    View Slide

  14. don’ts ❌
    WHAT SHOULD A REVIEWER DO?

    View Slide

  15. do ✓
    WHAT SHOULD A REVIEWER DO?

    View Slide

  16. Language
    WHAT SHOULD A REVIEWER DO?

    View Slide


  17. WHAT SHOULD A REVIEWER DO - LANGUAGE

    View Slide

  18. OMG I'M A BIG FAN OF UR
    CODES
    WHAT SHOULD A REVIEWER DO - LANGUAGE

    View Slide



  19. WHAT SHOULD A REVIEWER DO - LANGUAGE

    View Slide

  20. Thank you!
    @hannesvdvreken
    @webcampzg

    View Slide

  21. Time for questions.
    @hannesvdvreken
    @webcampzg

    View Slide