Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code review beyond code style - WebCamp Zagreb

Code review beyond code style - WebCamp Zagreb

Reviewing code can feel like a secondary task. Discussing code can be easy though,
if you leave out syntax details. Following a couple of guide lines for pull requests can make code reviewing much easier.

Some code style rules can drastically reduce the mental overhead needed to understand code changes. Furthermore this talk will give some general guidelines on how to give feedback on PRs as a peer developer or coworker. These rules are not to keep for yourself, share them with your peers and your life will get easier.

39eb3f3d313b13f05534e496285040b8?s=128

Hannes Van De Vreken

October 28, 2016
Tweet

Transcript

  1. Code reviews @hannesvdvreken @webcampzg

  2. Hi, my name is Hannes.

  3. !

  4. madewithlove.be

  5. Code reviews

  6. What makes a code review?

  7. git add -p WHAT MAKES A CODE REVIEW?

  8. Why spend time on that?

  9. Submitter WHY SPEND TIME ON THAT?

  10. Reviewer WHY SPEND TIME ON THAT?

  11. Management WHY SPEND TIME ON THAT?

  12. What should a submitter do?

  13. What should a reviewer do?

  14. don’ts ❌ WHAT SHOULD A REVIEWER DO?

  15. do ✓ WHAT SHOULD A REVIEWER DO?

  16. Language WHAT SHOULD A REVIEWER DO?

  17. WHAT SHOULD A REVIEWER DO - LANGUAGE

  18. OMG I'M A BIG FAN OF UR CODES WHAT SHOULD

    A REVIEWER DO - LANGUAGE
  19. WHAT SHOULD A REVIEWER DO - LANGUAGE

  20. Thank you! @hannesvdvreken @webcampzg

  21. Time for questions. @hannesvdvreken @webcampzg