$30 off During Our Annual Pro Sale. View Details »

Mob review at Akeneo

Mob review at Akeneo

How and why we changed our way to review code at Akeneo. Our path from almost no code review to mob review.

Julien Janvier

July 20, 2016
Tweet

More Decks by Julien Janvier

Other Decks in Technology

Transcript

  1. Mob review at
    3+ (wo)men, 1 laptop
    presented by Ju&Ju

    View Slide

  2. 2013 - no or optional code review

    View Slide

  3. 2014 - systematic peer review

    View Slide

  4. Systematic & public

    View Slide

  5. Good To Merge

    View Slide

  6. OK, problem solved?

    View Slide

  7. Well… nope :)

    View Slide

  8. 2015 - team/product growing

    View Slide

  9. Problems - A lot of comments

    View Slide

  10. Problem - Not focused on what’s important

    View Slide

  11. Problems - Long exchanges

    View Slide

  12. Problems - Misunderstandings with non verbal
    communication

    View Slide

  13. Github + many people => code review
    (not for us)

    View Slide

  14. Interactions >>> Tools

    View Slide

  15. 2016 - introducing mob review

    View Slide

  16. Mob programming is a software development approach where the
    whole team works on the same thing, at the same time, in the same
    space, and at the same computer.

    View Slide

  17. Mob programming review is a software development approach
    where the whole team works on reviews the same thing, at the same
    time, in the same space, and at the same computer.

    View Slide

  18. Informal & public

    View Slide

  19. View Slide

  20. Used only for “specific” topics

    View Slide

  21. Pros & cons

    View Slide

  22. Pros
    ● Easy to setup
    ● 0€ to setup
    ● Exchanges facilitated, less frustration
    ● Merge faster, less returns
    ● Knowledge is really shared
    ● Focus on what really matters
    ● Share a common technical vision
    ● Responsibility even more shared

    View Slide

  23. Cons
    ● Beware to not talk about something else
    ● Can’t put GIF anymore in the PRs :’(
    ● Sometimes hard to find reviewers
    ● Sometimes too much to review

    View Slide

  24. Tomorrow?

    View Slide

  25. Mob review at
    Questions?

    View Slide