コードレビューで自分が留意していること #phpblt

PHP BLT #5 @ GMO Yours (2016-07-20)

Transcript

1. ίʔυϨϏϡʔͰࣗ෼͕ ཹҙ͍ͯ͠Δ͜ͱ 2016-07-20 @ PHP BLT #5 ࡈ౻ ༞Ұ࿠ (@koemu) © Yuichiro Saito (@koemu), 2016 1
2. ࣗݾ঺հ 4 ࡈ౻ ༞Ұ࿠ (@koemu) 4 גࣜձࣾϝϧΧϦ ΤϯδχΞ (αʔ όAPI୲౰) 4 աڈ 4 MSPͰITΠϯϑϥӡ༻ͷࣗಈԽ 4 ࣗࣾαʔϏε։ൃ 4 SIer ͳͲͳͲ © Yuichiro Saito (@koemu), 2016 2
3. NOW ON SALE ITΠϯϑϥ؂ࢹ࣮ફೖ໳ © Yuichiro Saito (@koemu), 2016 3
4. ίʔυϨϏϡʔͰࣗ෼͕ ཹҙ͍ͯ͠Δ͜ͱ © Yuichiro Saito (@koemu), 2016 4
5. େલఏ 4 ࣗ෼͕Ҿ͖ܧ͙ͭ΋ΓͰ 4 ࢓༷ͱরΒ͠߹Θͤͯ 4 ਓ͕໨Λ௨͔͢Βͦ͜ࢦఠͰ͖Δ͜ͱΛ © Yuichiro Saito (@koemu), 2016 5
6. ྫ͑͹ԿΛݟΔͷ͔ 4 ཁٻ࢓༷ͱ߹கͨಈ͖Λ͍ͯ͠Δ͔ 4 ࣮૷͕ෆ଍͍ͯ͠ΔͳͲͳ͍͔ 4 ཁٻ࢓༷ͱҧ͏࣮૷ʹͳ͍ͬͯͳ͍͔ 4 ςετίʔυ͸ཁٻ࢓༷ͱ߹க͠ൈ͚࿙Ε͕ͳ͍͔ © Yuichiro Saito (@koemu), 2016 6
7. 4 ཁٻ࢓༷Ͱᐆດʹݟ͑Δͱ͜Ζ͸Ͳ͏ߟ͍͑ͯΔ͔͔֬Ί Δ 4 ͻΐͬͱͨ͠Βاը୲౰ऀͷೝࣝͱ૬ҧ͍ͯ͠Δ͔΋͠ Εͳ͍ 4 ྫ) ʮઃఆ͸ॊೈʹมߋͰ͖ΔΑ͏ʹ͢ΔʯॊೈͬͯԿ Αʁ © Yuichiro Saito (@koemu), 2016 7
8. ͳͥΈΔͷ͔ 4 ݟͯ΋Βͬͯࣗ෼ͷίʔυͷ඼࣭͕͕͋ͬͨ͜ͱ͕خ͔͠ ͬͨ 4 ࣗ෼ʹͳ͍஌ݟΛ֫ಘ͢Δ͜ͱ͕Ͱ͖ͨ 4 ࣗ෼͕ݟམͱ͍ͯͨ͜͠ͱΛݟ͚ͭͯ΋Β͑ͨ 4 ࠓ౓͸ࣗ෼͕ؐݩ͍ͨ͠ © Yuichiro Saito (@koemu), 2016 8
9. ͜Ε͔Βͷ՝୊ 4 ٕज़త՝୊΋ࢦఠͰ͖ΔΑ͏ʹ͢Δ 4 Ϋϥεͷ੹຿Λߟྀ͢Δ(ಛʹ੹຿͕޿͗͢ͳ͍͔ɺҟ ࣭ͳ΋ͷ͕͍ࠞͬͯ͟ͳ͍͔ͳͲ) 4 ΑΓޮ཰ͷߴ͍࣮૷ํ๏ 4 ΑΓݟ௨͠ͷྑ͍ίʔυ © Yuichiro Saito (@koemu), 2016 9
10. 4 ձࣾಠࣗͷ஌ݟΛద༻͢Δ 4 ࣾ಺ඪ४Λ΋ͱʹͨ͠ࢦఠ 4 ͸·ΓͲ͜Ζ 4 ଞͷ୲౰ͱͭͳ͕͍ͬͯΔ෦෼ͷӨڹͷߟྀ © Yuichiro Saito (@koemu), 2016 10
11. ँࣙ 4 ͜ΕΒͷ஌ݟ͸ɺۈ຿ઌͰଟ͘ͷιʔεΛಡΈɺࢦఠΛ͠ ͯͩ͘͞Δಉ྅͔Βಘͨ஌ݟΛɺࣗ෼ͳΓʹ뱌ͨ͠΋ͷ Ͱ͢ɻ © Yuichiro Saito (@koemu), 2016 11
12. େ੾ͳ͜ͱͳͷͰ΋͏Ұ౓ 4 ࣗ෼͕Ҿ͖ܧ͙ͭ΋ΓͰ 4 ࢓༷ͱরΒ͠߹Θͤͯ 4 ਓ͕໨Λ௨͔͢Βͦ͜ࢦఠͰ͖Δ͜ͱΛ © Yuichiro Saito (@koemu), 2016 12