Save 37% off PRO during our Black Friday Sale! »

For Whom the Quality Exists

023b04c98f39cc041293d780352432ff?s=47 Koichi ITO
September 27, 2018

For Whom the Quality Exists

Code Review Meetup #4 (https://sideci.connpass.com/event/98378)

023b04c98f39cc041293d780352432ff?s=128

Koichi ITO

September 27, 2018
Tweet

Transcript

  1. For Whom the Quality Exists ίʔυϨϏϡʔ͙͠͞ ,PJDIJ*50FTN  5IV $PEF3FWJFX.FFUVQ

    0QFO/FUXPSL4QBDFJO%BJLBOZBNB
  2. ඼࣭ͱ͸୭͔ʹͱͬͯ ͷՁ஋Ͱ͋Δ ʵ(FSBME.BSWJO8FJOCFSH

  3. !LPJD w ג Ӭ࿨γεςϜϚωδϝϯτ
 ίϛϡχςΟϚωʔδϟ w 3VCP$PQίϛολʔ w "30SBDMFFOIBODFE BEBQUFSίϛολʔ

    w $VDVNCFSίϛολʔ
  4. None
  5. None
  6. None
  7. "3VCZDPEF def badName if something test end end

  8. None
  9. None
  10. ࠓ೔ͷ࿩

  11. $PEF 3FWJFX

  12. $PEF 3FWJFX

  13. 2VBMJUZ 1FPQMF

  14. ࣭ʹର͢Δωλຊ wιϑτ΢ΣΞ޻ֶ͔Βͷώ ϯτ

  15. ਓʹର͢Δωλຊ wϏδωείϛϡχέʔγϣ ϯ͔Βͷώϯτ

  16. For Whom the Quality Exists ίʔυϨϏϡʔ͙͠͞ ,PJDIJ*50FTN  5IV $PEF3FWJFX.FFUVQ

    0QFO/FUXPSL4QBDFJO%BJLBOZBNB
  17. ଟ༷ͳϝϯόʔ͕ࢀը͢Δ ϓϩδΣΫτʹ͓͍ͯ ೗Կʹίʔυͷ࣭Λ্͛ͯ ͔͘ʁ

  18. ࣗ෼͸ԿΛϓϩδΣΫτʹߩݙ ͢Δͭ΋ΓͰɺϝϯόʔ͸ϓϩ δΣΫτʹԿΛߩݙͯ͠΋Β͍ ͍͔ͨΛڞ༗͢Δ࣮ફज़ υϥοΧʔ෩ΤΫααΠζ ʰΞδϟΠϧαϜϥΠʱ +POBUIBO3BTNVTTPOஶ

  19. None
  20. wख़࿅ऀ͔ΒϫφϏʔ·Ͱ͍ ΔϓϩδΣΫτΛྫͱ͢Δ wϨϏϡΞʔͱͯ͠ϨϏϡΠʔ ͷؔ܎ͱͯ͠ίʔυʹର͢ Δظ଴Λ͓࣋ͬͯ͘ 13΁ͷظ଴஋ͷ͢Γ߹Θͤ

  21. ਅ࣮ɿϓϩάϥϚݸਓΛ෼ੳ ͨ͠ݚڀʹΑΔͱɺ࠷΋༏लͳ ϓϩάϥϚ͸࠷ѱʹൺ΂ɺഒ ༏Ε͍ͯΔɻ ιϑτ΢ΣΞΤϯδχΞϦϯά ʰιϑτ΢ΣΞ։ൃͷਅ࣮ͱͷ΢ιʱ ϩόʔτɾ-ɾάϥε

  22. w܁Γฦ͠ίʔυΛߟ͖͑ͯͨϕ ςϥϯͱ࠷ۙϓϩάϥϛϯάΛ ֮͑ͨϫφϏʔͷίʔυ͸ҧ͏ w͋ΔݚڀʹΑΔͱϓϩάϥϚͷ ྗྔࠩ͸ഒ͋Δͱ͍͏ ϓϩάϥϛϯάೳྗͷࠩ

  23. ΧςΰϥΠζྫ ϫφϏʔ ٕज़తͳ ࣮ݱೳྗ υϝΠϯ஌ࣝ ˢ ˠ ίΞ։ൃऀ υϝΠϯΤΩεύʔτ ৽نࢀըͷ

    ։ൃऀ υϝΠϯ ΤΩεύʔτ
  24. ϓϩάϥϛϯάͱ͍͏ ٕܳ

  25. ͲΕ͕͓޷ΈͰ͔͢ʁ bmi = weight / (height ** 2) bmi=w/(h**2) bmi=weight/(height**2)

    " # $
  26. ಡΈͮΒ͍ίʔυͰ΋ ίϯϐϡʔλΛಈ͔ͤ Δ͕ɺͩΕ͔ʹͱͬͯ ಡΈ΍͍͢ίʔυʹ͢ Δʹ͸ηϯεΛཁ͢Δ

  27. wϩδοΫͷଥ౰ੑɺ໊෇͚ͷଥ౰ੑɺ ιϑτ΢ΣΞςετख๏ͳͲਓͷྖҬ wελΠϧͷϨΠΞ΢τͳͲͷϓϩδΣ Ϋτݻ༗จԽ w/ ݕग़ɺػցతʹݕग़ՄೳͳηΩϡ ϦςΟରࡦɺͳͲࣗಈԽͷྖҬ ϨϏϡʔൣғྫ

  28. wਓͰͳ͍ͱϨϏϡʔͰ͖ͳ ͍ϙΠϯτʹͰ͖Δ͚ͩয ఺Λ͍͋ͯͨ wਓ͔ΒਓʹٕܳΛ఻͑Δ ຊ࣭తͳϨϏϡʔ

  29. None
  30. wίʔυϨϏϡʔʹΑΔ੒௕ ػձ͸େ͖͍ w΋ͬͱ΋ίʔυϨϏϡʔྗ ͕ߴ͍಺༰͕νʔϜͰ࠷ߴ ͷ࣭ΛੜΈग़ͤΔ ։ൃϓϩηεਓ

  31. 4/ൺ 4Λ૿΍͠ /ΛݮΒ͢

  32. w13Λ։͘લʹࣗ෼ʹग़དྷΔ࠷ߴͷ13 Ͱ͋Δ͜ͱΛηϧϑϨϏϡʔ͢Δ wgit log -pͰݟฦ͢ɺ3VCP$PQ ͳͲͷ-JOUFSΛ࣮ߦ͢ΔɺͳͲ wࣗ෼ͷͰ͖ΔҎ্ͷ͜ͱ͸Ͱ͖ͳ͍ ͷͰɺͦ͜ΛϨϏϡΞʔʹ೚ͤΔ 4/ൺͷ/ΛݮΒ͢ॳख

  33. w-JOUFS͕ߦ͏ͷ͸ݴޠ࢓༷΍ϓ ϩδΣΫτϧʔϧʹରͯ͠ग़དྷ ͍ͯͳ͍Ұఆظ଴ج४Ϩϕϧ· Ͱͷఈ্͛͢Δ wͰ͖ΔਓΛΑΓͰ͖ΔΑ͏ʹ͢ Δ΋ͷͰ͸ͳ͍ -JOUFSΛ࢖ͬͨࣗಈԽ

  34. w৽͘͠ϓϩδΣΫτʹೖͬͨϝ ϯόʔ΁ͷελΠϧͷػցతͳ ఻ୡΛߦ͑Δ wਓϨϏϡʔͨ͠Βਓಉ ͡ࢦఠ͕Ͱ͖Δ಺༰͸-JOUFS޲ ͖ -JOUFSͷྑ͍ͱ͜Ζ

  35. wࣗ෼ͷॻ͍ͨίʔυʹ͸ࣗ ਎͕౤Ө͞Ε͕ͪ wϨϏϡΞʔରϨϏϡΠʔ :PVWTNF ͔Βࢦఠࣄ߲ ରϨϏϡΠʔͷߏਤʹม͑Δ 1SPCMFNWT6T

  36. -JOUπʔϧ Ξϯνύλʔϯ

  37. wܯࠂΛड͚ೖΕ͍ͯΔঢ়ଶ wσϑΥϧτͰͷద༻͕ϓϩ δΣΫτʹ߹͏͔ݕ౼͢Δ wͦΕ-JOUFSͷόά͔΋ʁ कഁ཭

  38. wͳͥͦͷελΠϧ͕޷·͍͠ ͷ͔͕ϝοηʔδ͚ͩͰ൑ அ͕೉͍͜͠ͱ͕͋Δ w໡໨తʹ-JOUFSΛ࢖͏ͷͰ ͸ͳ͘ελΠϧͷഎܠΛ஌Δ -JOUFSʹݶΒͣίϛϡχέʔγϣϯΛཔΕ

  39. wϋογϡͷΧοί಺ʹۭനΛೖ Εͳ͍೿
 {foo: 1, bar: 2} wϋογϡͷΧοί಺ʹۭനΛೖ ΕΔ೿
 { foo:

    1, bar: 2 } എ൓͢ΔίʔσΟϯάελΠϧ
  40. wΧοίʹۭനΛೖΕͳ͍೿ͷࢥ ૝ wϒϩοΫͱ͍ͬͨແ໊ؔ਺ͱͷ ରൺΛͯ͠ϋογϡͷΑ͏ͳී วతͳΦϒδΣΫτʹΧοί಺ ͷۭന͸ෆཁ ࢥ૝Λ஌Δ

  41. w໊લͷू·ΓͰ͋Δίʔυ ͦͷ΋ͷʹҙຯ͕͋ΔΑ͏ ʹɺϨΠΞ΢τ΍ۭߦʹ΋ ҙຯΛ࣋ͨͤΔ ίʔυͷҰߦɺ݂ͷҰణ

  42. wೣ೿ɺݘ೿ w͖ͷ͜೿ɺ͚ͨͷ͜೿ wจࣈྻμϒϧΫΥʔτ೿ɺ γϯάϧΫΥʔτ೿ ͦΕͧΕͷ޷Έʹݴ͍෼͕͋Δ

  43. IUUQEIBUFOBOFKQLFZXPSE""%"$&"#"#'"#"$&"#$&'$&

  44. wܯࠂΛड͚ೖΕ͍ͯΔঢ়ଶ wσϑΥϧτͰͷద༻͕ϓϩ δΣΫτʹ߹͏͔ݕ౼͢Δ wͦΕ-JOUFSͷόά͔΋ʁ ߟ͑Λ࣋ͬͯक͔Βഁ΁

  45. For Whom the Quality Exists

  46. wࣗಈԽ͞ΕͨϨΠΞ΢τɺ -JOUJOH3VCP$PQ &4-JOU  FUD w/  944ରࡦͳͲඇػೳཁ݅ #SBLFNBO #VMMFU

    FUD w։ൃऀͷϨϕϧʹ͋·Γґଘ͠ͳ͍ ࣗಈԽ͕ൺֱత༰қ
  47. wςʔϒϧઃܭɺΫϥεઃܭɺ໊෇͚ͷ ଥ౰ੑɺϩδοΫͷଥ౰ੑɺͳͲਓͷ ྖҬʹ͓͚Δ΄΅͢΂ͯ wϨϏϡʔΛࣗಈԽͰ͖ͳ͍ίʔυ͕ຊ དྷϨϏϡʔ͍ͨ͠ର৅ wˢ։ൃऀͷٕܳʹґଘ͢Δ࿹ͷݟͤॴ -JOUFSͷۤखͳͱ͜Ζ

  48. wϨϏϡʔʹ͸࣌ؒΛ࢖͏ w܁Γฦ͠දग़͢Δࣄ৅ʹର ͯ͠ίϯϐϡʔλ͸ಘҙ wະ஌ͷࣄ৅ʹ͍ͭͯ·ͩί ϯϐϡʔλʹ͸ݶք͕͋Δ ਓͱίϯϐϡʔλͷϨϏϡʔ

  49. ϨϏϡʔ5JQT

  50. wϨϏϡʔ͸ॳظʹ͚ۙΕ͹͍ۙ΄Ͳ ࢦఠࣄ߲͕ग़қ͍ wBQQSPWFͷ਺͕ҰఆҎ্ʹͳͬͯ ΋ͦΕ΄Ͳ඼࣭͸্͕Βͳ͍ wܦݧ্֓ͶͭBQQSPWF͋Ε͹ྑ͍ w΋ͪΖΜνʔϜͷ଎ͱ࣭ʹΑΔ Կਓ·ͰΫϩεϨϏϡʔʁ

  51. wؒҧ͍ͬͯΔ͜ͱΛؒҧ͍ͬͯΔͱݴΘΕΔ ͷ΋πϥ͍ wࣗ෼ͷࢦఠ͕ؒҧͬͯΔ͜ͱ͕͋Δ wʮ˓˓Ͱ͠ΐ͏͔ʁʯ͸ৗ౟۟Ͱ࢖ͬͨΓ͢ Δ w͔ͳΓͷ֬৴͕͋ͬͯ΋࢖ͬͨΓ͢Δ wಛʹҭ੒޲͖ͷख๏ ֬৴Λࣔ͢ΑΓ໰͍͔͚Α

  52. ౪ਓʹ΋ޒ෼ͷཧΛೝΊΔ ॏཁײΛ࣋ͨͤΔ ਓͷཱ৔ʹ਎Λஔ͘ ਓΛಈ͔̏͢ݪଇ ʰਓΛಈ͔͢ʱ %ɾΧʔωΪʔ

  53. wҰՈݴ͋ΔϨϏϡΞʔ͕͍Δػೳ ͕͋Δ w13Ͱ3FWJFX3FRVFTUΛ͋Β ͔͡Ίૹ͓ͬͯ͘ w͋ͱͰ͜Ε·ͰͷϨϏϡʔ͕Ҿͬ ܁ΓฦΔ͜ͱΛ༧๷͢Δ ൪௕΁ͷϨϏϡʔґཔ

  54. w৭΋৘ใͰ͋Δ wϨϏϡΞʔʹରͯ͠Χϥϑϧͳ৘ใʹͯ͠ ෛՙΛݮΒ͓͢΋ͯͳ͠ wόοΫΫΥʔτͭͷޙΖʹݴޠΛࢦఆ͠ ͯғΉ͜ͱͰϋΠϥΠτ͢Δ
 ```ruby
 puts 'hello, world'
 ```

    ಡΈखͷෛՙΛݮΒ͓͢΋ͯͳ͠
  55. w෇Ճ৘ใͱͯ͠۩ମతͳίʔυߦͷ63- ΛϦϯΫ෇͚Δͱ༗ޮͳ͜ͱ͕͋Δ w͋Δ೔(JU)VCͷίʔυϦϯΫͷ಺༰Λ ݟͨΒҧ͏ՕॴΛ͍ࣔͯ͠Δ wNBTUFSϒϥϯν͸ࠁʑͱมԽ͍ͯ͘͠ w(JU)VCͷίϛοτ্ͰlZzΛԡ͢ ύʔϚϦϯΫΛҾ༻͢Δ

  56. ͋ΘͤͯಡΈ͍ͨ

  57. wॻ͘ਓΑΓಡΉਓͷํ͕ଟ͍ w௕͘੒௕ͯ͠ߦ͘αʔϏε΄Ͳ ίʔυ͸ಡΈܧ͕Ε͍ͯ͘ wݱࡏͷಡऀͱະདྷͷಡऀʹͪΐͬ ͱͨ͠ؾ഑ΓΛ͓ͯ͘͠ 5IFXBZUPUIFUJNFMFTTXBZPG

  58. For Whom the Quality Exists

  59. ࣭ͷཐટ

  60. ίʔυ Ϗδωε ϨϏϡʔ

  61. ίʔυ Ϗδωε ϨϏϡʔ

  62. Ϗδωε ίʔυ ϨϏϡʔ

  63. ϨϏϡʔ Ϗδωε ίʔυ

  64. ίʔυ Ϗδωε ϨϏϡʔ lશମz

  65. ίʔυ Ϗδωε ϨϏϡʔ lશମz γεςϜ૊ΈࠐΈ΁ͷ ࣭޲্ͱ։ൃऀͷ੒௕

  66. wϏδωεϑΟʔυόοΫ΁ͷૉૣ࣮֬͘ͳ ରԠ͸ෳࡶͰͳ͍ίʔυ͕Մೳͱ͢Δ w௕णΞϓϦέʔγϣϯΛϦϓϨʔε͢Δͷ ͸ԟʑʹ༧ࢉͱ࣌ؒΛ൐͏ wίʔυϨϏϡʔͱ͍͏ఆظతͳ݈߁਍அ w༏लͳ։ൃऀ͸݈શͳίʔυ͕॓Δγες Ϝ։ൃʹ޲͔͏ ͳͥͦΜͳʹ΋಺ͳΔ࣭͸ॏཁ͔ʁ

  67. ඼࣭ͱ͸୭͔ʹͱͬͯ ͷՁ஋Ͱ͋Δ ʵ(FSBME.BSWJO8FJOCFSH

  68. None