The Art of Humanizing Pull Requests

The Art of Humanizing Pull Requests

Ba0adbbfa699d09f6ee7b4402e4dcf9f?s=128

Ankita Kulkarni

September 29, 2018
Tweet

Transcript

  1. @KULKARNIANKITA9 THE ART OF HUMANIZING PULL REQUESTS ANKITA KULKARNI, RANGLE.IO

  2. @KULKARNIANKITA9 HI I’M ANKITA

  3. AGENDA @KULKARNIANKITA9 HOW TO CREATE A PR? 
 HOW TO

    REVIEW A PR? HOW TO RESPOND TO FEEDBACK? WHAT IS A PR?
  4. @KULKARNIANKITA9 WHAT IS A PULL REQUEST (PR)?

  5. @KULKARNIANKITA9 HOW TO CREATE A PULL REQUEST?

  6. @KULKARNIANKITA9 BREAKDOWN YOUR STORY/FEATURE AS A USER, I CAN ADD/DELETE

    ITEMS FROM A LIST PR #1: ADD A TEXT BOX & AN ADD BUTTON ON THE PAGE PR #2: CLICKING ON ADD BUTTON ADDS THE ITEM TO THE LIST PR #3: CLICKING ON DELETE, DELETES ITEM FROM THE LIST
  7. @KULKARNIANKITA9 IN-LINE WITH THE PROGRAMMER’S OATH I WILL MAKE FREQUENT,

    SMALL, RELEASES SO THAT I DO NOT IMPEDE THE PROGRESS OF OTHERS. by Robert C. Martin “ “
  8. @KULKARNIANKITA9 YOU WILL GET REVIEWER BLESSINGS FOR DOING SO
 #BLESSINGS

  9. @KULKARNIANKITA9 ADD COMMENTS ON YOUR PR

  10. @KULKARNIANKITA9 ➕SCREENSHOTS/GIFS AS A USER, I WOULD LIKE TO VIEW

    EVERY SCREEN USING THE TAB BAR
  11. @KULKARNIANKITA9 TESTS ARE DOCUMENTATION 
 OF YOUR CODE

  12. @KULKARNIANKITA9 Can I split this code into smaller functions? Should

    I rename this function to something more obvious? How can I simplify my code further so it’s less complex? WHILE WRITING TESTS
  13. @KULKARNIANKITA9 REGARDLESS, YOU SHOULD 
 WRITE A TEST.

  14. @KULKARNIANKITA9

  15. @KULKARNIANKITA9 HOW TO REVIEW A PULL REQUEST?

  16. @KULKARNIANKITA9 BE EMPATHETIC

  17. @KULKARNIANKITA9 FEELINGS CAN GET HURT EASILY

  18. @KULKARNIANKITA9 DON’T BE TOO SERIOUS

  19. @KULKARNIANKITA9 FAMILIARIZE YOURSELF WITH THE CODE *

  20. @KULKARNIANKITA9 ALWAYS PROVIDE 
 CODE SUGGESTIONS

  21. @KULKARNIANKITA9 THIS WILL CRASH WHEN IT’S NULL SO YOU SHOULD

    NULL 
 CHECK THIS. WHAT WILL HAPPEN IF THIS VALUE IS NULL? WHAT ARE SOME CASES WHERE THIS VALUE MIGHT BE NULL? REWORDING FEEDBACK…
  22. @KULKARNIANKITA9 DON’T FORCE IT, KEEP IT REAL USE EMOJIS

  23. @KULKARNIANKITA9 TAKE IT OFFLINE OR .

  24. @KULKARNIANKITA9 NITPICK

  25. @KULKARNIANKITA9 MAKE IT AN ES/TS LINT RULE

  26. @KULKARNIANKITA9 DON’T LITTER CODE 
 WITH NITPICKS

  27. @KULKARNIANKITA9 HOW TO RESPOND TO FEEDBACK?

  28. @KULKARNIANKITA9 IF YOU THINK FEEDBACK IS VALID, IMPLEMENT IT

  29. @KULKARNIANKITA9 I WASN’T AWARE OF THIS API. THAT’S REALLY USEFUL!

    THAT’S AN EXCELLENT POINT, CHANGE COMING RIGHT AWAY! BREAKING UP THIS FUNCTION WAS A GREAT IDEA. SO MUCH SIMPLER NOW. THIS IS AN ELEGANT SOLUTION. I NEVER WOULD HAVE THOUGHT OF THAT. EXAMPLES…
  30. @KULKARNIANKITA9 IF YOU DISAGREE

  31. @KULKARNIANKITA9 MAKE YOUR COMMIT MESSAGES OBVIOUS USE GITMOJI

  32. @KULKARNIANKITA9 ✨ INTRODUCING A NEW FEATURE FIXING A BUG ✅

    ADDING TESTS! PR COMMENTS RELATED WRITING DOCS!
  33. @KULKARNIANKITA9 ONCE YOU FIX A DEFECT, ADD A TEST

  34. @KULKARNIANKITA9 WHAT IF THEY ARE REMOTE?

  35. @KULKARNIANKITA9 PAIR PROGRAMMING

  36. @KULKARNIANKITA9

  37. @KULKARNIANKITA9 SMALL THINGS CAN HAVE A BIG IMPACT

  38. @KULKARNIANKITA9 THANK YOU @KULKARNIANKITA9