The Art of Humanizing Pull Requests

The Art of Humanizing Pull Requests

Ba0adbbfa699d09f6ee7b4402e4dcf9f?s=128

Ankita Kulkarni

September 29, 2018
Tweet

Transcript

  1. 3.

    AGENDA @KULKARNIANKITA9 HOW TO CREATE A PR? 
 HOW TO

    REVIEW A PR? HOW TO RESPOND TO FEEDBACK? WHAT IS A PR?
  2. 6.

    @KULKARNIANKITA9 BREAKDOWN YOUR STORY/FEATURE AS A USER, I CAN ADD/DELETE

    ITEMS FROM A LIST PR #1: ADD A TEXT BOX & AN ADD BUTTON ON THE PAGE PR #2: CLICKING ON ADD BUTTON ADDS THE ITEM TO THE LIST PR #3: CLICKING ON DELETE, DELETES ITEM FROM THE LIST
  3. 7.

    @KULKARNIANKITA9 IN-LINE WITH THE PROGRAMMER’S OATH I WILL MAKE FREQUENT,

    SMALL, RELEASES SO THAT I DO NOT IMPEDE THE PROGRESS OF OTHERS. by Robert C. Martin “ “
  4. 12.

    @KULKARNIANKITA9 Can I split this code into smaller functions? Should

    I rename this function to something more obvious? How can I simplify my code further so it’s less complex? WHILE WRITING TESTS
  5. 21.

    @KULKARNIANKITA9 THIS WILL CRASH WHEN IT’S NULL SO YOU SHOULD

    NULL 
 CHECK THIS. WHAT WILL HAPPEN IF THIS VALUE IS NULL? WHAT ARE SOME CASES WHERE THIS VALUE MIGHT BE NULL? REWORDING FEEDBACK…
  6. 29.

    @KULKARNIANKITA9 I WASN’T AWARE OF THIS API. THAT’S REALLY USEFUL!

    THAT’S AN EXCELLENT POINT, CHANGE COMING RIGHT AWAY! BREAKING UP THIS FUNCTION WAS A GREAT IDEA. SO MUCH SIMPLER NOW. THIS IS AN ELEGANT SOLUTION. I NEVER WOULD HAVE THOUGHT OF THAT. EXAMPLES…
  7. 32.

    @KULKARNIANKITA9 ✨ INTRODUCING A NEW FEATURE FIXING A BUG ✅

    ADDING TESTS! PR COMMENTS RELATED WRITING DOCS!