Story of PR #4657

Story of one pull request, dramatized as a battle between a robot dog and a six eyed daikaiju.

Transcript

1. The Shameful Story of PR #4657 1 @lunardog 2017.03.15
2. 2 @lunardog @fchollet @isaacgreg Travis STARRING ALSO FEATURING ©BBC ©Hine Mizushima Six Eyed Bandel
3. Background 3
4. 4 DOGS vs CATS
5. 5 KERAS.io
6. 6 flow_from_ directory KERAS.io
7. 7 data/train/cats/*.jpg data/train/dogs/*.jpg
8. 8 A more complex dataset
9. 9 The Problem
10. 10 Computer says “NO”. ©BBC
11. %s/ os.listdir / os.walk /g 11 The Solution
12. “ 12
13. 13 PR #4552 (not PR #4657)
16. 16 © BBC Who is this?
19. 19 ©Google This is what Francois Chollet looks like:
20. 20 ©Google, poorly photoshopped by me ...but at that time, to me, he looked like this:
21. 21 © BBC ...and this is what I looked like to him.
25. 25 PR #4637 (burry that ugly code)
32. “ 32 Fail test in 30 minutes
33. “ 33 Fail test in 3 minutes!
34. “ 34
35. 35 PR #4643 (battle with Travis)
37. 37 MERGED!
38. 38 Good boy, K9! © BBC ...but the game is not over yet.
39. 39 ...back to PR #4637
41. 41 bad robot dog... © BBC
43. 43 PR #4657 Let’s do it right this time!
44. “ 44
48. 48 MERGED!
49. 49 The day is saved! © BBC
50. 50 Lessons Learned 1. Contributing to Open Source is a fun and valuable experience 2. If you see something you can fix - go for it! 3. Yes, everybody will see your ugly code 4. ...and you may even end up showing it on a meetup. 5. Don’t rush it! 6. Read before you write 7. Explain your changes and reasons as well as you can 8. Follow the rules 9. Update the documentation 10. Lint your code before pushing 11. Write tests 12. Write tests! 13. Actually run those tests locally before pushing
51. 51 Thanks to Francois Chollet for making Keras and being really supportive when reviewing my messy pull requests. ...and to Isaac Greg for asking me the right question at the right time. Keep on testing, Travis, good job! 6th eye is in the back
52. 52 Thanks to BBC for making Doctor Who. Hoping to see K9 again. Please don’t be too cross at me for using these images.