Danger による コードレビュープロセス改善 / Automated code review in minne

https://shibuya-apk.connpass.com/event/90517/

Transcript

1. ຊؒ
   ୎ਅ
   
   (.0
   1FQBCP
   *OD
   
   4IJCVZBBQL
    %BOHFS
   ʹΑΔ
   ίʔυϨϏϡʔϓϩηεվળ
2. (.0
   ϖύϘגࣜձࣾ
   
   NJOOF
   ࣄۀ෦ ຊؒ
   ୎ਅ
   !NBUBLVDPN 8FC
   "1*
   
   "OESPJE
   3VCZ
   PO
   3BJMT
   
   ,PUMJO
   
   4XJGU
   
3. ίʔυϨϏϡʔ
4. "OESPJE
   ʹ͓͚ΔίʔυϨϏϡʔ߲໨ͷҰྫ w7JFX
   ͷϨΠΞ΢τ
   wϓϩμΫτಠࣗͷϧʔϧʹԊ͍ͬͯΔ͔
   ΞʔΩςΫνϟͳͲ
   wͦ΋ͦ΋ͷ࢓༷ʹ͍͋ͬͯΔ͔ʁ
   ʜͳͲͳͲ
5. ਓؒͳͷͰҙਤ͠ͳ͍ͱ͜ΖͰ
   ݟಀ͢ͱ͜Ζ͕͋Δ
6. ҙਤ͠ͳ͍ݟಀ͠ wίϛοτ͢Δ΂͖ϑΝΠϧ͕ͳ͔ͬͨ
   w΍Δ΂͖͜ͱ͕࢒͍ͬͯΔ
   w༧ظ͠ͳ͍ಈ࡞Λ͢Δ
7. ؔ৺ࣄΛ૿΍͢
   
   ؤுΔ
   ࢓૊Έʹͤͣʹ
   ࣗಈԽͰ͖Δͱ͜Ζ͸͍ͯ͘͠
8. ࣗಈϨϏϡʔ
   CPU
   ͷ
   %BOHFS
   Λಋೖ w΋ͱ΋ͱ
   3VCZ
   ͷจԽ͕͋ͬͨͨΊ
   3VCZ
   ൛͕͋Δ΋ͷΛ࠾༻ͨ͠
   w+BWB4DSJQU
   ൛΋͋Δ
   w$*
   αʔϏε্Ͱಈ͖
   QVMM
   SFRVFTU
   ΠϕϯτΛϑοΫͯ͠νΣοΫ͢Δ
   w%BOHFSpMF
   ʹϧʔϧΛهड़͍ͯ͘͠
   wϓϥάΠϯͷػߏ͕͋Δ
9. %BOHFS
   ͷίϝϯτͷ༷ࢠ
10. NJOOF
    Ͱͷ׆༻ࣄྫ
11. "OESPJE
    MJOU
    ʹΑΔ੩తղੳ݁ՌΛίϝϯτ w௥Ճ
    มߋ͕͋ͬͨϑΝΠϧͷΈΛର৅ʹ͍ͯ͠Δ
    wIUUQTHJUIVCDPNMPBETNBSUEBOHFSBOESPJE@MJOU
    Λ࢖༻
    w8BSOJOH
    Ҏ্Λίϝϯτઃఆ
12. ϑΝΠϧͷίϛοτ๨ΕΛͳ͘͢ wηοτͰόʔδϣϯ؅ཧ͢Δ΂͖ϑΝΠϧ͕ίϛοτ͞Ε͍ͯΔ͔ΛνΣοΫ
    wIUUQTHJUIVCDPNNBUBLVEBOHFSMPDL@EFQFOEFODZ@WFSTJPOT
    
13. ಛఆͷจࣈྻΛνΣοΫ͢Δ w͋Δจࣈྻ͕͋ͬͨΒίϝϯτͯ͠΄͍͠
    w$VTUPN
    MJOU
    ʹ͢Δ·Ͱ΋ͳ͍΋ͷ
    50%0
    '*9.&
    ͳͲ
    wIUUQTHJUIVCDPNNBUBLVEBOHFSMPDBM@SVMFT
    Λ࢖༻
14. ੜ੒͞ΕΔ
    BQL
    ͷݖݶͷมԽΛݕ஌͢Δ w਎ʹ͕֮͑ͳ͍ݖݶ͕෇༩͞Ε͍ͯͨ৔߹ʹؾ෇͘ͷ͕ࠔ೉
    w(PPHMF
    1MBZ
    $POTPMF
    ʹ্͛ͯΑ͏΍͘ؾ෇͍ͨࣄྫ͕͋ͬͨ
    wओʹϥΠϒϥϦ
    ٴͼͦͷΞοϓσʔτΛ૝ఆ
    w IUUQTHJUIVCDPNNBUBLVEBOHFSBOESPJE@QFSNJTTJPOT@DIFDLFS
    Λ࢖༻
    wݱঢ়ͷݖݶͷϦετΛίϛοτ͓͖ͯ͠
    ੜ੒͞Εͨ
    BQL
    ͷݖݶͱൺֱ͠
    ࠩ෼͕͋Ε͹ίϝϯτ
    wBBQU
    ࢖༻
15. ੜ੒͞ΕΔ
    BQL
    ͷݖݶͷมԽΛݕ஌͢Δ
16. ྑ͍ϓϥάΠϯɾӡ༻ํ਑͕͋Ε͹
    ͥͻڭ͍͑ͯͩ͘͞ʂ