About using gem "cells" and "little refactoring"

Transcript

1. me Developer at datarockets email: maximabramchuck@gmail.com skype: maximabramchuk github: maximabramchuck twitter: @MaximAbramchuck Maxim Abramchuk
2. Wroclaw Minsk
3. me Developer at datarockets email: maximabramchuck@gmail.com skype: maximabramchuk github: maximabramchuck twitter: @MaximAbramchuck Maxim Abramchuk
4. Rails application
5. Rails application • main functional - managing orders
6. Rails application • main functional - managing orders • complex business logic
7. Rails application • main functional - managing orders • complex business logic
8. Rails application • main functional - managing orders • complex business logic • many roles (admin, call operator, post manager, analyst and etc.)
9. Rails application • main functional - managing orders • complex business logic • many roles (admin, call operator, post manager, analyst and etc.) • many order states (new, waiting for clarification, processing, sent, paid, returned)
10. Sample application
11. Sample application
14. Some examples: • Post manager can’t see order’s contact information if order is in state ’New’. • Call operator should see ‘Process' button if order is in state 'Waiting clarification’ only. • Analyst should have a ‘Cancel’ button if order is in all the states, except ‘Sent’ and ‘Paid’.
15. Problems:
16. Problems: • Plenty of duplicated code, which we could not reuse
17. Problems: • Plenty of duplicated code, which we could not reuse • A lot of ‘IF’ statements in the views because of logic depending on order’s state
18. Problems: • Plenty of duplicated code, which we could not reuse • A lot of ‘IF’ statements in the views because of logic depending on order’s state So, order’s logic was growing and our code was growing too.
20. WE
21. WE REFACTORED
22. WE REFACTORED A LITTLE
23. WE REFACTORED A LITTLE
24. WE REFACTORED A LITTLE
28. 1. Removed all the scoped controllers and created one OrdersController for all the roles
29. 1. Removed all the scoped controllers and created one OrdersController for all the roles 2. Created /concepts folder, and Order::Cell
30. 1. Removed all the scoped controllers and created one OrdersController for all the roles 2. Created /concepts folder, and Order::Cell 3. in app/views/orders/index.slim
31. And what is actually a cell?
32. And what is actually a cell?
34. Post Manager Sent
35. Post Manager Sent
36. Post Manager Sent PostManager::SentOrder::Cell
44. • The Analyst can’t see the order’s contact information if the order is in state ’New’.
45. As you remember in Order::Cell we had body_parts method and Analyst::NewOrder::Cell
46. Create Analyst::NewOrder::Cell inherited from Order::Cell
47. Create Analyst::NewOrder::Cell inherited from Order::Cell Remove contact_information from this array
48. Create Analyst::NewOrder::Cell inherited from Order::Cell Remove contact_information from this array
49. Thanks for your attention!