Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Reviewing Code Reviews
Search
Gio Lodi
August 30, 2018
Programming
1
1.2k
Reviewing Code Reviews
A look at the value of code reviews, with tips for authors, reviewers, and automation.
Gio Lodi
August 30, 2018
Tweet
Share
More Decks by Gio Lodi
See All by Gio Lodi
WWDC 2021: What's New in Testing
mokagio
0
1.9k
Slack Considered Harmful
mokagio
0
130
Less Conventional Swift (Lighting Talk)
mokagio
0
100
Talking myself into the value of acceptance testing
mokagio
0
71
Other Decks in Programming
See All in Programming
いま中途半端なSwift 6対応をするより、Default ActorやApproachable Concurrencyを有効にしてからでいいんじゃない?
yimajo
2
400
overlayPreferenceValue で実現する ピュア SwiftUI な AdMob ネイティブ広告
uhucream
0
180
Flutterで分数(Fraction)を表示する方法
koukimiura
0
130
Cloudflare AgentsとAI SDKでAIエージェントを作ってみた
briete
0
140
After go func(): Goroutines Through a Beginner’s Eye
97vaibhav
0
350
2分台で1500examples完走!爆速CIを支える環境構築術 - Kaigi on Rails 2025
falcon8823
3
3.5k
Signals & Resource API in Angular: 3 Effective Rules for Your Architecture @BASTA 2025 in Mainz
manfredsteyer
PRO
0
110
階層構造を表現するデータ構造とリファクタリング 〜1年で10倍成長したプロダクトの変化と課題〜
yuhisatoxxx
3
970
登壇は dynamic! な営みである / speech is dynamic
da1chi
0
270
Catch Up: Go Style Guide Update
andpad
0
210
CSC305 Lecture 06
javiergs
PRO
0
210
アメ車でサンノゼを走ってきたよ!
s_shimotori
0
220
Featured
See All Featured
個人開発の失敗を避けるイケてる考え方 / tips for indie hackers
panda_program
114
20k
YesSQL, Process and Tooling at Scale
rocio
173
14k
Understanding Cognitive Biases in Performance Measurement
bluesmoon
29
2.7k
A Tale of Four Properties
chriscoyier
160
23k
Thoughts on Productivity
jonyablonski
70
4.9k
Connecting the Dots Between Site Speed, User Experience & Your Business [WebExpo 2025]
tammyeverts
9
590
CoffeeScript is Beautiful & I Never Want to Write Plain JavaScript Again
sstephenson
162
15k
The Pragmatic Product Professional
lauravandoore
36
6.9k
Automating Front-end Workflow
addyosmani
1371
200k
Making Projects Easy
brettharned
119
6.4k
Refactoring Trust on Your Teams (GOTO; Chicago 2020)
rmw
35
3.2k
Being A Developer After 40
akosma
91
590k
Transcript
Reviewing Code Reviews
Gio iOS Lead at @mokagio gio.codes
What & Why
Code Reviews are… Discussion on the code
Code Reviews are… Learning opportunity
Code Reviews are… ✍ share new things they learnt "
teach what they know
Code Reviews are… Growth opportunity for the team
Invest in Code Reviews because… If code reviews make the
team better, then better code reviews will make the team even better
“Indeed, the ratio of time spent reading versus writing is
well over 10 to 1. We are constantly reading old code as part of the effort to write new code. Robert C. Martin (Uncle Bob) - Clean Code
"" "" "" "" "" ✍
Invest in Code Reviews because… Less back and forth
1. As an author ✍ 2. As a reviewer "
3. As a robot #
As an author ✍
As an author ✍ Write a great PR description -
What AND Why - Context - Graphs, Images, GIFs, Links
None
None
None
As an author ✍ Review your PRs yourself first
As an author ✍ Keep your PRs small and focused
https://twitter.com/iamdevloper/status/397664295875805184
As a reviewer "
As a reviewer " Watch your language
None
As a reviewer " $ “How would I feel if
someone left this comment to me?”
As a reviewer " Ask questions
As a reviewer " Constructive Criticism
As a reviewer " Strong rationales (and links to back
them up)
None
As a reviewer " Review what the code DOES not
how it LOOKS
As a reviewer " Use a style guide
https://github.com/iflix-letsplay/swift-style-guide
As a reviewer " You can code review your style
guide %
As a robot #
As a robot # Automate your style guide Linters Formatters
https://github.com/realm/SwiftLint
https://houndci.com/
https://prettier.io/
As a robot # Check for mistakes easy to make
https://danger.systems
https://danger.systems
https://danger.systems
As a robot # Use a PR template
https://blog.github.com/2016-02-17-issue-and-pull-request-templates/
https://blog.github.com/2016-02-17-issue-and-pull-request-templates/
https://twitter.com/mokagio/status/1019709696872087557
Recap ☝ Code Reviews are first and foremost a growth
opportunity for the team ' A good Code Review starts with the author ✍ As a reviewers, be inquisitive and constructive " Use automation to remove friction and take care of mundane checks #
Questions❓
@mokagio gio.codes/talks/lastconf18