Reviewing Code Reviews

A look at the value of code reviews, with tips for authors, reviewers, and automation.

Transcript

1. Reviewing Code Reviews
2. Gio iOS Lead at @mokagio gio.codes
3. What & Why
4. Code Reviews are… Discussion on the code
5. Code Reviews are… Learning opportunity
6. Code Reviews are… ✍ share new things they learnt " teach what they know
7. Code Reviews are… Growth opportunity for the team
8. Invest in Code Reviews because… If code reviews make the team better, then better code reviews will make the team even better
9. “Indeed, the ratio of time spent reading versus writing is well over 10 to 1. We are constantly reading old code as part of the effort to write new code. Robert C. Martin (Uncle Bob) - Clean Code
10. "" "" "" "" "" ✍
11. Invest in Code Reviews because… Less back and forth
12. 1. As an author ✍ 2. As a reviewer " 3. As a robot #
13. As an author ✍
14. As an author ✍ Write a great PR description - What AND Why - Context - Graphs, Images, GIFs, Links
18. As an author ✍ Review your PRs yourself first
19. As an author ✍ Keep your PRs small and focused
20. https://twitter.com/iamdevloper/status/397664295875805184
21. As a reviewer "
22. As a reviewer " Watch your language
24. As a reviewer " $ “How would I feel if someone left this comment to me?”
25. As a reviewer " Ask questions
26. As a reviewer " Constructive Criticism
27. As a reviewer " Strong rationales (and links to back them up)
29. As a reviewer " Review what the code DOES not how it LOOKS
30. As a reviewer " Use a style guide
31. https://github.com/iflix-letsplay/swift-style-guide
32. As a reviewer " You can code review your style guide %
33. As a robot #
34. As a robot # Automate your style guide Linters Formatters
35. https://github.com/realm/SwiftLint
36. https://houndci.com/
37. https://prettier.io/
38. As a robot # Check for mistakes easy to make
39. https://danger.systems
40. https://danger.systems
41. https://danger.systems
42. As a robot # Use a PR template
43. https://blog.github.com/2016-02-17-issue-and-pull-request-templates/
44. https://blog.github.com/2016-02-17-issue-and-pull-request-templates/
45. https://twitter.com/mokagio/status/1019709696872087557
46. Recap ☝ Code Reviews are first and foremost a growth opportunity for the team ' A good Code Review starts with the author ✍ As a reviewers, be inquisitive and constructive " Use automation to remove friction and take care of mundane checks #
47. Questions❓
48. @mokagio gio.codes/talks/lastconf18