Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Reviewing Code Reviews
Search
Gio Lodi
August 30, 2018
Programming
1
1.1k
Reviewing Code Reviews
A look at the value of code reviews, with tips for authors, reviewers, and automation.
Gio Lodi
August 30, 2018
Tweet
Share
More Decks by Gio Lodi
See All by Gio Lodi
WWDC 2021: What's New in Testing
mokagio
0
1.8k
Slack Considered Harmful
mokagio
0
120
Less Conventional Swift (Lighting Talk)
mokagio
0
83
Talking myself into the value of acceptance testing
mokagio
0
49
Other Decks in Programming
See All in Programming
2024年のWebフロントエンドのふりかえりと2025年
sakito
1
230
お前もAI鬼にならないか?👹Bolt & Cursor & Supabase & Vercelで人間をやめるぞ、ジョジョー!👺
taishiyade
5
3.8k
『GO』アプリ バックエンドサーバのコスト削減
mot_techtalk
0
130
iOSエンジニアから始める visionOS アプリ開発
nao_randd
3
120
Lottieアニメーションをカスタマイズしてみた
tahia910
0
120
いりゃあせ、PHPカンファレンス名古屋2025 / Welcome to PHP Conference Nagoya 2025
ttskch
1
270
SRE、開発、QAが協業して挑んだリリースプロセス改革@SRE Kaigi 2025
nealle
3
4.1k
Amazon Q Developer Proで効率化するAPI開発入門
seike460
PRO
0
110
GAEログのコスト削減
mot_techtalk
0
110
SpringBoot3.4の構造化ログ #kanjava
irof
2
970
DevinとCursorから学ぶAIエージェントメモリーの設計とMoatの考え方
itarutomy
1
640
ファインディの テックブログ爆誕までの軌跡
starfish719
2
1.1k
Featured
See All Featured
Principles of Awesome APIs and How to Build Them.
keavy
126
17k
Practical Tips for Bootstrapping Information Extraction Pipelines
honnibal
PRO
12
950
Why You Should Never Use an ORM
jnunemaker
PRO
55
9.2k
Raft: Consensus for Rubyists
vanstee
137
6.8k
Adopting Sorbet at Scale
ufuk
74
9.2k
Rails Girls Zürich Keynote
gr2m
94
13k
We Have a Design System, Now What?
morganepeng
51
7.4k
How to Think Like a Performance Engineer
csswizardry
22
1.3k
GraphQLの誤解/rethinking-graphql
sonatard
68
10k
10 Git Anti Patterns You Should be Aware of
lemiorhan
PRO
656
59k
Code Reviewing Like a Champion
maltzj
521
39k
Fantastic passwords and where to find them - at NoRuKo
philnash
51
3k
Transcript
Reviewing Code Reviews
Gio iOS Lead at @mokagio gio.codes
What & Why
Code Reviews are… Discussion on the code
Code Reviews are… Learning opportunity
Code Reviews are… ✍ share new things they learnt "
teach what they know
Code Reviews are… Growth opportunity for the team
Invest in Code Reviews because… If code reviews make the
team better, then better code reviews will make the team even better
“Indeed, the ratio of time spent reading versus writing is
well over 10 to 1. We are constantly reading old code as part of the effort to write new code. Robert C. Martin (Uncle Bob) - Clean Code
"" "" "" "" "" ✍
Invest in Code Reviews because… Less back and forth
1. As an author ✍ 2. As a reviewer "
3. As a robot #
As an author ✍
As an author ✍ Write a great PR description -
What AND Why - Context - Graphs, Images, GIFs, Links
None
None
None
As an author ✍ Review your PRs yourself first
As an author ✍ Keep your PRs small and focused
https://twitter.com/iamdevloper/status/397664295875805184
As a reviewer "
As a reviewer " Watch your language
None
As a reviewer " $ “How would I feel if
someone left this comment to me?”
As a reviewer " Ask questions
As a reviewer " Constructive Criticism
As a reviewer " Strong rationales (and links to back
them up)
None
As a reviewer " Review what the code DOES not
how it LOOKS
As a reviewer " Use a style guide
https://github.com/iflix-letsplay/swift-style-guide
As a reviewer " You can code review your style
guide %
As a robot #
As a robot # Automate your style guide Linters Formatters
https://github.com/realm/SwiftLint
https://houndci.com/
https://prettier.io/
As a robot # Check for mistakes easy to make
https://danger.systems
https://danger.systems
https://danger.systems
As a robot # Use a PR template
https://blog.github.com/2016-02-17-issue-and-pull-request-templates/
https://blog.github.com/2016-02-17-issue-and-pull-request-templates/
https://twitter.com/mokagio/status/1019709696872087557
Recap ☝ Code Reviews are first and foremost a growth
opportunity for the team ' A good Code Review starts with the author ✍ As a reviewers, be inquisitive and constructive " Use automation to remove friction and take care of mundane checks #
Questions❓
@mokagio gio.codes/talks/lastconf18