Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Reviewing Code Reviews
Search
Gio Lodi
August 30, 2018
Programming
1
1.1k
Reviewing Code Reviews
A look at the value of code reviews, with tips for authors, reviewers, and automation.
Gio Lodi
August 30, 2018
Tweet
Share
More Decks by Gio Lodi
See All by Gio Lodi
WWDC 2021: What's New in Testing
mokagio
0
1.9k
Slack Considered Harmful
mokagio
0
120
Less Conventional Swift (Lighting Talk)
mokagio
0
90
Talking myself into the value of acceptance testing
mokagio
0
57
Other Decks in Programming
See All in Programming
Design Pressure
hynek
0
160
バイラテラルアップサンプリング
fadis
3
620
Global Azure 2025 @ Kansai / Hyperlight
kosmosebi
0
160
AIコーディングの理想と現実
tomohisa
38
40k
fieldalignmentから見るGoの構造体
kuro_kurorrr
0
140
iOSアプリで測る!名古屋駅までの 方向と距離
ryunakayama
0
160
Cursorを活用したAIプログラミングについて 入門
rect
0
290
generative-ai-use-cases(GenU)の推しポイント ~2025年4月版~
hideg
1
430
データベースの技術選定を突き詰める ~複数事例から考える最適なデータベースの選び方~
nnaka2992
3
2.4k
「MCPを使ってる人」が より詳しくなるための解説
yamaguchidesu
0
250
OpenTelemetry + LLM = OpenLLMetry!?
yunosukey
2
190
カウシェで Four Keys の改善を試みた理由
ike002jp
1
140
Featured
See All Featured
個人開発の失敗を避けるイケてる考え方 / tips for indie hackers
panda_program
105
19k
What's in a price? How to price your products and services
michaelherold
245
12k
The World Runs on Bad Software
bkeepers
PRO
68
11k
[RailsConf 2023] Rails as a piece of cake
palkan
55
5.5k
Rails Girls Zürich Keynote
gr2m
94
13k
The Illustrated Children's Guide to Kubernetes
chrisshort
48
50k
No one is an island. Learnings from fostering a developers community.
thoeni
21
3.3k
The Invisible Side of Design
smashingmag
299
50k
Scaling GitHub
holman
459
140k
How to Ace a Technical Interview
jacobian
276
23k
A designer walks into a library…
pauljervisheath
205
24k
Templates, Plugins, & Blocks: Oh My! Creating the theme that thinks of everything
marktimemedia
30
2.4k
Transcript
Reviewing Code Reviews
Gio iOS Lead at @mokagio gio.codes
What & Why
Code Reviews are… Discussion on the code
Code Reviews are… Learning opportunity
Code Reviews are… ✍ share new things they learnt "
teach what they know
Code Reviews are… Growth opportunity for the team
Invest in Code Reviews because… If code reviews make the
team better, then better code reviews will make the team even better
“Indeed, the ratio of time spent reading versus writing is
well over 10 to 1. We are constantly reading old code as part of the effort to write new code. Robert C. Martin (Uncle Bob) - Clean Code
"" "" "" "" "" ✍
Invest in Code Reviews because… Less back and forth
1. As an author ✍ 2. As a reviewer "
3. As a robot #
As an author ✍
As an author ✍ Write a great PR description -
What AND Why - Context - Graphs, Images, GIFs, Links
None
None
None
As an author ✍ Review your PRs yourself first
As an author ✍ Keep your PRs small and focused
https://twitter.com/iamdevloper/status/397664295875805184
As a reviewer "
As a reviewer " Watch your language
None
As a reviewer " $ “How would I feel if
someone left this comment to me?”
As a reviewer " Ask questions
As a reviewer " Constructive Criticism
As a reviewer " Strong rationales (and links to back
them up)
None
As a reviewer " Review what the code DOES not
how it LOOKS
As a reviewer " Use a style guide
https://github.com/iflix-letsplay/swift-style-guide
As a reviewer " You can code review your style
guide %
As a robot #
As a robot # Automate your style guide Linters Formatters
https://github.com/realm/SwiftLint
https://houndci.com/
https://prettier.io/
As a robot # Check for mistakes easy to make
https://danger.systems
https://danger.systems
https://danger.systems
As a robot # Use a PR template
https://blog.github.com/2016-02-17-issue-and-pull-request-templates/
https://blog.github.com/2016-02-17-issue-and-pull-request-templates/
https://twitter.com/mokagio/status/1019709696872087557
Recap ☝ Code Reviews are first and foremost a growth
opportunity for the team ' A good Code Review starts with the author ✍ As a reviewers, be inquisitive and constructive " Use automation to remove friction and take care of mundane checks #
Questions❓
@mokagio gio.codes/talks/lastconf18