Railsの気持ちを考えながらコントローラとビューを整頓する/tidying-rails-controllers-and-views-as-rails-think

3BJMTͷؾ࣋ͪΛߟ͑ͳ͕Β ίϯτϩʔϥͱϏϡʔΛ ੔಴͢Δ ॾڮګհ!NPSP 3BJMT5PLZP

EZOBNJD ॾڮګհ!NPSP ,BJHJPO3BJMT,FZOPUF

https://speakerdeck.com/yahonda/railsnohua-wosiyou?slide=23

3BJMTͷؾ࣋ͪΛߟ͑ͳ͕Β ίϯτϩʔϥͱϏϡʔΛ ੔಴͢Δ

3BJMTͷؾ࣋ͪʹԊ͏ͱɺγϯϓϧʹ࣮૷Ͱ͖Δ w ΠϕϯτΤϯςΟςΟΛݟग़ͯ͠3%#ʹදݱ͠ɺIBT@NBOZUISPVHIͳ "3Ϟσϧͱͯ͠ɺҰڃʹѻ͏ w ΠϕϯτΤϯςΟςΟʹ୅ද͞ΕΔʮίτʯΛ3&45Ϧιʔεͱͯ͠ଊ͑ ΍Γ͍ͨ͜ͱΛͦͷ$36%ૢ࡞Ͱදݱ͢Δ w 3BJMT͕ఏڙ͢ΔΠϯλʔϑΣʔεΛࢥ͍ඳ͖ɺ"3΍".Pɺ 3VCZͷॊೈੑΛ׆͔ͯ͠ܧଓతʹ։ൃɾϦϑΝΫλϦϯά͍ͯ͘͠

ࢲ͕ࢥ͏3BJMTͷؾ࣋ͪ w ੲ͔ΒมΘΒͣ͋Δجຊ"1*͸ɺ3BJMT΋࢖ͬͯཉ͔͠Ζ͏ w ͜͏Ͱ͖ͨΒͳͱࢥͬͨΒɺ3BJMT΋ͦͷͱ͓Γʹൃలͨ͠ "1*΋ؾ࣋ͪʹԊ͏ͩΖ͏ w جຊઃܭΛҡ࣋ͨ͠͏͑Ͱચ࿅͞Εଓ͚͍ͯΔ"1*΋ɺ ͖ͬͱͲΜͲΜ׆༻ͯ͠ཉ͍͠ͷͰ͸ͳ͍͔

ੲ͔Β͋Δجຊ"1*Λ࢖͏ w 3&45Ͱ͋ΓɺΞϓϦέʔγϣϯػೳΛϦιʔεͷ$36%Ͱදݱ͢Δ w ʮ$36%ͰࡁΉΞϓϦέʔγϣϯʹ޲͍ͯΔʯͱ͍͏ͷͱ͸ͪΐͬͱے͕ٯ w ϑϨʔϜϫʔΫͱͷ݁߹ʹ͸ɺ999#BTFͷܧঝΛ༻͍Δ w ͦΕҎ֎Ͱ͍ͬͺ͍ܧঝ͠Ζɺͱ͸ݴͬͯͳ͍ɻ͢Δͳͱ΋ݴͬͯͳ͍͚Ͳ w
ΞϓϦέʔγϣϯίʔυͰͷڞ௨Խ͸$PODFSOΛ࢖͏ɺͱ͔΋

͜͏͍ͨ͠ͱࢥͬͯͨΒɺͦ͏ൃలͨ͠"1*Λ࢖͏ w "3ͷ%#ඇґଘͷػೳΛ࢖͍͍ͨͳʔͱࢥ͍ͬͯͨΒ "DUJWF.PEFM͕Ͱ͖ͨ w ΞϓϦέʔγϣϯͰͷڞ௨نఆΫϥε͕ཉ͍͠ͱࢥͬͯͨΒ "QQMJDBUJPO3FDPSE͕ఆٛ͞ΕΔΑ͏ʹͳͬͨ w QBSBNTSFRVJSF R
QFSNJU B C D ͕ΊΜͲ͍͘͞ͱࢥͬͯͨΒ QBSBNTFYQFDU͕௥Ճ͞Εͨ

جຊઃܭΛҡ࣋ɺચ࿅͞Εଓ͚͍ͯΔ"1*Λ࢖͏ w "DUJWF3FDPSE͸΄Μͱ͏ʹ͍͢͝ɻ%#ͷςʔϒϧΧϥϜ໊Λ Ϋϥεଐੑ໊ʹϚοϐϯά͢Δͱ͍͏جຊػೳ͸มΘΒͣศརͳ͏͑Ͱɺ w "DUJWF3FDPSE3FMBUJPOͱɺͦͷج൫ͷ"SFM3FMBUJPOɺͦΕΛ࢖ͬͨ "TTPDJBUJPO1SPYZ͕ຊ౰ʹ͍͢͝ͷͰɺ͜ΕΛ࢖͍౗͍ͨ͠ w IBT@NBOZdUISPVHIΛ͞ΒʹUISPVHIͰ͖ͯɺ·ͱ΋ͳΫΤϦʹͳΔΜͰ͢Α

ίϯτϩʔϥͱϏϡʔ w 'BU$POUSPMMFSΑ͘ͳ͍ΑͶɺ͘Β͍͔͠ޠΒΕ͍ͯͳ͍ w ແيಓʹ'BUͳίϯτϩʔϥ͸Α͘ͳ͍ w ωΨςΟϒදݱ ͳ ର৅ ͸Α͘ͳ͍ɻͦΕ͸ͦ͏
w ίϯτϩʔϥͷ੹຿͚ͩ΍ΔίϯτϩʔϥͳΒ͹Α͍ͷͰ͸ w ϙδςΟϒදݱ ͳ ର৅ ͳΒΑ͍ͷͰ͸ ͦΕ͸ͦ͏ w ͋Μ·ΓޠΒΕͯ͜ͳ͔ͬͨͱ͜ΖͳͷͰߟ͑ͯΈ͍ͨ

“ 整頓。整頓可愛小、誰嫌。 ,FOU#FDLʮ5JEZ'JSTU ʯ
ୈ෦੔಴

ՄѪͯ͘;Θ;Θͨ͠খ͞ͳαϒηοτ w શ໘ϦχϡʔΞϧ΍ɺφϯτΧΞʔΩςΫνϟͷಋೖͰ͸ͳ͍ w ೔ʑͷ։ൃΛ͠ͳ͕ΒίʔυΛগͣͭ͠ઃܭͯ͠มߋ͢Δ w EZOBNJDͷ࿩Ͱ͢

‣ "DUJWF3FDPSE3FMBUJPOΛ׆༻͢Δ ‣ ίϯτϩʔϥͷΠϯελϯεม਺ΛݮΒ͢ ‣ Ұ෦ͷJODMVEFT͸ϏϡʔͰࢦఆ͢Δ

جຊઃܭΛҡ࣋ɺચ࿅͞Εଓ͚͍ͯΔ"1*Λ࢖͏ w "DUJWF3FDPSE͸΄Μͱ͏ʹ͍͢͝ɻ%#ͷςʔϒϧΧϥϜ໊Λ Ϋϥεଐੑ໊ʹϚοϐϯά͢Δͱ͍͏جຊػೳ͸มΘΒͣศརͳ͏͑Ͱɺ w "DUJWF3FDPSE3FMBUJPOͱɺͦͷج൫ͷ"SFM3FMBUJPOɺͦΕΛ࢖ͬͨ "TTPDJBUJPO1SPYZ͕ຊ౰ʹ͍͢͝ͷͰɺ͜ΕΛ࢖͍౗͍ͨ͠ w IBT@NBOZdUISPVHIΛ͞ΒʹUISPVHIͰ͖ͯɺ·ͱ΋ͳΫΤϦʹͳΔΜͰ͢Α

‣ "DUJWF3FDPSE3FMBUJPOΛ׆༻͢Δ ‣ ݖݶνΣοΫΛΞιγΤʔγϣϯͰදݱ͢Δ ‣ ෳࡶͳؔ܎ΛUISPVHIͷUISPVHIͰදݱ͢Δ ‣ ίϯτϩʔϥͷΠϯελϯεม਺ΛݮΒ͢ ‣ Ұ෦ͷJODMVEFT͸ϏϡʔͰࢦఆ͢Δ

ݖݶνΣοΫΛΞιγΤʔγϣϯͰදݱ͢Δ w ίϯτϩʔϥͷίʔυ͕૿͑Δཧ༝ͷҰͭʹɺର৅Ϧιʔε ΁ͷΞΫηεՄ൱੍ޚͷίʔυ͕͋Δ w ΞιγΤʔγϣϯΛ׆༻͢Δ͜ͱͰ͋Δछͷݖݶ੍ޚ͕Ͱ͖Δ w ͜ͷΞιγΤʔγϣϯΛࢧ͑Δͷ͕"DUJWF3FDPSE3FMBUJPO

Սۭͷ*TTVF؅ཧΛྫʹऔΓ·͢

1FSTPOIBT@NBOZQSPKFDUT UISPVHINFNCFSTIJQT w IBT@NBOZUISPVHIΞιγΤʔγϣϯ w "DUJWF3FDPSEͰ/.ؔ࿈Λදݱ͢Δఆ൪ w ަࠩςʔϒϧ΋Ϟσϧͱͯ͠ѻ͑Δ w ͦͷؔ࿈ͰΛϞσϧͱͯ͠ѻ͑ΔͨΊɺ͞Βʹ৘ใΛ෇ՃͰ͖Δ
w NFNCFSTIJQTͷSPMFͳͲ IBT@NBOZ͕QVCMJDϝιουͳͷͰSBJMTDͰͷࢼߦࡨޡ͕΍Γ΍͍͢ͷྑ͍Ͱ͢ΑͶɻ޷͖

3BJMTͷؾ࣋ͪʹͳͬͯߟ͑Δ w ࠷ॳͷ࠷ॳ͸IBCUN͜ͱIBT@BOE@CFMPOHT@UP@NBOZؔ࿈͚͕ͩ͋ͬͨ w 3BJMTͷஈ֊ͰɺIBT@NBOZUISPVHI͕௥Ճ͞Εͨ w ͦͷ͋ͱ΋ɺIBT@POFUISPVHI΍CFMPOHT@UPUISPVHIͳͲɺ UISPVHI଒ོ͕੝ΛۃΊ͍ͯΔ w υϝΠϯͷදݱͱͯ͠༏Ε͍ͯΔ
͖ΐ͏͸ͬͪ͜ͷ࿩ w ػೳతʹ΋UISPVHIͷUISPVHIͳͲͰؔ࿈Λ୧ΕΔͷ͕ͪΐ͏ศར͡Όͳ͍Ͱ͔͢ "3εΰΠ

վળલϩʔυͨ͠ޙʹݖݶΛνΣοΫ͢Δ w *TTVFΛߋ৽͢ΔલʹɺҎԼΛνΣοΫ͍ͨ͠ɿ w ΞΫηεऀ͕ϓϩδΣΫτͷϝϯόʔͰ͋Δ͜ͱ w ର৅ͷ*TTVF͕ຊ౰ʹͦͷϓϩδΣΫτͷ΋ͷͰ͋Δ͜ͱ

վળલϩʔυͨ͠σʔλͷݖݶΛνΣοΫ͢Δ class IssuesController < ApplicationController def update @project = Project.find_by(name:
params[:project_name]) member_ids = @project.memberships.pluck(:person_id) unless member_ids.include?(current_person.id) render plain: 'ͩΊͩΑʔ' return end @issue = Issue.find(params[:id]) unless @issue.project_id == @project.id render plain: 'ͩΊͩΑʔ' return end @issue.update!(params.expect(issue: %i(title description status))) # ...

վળޙΞΫηεՄೳͳू߹͔Βର৅Λ୳͢ w ϩʔυ͔ͯ͠ΒݖݶΛνΣοΫ͢ΔͷͰͳ͘ w ΞΫηεͰ͖Δؔ܎ੑʹ͋Δू߹͔Βݕࡧ͢Δ w ʮΞΫηεͰ͖Δؔ܎ੑʯ͕͋Δ͜ͱ͸ɺNFNCFSTIJQT͔Β୧ΕΔ

վળޙΞΫηεՄೳͳू߹͔Βର৅Λ୳͢ class IssuesController < ApplicationController def update @project = current_person.projects.find_by!(name:
params[:project_name]) @issue = @project.issues.find(params[:id]) @issue.update!(params.expect(issue: %i(title description status))) # ... rescue ActiveRecord::RecordNotFound render plain: 'ͩΊͩΑʔ' end end

վળޙΞΫηεՄೳͳू߹͔Βର৅Λ୳͢ w DVSSFOU@QFSTPOQSPKFDUT ͸IBT@NBOZdUISPVHI NFNCFSTIJQTͰ݁͹Ε͍ͯΔϓϩδΣΫτͷΈΛબ୒͢Δ w !QSPKFDUJTTVFT ͸ͦͷϓϩδΣΫτͷΠγϡʔ͚ͩΛબ୒͢Δ w ͦΕͧΕɺݟ͔ͭΒͳ͚Ε͹3FDPSE/PU'PVOE͕ൃੜ͢Δ
w ͜ͷΫΤϦ΋ɺ"DUJWF3FDPSE͕ޮ཰తͳ΍ͭΛ࡞ͬͯ͘ΕΔ

rails-tokyo-sample(dev):001> Project.first.issues.class.ancestors Project Load (0.1ms) SELECT "projects".* FROM "projects" ORDER
BY "projects"."id" ASC LIMIT 1 /*application='RailsTokyoSample'*/ => [Issue::ActiveRecord_Associations_CollectionProxy, Issue::GeneratedRelationMethods, ApplicationRecord::GeneratedRelationMethods, ActiveRecord::Delegation::ClassSpecificRelation, ActiveRecord::Associations::CollectionProxy, ActiveRecord::Relation, ActiveRecord::SignedId::RelationMethods, ActiveRecord::TokenFor::RelationMethods, ActiveRecord::FinderMethods, ActiveRecord::Calculations, ActiveRecord::SpawnMethods, ... ࠓ೔͸ͦͬͪ۷Γ·ͤΜ͕ɺ*TTVF"DUJWF3FDPSE@"TTPDJBUJPOT@$PMMFDUJPO1SPYZͱ͔΋໘ന͍

‣ "DUJWF3FDPSE3FMBUJPOΛ׆༻͢Δ ‣ ݖݶνΣοΫΛΞιγΤʔγϣϯͰදݱ͢Δ ‣ ෳࡶͳؔ܎ΛUISPVHIͷUISPVHIͰදݱ͢Δ ‣ ίϯτϩʔϥͷΠϯελϯεม਺ΛݮΒ͢ ‣ Ұ෦ͷJODMVEFT͸ϏϡʔͰࢦఆ͢Δ

ෳࡶͳؔ܎ΛUISPVHIͷUISPVHIͰදݱͰ͢Δ class Assignment < ApplicationRecord belongs_to :issue belongs_to :person end
w *TTVFͷ୲౰ऀΛBTTJHO͢ΔέʔεΛߟ͑Δ w ૉ๿ʹCFMPOHT@UPQFSTPO͢Δͱྑ͘ͳ͍ w QFSTPO͕཭೚͢Δͱ͖ʹ΋ɺQFSTPOࣗମΛফ͢Θ͚ʹ͸͍͔ͳ͍ w ͢ΔͱBTTJHONFOUΛݸผʹফ͢ඞཁ͕͋Δ ͳΜ͔ΊΜͲ͍͘͞

"TTJHONFOUͷCFMPOHT@UPઌ͸NFNCFSTIJQT͔΋ w ͭ͡͸"TTJHOର৅͸ʮ͜ͷਓ͕͜ͷϓϩδΣΫτʹࢀը͍ͯ͠ΔίτʯͰ͸ w ͭ·ΓCFMPOHT@UPNFNCFSTIJQT w ࣮ࡍͷυϝΠϯϞσϧͱͯ͠΋ଥ౰ͦ͏ɻEFQFOEFOUEFTUSPZͰ཭೚ͨ͠ΒΞαΠϯ͕ফ͑Δ w ͍ͬΆ͏ීஈ͸ʮΞαΠϯ͞Ε͍ͯΔਓʯ͘Β͍ͷؾܰ͞Ͱࢀর͍ͨ͠
w JTTVFBTTJHONFOUTNBQ\JUNFNCFSTIJQQFSTPO^ͱ͔ॻ͖ͨ͘ͳ͍ w ͦΕ͕UISPVHIΛUISPVHI͢Δ͚ͩͰͰ͖Δ w ൃߦ͞ΕΔΫΤϦ΋·ͱ΋ɻKPJOͨ͠Γ·ͱΊͯϓϦϩʔυͨ͠ΓͰ͖Δ

վળޙUISPVHINFNCFSTIJQT

class Issue < ApplicationRecord has_many :assignments has_many :memberships, through: :assignments
has_many :assignees, through: :memberships, source: :person end class Assignment < ApplicationRecord belongs_to :issue belongs_to :membership end class Membership < ApplicationRecord belongs_to :person belongs_to :project has_many :assignments, dependent: :destroy end UISPVHIΛUISPVHI͢Δ

rails-tokyo-sample(dev):002> project.issues.includes(:assignees) .map { [it, it.assignees.size] } Issue Load (0.3ms)
SELECT "issues".* FROM "issues" WHERE "issues"."project_id" = 152639770 /*application='RailsTokyoSample'*/ Assignment Load (0.1ms) SELECT "assignments".* FROM "assignments" WHERE "assignments"."issue_id" IN (77551669, 540637335) / *application='RailsTokyoSample'*/ Membership Load (0.1ms) SELECT "memberships".* FROM "memberships" WHERE "memberships"."id" IN (1010729577, 996949822, 664416693) / *application='RailsTokyoSample'*/ Person Load (0.1ms) SELECT "people".* FROM "people" WHERE "people"."id" IN (786122151, 902541635, 663665735) /*application='RailsTokyoSample'*/

rails-tokyo-sample(dev):003> project.issues.eager_load(:assignees) .map { [it, it.assignees.size] } Issue Eager Load
(0.4ms) SELECT "issues"."id" AS t0_r0, "issues"."created_at" AS t0_r1, "issues"."creator_id" AS t0_r2, "issues"."description" AS t0_r3, "issues"."project_id" AS t0_r4, "issues"."status" AS t0_r5, "issues"."title" AS t0_r6, "issues"."updated_at" AS t0_r7, "people"."id" AS t1_r0, "people"."created_at" AS t1_r1, "people"."updated_at" AS t1_r2 FROM "issues" LEFT OUTER JOIN "assignments" ON "assignments"."issue_id" = "issues"."id" LEFT OUTER JOIN "memberships" ON "memberships"."id" = "assignments"."membership_id" LEFT OUTER JOIN "people" ON "people"."id" = "memberships"."person_id" WHERE "issues"."project_id" = 152639770 /*application='RailsTokyoSample'*/

w "DUJWF3FDPSE3FMBUJPO͸ɺ3%#ͷؔ܎୅਺తͳૢ࡞ બ୒XIFSF ࣹӨTFMFDU ݁߹KPJO Λ3VCZΦϒδΣΫτͱͯ͠ѻ͑Δ w ཧ࿦ͦͷ΋ͷͰ͸ͳ͍͕ɺయܕతͳ8FCΞϓϦͰ΍Γ͍ͨ͜ͱ͸͍ͩͿͰ͖Δ w 3FMBUJPOಉ࢜ͷνΣʔϯ΍NFSHFͱ͔Ͱ͖Δͷ͘͢͝ͳ͍Ͱ͢
w ͜ͷϛϥΫϧ🦄ͳ"DUJWF3FDPSEΛ࢖͍౗͠·͠ΐ͏ w ʮͪΌΜͱͨ͠ςʔϒϧߏ଄ʯΛఆٛͯ͠ɺͦΕΛਏ͘ͳ͘׆༻Ͱ͖Δ ͜ͷΞϓϩʔνͷ3BJMTͷؾ࣋ͪ ͦ͏͸͍ͬͯ΋ूܭΫΤϦΑɺɺɺΈ͍ͨͳͷ͸͋ΔΜͰ͕͢ɺ͋Ε͸ʮΞΫςΟϒϨίʔυύλʔϯʯΛ ద༻͠ͳ͍ํ͕ྑ͍ϑΥʔε͕͋ΔΘ͚ͳͷͰɺ͞ΒʹผʹΞϓϩʔνͷ΄͏͕ྑ͍ͱࢥͬͯ·͢ɻ

ίϯτϩʔϥͷΠϯελϯεม਺ΛݮΒ͢ ͜͜Βล͔Βࢥ૝͕ڧ͘ͳ͖ͬͯ·͢ɻภΓ͕͋Δ࠙਌ձ΍ΠϯλʔωοτͰײ૝Λฉ͔͍ͤͯͩ͘͞ɻ class IssuesController < ApplicationController def index @project =
current_person.projects.find_by!(name: params[:pj_name]) @issues = @project.issues.order(updated_at: :desc) # ͜͏͍͏΍ͭΛݮΒ͍ͨ͠ @news = @project.news.order(updated_at: :desc).limit(3) end w αΠυόʔͷ߲໨ͳͲɺΞΫγϣϯͷຊ෼Ͱ͸ͳ͍σʔλ͸ ʮίϯτϩʔϥͷΠϯελϯεม਺ʯʹ͸͠ͳ͍ɻ

ίϯτϩʔϥͷJWBS͸$7ͷΠϯλʔϑΣʔε w લఏͱͯ͠ɺ3BJMTίϯτϩʔϥͷΠϯελϯεม਺͸ɺ $Ͱ༻ҙͨ͠σʔλΛ7ʹ౉͢ΠϯλʔϑΣʔεͰ͋Δ w ͍ΘΏΔڱٛͷ001ʹ͓͚ΔΠϯελϯεม਺ͱ͸ɺͱ͔ɺ .7$ ͷίϯτϩʔϥͱ͸ɺΈ͍ͨͳ͜ͱΛߟ͑͗͢ͳ͍ w
ΤϯτϦϙΠϯτͱͳΔϝιου ΞΫγϣϯ ͕ҧ͏ͱɺηοτ͞ΕΔΠϯελϯεม਺ͷ छྨࣗମ͕มΘΔͱ͔ɺ001ͱͯ͠͸μ ϝͳײ͕͢͡ΔX w 3BJMTͷ͜ͱΛߟ͑·͠ΐ͏ 3BJMTͱ઀ଓͨ͠ઌͷɺϞσϧͷϩδοΫΛॻ͘ͱ͖ͳΜ͔͸ɺ΋ͪΖΜ001ͷྑ͍ݪଇΛଚॏ͠·͠ΐ͏ɻ ݴ͍׵͑Δͱɺ͜ͷ઀໘Λհͯ͠3BJMTੈքͱυϝΠϯքΛڥք͚ͮΔͱ͍͏͔

‣ "DUJWF3FDPSE3FMBUJPOΛ׆༻͢Δ ‣ ίϯτϩʔϥͷΠϯελϯεม਺ΛݮΒ͢ ‣ ಛఆදݱͷΈͰ࢖͏σʔλ͸ϏϡʔͰϩʔυ͢Δ ‣ QBSUJBMʹίϯϙʔωϯτΛݟग़͢ ‣ Ұ෦ͷJODMVEFT͸ϏϡʔͰࢦఆ͢Δ

3BJMT͸୯ҰΞΫγϣϯ͔Βෳ਺දݱΛฦͤΔ w SFRVFTUGPSNBUʹΑͬͯɺSFTQPOE@UPͰ෼ذͨ͠Γɺ JOEFYIUNMFSCJOEFYKTPOKCVJMEFSͷબग़͕มΘΔ w ࠷ۙ΋.BSLEPXOϨϯμϥʔ͕ೖͬͨΓͯ͠ΔͷͰɺ͜ͷࢥ૝΋ݱ໾ͳ͸ͣ w ίϯτϩʔϥͷ੹຿Λ࠷খԽ͢Δͱɺ)5.-දݱͱ+40/දݱ ͱͰ྆ํͰ࢖͏σʔλͷΈΛϏϡʔʹ౉͢΂͖ ಉ͜͡ͱ͸)PUXJSFΛߟ͑ͯ΋ݴ͑ͦ͏ɻͭ·ΓUVSCPTUSFBN͕ಡΈࣺͯΔՕॴΛϨϯμϦϯά͢ΔͨΊͷ
σʔλΛίϯτϩʔϥͰϩʔυ͢Δͷ͸ແବͩͱࢥ͍·͢ɻޙड़ͷΑ͏ʹΫΤϦࣗମ͸ൃߦ͞Εͳ͍͔΋Ͱ͕͢ɻ

͡Ό͋Ͳ͏͢Δ͔ w ಛఆςϯϓϨʔτ͚ͩͰඞཁͳσʔλ͸ɺ&3#ςϯϓϨʔτ΍ IFMQFSͰ;ͭ͏ʹϩʔυ͢Ε͹ྑ͍ͷͰ͸ w ͭ·Γɺ3VCZίʔυΛॻ͖·͠ΐ͏ w FSCͩͱͪΐͬͱځ۶͔΋͠Εͳ͍͚ΕͲɺ KTPOKCVJMEFS΍ɺ KTPOSVCZͳͲͰ͸;ͭ͏ʹ3VCZίʔυ͕ॻ͚Δ͠

ϏϡʔͰσʔλΛϩʔυ͢ΔͷΞϦ🐜 w ϏϡʔͰσʔλΛϩʔυ͢ΔʺϏϡʔʹ42-Λॻ͘ w ੜ42-͸͕͢͞ʹಡΈͮΒ͍͔Βμϝͩͱࢥ͍·͢🍐 w Ͱ΋͋͘·ͰϓϥΫςΟΧϧͳಡΈਏ͞ͷ໰୊Ͱ͋Γɺ࡞๏ͷ࿩Ͱ͸ͳ͍ <% query =
'SELECT * FROM news WHERE ...ORDER BY created_at DESC LIMIT 3' %> <% ActiveRecord::Base.connection.execute(query).each do |row| %> ... <% end %> ͜ͷʮϏϡʔʹ42-ॻ͘ͳʯ Θ͔Δ ͕ͩΜͩΜͱʮϏϡʔͰ%#ʹΞΫηε͢Δͳʯʹͳͬͨͷ͔ͳͱࢥͬͯ·͢ɻ ·ͨ͸ϨΠϠ෼ׂΞʔΩςΫνϟͷӨڹ͔ɻͰ΋.7$ҰൠͰ͸ͳ͘ɺ3BJMTݸผͷ࿩ͳͷͰɺͱ͍͏ͷ͕࿦ࢫͰ͢

"DUJWF3FDPSEͷϝιουνΣʔϯΛॻ͘ͷ͸ΞϦ🐜 w ϞσϧʹQVCMJTIFEͳͲͷTDPQFΛఆٛͯ͠࢖ͬͨΓɺPSEFS ΍ MJNJU ͳͲ"3ͷϝιουΛݺΜͩΓ͢Δͷ͸͋Γ w νΣΠϯ͕௕ͯ͘ಡΈͮΒ͘ͳͬͨΒɺదٓ͞ΒʹTDPQF΍ ΫϥεϝιουΛఆٛͨ͠Γɺϔϧύʔʹநग़ͨ͠Γ͢Δ <%
project.news.published.order(created_at: :desc).limit(3).each do |news| %> ... <% end %> நग़ઌͱͯ͠ɺίϯτϩʔϥ΋3VCZίʔυΛॻ͖΍͍͢ͷͰͦ͜Ͱ͍͍͡ΌΜɺͱ͍͏ͷ͸ҰपճͬͯΞϦ͔΋ɻ ผϝιουʹͯ͠IFMQFSએݴͰ࢖͑ΔΑ͏ʹ͢Δͱ͔͸ྑ͍ͱࢥ͍·͢ɻOFXTͰ΍Δ͜ͱ͡Όͳ͍͚Ͳɻ

ͦ΋ͦ΋"33FMBUJPOͷΫΤϦ͸MB[ZʹධՁ͞ΕΔ w QSPKFDUOFXTQVCMJTIFE ͷ࣌఺Ͱ͸·ͩ42-͸ൃߦ͞Εͣɺ "DUJWF3FDPSE3FMBUJPO͕ฦΔ w FBDI ͰϧʔϓΛճ࣌͢఺ͰॳΊͯ42-͕ൃߦ͞ΕΔ w ͜Ε͸ɺίϯτϩʔϥͰJWBSʹೖΕͯ΋ಉ͜͡ͱ
w ΫΤϦൃߦΛΘ͟ͱMB[Zʹ͢Δ3BJMTͷҙਤΛײ͡ΔͷͰɺ ࢖͏ଆ΋ؤுͬͯؾʹ͠ͳ͍Α͏ʹ͍ͨ͠ ͦΕΛආ͚Δʹ͸ίϯτϩʔϥͰUP@B͢Δͱ͔ʹͳΔ͚ͲɺͦΕ͸΍Γͨ͘ͳ͍͡Όͳ͍Ͱ͔͢

‣ "DUJWF3FDPSE3FMBUJPOΛ׆༻͢Δ ‣ ίϯτϩʔϥͷΠϯελϯεม਺ΛݮΒ͢ ‣ ಛఆදݱͷΈͰ࢖͏σʔλ͸ϏϡʔͰϩʔυ͢Δ ‣ QBSUJBMʹίϯϙʔωϯτΛݟग़͢ ‣ Ұ෦ͷJODMVEFT͸ϏϡʔͰࢦఆ͢Δ

QBSUJBMʹίϯϙʔωϯτΛݟग़͢ w SFOEFSQBSUJBMͷ෼ׂςϯϓϨʔτʹίϯϙʔωϯτΛݟग़͢ w ݺͼग़͢λΠϛϯάͰม਺Λ٧Ί௚ͤΔ w Πϯελϯεม਺Λ௚઀ࢀর͢Δͷ͸ආ͚ͨ΄͏͕Α͍Ͱ͢Ͷ w 4USJDU-PDBMTͷ͜ͱΛߟ͑ͯ΋ɺQBSUJBMʹίϯϙʔωϯτΛ ݟग़͍ͯ͠ΔΑ͏ʹײ͍ͯ͡Δ
෼ׂςϯϓϨʔτͷ๯಄Ͱϑϥά ϝϯτΩϟογϡ͔͚ΔͱɺςϯϓϨʔτͷมߋͰΩϟογϡ͕ ࣗಈͰύʔδ͞ΕΔɺͱ͍͏ͷ΋͜ͷཪ෇͚ʹͳ͍ͬͯΔؾ͕͢ΔΜͰ͢ΑͶɻ

ڞ௨ύʔπΛίϯϙʔωϯτʹ͢Δ # app/views/projects/_news.html.erb <%# locals: (project:) %> <ul> <%# projects
ͷΈΛೖྗʹͯ͠ɺ͔ͦ͜ΒඞཁͳnewsΛҾ͍ͯϨϯμϦϯά͢Δ %> <% project.news.published.order(created_at: :desc).limit(3).each do |news| %> <li> <%= link_to news.title, project_news_path(project, news) %> </li> <% end %> </ul>

ڞ௨ύʔπΛίϯϙʔωϯτʹ͢Δ w QSPKFDU ΛMPDBMTͰड͚औΓ͔ͦ͜ΒΞιγΤʔγϣϯΛ୧Δ w "33FMBUJPOͳͷͰQVCMJTIFEPSEFS ʜ MJNJU ʜ ͱଓ͚ΒΕΔ
w ͜Ε͕௕͍ͳͱࢥͬͨΒɺϞσϧʹϝιουΛ௥Ճͨ͠Γɺ ϔϧύʔʹநग़ͨ͠Γ͢Δ

͜ͷΞϓϩʔνͷ3BJMTͷؾ࣋ͪ w ίϯτϩʔϥͷΠϯελϯεม਺͸ɺϏϡʔͱͷେࣄͳΠϯλʔ ϑΣʔεͰ͋ΓɺߜΔ΂͖ w )5.-Ͱ΋+40/Ͱ΋྆ํͰ࢖͏Α͏ͳσʔλ͚ͩΛϩʔυ͢Δ w αΠυόʔ༻ͷσʔλ͸ίϯτϩʔϥͰ͸ϩʔυ͠ͳ͍ w ڞ௨ίϯϙʔωϯτ͸QBSUJBMΛ࢖ͬͯίϯϙʔωϯτΛ࡞Δ
w QBSUJBMͰ"3ͷϝιουνΣʔϯΛ࢖ͬͯσʔλΛऔಘ͢Δͷ΋͋Γ w "3ͷMB[ZධՁʹΑΓɺ݁Ռతʹ42-ൃߦλΠϛϯά͕ϏϡʔʹͳΔͷ͸Θ͟ͱͬΆ͍

༨ஊWJFX@DPNQPOFOUHFN w ͜ͷํ޲ੑͱίϯϑϦΫτ͠ͳ͍ͷͰɺҹ৅͸ѱ͘͸ͳ͍ w ʮදࣔͷͨΊͷ3VCZϩδοΫʯͷஔ͖৔ͱͯ͠IFMQFS͕͋Δ͚Ͳɺ ΋͏গ͠੔಴ͨ͘͠ͳͬͨ࣌ʹબ୒ࢶʹͳΓͦ͏ w ͍ͬΆ͏Ͱʮ෼͚ͯΈΑ͏͔ͳʯͷஈ֊Ͱಋೖ͢Δͱ৵ऻ౓͕େ͖͍ w HFN΋૿͑ΔΘ͚ͩ͠
w ίϯϙʔωϯτ͝ͱʹʮઐ༻ͷσ ΟϨΫτϦ 3VCZιʔεϑΝΠϧͱςϯϓϨʔτʯWT ʮQBSUJBMςϯϓϨʔτҰݸʯ w ͔ͤͬ͘ݸผʹಋೖͰ͖ΔΘ͚ͰɺΑ΄Ͳෳࡶͳ΍͚ͭͩͱ͔͕ྑ͍͔ͳ

Ұ෦ͷJODMVEFT͸ϏϡʔͰࢦఆ͢Δ ͲΜͲΜࢥ૝͕ڧ͘ͳΔΑ w લઅ͸ʮΞΫγϣϯͰද͍ࣔͨ͠಺༰ͷຊ෼͡Όͳ͍΋ͷʯΛ ίϯτϩʔϥͰϩʔυ͢ΔͷΛ΍ΊΑ͏ͱ͍͏ओுͩͬͨ w ࠓ౓͸ʮͦͷΞΫγϣϯͷຊ෼ͷσʔλ܈Ͱ΋ɺಛఆͷදݱͰͷΈ ඞཁͳؔ࿈ͷϩʔυ͸Ϗϡʔͷ੹຿Ͱ͋Δʯͱ͍͏ओுͰ͢

class IssuesController < ApplicationController def index @project = current_person.projects.find_by!(name: params[:pj_name])
# HTMLදࣔ༻ͷؔ࿈σʔλ·ͰίϯτϩʔϥͰϩʔυ @issues = @project.issues .includes(creator: :avatar) # HTML༻ .order(updated_at: :desc) end end # app/views/issues/index.html.erb <% @issues.each do |issue| %> <div> <%= image_tag issue.creator.avatar.url %> <%= issue.title %> </div> <% end %> ͜͏͍͏ͷΛ

class IssuesController < ApplicationController def index @project = current_person.projects.find_by!(name: params[:pj_name])
# ίϯτϩʔϥ͸࠷খݶɻAR::Relationͷ··౉͢ @issues = @project.issues.order(updated_at: :desc) end end # app/views/issues/index.html.erb <% @issues.includes(creator: :avatar).each do |issue| %> <div> <%= image_tag issue.creator.avatar.url %> <%= issue.title %> </div> <% end %> ͜͏͍ͨ͠

දࣔ͢Δؔ࿈ઌΛ൑அ͢Δͷ͸Ϗϡʔͷ੹຿ w JTTVFͷىҊऀͰ͋ΔQFSTPOͷΞΠίϯը૾Λग़͔͢Ͳ͏͔ɺΛ ൑அ͢Δͷ͸Ϗϡʔͷ੹຿Ͱ͋Δ w )5.-දݱʹ͓͍ͯ͸ग़͕͢ɺ+40/දݱͰ͸ग़͞ͳ͍ɺͳͲ w !JTTVFTJODMVEFT DSFBUPSBWBUBS ΛͲ͜Ͱݺͼग़͔͢
w ίϯτϩʔϥͰݺͿͱશͯͷςϯϓϨʔτͰಉ͡JODMVEFT͕ద༻͞Εͯ͠·͏ w ϏϡʔͰݺͿͱɺ֤දݱͰඞཁͳ΋ͷΛJODMVEFͰ͖Δ ੲ͸࢖͍͚ͬͯͨͲϏϡʔΛม͑Δ͏ͪʹෆཁʹͳͬͨJODMVEF͕࢒͍ͬͯͯɺ๨ΕͨࠒʹύϑΥʔϚϯε ѱԽͷݪҼʹͳͬͨɺΈ͍ͨͳܦݧ͋Δਓ΋ଟ͍͔ͱࢥ͍·͢ɻࢲ΋͍ͬͺ͍͋Γ·͢X

“ 設計決定際、共有知識、知識移動
距離注意払必要。(略) 最終的、結合影響注意。近接互影響与。 7MBE,IPOPOPWʮιϑτ΢ΣΞઃܭͷ݁߹όϥϯεʯ ୈষڑ཭

΍͸Γ"DUJWF3FDPSE3FMBUJPO w "33FMBUJPOͷΫΤϦൃߦ͕MB[ZͰ͋Δ͔Βͦ͜ɺϏϡʔʹ ౉ͨ͋͠ͱͰJODMVEFTΛ௥ՃࢦఆͰ͖Δ w ΍͸Γ͜ͷॊೈੑΛ࢖͍౗͢ͷ͕3BJMTͷؾ࣋ͪͩΖ͏ ͱ͸͍͑ɺ͢΂ͯͷJODMVEFTΛϏϡʔͰ΍Δɺͱ͍͏Θ͚͡Όͳ͍Ͱ͢ɻϞσϧͷϩδοΫͰඞཁͳઌಡΈ͸ ϞσϧͰ΍ΔɻͦΕ͸ͦ͏ɻ

͜ͷΞϓϩʔνͷ3BJMTͷؾ࣋ͪ w લઅͱ΄΅ಉ͡ɻෳ਺3FQSFTFOUBUJPOͰ࢖͏ॲཧ͚ͩʹ͢Δͱ ίϯτϩʔϥͷίʔυ͕ݮΔ w ࢖͏৔ॴͷۙ͘ͰJODMVEFT͢Δͱɺڧ͍݁߹ͷ͋ΔίʔυΛ ෺ཧతʹۙ͘഑ஔͰ͖Δ w ϛϥΫϧ🦄ͳ"DUJWF3FDPSE3FMBUJPOΛ࢖͍౗͢

੔಴ޙʹ࢒Δίϯτϩʔϥͷ੹຿ w 8FCϦΫΤετͷίϯςΩετ͔ΒೖྗΛऔΓग़͢ͱ͜Ζ w औΓग़ͨ͠ೖྗΛϑΝαʔυͱͳΔϞσϧʹ౉ͯ͠ɺϢʔεέʔεͷ ॲཧΛݺͼग़͢ͱ͜Ζ w ͦͷओॲཧͷ݁ՌΛΠϯελϯεม਺ʹೖΕͯɺϏϡʔʹ౉͢ͱ͜Ζ w ॲཧ݁ՌʹԠͯ͡SFOEFSͨ͠ΓSFEJSFDU@UPͨ͠Γ͢Δͱ͜Ζ

࢒ͬͨ੹຿΋΋͏গ͠੔಴Ͱ͖Δ w ηογϣϯ৘ใ͔ΒΞΫηεऀऔಘɺͳͲʹ͸ఆ൪ͷ Πσ ΟΦϜ͕͋Δ w DVSSFOU@QFSTPO ͷΑ͏ʹ"QQMJDBUJPO$POUSPMMFSͰऔಘɾϝϞԽͨ͠Γ w "DUJWF4VQQPSU$VSSFOU"UUSJCVUFΛ࢖ͬͨΓ
w ΋ͬͱجຊతʹϓϥΠϕʔτϝιουநग़ͯ͠΋Α͍ɻ3VCZͳͷͰ w ϏϡʔͰ΋ݺͼ͚ͨΕ͹IFMQFS@NFUIPEએݴͳͲͰ֦ு΋Ͱ͖Δ

ίϯτϩʔϥͱϏϡʔΛ੔಴͢Δ w ͜ΕΒͷॲཧΛநग़͢ΔͱɺίϯτϩʔϥͷίʔυΛ े෼ʹݮΒͤͦ͏ w ৽͍͠ϥΠϒϥϦ΍ϑϨʔϜϫʔΫɺΞʔΩςΫνϟΛ ಋೖͨ͠Θ͚Ͱ͸ͳ͍ ͦΕͰ΋࢒Δ੹຿͸͋ΔͷͰɺߦϝιουϧʔϧͳͲͷݫक͸Ͱ͖ͳ͍͔΋Ͱ͕͢ɺݟ௨͠͸ྑ͘ͳΔ͸ͣ

੔಴͸ՄѪͯ͘;Θ;Θͨ͠খ͞ͳϦϑΝΫλϦϯά w ͜ͷ࿩Λؾʹೖͬͯ͘Εͯ΋ɺҰؾʹશ෦΍Ζ͏ͱ͠ͳ͍Ͱ⚠ w ةͳ͍͔ΒͶ w ίϯτϩʔϥͷɺΞΫγϣϯʹɺUJQT͚ͩΛద༻͢Δ w ͦΕͰɺ໨ͷલͷιϑτ΢ΣΞ͕গͣͭ͠੔಴͞Ε͍ͯ͘ w
ͦΕ΋·ͨEZOBNJDͳ׆ಈͳͷͩͱࢥ͍·͢ ͱɺ"1*ͳͲ͔Β3BJMTͷؾ࣋ͪΛ উखʹ ಡΈͱΓͭͭɺΞϓϦέʔγϣϯ͕͍͍ײ͡Ͱ͋ΕΔΑ͏ʹ೔ʑ ੔಴ͯ͠म෮͠ଓ͚Δͷ͕ʮࢲͷ3BJMTͷ࿩ʯͰ͢ɻ஍ຯͰ͚͢Ͳ΋΍ͬͯΈΔͱ໘ന͍Ͱ͢Α

Railsの気持ちを考えながらコントローラとビューを整頓する/tidying-rails-co...

Railsの気持ちを考えながらコントローラとビューを整頓する/tidying-rails-controllers-and-views-as-rails-think

More Decks by MOROHASHI Kyosuke

Other Decks in Programming

Featured

Transcript