Contribution to Rails

Transcript

1. Contribution to Rails Naoto Kaneko
5. DEMO
6. ܦҢ • ͖͔͚ͬ͸brancherͷ։ൃͰ࢖͍ͬͯͨ։ൃ༻ͷ σόοάίʔυ • railsͷҰ࿈ͷىಈϓϩηεʹ͍ͭͯ͸ιʔείʔ υϦʔσΟϯάΛ͍ͯͨ͠ • ΄Μͷ͍ܰϊϦͰॻ͍ͨ5ߦఔ౓ͷίʔυΛPull requestͰૹͬͯΈͨ →✨merged ✨
7. ίϯτϦϏϡʔτͷ࢓ํ • fork, checkout, push, pull req • มߋ఺ΛCHANGELOGʹ௥ه • mergeઌʹ஫ҙ!!! • master͸rails 5ܥ • ͙͢ʹϦϦʔε͍ͨ͠ͳΒ4-1-stable, 4-2-stable
8. ·ͣίʔυΛಡΉ • ಈ͔ͳ͍ͱ͜Ζ • ڍಈʹෆຬ͕͋Δͱ͜Ζ
9. ྫ͑͹ # config/secrets.yml development: secret_key_base: aaaaaaaa facebook: app_id: bbbbbbbb app_secret: ccccccccc # rails c > Rails.application.secrets.secret_key_base #=> aaaaaaaa > Rails.application.secrets.facebook[:app_id] #=> bbbbbbbb facebook.app_id ͬͯॻ͖͍ͨ
10. railties/lib/rails/ application.rb:386 def secrets @secrets ||= begin secrets = ActiveSupport::OrderedOptions.new yaml = config.paths["config/secrets"].first if File.exist?(yaml) require "erb" all_secrets = YAML.load(ERB.new(IO.read(yaml)).result) || {} env_secrets = all_secrets[Rails.env] secrets.merge!(env_secrets.symbolize_keys) if env_secrets end # Fallback to config.secret_key_base if secrets.secret_key_base isn't set secrets.secret_key_base ||= config.secret_key_base # Fallback to config.secret_token if secrets.secret_token isn't set secrets.secret_token ||= config.secret_token secrets end end
11. railties/lib/rails/ application.rb:386 def secrets @secrets ||= begin secrets = ActiveSupport::OrderedOptions.new yaml = config.paths["config/secrets"].first if File.exist?(yaml) require "erb" all_secrets = YAML.load(ERB.new(IO.read(yaml)).result) || {} env_secrets = all_secrets[Rails.env] secrets.merge!(env_secrets.symbolize_keys) if env_secrets end # Fallback to config.secret_key_base if secrets.secret_key_base isn't set secrets.secret_key_base ||= config.secret_key_base # Fallback to config.secret_token if secrets.secret_token isn't set secrets.secret_token ||= config.secret_token secrets end end ϝιουͬΆ͘ΞΫηεͰ͖Δ΍ͭ
12. railties/lib/rails/ application.rb:386 def secrets @secrets ||= begin secrets = ActiveSupport::OrderedOptions.new yaml = config.paths["config/secrets"].first if File.exist?(yaml) require "erb" all_secrets = YAML.load(ERB.new(IO.read(yaml)).result) || {} env_secrets = all_secrets[Rails.env] secrets.merge!(env_secrets.symbolize_keys) if env_secrets end # Fallback to config.secret_key_base if secrets.secret_key_base isn't set secrets.secret_key_base ||= config.secret_key_base # Fallback to config.secret_token if secrets.secret_token isn't set secrets.secret_token ||= config.secret_token secrets end end ͨͩͷHashΛmergeͯ͠ΔͬΆ͍ͷͰ ࠶ؼతʹAS::OrderedOptions࢖͑͹Αͦ͞͏
13. ✨ϓϧϦΫνϟϯε✨
15. ͜ΕͰ͋ͳͨ΋ RailsίϯτϦϏϡʔλʔʹ