Tests refletions

First tech talk at Locaweb

Transcript

1. Refletindo sobre testes
2. Rafael Lima @dorafaellima github.com/rafaellima
4. Qualidade dos testes
5. FFF ! - Full (Devem cobrir o seu sistema.) - Fast (Devem ser rápidos para minimizar o tempo que esperamos pelo feedback.) - Focus (Devem ser focados em fornecer detalhes específicos de onde o erro está.)
6. Velocidade
9. Normal
10. Testes mal escritos nos levam a mudar a maneira como testamos
11. Guard Spring Spork
13. Resolve o problema?
14. Resolve o problema raiz?
17. Ameniza, mas não resolve
18. Mas como melhorar?
19. Testes bem escritos nos levam a pensar sobre o design
20. Antes de melhorar a velocidade, vamos ver como os nossos testes são escritos.
21. Um controller que lista os produtos e suas categorias baseado no usuário (vendedor) que está logado
22. class Dashboard::ProductsController < ApplicationController before_action :authenticate_user! def index @products = Product.where(seller_id: current_user.seller_id) @categories = Category.find(@products.map(&:category_id)) end end
23. Filtros SQL no controller
25. require 'spec_helper' describe Dashboard::ProductsController do let(:seller) { create :seller } let(:user) { create(:user, seller: seller) } let(:category) { create :category } let!(:product1) { create :product, name: 'p1', seller: seller, category: category } let!(:product2) { create :product, name: 'p2', seller: seller, category: category } let(:another_seller) { create :seller, id: 33 } let(:another_user) { create(:another_user, seller: another_seller) } let(:another_category) { create :category } let!(:anther_product) { create :product, seller: another_seller, category: another_category } before { sign_in user } describe 'GET index' do before { get :index } describe 'product list' do subject { assigns(:products) } it { should eq([product1, product2]) } end describe 'categories' do subject { assigns(:categories) } it { should eq([category]) } end end end
26. Desconfortável
27. Testes devem influenciar no design
28. Saindo do Rails “default”
29. View -> Controller -> Model
30. Esse padrão nos leva a ter modelos gigantes
31. fat Model, skinny Controller
32. Validações + Associações + Regras de negócio
33. class User < ActiveRecord::Base before_create :build_default_social_network attr_accessible :email, :password, :password_confirmation, :remember_me, :provider, :name, :user_name, :image, :image_cache, :remote_image_url, :profile_attributes, :accept_terms accepts_nested_attributes_for :profile mount_uploader :image, ProfileImageUploader validates :image, file_mime_type: { content_type: /image/ } validates :user_name, uniqueness: true, length: { maximum: 30 }, format: { with: /\A[a-zA-Z0-9_.]+\Z/, message: 'Only letters, numbers, underscore and dots' } validates :name, presence: true, on: :update validates :user_name, presence: true, on: :update validates :accept_terms, acceptance: true, on: :update has_one :profile, dependent: :destroy, class_name: 'UserProfile' has_one :social_network, dependent: :destroy has_many :product_entries, foreign_key: :participant_id has_many :products, foreign_key: :submitter_id has_many :yurns, foreign_key: :yurner_id has_many :bought_orders, foreign_key: :buyer_id, class_name: 'Order' has_many :sold_orders, foreign_key: :merchant_id, class_name: 'Order' has_many :follows, dependent: :destroy has_many :followers, through: :follows, class_name: 'User' def followed_by?(user) followers.include?(user) end def followed_by!(user) if user != self followers << user unless followed_by?(user) end end def not_followed_by?(user) ! followed_by?(user) end def not_followed_by!(user) Follow.destroy_all(follower_id: user, followable_id: self, followable_type: self.send(:class)) end end
34. class Group < ActiveRecord::Base scope :active, -> { where(active: true) } attr_accessible :description, :name, :author, :image, :author_id, :board_ids, :admin_ids mount_uploader :image, GroupImageUploader validates :image, file_mime_type: { content_type: /image/ } validates_presence_of :name belongs_to :author, class_name: 'User', foreign_key: "author_id" has_and_belongs_to_many :boards, join_table: "groups_boards" has_many :group_collaborations, dependent: :destroy has_many :collaborators, through: :group_collaborations has_many :modules, foreign_key: "group_id", class_name: "GroupModule" has_many :twitter_modules has_many :discussion_modules has_many :poll_modules has_many :user_modules has_many :board_modules has_many :follows, dependent: :destroy has_many :followers, through: :follows, class_name: 'User' def followed_by?(user) followers.include?(user) end def followed_by!(user) if user != self followers << user unless followed_by?(user) end end def not_followed_by?(user) ! followed_by?(user) end def not_followed_by!(user) Follow.destroy_all(follower_id: user, followable_id: self, followable_type: self.send(:class)) end end
35. Duplicação de conhecimento
36. Mas o Rails evoluiu
37. View -> Controller -> Service -> Model
38. Service Encapsula a regra de negócio
39. Concerns
40. require 'active_support/concern' ! module Concerns module Followable extend ActiveSupport::Concern ! included do has_many :follows, as: :followable, dependent: :destroy has_many :followers, through: :follows, class_name: 'User' end ! def followed_by?(user) followers.include?(user) end ! def followed_by!(user) if user != self followers << user unless followed_by?(user) end end ! def not_followed_by?(user) ! followed_by?(user) end ! def not_followed_by!(user) Follow.destroy_all(follower_id: user, followable_id: self, followable_type: self.send(:class)) end end end
41. class User < ActiveRecord::Base before_create :build_default_social_network attr_accessible :email, :password, :password_confirmation, :remember_me, :provider, :name, :user_name, :image, :image_cache, :remote_image_url, :profile_attributes, :accept_terms accepts_nested_attributes_for :profile mount_uploader :image, ProfileImageUploader validates :image, file_mime_type: { content_type: /image/ } validates :user_name, uniqueness: true, length: { maximum: 30 }, format: { with: /\A[a-zA-Z0-9_.]+\Z/, message: 'Only letters, numbers, underscore and dots' } validates :name, presence: true, on: :update validates :user_name, presence: true, on: :update validates :accept_terms, acceptance: true, on: :update has_one :profile, dependent: :destroy, class_name: 'UserProfile' has_one :social_network, dependent: :destroy has_many :product_entries, foreign_key: :participant_id has_many :products, foreign_key: :submitter_id has_many :yurns, foreign_key: :yurner_id has_many :bought_orders, foreign_key: :buyer_id, class_name: 'Order' has_many :sold_orders, foreign_key: :merchant_id, class_name: 'Order' include Concerns::Followable end
42. class Group < ActiveRecord::Base scope :active, -> { where(active: true) } attr_accessible :description, :name, :author, :image, :author_id, :board_ids, :admin_ids belongs_to :author, class_name: 'User', foreign_key: "author_id" has_and_belongs_to_many :boards, join_table: "groups_boards" has_many :group_collaborations, dependent: :destroy has_many :collaborators, through: :group_collaborations has_many :modules, foreign_key: "group_id", class_name: "GroupModule" has_many :twitter_modules has_many :discussion_modules has_many :poll_modules has_many :user_modules has_many :board_modules include Concerns::Followable end
43. Service - Encapsula a lógica de negócio - Plain Old Ruby Objects
44. Foco Testar somente o que precisamos, em um só lugar
45. require 'spec_helper' describe MODEL do it_behaves_like Concerns::Followable end
46. Testar classes/módulos Ruby é melhor que testar controllers
47. require 'spec_helper' describe MODEL do it 'should be true' do expect(true).to be_true end end
48. Usando o spec_helper
50. Quando é uma classe/módulo Ruby não precisamos do Rails inteiro.
51. require 'active_record' connection_info = YAML.load_file("config/database.yml")["test"] ActiveRecord::Base.establish_connection(connection_info) RSpec.configure do |config| config.around do |example| ActiveRecord::Base.transaction do example.run raise ActiveRecord::Rollback end end end
53. RSPEC 3 rails_helper spec_helper
54. Refletindo sobre o que fazemos no dia a dia
55. class Event < ActiveRecord::Base scope :running_today, -> { where('DATE(created_at) = ?', Date.today) } end
56. describe Event do describe "#running_today" do context "when events are happening today" do let(:yesterday_event) { FactoryGirl.create(:event, :today) } let(:today_event) { FactoryGirl.create(:event, :today) } let(:tomorrow_event) { FactoryGirl.create(:event, :today) } it "returns those events" do expect(Event.running_today).to eq [today_event] end end end end
57. class EventsController < ApplicationController def index @events = Events.running_today end end
58. require 'spec_helper' describe EventsController do describe "GET /index" do get '/events', {}, { 'Accept' => Mime::JSON } expect(response).to be_success expect(response.content_type).to eq Mime::JSON end end
59. Falso positivo, não testamos os outros cenários
60. Duas chamadas no banco de dados, mas usando a resposta somente uma vez
61. Testes mais rápidos e focados nos levam a melhorar nosso código de produção
62. Conclusão
63. Orientação a objetos é sobre mensagens
64. Orientação a objetos é sobre interações
65. Orientação a objetos é sobre serviços
66. Obrigado! @dorafaellima speakerdeck.com/rafaellima/tests-refletions