$30 off During Our Annual Pro Sale. View Details »

Zero-confidence by Katrina Owen

Zero-confidence by Katrina Owen

Watch the talk here: https://vimeo.com/68730418

Railsberry

April 23, 2013
Tweet

More Decks by Railsberry

Other Decks in Technology

Transcript

  1. .................................
    .................................
    .................................
    .................................
    ............................
    467 tests, 0 failures, 0 confidence
    Katrina Owen
    @kytrinyx
    JumpstartLab

    View Slide

  2. Pointe
    •◀
    .

    View Slide

  3. ......F...

    View Slide

  4. F F F F F F F F F

    View Slide

  5. test results
    not implementation

    View Slide

  6. results

    View Slide

  7. command query
    separation .
    .
    .
    .
    .
    .
    .
    .
    .
    .
    .
    .
    .
    .
    .
    .
    .
    .

    View Slide

  8. returns a value, has no side effects
    query

    View Slide

  9. has side effects, returns nil
    command

    View Slide

  10. .
    .
    .
    .
    .
    .
    .
    .
    .
    .
    .
    .
    .
    .
    .
    .
    .

    command query

    View Slide

  11. query
    @waiter.menu

    View Slide

  12. command
    @bill.add(steak)

    View Slide

  13. both
    ... it’s complicated

    View Slide

  14. responsibility
    and collaboration

    View Slide

  15. mock
    expectation

    View Slide

  16. mock stub
    .
    .
    .
    .
    .
    .
    .
    .
    .
    .
    .
    .
    .
    .
    .
    .
    .

    assertion dumb value

    View Slide

  17. who
    is responsible?

    View Slide

  18. sender
    :message
    receiver
    outgoing incoming

    View Slide

  19. incoming
    assert the state of the system

    View Slide

  20. outgoing
    assert collaboration

    View Slide

  21. rules
    of thumb

    View Slide

  22. Query
    Incoming ?

    View Slide

  23. Query
    Incoming assert return value

    View Slide

  24. Query Command
    Incoming assert return value ?

    View Slide

  25. Query Command
    Incoming assert return value assert side effects

    View Slide

  26. Query Command
    Incoming
    Outgoing
    assert return value assert side effects
    ?

    View Slide

  27. Query Command
    Incoming
    Outgoing
    assert return value assert side effects
    do not assert

    View Slide

  28. Query Command
    Incoming
    Outgoing
    assert return value assert side effects
    do not assert ?

    View Slide

  29. Query Command
    Incoming
    Outgoing
    assert return value assert side effects
    do not assert assert message sent

    View Slide

  30. Query Command
    Incoming
    Private
    Outgoing
    assert return value assert side effects
    ? ?
    do not assert assert message sent

    View Slide

  31. Query Command
    Incoming
    Private
    Outgoing
    assert return value assert side effects
    do not assert do not assert
    do not assert assert message sent

    View Slide

  32. Query Command
    Incoming
    Private
    Outgoing
    assert return value assert side effects
    do not assert do not assert
    do not assert assert message sent

    View Slide

  33. 1incoming query
    assert return value

    View Slide

  34. 1incoming query
    assert return value
    assert_equal "...", @waiter.menu

    View Slide

  35. assert direct, local side effects
    2
    incoming command

    View Slide

  36. assert direct, local side effects
    2
    incoming command
    bill.add(steak)

    View Slide

  37. assert direct, local side effects
    2
    bill.add(steak)
    assert_equal 32.90, bill.total
    incoming command

    View Slide

  38. 3outgoing query
    do not assert

    View Slide

  39. 3outgoing query
    do not assert
    chef.todays_special

    View Slide

  40. assert message send
    4
    outgoing command

    View Slide

  41. assert message send
    kitchen.expect(:order_up)
    4
    outgoing command

    View Slide

  42. assert message send
    kitchen.expect(:order_up)
    waiter.i_would_like(:steak)
    4
    outgoing command

    View Slide

  43. assert message send
    kitchen.expect(:order_up)
    waiter.i_would_like(:steak)
    kitchen.verify
    4
    outgoing command

    View Slide

  44. assert message send
    4
    outgoing command
    kitchen.should_receive(:order_up)
    waiter.i_would_like(:steak)

    View Slide

  45. 5private message
    do not assert

    View Slide

  46. 5private message
    do not assert
    note_to_self(stuff)

    View Slide

  47. unit test

    View Slide

  48. unit test
    return values +

    View Slide

  49. unit test
    return values +
    side effects +

    View Slide

  50. unit test
    return values +
    side effects +
    critical interations +

    View Slide

  51. unit test
    return values +
    side effects +
    critical interations +
    implementation details -

    View Slide

  52. meet practice
    theory

    View Slide

  53. github.com/it-agile
    codersdojo_client

    View Slide

  54. @kata.generate 'ruby.rspec', 'prime'

    View Slide

  55. code kata
    small coding exercise

    View Slide

  56. @kata.generate 'ruby.rspec', 'prime'

    View Slide

  57. @kata.generate 'ruby.rspec', 'prime'

    View Slide

  58. @kata.generate 'ruby.rspec', 'prime'

    View Slide

  59. @kata.generate 'ruby.rspec', 'prime'

    View Slide

  60. class Prime
    def foo
    'fixme'
    end
    end

    View Slide

  61. class Prime
    def foo
    'fixme'
    end
    end
    describe Prime do
    let(:prime) { Prime.new }
    its(:foo) { should == 'bar' }
    end

    View Slide

  62. View Slide

  63. limit
    work in progress

    View Slide

  64. Query Command
    Incoming
    Private
    Outgoing

    View Slide

  65. incoming command
    assert direct, local side effects

    View Slide

  66. describe Scaffolder do
    it "generates the files and directories"
    it "replaces placeholders"
    end

    View Slide

  67. describe Scaffolder do
    before (:each) do
    @shell = mock
    @shell.should_receive(:shell_extension).any_number_of_times.and_return "cmd"
    @shell.should_receive(:remove_command_name).any_number_of_times.and_return "del"
    @shell.should_receive(:path_separator).any_number_of_times.and_return ";"
    @shell.should_receive(:dir_separator).any_number_of_times.and_return "/"
    Scaffolder.should_receive(:current_file).any_number_of_times.and_return("aDir/lib/aFile.rb")
    @scaffolder = Scaffolder.new @shell
    end
    it "generates the files and directories" do
    @shell.should_receive(:real_dir_entries).with("aDir/templates/a.template").and_return ["a", "b"]
    @shell.should_receive(:cp_r).with "aDir/templates/a.template/a", "."
    @shell.should_receive(:file?).with("a").and_return false
    @shell.should_receive(:cp_r).with "aDir/templates/a.template/b", "."
    @shell.should_receive(:file?).with("b").and_return fals
    @scaffolder.scaffold "a.template", 'myKata'
    end
    it "replaces placeholders" do
    @shell.should_receive(:real_dir_entries).with("aDir/templates/a.template").and_return ["a", "README", "run-once.sh", "run-endless.sh"]
    @shell.should_receive(:cp_r).with "aDir/templates/a.template/a", "."
    @shell.should_receive(:file?).with("a").and_return false
    @shell.should_receive(:cp_r).with "aDir/templates/a.template/README", "."
    @shell.should_receive(:file?).with("README").and_return true
    @shell.should_receive(:read_file).with("README").and_return '%rm% %kata_file%\nb.%sh%\nc%:%d'
    @shell.should_receive(:write_file).with "README", 'del myKata\nb.cmd\nc;d'
    @shell.should_receive(:cp_r).with "aDir/templates/a.template/run-once.sh", "."
    @shell.should_receive(:file?).with("run-once.sh").and_return true
    @shell.should_receive(:read_file).with("run-once.sh").and_return "%rm% a\nb.%sh%\nc%:%d"
    @shell.should_receive(:write_file).with "run-once.sh", "del a\nb.cmd\nc;d"
    @shell.should_receive(:cp_r).with "aDir/templates/a.template/run-endless.sh", "."
    @shell.should_receive(:file?).with("run-endless.sh").and_return true
    @shell.should_receive(:read_file).with("run-endless.sh").and_return "%rm% a\nb.%sh%\nc%:%d"
    @shell.should_receive(:write_file).with "run-endless.sh", "del a\nb.cmd\nc;d"
    @scaffolder.scaffold "a.template", 'myKata'
    end
    end

    View Slide

  68. describe Scaffolder do
    it "generates the files and directories" do
    @shell.should_receive(:real_dir_entries).with("aDir/templates/a.template").and
    @shell.should_receive(:cp_r).with "aDir/templates/a.template/a", "."
    @shell.should_receive(:file?).with("a").and_return false
    @shell.should_receive(:cp_r).with "aDir/templates/a.template/b", "."
    @shell.should_receive(:file?).with("b").and_return false
    @scaffolder.generate "a.template", 'myKata'
    end
    end

    View Slide

  69. describe Scaffolder do
    it "replaces placeholders" do
    @shell.should_receive(:real_dir_entries).with("aDir/templates/a.template").and
    @shell.should_receive(:cp_r).with "aDir/templates/a.template/a", "."
    @shell.should_receive(:file?).with("a").and_return false
    @shell.should_receive(:cp_r).with "aDir/templates/a.template/README", "."
    @shell.should_receive(:file?).with("README").and_return true
    @shell.should_receive(:read_file).with("README").and_return '%rm% %kata_file%\
    @shell.should_receive(:write_file).with "README", 'del myKata\nb.cmd\nc;d'
    @shell.should_receive(:cp_r).with "aDir/templates/a.template/run-once.sh", "."
    @shell.should_receive(:file?).with("run-once.sh").and_return true
    @shell.should_receive(:read_file).with("run-once.sh").and_return "%rm% a\nb.%s
    @shell.should_receive(:write_file).with "run-once.sh", "del a\nb.cmd\nc;d"
    @shell.should_receive(:cp_r).with "aDir/templates/a.template/run-endless.sh",
    @shell.should_receive(:file?).with("run-endless.sh").and_return true
    @shell.should_receive(:read_file).with("run-endless.sh").and_return "%rm% a\nb
    @shell.should_receive(:write_file).with "run-endless.sh", "del a\nb.cmd\nc;d"
    @scaffolder.generate "a.template", 'myKata'
    end
    end

    View Slide

  70. describe Scaffolder do
    before(:each) do
    @shell = mock
    @shell.should_receive(:shell_extension).any_number_of_times.and_return "cmd"
    @shell.should_receive(:remove_command_name).any_number_of_times.and_return "de
    @shell.should_receive(:path_separator).any_number_of_times.and_return ";"
    @shell.should_receive(:dir_separator).any_number_of_times.and_return "/"
    Scaffolder.should_receive(:current_file).any_number_of_times.and_return("aDir/
    @scaffolder = Scaffolder.new @shell
    end
    end

    View Slide

  71. ZOM G
    ......F...

    View Slide

  72. <3

    View Slide

  73. test
    all the things

    View Slide

  74. 30 assertions

    View Slide

  75. 30 assertions
    @shell.should_receive(:x)

    View Slide

  76. 30 assertions
    @shell.should_receive(:x)
    .with(y)

    View Slide

  77. 30 assertions
    @shell.should_receive(:x)
    .with(y)
    .and_return z

    View Slide

  78. .........
    .........
    .........
    .........

    View Slide

  79. unit tests
    30 assertions
    20 assertions
    10 assertions
    0 assertions

    View Slide

  80. unit tests
    testing what, exactly?

    View Slide

  81. @kata.generate
    README
    prime.rb
    run.sh
    ...
    ?

    View Slide

  82. @kata.generate
    README
    prime.rb
    run.sh
    ...

    View Slide

  83. magic
    happens here

    View Slide

  84. @shell.should_receive(:real_dir_entries).with("aDir/
    @shell.should_receive(:cp_r).with "aDir/templates/a.
    @shell.should_receive(:file?).with("a").and_return f
    @shell.should_receive(:cp_r).with "aDir/templates/a.
    @shell.should_receive(:file?).with("README").and_ret
    @shell.should_receive(:read_file).with("README").and
    @shell.should_receive(:write_file).with "README", 'd
    @shell.should_receive(:cp_r).with "aDir/templates/a.
    @shell.should_receive(:file?).with("run-once.sh").an
    @shell.should_receive(:read_file).with("run-once.sh"
    @shell.should_receive(:write_file).with "run-once.sh
    @shell.should_receive(:cp_r).with "aDir/templates/a.
    @shell.should_receive(:file?).with("run-endless.sh")
    @shell.should_receive(:read_file).with("run-endless.
    @shell.should_receive(:write_file).with "run-endless

    View Slide

  85. delegation
    vs micro-management

    View Slide

  86. unit tests
    have conceded defeat

    View Slide

  87. describe Scaffolder do
    before (:each) do
    @shell = mock
    @shell.should_receive(:shell_extension).any_number_of_times.and_return "cmd"
    @shell.should_receive(:remove_command_name).any_number_of_times.and_return "del"
    @shell.should_receive(:path_separator).any_number_of_times.and_return ";"
    @shell.should_receive(:dir_separator).any_number_of_times.and_return "/"
    Scaffolder.should_receive(:current_file).any_number_of_times.and_return("aDir/lib/aFile.rb")
    @scaffolder = Scaffolder.new @shell
    end
    it "generates the files and directories" do
    @shell.should_receive(:real_dir_entries).with("aDir/templates/a.template").and_return ["a", "b"]
    @shell.should_receive(:cp_r).with "aDir/templates/a.template/a", "."
    @shell.should_receive(:file?).with("a").and_return false
    @shell.should_receive(:cp_r).with "aDir/templates/a.template/b", "."
    @shell.should_receive(:file?).with("b").and_return false
    @scaffolder.scaffold "a.template", 'myKata'
    end
    it "replaces placeholders" do
    @shell.should_receive(:real_dir_entries).with("aDir/templates/a.template").and_return ["a", "README", "run-once.sh", "run-endless.sh"]
    @shell.should_receive(:cp_r).with "aDir/templates/a.template/a", "."
    @shell.should_receive(:file?).with("a").and_return false
    @shell.should_receive(:cp_r).with "aDir/templates/a.template/README", "."
    @shell.should_receive(:file?).with("README").and_return true
    @shell.should_receive(:read_file).with("README").and_return '%rm% %kata_file%\nb.%sh%\nc%:%d'
    @shell.should_receive(:write_file).with "README", 'del myKata\nb.cmd\nc;d'
    @shell.should_receive(:cp_r).with "aDir/templates/a.template/run-once.sh", "."
    @shell.should_receive(:file?).with("run-once.sh").and_return true
    @shell.should_receive(:read_file).with("run-once.sh").and_return "%rm% a\nb.%sh%\nc%:%d"
    @shell.should_receive(:write_file).with "run-once.sh", "del a\nb.cmd\nc;d"
    @shell.should_receive(:cp_r).with "aDir/templates/a.template/run-endless.sh", "."
    @shell.should_receive(:file?).with("run-endless.sh").and_return true
    @shell.should_receive(:read_file).with("run-endless.sh").and_return "%rm% a\nb.%sh%\nc%:%d"
    @shell.should_receive(:write_file).with "run-endless.sh", "del a\nb.cmd\nc;d"
    @scaffolder.scaffold "a.template", 'myKata'
    end
    end

    View Slide

  88. unit tests
    for the generated kata files

    View Slide

  89. integration tests
    for the generated kata files

    View Slide

  90. characterization

    View Slide

  91. characterization
    run the code

    View Slide

  92. characterization
    run the code
    make assertions about
    whatever happens

    View Slide

  93. describe Scaffolder do
    end

    View Slide

  94. describe Scaffolder do
    it "works" do
    scaffolder.generate('ruby.rspec', 'prime')
    end
    end

    View Slide

  95. describe Scaffolder do
    let(:scaffolder) { }
    it "works" do
    scaffolder.generate('ruby.rspec', 'prime')
    end
    end

    View Slide

  96. describe Scaffolder do
    let(:scaffolder) { Scaffolder.new }
    it "works" do
    scaffolder.generate('ruby.rspec', 'prime')
    end
    end

    View Slide

  97. describe Scaffolder do
    let(:scaffolder) { Scaffolder.new(shell) }
    it "works" do
    scaffolder.generate('ruby.rspec', 'prime')
    end
    end

    View Slide

  98. describe Scaffolder do
    let(:shell) { ShellWrapper.new }
    let(:scaffolder) { Scaffolder.new(shell) }
    it "works" do
    scaffolder.scaffold('ruby.rspec', 'prime')
    end
    end

    View Slide

  99. View Slide

  100. $ git status

    View Slide

  101. $ git status
    # Untracked files:
    #
    #!.meta
    #!README
    #!prime.rb
    #!run-endless.sh
    #!run-once.sh

    View Slide

  102. describe Scaffolder do
    let(:files) do
    [
    '.meta',
    'prime.rb',
    'README',
    'run-endless.sh',
    'run-once.sh'
    ]
    end
    it "works"...
    end

    View Slide

  103. describe Scaffolder do
    it "works" do
    scaffolder.scaffold('ruby.rspec', 'prime')
    expect(File.read('.meta')).to eq('...')
    expect(File.read('README')).to eq('...')
    # etc
    end
    end

    View Slide

  104. describe Scaffolder do
    after(:each) do
    files.each do |file|
    FileUtils.rm_f(file)
    end
    end
    it "works" do
    # ...
    end
    end

    View Slide

  105. Finished in 0.00632 seconds
    1 example, 0 failures
    .

    View Slide

  106. I’m no genius
    and so can you

    View Slide

  107. reality
    vs fantasy

    View Slide

  108. red flag
    time to refactor

    View Slide

  109. the secret fate
    of a characterization test

    View Slide

  110. confidence
    to refactor

    View Slide

  111. decouple
    template source and kata destination

    View Slide

  112. simplify
    the algorithm

    View Slide

  113. spot
    the abstractions

    View Slide

  114. a KataFile
    KataFile = Struct.new(:name, :contents)

    View Slide

  115. kata
    a Translator
    template

    View Slide

  116. a KataStore
    ./templates/ruby.rspec/* [kata_file1, kata_file2, ...]
    [kata_file1, kata_file2, ...] /tmp/*

    View Slide

  117. or something
    like that

    View Slide

  118. theory
    vs practice

    View Slide

  119. clarity
    and chaos

    View Slide

  120. Query Command
    Incoming
    Private
    Outgoing
    assert return value assert side effects
    do not assert do not assert
    do not assert assert message sent

    View Slide

  121. F F F F F F F
    thank you
    <3 <3 <3
    ......... c

    View Slide

  122. Practical Object Oriented Design in Ruby Sandi Metz
    The Magic Tricks of Testing Sandi Metz
    Working Effectively with Legacy Code Michael Feathers
    CodersDojo Client FreeBSD License, (c) The CodersDojo Team
    Limited Red Joseph Wilk
    Fonts & Colors Damon Davison

    View Slide