Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code review - English version

Avatar for Sébastien Charrier Sébastien Charrier
October 20, 2017
Programming
0
62

Code review - English version

Is code review a fucking waste of time?

Video [FR]: https://www.youtube.com/watch?v=6aQK6GoTbxM

Avatar for Sébastien Charrier

Sébastien Charrier

October 20, 2017
Tweet

More Decks by Sébastien Charrier

See All by Sébastien Charrier
Prenez la parole !
Avatar for Sébastien Charrier scharrier
0
160
Code review - DevFest Nantes
Avatar for Sébastien Charrier scharrier
3
680
Tous UX designers !
Avatar for Sébastien Charrier scharrier
1
290
Angers.io - 8 mois après le lancement
Avatar for Sébastien Charrier scharrier
0
90
De l'idée au produit pour 4999€
Avatar for Sébastien Charrier scharrier
0
150
Web et vie privée
Avatar for Sébastien Charrier scharrier
0
77
Mainelabs en 1 an
Avatar for Sébastien Charrier scharrier
0
81
Remote
Avatar for Sébastien Charrier scharrier
4
160
Comment (ne pas) foirer un produit en beauté - Blendwebmix
Avatar for Sébastien Charrier scharrier
1
230

Other Decks in Programming

See All in Programming
リバースエンジニアリング新時代へ！
GhidraとClaude DesktopをMCPで繋ぐ/findy202507
Avatar for @tkmru tkmru
4
1.2k
MDN Web Docs に日本語翻訳でコントリビュートしたくなる
Avatar for uutan1108 ohmori_yusuke
1
130
Workers を定期実行する方法は一つじゃない
Avatar for rokuosan rokuosan
0
130
11年かかって やっとVibe Codingに 時代が追いつきましたね
Avatar for yimajo yimajo
0
150
Claude Code で Astro blog を Pages から Workers へ移行してみた
Avatar for Kei Kamikawa codehex
0
150
What's new in AppKit on macOS 26
Avatar for 1024jp 1024jp
0
170
階層化自動テストで開発に機動力を
Avatar for ICKX ickx
1
420
おやつのお供はお決まりですか？@WWDC25 Recap -Japan-\(region).swift
Avatar for gangan shingangan
0
150
ISUCON研修おかわり会 講義スライド
Avatar for Yuki Yata arfes0e2b3c
1
480
PHPカンファレンス関西2025　基調講演
Avatar for SUGIMOTO Kei sugimotokei
5
940
Claude Code + Container Use と Cursor で作る ローカル並列開発環境のススメ / ccc local dev
Avatar for Yuichi Maekawa kaelaela
12
7.4k
코딩 에이전트 체크리스트: Claude Code ver.
Avatar for nacyot nacyot
0
990

Featured

See All Featured
StorybookのUI Testing Handbookを読んだ
Avatar for Shingo Yamazaki zakiyama
30
5.9k
Unsuck your backbone
Avatar for Amy Palamountain ammeep
671
58k
Building Better People: How to give real-time feedback that sticks.
Avatar for Will Jessup wjessup
367
19k
VelocityConf: Rendering Performance Case Studies
Avatar for Addy Osmani addyosmani
332
24k
What's in a price? How to price your products and services
Avatar for Michael Herold michaelherold
246
12k
JavaScript: Past, Present, and Future - NDC Porto 2020
Avatar for David Neal reverentgeek
50
5.5k
The Invisible Side of Design
Avatar for Vitaly Friedman smashingmag
301
51k
Chrome DevTools: State of the Union 2024 - Debugging React & Beyond
Avatar for Addy Osmani addyosmani
7
760
GraphQLの誤解/rethinking-graphql
Avatar for sonatard sonatard
71
11k
Save Time (by Creating Custom Rails Generators)
Avatar for Garrett Dimon garrettdimon
PRO
31
1.3k
Dealing with People You Can't Stand - Big Design 2015
Avatar for Cassini Nazir cassininazir
367
26k
Balancing Empowerment & Direction
Avatar for Lara Hogan lara
1
490

Transcript

  1. #CODE A fucking waste of time. DEVFEST NANTES - 20/10/2017

    REVIEW

  2. Sébastien 
 Charrier scharrier

  3. None

  4. BACK TO THE PAST, WHEN WORKING WITH SVN, OR CVS.

  5. CODING WAS FAST

  6. None

  7. GIT, Then, we got GITHUB, GITLAB, BITBUCKET…

  8. SOME GOOD TOOLS TOGETHER TO WORK AND CODE

  9. PULL* REQUEST * or merge

  10. CODE REVIEW Yea. We could do before merging.

  11. Ask a peer to read and validate our code before

    merging it into the product.

  12. Fuck, it takes too much time. Your boss

  13. AT LEAST 30% OF MY TIME * personal estimation

  14. None

  15. COSTS Yep, it but…

  16. QUALITY,

  17. CONSISTENCY,

  18. LEARNING.

  19. IT’S AN INVESTMENT. Finally,

  20. There are two important things.

  21. STATE OF MIND

  22. None

  23. We work together to create the best product we can.

  24. GUIDELINES

  25. None

  26. Write code style rules and review rules.

  27. In order to not repeat yourself, and avoid conflicts.

  28. SOME OF MY RULES

  29. FOR EVERYBODY

  30. EMPATHY

  31. STAY HUMBLE EMPATHY

  32. STAY HUMBLE NO IRONY EMPATHY

  33. STAY HUMBLE NO IRONY NO FUCKING INSULTS * * true

    story. EMPATHY
  34. None

  35. I AM THE REVIEWER

  36. QUESTIONS, NO ORDERS

  37. QUESTIONS, NO ORDERS BE EXPLICIT

  38. QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF

  39. QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF BE RESPONSIBLE

  40. None

  41. I AM REVIEWED

  42. KEEP PRS SMALL

  43. BE GRATEFUL KEEP PRS SMALL

  44. BE GRATEFUL EXPLAIN YOUR CHOICES KEEP PRS SMALL

  45. BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS KEEP PRS

    SMALL

  46. BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS DO NOT

    GIVE UP KEEP PRS SMALL

  47. STILL DISAGREE ?

  48. None

  49. CLOSE COMPUTERS AND DISCUSS IRL

  50. OR ASK SOMEBODY ELSE’S POINT OF VIEW.

  51. None

  52. THE FINAL DECISION Finally, let the maintainer take (but do

    another PR later.)

  53. THANKS. http://bump.sh Psssst !