Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code review - English version
Search
Sébastien Charrier
October 20, 2017
Programming
0
62
Code review - English version
Is code review a fucking waste of time?
Video [FR]:
https://www.youtube.com/watch?v=6aQK6GoTbxM
Sébastien Charrier
October 20, 2017
Tweet
Share
More Decks by Sébastien Charrier
See All by Sébastien Charrier
Prenez la parole !
scharrier
0
160
Code review - DevFest Nantes
scharrier
3
680
Tous UX designers !
scharrier
1
290
Angers.io - 8 mois après le lancement
scharrier
0
90
De l'idée au produit pour 4999€
scharrier
0
150
Web et vie privée
scharrier
0
77
Mainelabs en 1 an
scharrier
0
81
Remote
scharrier
4
160
Comment (ne pas) foirer un produit en beauté - Blendwebmix
scharrier
1
230
Other Decks in Programming
See All in Programming
リバースエンジニアリング新時代へ! GhidraとClaude DesktopをMCPで繋ぐ/findy202507
tkmru
4
1.2k
MDN Web Docs に日本語翻訳でコントリビュートしたくなる
ohmori_yusuke
1
130
Workers を定期実行する方法は一つじゃない
rokuosan
0
130
11年かかって やっとVibe Codingに 時代が追いつきましたね
yimajo
0
150
Claude Code で Astro blog を Pages から Workers へ移行してみた
codehex
0
150
What's new in AppKit on macOS 26
1024jp
0
170
階層化自動テストで開発に機動力を
ickx
1
420
おやつのお供はお決まりですか?@WWDC25 Recap -Japan-\(region).swift
shingangan
0
150
ISUCON研修おかわり会 講義スライド
arfes0e2b3c
1
480
PHPカンファレンス関西2025 基調講演
sugimotokei
5
940
Claude Code + Container Use と Cursor で作る ローカル並列開発環境のススメ / ccc local dev
kaelaela
12
7.4k
코딩 에이전트 체크리스트: Claude Code ver.
nacyot
0
990
Featured
See All Featured
StorybookのUI Testing Handbookを読んだ
zakiyama
30
5.9k
Unsuck your backbone
ammeep
671
58k
Building Better People: How to give real-time feedback that sticks.
wjessup
367
19k
VelocityConf: Rendering Performance Case Studies
addyosmani
332
24k
What's in a price? How to price your products and services
michaelherold
246
12k
JavaScript: Past, Present, and Future - NDC Porto 2020
reverentgeek
50
5.5k
The Invisible Side of Design
smashingmag
301
51k
Chrome DevTools: State of the Union 2024 - Debugging React & Beyond
addyosmani
7
760
GraphQLの誤解/rethinking-graphql
sonatard
71
11k
Save Time (by Creating Custom Rails Generators)
garrettdimon
PRO
31
1.3k
Dealing with People You Can't Stand - Big Design 2015
cassininazir
367
26k
Balancing Empowerment & Direction
lara
1
490
Transcript
#CODE A fucking waste of time. DEVFEST NANTES - 20/10/2017
REVIEW
Sébastien Charrier scharrier
None
BACK TO THE PAST, WHEN WORKING WITH SVN, OR CVS.
CODING WAS FAST
None
GIT, Then, we got GITHUB, GITLAB, BITBUCKET…
SOME GOOD TOOLS TOGETHER TO WORK AND CODE
PULL* REQUEST * or merge
CODE REVIEW Yea. We could do before merging.
Ask a peer to read and validate our code before
merging it into the product.
Fuck, it takes too much time. Your boss
AT LEAST 30% OF MY TIME * personal estimation
None
COSTS Yep, it but…
QUALITY,
CONSISTENCY,
LEARNING.
IT’S AN INVESTMENT. Finally,
There are two important things.
STATE OF MIND
None
We work together to create the best product we can.
GUIDELINES
None
Write code style rules and review rules.
In order to not repeat yourself, and avoid conflicts.
SOME OF MY RULES
FOR EVERYBODY
EMPATHY
STAY HUMBLE EMPATHY
STAY HUMBLE NO IRONY EMPATHY
STAY HUMBLE NO IRONY NO FUCKING INSULTS * * true
story. EMPATHY
None
I AM THE REVIEWER
QUESTIONS, NO ORDERS
QUESTIONS, NO ORDERS BE EXPLICIT
QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF
QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF BE RESPONSIBLE
None
I AM REVIEWED
KEEP PRS SMALL
BE GRATEFUL KEEP PRS SMALL
BE GRATEFUL EXPLAIN YOUR CHOICES KEEP PRS SMALL
BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS KEEP PRS
SMALL
BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS DO NOT
GIVE UP KEEP PRS SMALL
STILL DISAGREE ?
None
CLOSE COMPUTERS AND DISCUSS IRL
OR ASK SOMEBODY ELSE’S POINT OF VIEW.
None
THE FINAL DECISION Finally, let the maintainer take (but do
another PR later.)
THANKS. http://bump.sh Psssst !