Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code review - English version

Sponsored · Your Podcast. Everywhere. Effortlessly. Share. Educate. Inspire. Entertain. You do you. We'll handle the rest. →
Avatar for Sébastien Charrier Sébastien Charrier
October 20, 2017
Programming
77
0

Code review - English version

Is code review a fucking waste of time?

Video [FR]: https://www.youtube.com/watch?v=6aQK6GoTbxM

Avatar for Sébastien Charrier

Sébastien Charrier

October 20, 2017

More Decks by Sébastien Charrier

See All by Sébastien Charrier
Prenez la parole !
Avatar for Sébastien Charrier scharrier
0
180
Code review - DevFest Nantes
Avatar for Sébastien Charrier scharrier
3
700
Tous UX designers !
Avatar for Sébastien Charrier scharrier
1
350
Angers.io - 8 mois après le lancement
Avatar for Sébastien Charrier scharrier
0
100
De l'idée au produit pour 4999€
Avatar for Sébastien Charrier scharrier
0
160
Web et vie privée
Avatar for Sébastien Charrier scharrier
0
86
Mainelabs en 1 an
Avatar for Sébastien Charrier scharrier
0
100
Remote
Avatar for Sébastien Charrier scharrier
4
170
Comment (ne pas) foirer un produit en beauté - Blendwebmix
Avatar for Sébastien Charrier scharrier
1
250

Other Decks in Programming

See All in Programming
GitHubCopilotCLIをはじめよう.pdf
Avatar for tkym htkym
0
300
Making the RBS Parser Faster
Avatar for Soutaro Matsumoto soutaro
0
620
エラー処理の温故知新 / history of error handling technic
Avatar for nakaryo ryotanakaya
7
1.8k
書き換えて学ぶTemporal #fukts
Avatar for Hiroyuki ANAI pirosikick
1
300
Spec-driven Development: How AI Changes Everything (And Nothing)
Avatar for Simon Martinelli simas
PRO
0
490
ハーネスエンジニアリングにどう向き合うか 〜ルールファイルを超えて開発プロセスを設計する〜 / How to approach harness engineering
Avatar for r-kagaya rkaga
24
16k
Claude Code × Gemini × Ebitengine ゲーム制作素人WebエンジニアがGoでゲームを作った話
Avatar for webzawa webzawa
0
210
運転動画を検索可能にする〜Cosmos-Embed1とDatabricks Vector Searchで〜/cosmos-embed1-databricks-vector-search
Avatar for 開発室Graph studio_graph
1
530
Terraform言語の静的解析 / static analysis of Terraform language
Avatar for Kazuma Watanabe wata727
1
120
ふりがな Deep Dive try! Swift Tokyo 2026
Avatar for watura watura
0
250
Oxlintとeslint-plugin-react-hooks 明日から始められそう？
Avatar for t6adev t6adev
0
300
tRPCの概要と少しだけパフォーマンス
Avatar for Keigo Ebihara misoton665
2
250

Featured

See All Featured
No one is an island. Learnings from fostering a developers community.
Avatar for Antonio thoeni
21
3.7k
My Coaching Mixtape
Avatar for mlcsv mlcsv
0
110
Six Lessons from altMBA
Avatar for Skipper Chong Warson skipperchong
29
4.2k
A better future with KSS
Avatar for Kyle Neath kneath
240
18k
Design and Strategy: How to Deal with People Who Don’t "Get" Design
Avatar for Morgane Peng morganepeng
133
19k
DBのスキルで生き残る技術 - AI時代におけるテーブル設計の勘所
Avatar for soudai sone soudai
PRO
64
54k
The Psychology of Web Performance [Beyond Tellerrand 2023]
Avatar for Tammy Everts tammyeverts
49
3.4k
Templates, Plugins, & Blocks: Oh My! Creating the theme that thinks of everything
Avatar for Michelle Schulp Hunt marktimemedia
31
2.8k
How to Get Subject Matter Experts Bought In and Actively Contributing to SEO & PR Initiatives.
Avatar for Liv Day livdayseo
0
110
KATA
Avatar for Megan Lloyd mclloyd
PRO
35
15k
Marketing to machines
Avatar for Jono Alderson jonoalderson
1
5.2k
How GitHub (no longer) Works
Avatar for Zach Holman holman
316
150k

Transcript

  1. #CODE A fucking waste of time. DEVFEST NANTES - 20/10/2017

    REVIEW

  2. Sébastien 
 Charrier scharrier

  3. None

  4. BACK TO THE PAST, WHEN WORKING WITH SVN, OR CVS.

  5. CODING WAS FAST

  6. None

  7. GIT, Then, we got GITHUB, GITLAB, BITBUCKET…

  8. SOME GOOD TOOLS TOGETHER TO WORK AND CODE

  9. PULL* REQUEST * or merge

  10. CODE REVIEW Yea. We could do before merging.

  11. Ask a peer to read and validate our code before

    merging it into the product.

  12. Fuck, it takes too much time. Your boss

  13. AT LEAST 30% OF MY TIME * personal estimation

  14. None

  15. COSTS Yep, it but…

  16. QUALITY,

  17. CONSISTENCY,

  18. LEARNING.

  19. IT’S AN INVESTMENT. Finally,

  20. There are two important things.

  21. STATE OF MIND

  22. None

  23. We work together to create the best product we can.

  24. GUIDELINES

  25. None

  26. Write code style rules and review rules.

  27. In order to not repeat yourself, and avoid conflicts.

  28. SOME OF MY RULES

  29. FOR EVERYBODY

  30. EMPATHY

  31. STAY HUMBLE EMPATHY

  32. STAY HUMBLE NO IRONY EMPATHY

  33. STAY HUMBLE NO IRONY NO FUCKING INSULTS * * true

    story. EMPATHY
  34. None

  35. I AM THE REVIEWER

  36. QUESTIONS, NO ORDERS

  37. QUESTIONS, NO ORDERS BE EXPLICIT

  38. QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF

  39. QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF BE RESPONSIBLE

  40. None

  41. I AM REVIEWED

  42. KEEP PRS SMALL

  43. BE GRATEFUL KEEP PRS SMALL

  44. BE GRATEFUL EXPLAIN YOUR CHOICES KEEP PRS SMALL

  45. BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS KEEP PRS

    SMALL

  46. BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS DO NOT

    GIVE UP KEEP PRS SMALL

  47. STILL DISAGREE ?

  48. None

  49. CLOSE COMPUTERS AND DISCUSS IRL

  50. OR ASK SOMEBODY ELSE’S POINT OF VIEW.

  51. None

  52. THE FINAL DECISION Finally, let the maintainer take (but do

    another PR later.)

  53. THANKS. http://bump.sh Psssst !