Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code review - English version
Search
Sébastien Charrier
October 20, 2017
Programming
0
56
Code review - English version
Is code review a fucking waste of time?
Video [FR]:
https://www.youtube.com/watch?v=6aQK6GoTbxM
Sébastien Charrier
October 20, 2017
Tweet
Share
More Decks by Sébastien Charrier
See All by Sébastien Charrier
Prenez la parole !
scharrier
0
160
Code review - DevFest Nantes
scharrier
3
660
Tous UX designers !
scharrier
1
260
Angers.io - 8 mois après le lancement
scharrier
0
86
De l'idée au produit pour 4999€
scharrier
0
150
Web et vie privée
scharrier
0
67
Mainelabs en 1 an
scharrier
0
76
Remote
scharrier
4
150
Comment (ne pas) foirer un produit en beauté - Blendwebmix
scharrier
1
220
Other Decks in Programming
See All in Programming
プログラミング言語学習のススメ / why-do-i-learn-programming-language
yashi8484
0
160
Datadog Workflow Automation で圧倒的価値提供
showwin
1
160
PHPのバージョンアップ時にも役立ったAST
matsuo_atsushi
0
230
未経験でSRE、はじめました! 組織を支える役割と軌跡
curekoshimizu
1
150
Ruby on cygwin 2025-02
fd0
0
180
仕様変更に耐えるための"今の"DRY原則を考える
mkmk884
9
3.2k
コミュニティ駆動 AWS CDK ライブラリ「Open Constructs Library」 / community-cdk-library
gotok365
2
240
Domain-Driven Transformation
hschwentner
2
1.9k
負債になりにくいCSSをデザイナとつくるには?
fsubal
10
2.6k
Go 1.24でジェネリックになった型エイリアスの紹介
syumai
2
280
Datadog DBMでなにができる? JDDUG Meetup#7
nealle
0
140
pylint custom ruleで始めるレビュー自動化
shogoujiie
0
150
Featured
See All Featured
Put a Button on it: Removing Barriers to Going Fast.
kastner
60
3.7k
GraphQLとの向き合い方2022年版
quramy
44
14k
Bootstrapping a Software Product
garrettdimon
PRO
306
110k
Mobile First: as difficult as doing things right
swwweet
223
9.4k
Cheating the UX When There Is Nothing More to Optimize - PixelPioneers
stephaniewalter
280
13k
Building Flexible Design Systems
yeseniaperezcruz
328
38k
How GitHub (no longer) Works
holman
314
140k
Six Lessons from altMBA
skipperchong
27
3.6k
Stop Working from a Prison Cell
hatefulcrawdad
267
20k
VelocityConf: Rendering Performance Case Studies
addyosmani
328
24k
Practical Tips for Bootstrapping Information Extraction Pipelines
honnibal
PRO
12
990
Faster Mobile Websites
deanohume
306
31k
Transcript
#CODE A fucking waste of time. DEVFEST NANTES - 20/10/2017
REVIEW
Sébastien Charrier scharrier
None
BACK TO THE PAST, WHEN WORKING WITH SVN, OR CVS.
CODING WAS FAST
None
GIT, Then, we got GITHUB, GITLAB, BITBUCKET…
SOME GOOD TOOLS TOGETHER TO WORK AND CODE
PULL* REQUEST * or merge
CODE REVIEW Yea. We could do before merging.
Ask a peer to read and validate our code before
merging it into the product.
Fuck, it takes too much time. Your boss
AT LEAST 30% OF MY TIME * personal estimation
None
COSTS Yep, it but…
QUALITY,
CONSISTENCY,
LEARNING.
IT’S AN INVESTMENT. Finally,
There are two important things.
STATE OF MIND
None
We work together to create the best product we can.
GUIDELINES
None
Write code style rules and review rules.
In order to not repeat yourself, and avoid conflicts.
SOME OF MY RULES
FOR EVERYBODY
EMPATHY
STAY HUMBLE EMPATHY
STAY HUMBLE NO IRONY EMPATHY
STAY HUMBLE NO IRONY NO FUCKING INSULTS * * true
story. EMPATHY
None
I AM THE REVIEWER
QUESTIONS, NO ORDERS
QUESTIONS, NO ORDERS BE EXPLICIT
QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF
QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF BE RESPONSIBLE
None
I AM REVIEWED
KEEP PRS SMALL
BE GRATEFUL KEEP PRS SMALL
BE GRATEFUL EXPLAIN YOUR CHOICES KEEP PRS SMALL
BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS KEEP PRS
SMALL
BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS DO NOT
GIVE UP KEEP PRS SMALL
STILL DISAGREE ?
None
CLOSE COMPUTERS AND DISCUSS IRL
OR ASK SOMEBODY ELSE’S POINT OF VIEW.
None
THE FINAL DECISION Finally, let the maintainer take (but do
another PR later.)
THANKS. http://bump.sh Psssst !