Code review - English version

Is code review a fucking waste of time?

Video [FR]: https://www.youtube.com/watch?v=6aQK6GoTbxM

Transcript

1. #CODE A fucking waste of time. DEVFEST NANTES - 20/10/2017 REVIEW
2. Sébastien 
 Charrier scharrier
4. BACK TO THE PAST, WHEN WORKING WITH SVN, OR CVS.
5. CODING WAS FAST
7. GIT, Then, we got GITHUB, GITLAB, BITBUCKET…
8. SOME GOOD TOOLS TOGETHER TO WORK AND CODE
9. PULL* REQUEST * or merge
10. CODE REVIEW Yea. We could do before merging.
11. Ask a peer to read and validate our code before merging it into the product.
12. Fuck, it takes too much time. Your boss
13. AT LEAST 30% OF MY TIME * personal estimation
15. COSTS Yep, it but…
16. QUALITY,
17. CONSISTENCY,
18. LEARNING.
19. IT’S AN INVESTMENT. Finally,
20. There are two important things.
21. STATE OF MIND
23. We work together to create the best product we can.
24. GUIDELINES
26. Write code style rules and review rules.
27. In order to not repeat yourself, and avoid conflicts.
28. SOME OF MY RULES
29. FOR EVERYBODY
30. EMPATHY
31. STAY HUMBLE EMPATHY
32. STAY HUMBLE NO IRONY EMPATHY
33. STAY HUMBLE NO IRONY NO FUCKING INSULTS * * true story. EMPATHY
35. I AM THE REVIEWER
36. QUESTIONS, NO ORDERS
37. QUESTIONS, NO ORDERS BE EXPLICIT
38. QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF
39. QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF BE RESPONSIBLE
41. I AM REVIEWED
42. KEEP PRS SMALL
43. BE GRATEFUL KEEP PRS SMALL
44. BE GRATEFUL EXPLAIN YOUR CHOICES KEEP PRS SMALL
45. BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS KEEP PRS SMALL
46. BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS DO NOT GIVE UP KEEP PRS SMALL
47. STILL DISAGREE ?
49. CLOSE COMPUTERS AND DISCUSS IRL
50. OR ASK SOMEBODY ELSE’S POINT OF VIEW.
52. THE FINAL DECISION Finally, let the maintainer take (but do another PR later.)
53. THANKS. http://bump.sh Psssst !