Code review - English version

0a5864849f2b7f748d5949da877c0a32?s=47 Sébastien Charrier
October 20, 2017
Programming
0
31

Code review - English version

Is code review a fucking waste of time?

Video [FR]: https://www.youtube.com/watch?v=6aQK6GoTbxM

0a5864849f2b7f748d5949da877c0a32?s=128

Sébastien Charrier

October 20, 2017
Tweet

Want more?

0a5864849f2b7f748d5949da877c0a32?s=48 scharrier
1
94
0a5864849f2b7f748d5949da877c0a32?s=48 scharrier
3
460
0a5864849f2b7f748d5949da877c0a32?s=48 scharrier
1
170
3ab1249be442027903e1180025340b3f?s=48 reverentgeek
13
750
A9a491b0fcbe0fbce3d64063a37add99?s=48 rmw
4
400
766b9746b59e6f09e280cd33cf4ed419?s=48 skipperchong
0
250
61857dafbd287b3027c4dcea9008ad3c?s=48 carmenhchung
8
540
06f8b41980eb4c577fa40c41d5030c19?s=48 keathley
9
290
C0390e8b11079f8761c0cd3274ed61cb?s=48 productmarketing
3
340
C35e01544a0dd94a2cf1619ee8a42ebb?s=48 clairelew
4
800
6bb82b13cda86d3b821fa44100335ddf?s=48 thoeni
1
210
B3ace07412a5178ea778e7eec161fc0a?s=48 jcasabona
4
280

Transcript

  1. 1.

    #CODE A fucking waste of time. DEVFEST NANTES - 20/10/2017

    REVIEW
  2. 2.

    Sébastien 
 Charrier scharrier

  3. 3.
    None
  4. 4.

    BACK TO THE PAST, WHEN WORKING WITH SVN, OR CVS.

  5. 5.

    CODING WAS FAST

  6. 6.
    None
  7. 7.

    GIT, Then, we got GITHUB, GITLAB, BITBUCKET…

  8. 8.

    SOME GOOD TOOLS TOGETHER TO WORK AND CODE

  9. 9.

    PULL* REQUEST * or merge

  10. 10.

    CODE REVIEW Yea. We could do before merging.

  11. 11.

    Ask a peer to read and validate our code before

    merging it into the product.
  12. 12.

    Fuck, it takes too much time. Your boss

  13. 13.

    AT LEAST 30% OF MY TIME * personal estimation

  14. 14.
    None
  15. 15.

    COSTS Yep, it but…

  16. 16.

    QUALITY,

  17. 17.

    CONSISTENCY,

  18. 18.

    LEARNING.

  19. 19.

    IT’S AN INVESTMENT. Finally,

  20. 20.

    There are two important things.

  21. 21.

    STATE OF MIND

  22. 22.
    None
  23. 23.

    We work together to create the best product we can.

  24. 24.

    GUIDELINES

  25. 25.
    None
  26. 26.

    Write code style rules and review rules.

  27. 27.

    In order to not repeat yourself, and avoid conflicts.

  28. 28.

    SOME OF MY RULES

  29. 29.

    FOR EVERYBODY

  30. 30.

    EMPATHY

  31. 31.

    STAY HUMBLE EMPATHY

  32. 32.

    STAY HUMBLE NO IRONY EMPATHY

  33. 33.

    STAY HUMBLE NO IRONY NO FUCKING INSULTS * * true

    story. EMPATHY
  34. 34.
    None
  35. 35.

    I AM THE REVIEWER

  36. 36.

    QUESTIONS, NO ORDERS

  37. 37.

    QUESTIONS, NO ORDERS BE EXPLICIT

  38. 38.

    QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF

  39. 39.

    QUESTIONS, NO ORDERS BE EXPLICIT SHOW GOOD STUFF BE RESPONSIBLE

  40. 40.
    None
  41. 41.

    I AM REVIEWED

  42. 42.

    KEEP PRS SMALL

  43. 43.

    BE GRATEFUL KEEP PRS SMALL

  44. 44.

    BE GRATEFUL EXPLAIN YOUR CHOICES KEEP PRS SMALL

  45. 45.

    BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS KEEP PRS

    SMALL
  46. 46.

    BE GRATEFUL EXPLAIN YOUR CHOICES ANSWER *ALL* COMMENTS DO NOT

    GIVE UP KEEP PRS SMALL
  47. 47.

    STILL DISAGREE ?

  48. 48.
    None
  49. 49.

    CLOSE COMPUTERS AND DISCUSS IRL

  50. 50.

    OR ASK SOMEBODY ELSE’S POINT OF VIEW.

  51. 51.
    None
  52. 52.

    THE FINAL DECISION Finally, let the maintainer take (but do

    another PR later.)
  53. 53.

    THANKS. http://bump.sh Psssst !