日本語: Skinny Controllers, Skinny Models #m3dev

7 つの実装パターンと Code Climate を使った実際のリファクタリング実践の紹介です。

Transcript

1. 4LJOOZ
   $POUSPMMFST
   4LJOOZ
   .PEFMT
   .
   5FDI
   5BML
   NEFW
   ,B[VIJSP
   4FSB
   !TFSBUDI
   
2. 3VCZ,BJHJ
   
   •  -5
   ͠·ͨ͠ʢSTQFDLJDLTUBSUFSʣ
   •  ੮ʹ໭ͬͨΒ
   (FNpMF
   ʹ௥Ճʂ
   •  ࠓ೔͸
   l3FGBDUPSJOH
   'BU
   .PEFMT
   XJUI
   1BUUFSOTz
   ͱ͍͏ߨԋͷ಺༰ͱͦͷ࣮ફʹ ͍ͭͯ঺հ͠·͢
   •  ڵຯΛ࣋ͬͨํ͸ɺಈը͕ެ։͞Ε͍ͯΔ ͷͰޙͰ؍ͯΈ͍ͯͩ͘͞
   IUUQTWJNFPDPN
   
4. !CSZOBSZ
   •  #SZBO
   )FMNLBNQ
   •  $PEF
   $MJNBUF
   ૑ۀऀ
   •  ސ٬ͷ
   3VCZ
   ίʔυΛղੳͯ͠඼࣭ɾη ΩϡϦςΟվળΛࢧԉ͢ΔαʔϏε
   •  044
   ͳΒແྉɺҎԼ͸
   (JTUVC
   ͷྫ
   •  IUUQTDPEFDMJNBUFDPNHJUIVC TFSBUDIHJTUVC
   
5. $PEF
   $MJNBUF
   3BUJOH
   
6. $PEF
   $MJNBUF
   $PEF
   4NFMM
   
7. $PEF
   $MJNBUF
   $MBTTFT
   
8. ϒϩάΤϯτϦ
   •  
   1BUUFSOT
   UP
   3FGBDUPS
   'BU
   "DUJWF3FDPSE
   .PEFMT
   •  IUUQCMPHDPEFDMJNBUFDPNCMPH XBZTUPEFDPNQPTFGBU BDUJWFSFDPSENPEFMT
   •  ͞Βʹվળ͞ΕͨίʔυྫΛ
   (JU)VC
   Ͱެ։ ͍ͯ͠Δʢ3VCZ,BJHJ
   ͰͷൃදͰ࢖༻ʣ
   •  IUUQTHJUIVCDPNDPEFDMJNBUF SFGBDUPSJOHGBUNPEFMT
   
9. 3BJMT
   "DUJWF3FDPSE
   •  1SP
   γϯϓϧ͞
   •  $PO
   %#
   ͷςʔϒϧͱ
   
   Λڧ͍ΒΕΔ
   
10. 3BJMT
    ΞϓϦͰͷࣦഊྫ
    •  ద੾ʹσβΠϯ͞ΕͨΦϒδΣΫτࢦ޲ͷ ίʔυ͸ϥϏΦϦʹྫ͑ΒΕΔ
    •  ࣌ંɺΧϧκʔωΈ͍ͨʹҰΧॴʹ٧Ίࠐ Μͩ
    3BJMT
    ίʔυΛݟ͔͚Δɾɾ
    
11. 4LJOOZ
    .PEFMT
    •  'BU
    .PEFMT
    ͱΑ͘ݴΘΕΔ͕
    .PEFM
    ΋
    4LJOOZ
    Ͱ͋Δ΂͖ͳΜͰ͸ʁ
    
12. 'BU
    .PEFMT
    ͱͷઓ͍
    •  $POUSPMMFS
    ͕ංେԽ͢ΔΑΓ͸Ϛγʁ
    •  طଘͷ
    "3 "DUJWF3FDPSE
    NPEFM
    
    ʹ੹ ຿Λ͍࣋ͨͤͯ͘ͱͲΜͲΜංେԽ
    •  ࠷ѱͷέʔε͸ਆΦϒδΣΫτ͕஀ੜ
    •  !CSZOBSZ
    ͸ɺఆ൪ͷ࣮૷ύλʔϯΛ͏· ͘
    3BJMT
    ͷ
    NPEFM
    ͷϦϑΝΫλϦϯάʹ ద༻͢Δํ๏ΛఏҊ͍ͯ͠Δ
    
13. Ξϯνύλʔϯ
    •  ͨͩ͠ɺ҆қʹ
    NJYJO
    ͱͯ͠
    NPEVMF
    ʹ ੾Γग़͢ͷ͸Ξϯνύλʔϯ
    •  NJYJO
    ͸ܗΛม͑ͨܧঝ
    •  ͕Βͨ͘ΛಥͬࠐΉҾ͖ग़͠ʢίʔυΛ
    NPEVMF
    ʹҠͯ͠
    JODMVEF
    ͢Δ͚ͩʣ
    •  ͨ͘͞Μ
    NJYJO
    ͞Εͨ
    DMBTT
    ͩͱͲΜͳ ΦϒδΣΫτ͔೺Ѳ͢Δͷ͕େมʹͳΔ
    
14. 
    ͭͷ࣮૷ύλʔϯ
    •  7BMVF
    0CKFDUT
    •  4FSWJDF
    0CKFDUT
    •  'PSN
    0CKFDUT
    •  2VFSZ
    0CKFDUT
    •  7JFX
    0CKFDUT
    •  1PMJDZ
    0CKFDUT
    •  %FDPSBUPST
    
15. 7BMVF
    0CKFDUT
    •  ͓ͳ͡Έ
    7BMVF
    0CKFDU
    •  JNNVUBCMF
    ͳ஋Λอ࣋͢ΔΫϥε
    •  อ࣋͢Δ஋ʹΑͬͯൺֱՄೳ
    •  ԿΒ͔ͷϩδοΫΛ࣋ͭ
    BUUSJCVUFʢ·ͨ ͸ͦͷখ͞ͳू߹ʣ͕ద͍ͯ͠Δ
    •  ۩ମྫɿ1IPOF/VNCFSɺ.POFZɺ 3BUJOHͳͲ
    
16. 4FSWJDF
    0CKFDUT
    •  ෳ਺ͷ
    NPEFM
    Λར༻͢Δ৔߹
    •  ֎෦ͷαʔϏεɺ"1*
    ͱ࿈ܞ͢Δ৔߹
    •  ෳࡶͳϩδοΫΛ࣮૷͢Δ৔߹
    •  طଘͷ
    NPEFM
    ͷओͨΔ੹຿Ͱͳ͍৔߹
    •  4USBUFHZ
    ύλʔϯΛద༻͍ͨ͠৔߹
    •  ී௨
    "DUJWF.PEFM
    Ͱ͸ͳ͍
    
17. 'PSN
    0CKFDUT
    •  ҰͭͷϑΥʔϜͰෳ਺ͷ
    "3
    NPEFM
    Λߋ ৽͍ͨ͠৔߹ʹ༗ޮ
    •  "DUJWF.PEFM
    ʹ͢Δ
    •  'PSN
    ͷ
    TBWF
    ͷ಺෦Ͱෳ਺ͷ
    "3
    NPEFM
    
    ͷ
    TBWF
    Λݺͼग़͢
    •  ඪ४ͷ
    BDDFQUT@OFTUFE@BUUSJCVUFT@GPS
    ͸
    !CSZOBSZ
    తʹ͸ඇਪ঑
    •  ෳࡶʹͳͬͨΒӬଓԽॲཧΛ
    4FSWJDF
    ʹ
    
18. 2VFSZ
    0CKFDUT
    •  όον༻
    PS
    ෳࡶͳ৚݅ͷ
    42-
    Λ
    "3
    ͷ
    TDPQF
    ΍Ϋϥεϝιουʹͤͣ
    2VFSZ
    0CKFDU
    ͱͯ͠෼཭
    •  ॳظԽ࣌ʹ
    "33FMBUJPO
    ΦϒδΣΫτΛ ౉͢Α͏ʹ͢Δͱ߹੒ՄೳʹͳΔ
    •  5SJBM2VFSZOFX "DDPVOUXIFSF ʜ pO E@FBDI
    EP
    cFc
    ʜ
    FOE
    
19. 7JFX
    0CKFDUT
    •  7JFX
    ͷͨΊͷϩδοΫΛ
    "3
    NPEFM
    ʹ ॻ͔ͳ͍ʢΤϥʔϝοηʔδੜ੒ͳͲʣ
    •  "3
    NPEFM
    Λอ࣋͢ΔΫϥεΛఆٛ͠
    SFOEFS
    ʹ͸ͪ͜ΒΛ౉͢Α͏ʹ͢Δ
    •  IFMQFS
    ʹ
    "3
    NPEFM
    Λ౉࣮͢૷ΑΓ΋ɺ ϦϑΝΫλϦϯά͕ଅਐ͞ΕΔ
    •  ଟ༷ͳ
    6*
    ʹରԠ͢Δ৔߹ʹ΋༗ޮ
    
20. 1PMJDZ
    0CKFDUT
    •  "3
    NPEFM
    Λࢀর͸͢Δ͕ओͨΔυϝΠ ϯͰ͸ͳ͍ϩδοΫʢ෼ੳͷͨΊͷ൑ఆ ͳͲʣΛ෼཭͢Δ
    •  ྫɿϝʔϧ഑৴ର৅ʁΞΫςΟϒϢʔβʁ
    •  "3
    NPEFM
    Λอ࣋͢ΔΫϥεͱͯ͠ఆٛ
    •  ଞͱͷҧ͍ɿ1PMJDZ
    ͸
    SFBE
    ͳॲཧ͚ͩ
    4FSWJDF
    ͸
    XSJUF
    ΋ؚΉɺ2VFSZ
    ͸
    42-
    ࣮ߦͱ
    SFTVMU
    TFU
    Λ
    ZJFME
    ʹ౉͚ͩ͢
    
21. %FDPSBUPST
    •  %FDPSBUPS
    ύλʔϯΛద༻ͯ͠
    DBMMCBDL
    ஍ࠈΛճආ͢Δ
    •  ྫɿTBWF
    ϝιουΛ਺चͭͳ͗ʹ͢Δ ʢ"3
    ͷ
    0SEFSTBWF
    Ͱ
    PSEFST
    ςʔϒϧ ʹ
    JOTFSU
    
    %)8
    ʹ௨஌
    
    ड෇׬ྃ ϝʔϧΛૹ৴ʣ
    
22. ࣮ફͯ͠Έͨ
    •  ࣮ࡍʹύλʔϯΛ࢖ͬͯ
    (JTUVC
    ͷϦϑΝ ΫλϦϯάΛͯ͠Έͨ
    
23. ύλʔϯΛ࣮ફ͢Δલ
    
24. ύλʔϯΛ࣮ફͨ͠ޙ
    
25. ΍ͬͨ͜ͱ
    •  ࢖ͬͨύλʔϯ͸
    4FSWJDF
    0CKFDUT
    ͚ͩ
    •  ୯ʹ
    $POUSPMMFS
    ͔Β
    4FSWJDF
    ʹ੾Γग़͠ ͚ͨͩͩͱɺࠓ౓͸ͦͷ৽͍͠
    4FSWJDF
    ͷείΞ͕ѱ͔ͬͨʢ౰ͨΓલʣ
    •  ෳࡶ౓ͷߴ͗͢ΔϝιουΛ໊લΛ෇͚ ΒΕΔ୯Ґʹ෼ׂ
    •  ίʔυͷॏෳΛڞ௨Խ
    
26. վળͷաఔ
    
27. ࠓ೔͔Βग़དྷΔ͜ͱ
    •  ໡໨తʹ
    "3
    ͷΫϥεϝιουʹ͠ͳ͍
    •  "3
    Ͱͳ͍Ϟσϧ΋ͲΜͲΜͭ͘Δ
    •  $POUSPMMFS
    ʹ
    "3
    NPEFM
    ݺͼग़͠Λζϥ ζϥॻ͘ΑΓ
    4FSWJDF
    ʹ͢Δ
    •  ෳࡶͳϑΥʔϜ͸
    'PSN
    Λಋೖ͢Δ
    •  "3
    ʹදࣔ༻ϩδοΫΛ࣋ͨͣ
    7JFX
    0CKFDU
    Ͱϥοϓͯ͠දࣔॲཧʹ౉͢
    
28. ·ͱΊ
    •  طʹ࣮ફ͞Ε͍ͯΔ΋ͷ΋ଟ͍͕ɺύλʔ ϯʹ໊લ͕͍ͭͯݴޠԽ͞ΕΔ͜ͱ͸େࣄ
    •  ࠷ॳ͸γϯϓϧͰΑ͍ʢύλʔϯͷ΍Γ͢ ͗͸
    PWFS
    FOHJOFFSJOHʣ
    •  ΞϓϦ͕ҭ͍ͬͯ͘தͰن໛ʹԠͨ͡Ϧ ϑΝΫλϦϯά͸ඞཁʹͳ͍ͬͯ͘
    •  ͨͩ͠ɺे෼ͳίʔυΧόϨοδ͸ඞਢ
    
29. ΞϓϦن໛ͱΞʔΩςΫνϟ
    
30. 2"
    .
    5FDI
    5BML
    NEFW
    ,B[VIJSP
    4FSB
    !TFSBUDI
    "OZ
    2VFTUJPO