Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Effective Code Review

Attia Mo
December 25, 2019

Effective Code Review

Attia Mo

December 25, 2019
Tweet

More Decks by Attia Mo

Other Decks in Technology

Transcript

  1. A t t i a M o
    Effective Code Review
    @AttiaMoTheDev

    View full-size slide


  2. A t t i a M o @AttiaMoTheDev

    View full-size slide

  3. A t t i a M o @AttiaMoTheDev
    1⃣ What’s Code Review?
    2⃣ Why Should We Care about it?
    3⃣ Code Review Checklist ✅
    4⃣ Feedback Culture
    5⃣ Resources
    Agenda .

    View full-size slide

  4. A t t i a M o @AttiaMoTheDev
    wikipedia
    1⃣ What’s Code Review?
    Code review is systematic examination (sometimes referred to as peer
    review) of computer source code. It is intended to find mistakes
    overlooked in the initial development phase, improving the overall quality
    of software.

    View full-size slide

  5. A t t i a M o @AttiaMoTheDev

    View full-size slide

  6. A t t i a M o @AttiaMoTheDev
    2⃣ Why?

    View full-size slide

  7. A t t i a M o @AttiaMoTheDev
    Styles/ Convention
    Why?

    View full-size slide

  8. A t t i a M o @AttiaMoTheDev
    ⚙ Integrity
    Why?

    View full-size slide

  9. A t t i a M o @AttiaMoTheDev
    Code quality
    Why?
    Code smell

    View full-size slide

  10. A t t i a M o @AttiaMoTheDev
    Long Method
    Code Smell
    Large classe
    Message chain
    Mutable Data Class
    Access control
    Feature envy
    Resource

    View full-size slide

  11. A t t i a M o @AttiaMoTheDev
    Why?
    ♻ Reinventing the Wheel

    View full-size slide

  12. A t t i a M o @AttiaMoTheDev
    Why?
    Security

    View full-size slide

  13. A t t i a M o @AttiaMoTheDev
    Maintainability
    Why?

    View full-size slide

  14. A t t i a M o @AttiaMoTheDev
    3⃣ Checklist ✅

    View full-size slide

  15. A t t i a M o @AttiaMoTheDev

    View full-size slide

  16. A t t i a M o @AttiaMoTheDev
    Project Guidelines (linting ..etc) ✅
    Checklist ☑

    View full-size slide

  17. A t t i a M o @AttiaMoTheDev
    Run Unit/UI/Integration Tests ✅
    Checklist ☑

    View full-size slide

  18. A t t i a M o @AttiaMoTheDev

    View full-size slide

  19. A t t i a M o @AttiaMoTheDev

    View full-size slide

  20. A t t i a M o @AttiaMoTheDev
    System Design ✅
    Checklist ☑

    View full-size slide

  21. A t t i a M o @AttiaMoTheDev
    Functionality ✅
    Checklist ☑

    View full-size slide

  22. A t t i a M o @AttiaMoTheDev
    UI changes ✅
    Checklist ☑

    View full-size slide

  23. A t t i a M o @AttiaMoTheDev
    Good Things ✅
    Checklist ☑

    View full-size slide

  24. A t t i a M o @AttiaMoTheDev
    4⃣ Feedback Culture

    View full-size slide

  25. A t t i a M o @AttiaMoTheDev
    Feedback

    1⃣ Culture.
    2⃣ Time.
    3⃣ Accuracy.

    View full-size slide

  26. A t t i a M o @AttiaMoTheDev
    1⃣ Focus on the behavior, not the person! (this
    code Vs You).
    2⃣ You don’t have any authority.
    3⃣ Culture difference should be taken into an
    account.
    4⃣ You should not escalate it anyway to conflict.

    Culture

    View full-size slide

  27. A t t i a M o @AttiaMoTheDev
    1⃣ Always be within PR scope.
    2⃣ Write all your feedback at once.
    3⃣ Give me actionable item.
    4⃣ You should not escalate it anyway
    to conflict.

    Specific

    View full-size slide

  28. A t t i a M o @AttiaMoTheDev
    1⃣ Write all feedback at once.
    2⃣ Don’t wait for ages to review others.
    3⃣ Don’t rush your code reviews.
    4⃣ Don’t Deploy the day before
    weekend

    Timely

    View full-size slide

  29. A t t i a M o @AttiaMoTheDev
    6⃣ Resources

    View full-size slide


  30. A t t i a M o @AttiaMoTheDev
    https://kristina.io/pull-request-checklists/
    https://medium.com/@same7mabrouk/the-checklist-of-my-code-
    review-18cc6f6fb5b3
    https://google.github.io/eng-practices/review/reviewer/

    View full-size slide

  31. A t t i a M o @AttiaMoTheDev
    1⃣ What’s Code Review?
    2⃣ Why Should We Care about it?
    3⃣ Code Review Checklist ✅
    4⃣ Feedback Culture
    5⃣ Resources
    Recap!

    View full-size slide

  32. Thanks.
    A t t i a M o @AttiaMoTheDev

    View full-size slide