Code Reviews

Code Reviews

When working in the cold and calculating space of computers, it can be easy to forget the emotions of our fellow team mates. This is especially true when it comes to feedback of someone else's work. We need to be sensitive to one's time, effort, and thought while also providing constructive feedback. Emoticons can help express the connotation of feedback you are giving which is sometimes lost in written form. This talk discusses how to use emoticons to set the tone and provide clear visual indication in code review feedback.

E0e036f89c14b3e59640318eedf9670b?s=128

Brooke Kuhlmann

July 11, 2020
Tweet

Transcript

  1. Code Reviews Presented by Brooke Kuhlmann

  2. https://www.alchemists.io/articles/peopleware Peopleware

  3. "When a group of people fuse into a meaningful whole,

    the entire character of the work changes." https://www.alchemists.io/articles/peopleware Peopleware
  4. "When a group of people fuse into a meaningful whole,

    the entire character of the work changes." https://www.alchemists.io/articles/peopleware Peopleware "A jelled team is a group of people so strongly knit that the whole is greater than the sum of the parts."
  5. None
  6. TRUST

  7. Building Trust

  8. Building Trust Ideas Work ❤ Compassion

  9. Insensitive Feedback

  10. Insensitive Feedback No. This can't possibly work. I don't agree

    with these changes. This is unacceptable. You might as well do this over.
  11. Considerate Feedback

  12. Considerate Feedback Nice work and thanks for fixing the issue.

    Have you thought about the security implications? What about using the following solution? Would you want to use the following instead? Maybe leverage this aspect of the architecture?
  13. Emoticons

  14. Emoticons ⭐ ℹ ✅

  15. Categories Blocking Non-blocking

  16. Categories Blocking Non-blocking • Requires immediate attention.

  17. Categories Blocking Non-blocking • Requires immediate attention. • Must be

    fixed.
  18. Categories Blocking Non-blocking • Requires immediate attention. • Must be

    fixed. • Informative or suggestive.
  19. Categories Blocking Non-blocking • Requires immediate attention. • Must be

    fixed. • Informative or suggestive. • Author's discretion.
  20. Categories Blocking Non-blocking • Requires immediate attention. • Must be

    fixed. • Informative or suggestive. • Author's discretion. • Discussion can continue.
  21. Review • Non-blocking. • Status update only.

  22. Review • Non-blocking. • Status update only. :tea:

  23. Favorite ⭐ • Non-blocking. • Positive only. • Must be

    authentic.
  24. Favorite ⭐ • Non-blocking. • Positive only. • Must be

    authentic. :star:
  25. Information ℹ • Non-blocking. • Status update. • Generally doesn't

    need responding to.
  26. Information ℹ • Non-blocking. • Status update. • Generally doesn't

    need responding to. :information_source:
  27. Inquire • Non-blocking. • A chance to learn more.

  28. Inquire • Non-blocking. • A chance to learn more. :thought_balloon:

  29. Typo • Blocking. • Detected misspelling.

  30. Typo • Blocking. • Detected misspelling. :abc:

  31. Style • Non-blocking or blocking. • Improvements to style.

  32. Style • Non-blocking or blocking. • Improvements to style. :art:

  33. Implementation/Architecture • Blocking. • Signifies overarching architectural concerns

  34. Implementation/Architecture • Blocking. • Signifies overarching architectural concerns :classical_building:

  35. Security • Blocking. • Identifies a security violation.

  36. Security • Blocking. • Identifies a security violation. :lock:

  37. Tip • Non-blocking or blocking. • A chance to educate.

  38. Tip • Non-blocking or blocking. • A chance to educate.

    :bulb:
  39. Approve ✅ • Non-blocking. • Approval.

  40. Approve ✅ • Non-blocking. • Approval. :white_check_mark:

  41. Thanks • Non-blocking. • A chance to honor feedback.

  42. Thanks • Non-blocking. • A chance to honor feedback. :bow:

  43. Feedback Format

  44. Feedback Format <emoticon> <message>.

  45. Feedback Format <emoticon> <message>. Would you want to use `Object#then`

    here in order to avoid the temporary local variable?
  46. Resolving Feedback • Address quickly. • Split into smaller stories

    as necessary.
  47. Cadence

  48. Cadence ☀ Dawn Noon Dusk

  49. Guidelines

  50. Guidelines • Lines of Code: ~250 lines (max)

  51. Guidelines • Lines of Code: ~250 lines (max) • Lenght

    of Time: ~1 day (max)
  52. Recap https://www.alchemists.io/projects/git-lint/#_code_reviews

  53. Recap • Be considerate of other's work, ideas, and time.

    https://www.alchemists.io/projects/git-lint/#_code_reviews
  54. Recap • Be considerate of other's work, ideas, and time.

    • Use emoticons. https://www.alchemists.io/projects/git-lint/#_code_reviews
  55. Recap • Be considerate of other's work, ideas, and time.

    • Use emoticons. • Follow the Git Lint Style Guide. https://www.alchemists.io/projects/git-lint/#_code_reviews
  56. Thanks https://www.alchemists.io