Danger: code reviews mais automatizados, rápidos e inteligentes

O processo de code review tem sido cada vez mais adotado por quem preza pela qualidade do código gerado. Ter o código revisado por outro(a) desenvolvedor(a) antes de submetê-lo permite que, com uma visão menos enviesada e com experiências diferentes, os revisores possam apontar erros e melhorias não levadas em consideração anteriormente.

Contudo, este processo pode consumir bastante tempo do dia-a-dia de trabalho. Com o biblioteca Danger consegue-se automatizar parte do code review, aumentando a sua eficácia e velocidade.

Entenda como o Danger funciona, como pode ser aplicado e como podemos melhorá-lo. Conheça um caso de sua aplicação na empresa Loadsmart e quais foram os seus os resultados.

https://thedevconf.com/tdc/2018/florianopolis/trilha-ruby;jsessionid=7750FC3FCA83E1C17F7B6FB72C16A1A7

Transcript

1. Danger: smarter, faster and more efficient code reviews Camila Maia
2. Who am I? • Backend Engineer in the Mobile Squad
3. Code Reviews
4. Code Reviews: They take time!
5. How can we make code reviews smarter, faster and more efficient?
6. Automation
9. • An automated reviewer of your code • Ruby gem • Runs after your CI automating your team's conventions surrounding code review What?
10. CI Systems Peer Review Tools Source Control Management (SCM)
11. It is as generic as you want Like Unit Tests, but for your Team Culture. Formalize your Pull Request etiquette.
12. Why? • More precision on PRs • Take less time on code reviews
13. With Danger, you can leave humans to think about harder problems.
14. How does it work?
15. Domain Specific Languages (DSL’s)
16. # Make it more obvious that a PR is a work in progress and shouldn't be merged yet if github.pr_title.downcase.include? "[wip]" warn("PR is classed as Work in Progress") end # Warn when there is a big PR warn("Big PR") if git.lines_of_code > 500 # Warn if there's no description warn("Please, provide a description to your PR") if github.pr_body.empty?
17. IMPORT FROM A LOCAL FILE REFERENCE danger.import_plugin("danger/plugins/watch_plugin.rb") RETURNS THE NAME OF THE CURRENT SCM PROVIDER BEING USED. danger.scm_provider
18. Plugins
19. How to integrate it?
20. 1 INCLUDE DANGER 2 CREATE DANGERFILE 3 CREATE AN ACCOUNT FOR DANGER 4 CREATE AN ACCESS TOKEN FOR DANGER 5 SETTING UP DANGER TO RUN ON YOUR CI Setup
21. Include Danger
22. Create a Dangerfile DON'T ALLOW A FILE TO BE DELETED deleted = git.deleted_files.include? "my/favourite.file" fail "Don't delete my precious" if deleted
23. Create an Account and an Access Token for Danger
24. Setting up Danger to Run on your Ci
26. Our Experience • Gradual integration works better • The culture is the most important part • It takes time to coworkers get engaged
27. Our Experience • Pair programming • Check other projects • It is awesome for open source projects • Inheritance might be not that easy
30. Community
33. What is next?
34. What? • Hosted Danger • Typescript • Danger JS • It is a really recent project
35. Why? • More flexibility: ◦ Scheduler, for example • Settings are more powerful ◦ Composition besides inheritance
36. Why? • Easier to test • Installation can literally be a single click on the website • It is a GitHub App (not an account) ◦ no need to consider scope for tokens ◦ no need to ensure bot has access to repo
38. Stop saying "you forgot to …" in code review
39. THANK YOU FOR YOUR TIME
40. @_camila_maia_ camilamaia https://loadsmart.com/careers/ WE ARE HIRING!