Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Decoding Code Review - Elixir Conf US
Search
Elaine Naomi
September 07, 2023
Programming
4
270
Decoding Code Review - Elixir Conf US
Lightning Talk
Elaine Naomi
September 07, 2023
Tweet
Share
More Decks by Elaine Naomi
See All by Elaine Naomi
Desenvolvimento Web com Elixir, Phoenix e Ecto - ELUG SP 2024
elainenaomi
1
39
Code Smells in Elixir - CODE BEAM EU 2023
elainenaomi
4
170
Exploring Code Smells - ElixirConf US 2023
elainenaomi
2
400
Getting Started With Phoenix - ElixirConf UY
elainenaomi
3
220
Decodificando o Code Review - Lovecoding 2022
elainenaomi
2
150
Mantendo sistemas Ruby e Elixir: lições aprendidas
elainenaomi
3
390
Decoding code review - Tech & Beers
elainenaomi
4
190
Elixir Conf EU - Lessons Learned from Elixir Learning Paths
elainenaomi
4
440
Elixir Brasil 2020 - Code Smells, Refactoring e Elixir
elainenaomi
5
240
Other Decks in Programming
See All in Programming
Rails 1.0 のコードで学ぶ find_by* と method_missing の仕組み / Learn how find_by_* and method_missing work in Rails 1.0 code
maimux2x
1
290
研究開発と実装OSSと プロダクトの好循環 / A virtuous cycle of research and development implementation OSS and products
linyows
1
140
良いコードレビューとは
danimal141
10
10k
Rubyと自由とAIと
yotii23
6
2k
イベントソーシングによってインピーダンスミスマッチから解放された話
tkawae
1
130
10년 개발한 프로젝트. 애자일 업무 조직에서 모듈화 했던 경험을 공유합니다.
winterlovedev
PRO
0
540
気がついたら子供が社会人になって 自分と同じモバイルアプリエンジニアになった件 / Parent-Child Engineers
koishi
0
210
Lambdaの監視、できてますか?Datadogを用いてLambdaを見守ろう
nealle
2
900
Swift Testingのモチベを上げたい
stoticdev
2
250
DenoでOpenTelemetryに入門する
yotahada3
1
210
15分で学ぶDuckDBの可愛い使い方 DuckDBの最近の更新
notrogue
3
920
もう一人で悩まない! 個の知見をチームの知見にする3つの習慣と工夫 / Into team knowledge.
honyanya
3
450
Featured
See All Featured
[RailsConf 2023] Rails as a piece of cake
palkan
53
5.3k
Designing for Performance
lara
605
69k
実際に使うSQLの書き方 徹底解説 / pgcon21j-tutorial
soudai
176
52k
GitHub's CSS Performance
jonrohan
1030
460k
Easily Structure & Communicate Ideas using Wireframe
afnizarnur
194
16k
Fight the Zombie Pattern Library - RWD Summit 2016
marcelosomers
233
17k
Keith and Marios Guide to Fast Websites
keithpitt
411
22k
Distributed Sagas: A Protocol for Coordinating Microservices
caitiem20
330
21k
Creating an realtime collaboration tool: Agile Flush - .NET Oxford
marcduiker
28
2k
The Illustrated Children's Guide to Kubernetes
chrisshort
48
49k
GraphQLとの向き合い方2022年版
quramy
44
14k
The Power of CSS Pseudo Elements
geoffreycrofte
75
5.7k
Transcript
DECODING CODE REVIEW ElixirConf US - 2023
ELAINE NAOMI WATANABE B.Sc. in Computer Engineering M.Sc. in Computer
Science Senior Software Engineer @ TheRealReal twitter.com/elaine_nw speakerdeck.com/elainenaomi linkedin.com/in/elainenaomi slides
None
CODE REVIEW
2001
60% of defects can be identified in code review process
Boehm, Barry, and Victor R. Basili. "Top 10 list [software development]." Computer 34.1 (2001): 135-137
2009
Code review is a valuable tool for identifying code evolvability-related
defects that are not detectable during the testing phase Mäntylä, Mika V., and Casper Lassenius. "What types of defects are really discovered in code reviews?." IEEE Transactions on Software Engineering 35.3 (2009): 430-448
http://agilemodeling.com/essays/modelReviews.htm Dev. Cost of Change Time Requirements Analysis and Design
Review Tests Production
http://agilemodeling.com/essays/modelReviews.htm Dev. Cost of Change Time Requirements Analysis and Design
Review Tests Production
As an Author
Self-descriptive title Motivation (Business Context) List previous questions and discussions
GIFs, screenshots from the changes
Coherent commit messages Complete, tested code Small changes Single responsibility
principle
Review your own PR Tag people as reviewers Apply necessary
changes Respond to all comments
RubyConf 2018 - A Branch in Time https://www.youtube.com/watch?v=8OOTVxKDwe0 capture the
why, not the what
As a Reviewer
Identify defects (bugs) Suggest alternatives, refactorings Reinforce patterns Validate functionality
(code + business)
Identify security issues Analyze performance impact Suggest documentation Validate the
code quality
Be introduced to new functionalities Learn new technologies Share knowledge
and questions
#
Feedback is about the source code, not about people
Promote the participation of everyone in your team
None
Toxic behaviors in code review may not be so obvious…
Toxic behaviors in code review may not be so obvious…
ask feedback
Toxic behaviors in code review may not be so obvious…
read about Non-Violent Communication
"This PR should not be merged" Opinion-based comment, lacking concrete
action, imperative
"Why haven't you created a new module?" A question with
a judgmental tone "Why didn't you think of that?"
Code reviews like a Human https://mtlynch.io/human-code-reviews-1/ https://mtlynch.io/human-code-reviews-2/
it's about adding comments in a more constructive manner
"Why haven't you created a new module?" A question with
a judgmental tone "Why didn't you think of that?"
constructive manner "What do you think about extracting this logic
into a module? I think it will improve readability and reduce complexity"
no assumptions, just a suggestion "I don't know if you've
already considered this, but wouldn't it be worth creating a new module for this case?"
Be mindful about unconscious bias
For example, about seniority bias
Don't assume that a junior engineer needs explanation for everything
And also, about gender bias
Please, don't try to explain what Elixir is to a
female Elixir engineer
Pay attention for not assuming a female Elixir engineer is
a junior engineer
#
None
None
https://sourcelevel.io/code-review-ebook
None
None
google.github.io/eng-practices/review/reviewer/standard.html
None
railsgirls.com.br
None
CARNIVAL EDITION
speakerdeck.com/elainenaomi elainenaomi.dev Muito obrigada illustrations from undraw.co translation: thank you
so much! slides