Refactor ruby code based on AST

Transcript

1. Refactor ruby code based on AST Richard Huang @flyerhzm
4. Problem
5. Code Review
8. Repeat, Repeat, Repeat
11. Any solution?
12. CodeClimate
15. PullReview
16. How they work?
17. CodeClimate / PullReview flay flog brakeman rails_best_practices … Open Source Gems
18. flay analyzes code for structural similarities
20. flog reports the most tortured code
22. brakeman a static analysis security vulnerability scanner for rails applications
24. rails_best_practices checks the quality of rails code
26. How they work?
27. flay flog brakeman rails_best_practices … ruby_parser ripper parser ruby parser => AST CodeClimate / PullReview
28. ParseTree • First ruby parser • Not support ruby 1.9 or newer
29. ruby_parser • Most popular ruby parser • Output is 100% equivalent to ParseTree
32. ActiveRecord::Base belongs_to :user touch :archived_at def archive
33. ripper • Ruby built-in parser • Support ruby
35. ActiveRecord::Base belongs_to :user def archive touch :archived_at
36. parser • A new ruby parser • Support rewriting
38. ActiveRecord::Base belongs_to :user def archive touch :archived_at
39. Good enough?
40. Auto rewrite!
41. transpec the rspec syntax converter
46. rubocop static code analyzer based on the community ruby style guide
49. transpec rubocop parser
51. Generic Solution
52. Synvert converts ruby code to better syntax
53. DSL • within_file / within_files • with_node / within_node • if_exist_node / unless_exist_node • append / insert / insert_after / replace_with / remove • ……
57. Demo Convert rspec to new syntax Convert rails code from 2.3 to 3.0 Convert rails code from 3.2 to 4.0
58. Side Project not published yet
61. Refs CodeClimate - https://codeclimate.com/ PullReview - https://www.pullreview.com/ flay - https://github.com/seattlerb/flay flog - https://github.com/seattlerb/flog brakeman - https://github.com/presidentbeef/brakeman rails_best_practices - https://github.com/railsbp/ rails_best_practices
62. Refs parsetree - https://github.com/seattlerb/parsetree ruby_parser - https://github.com/seattlerb/ruby_parser parser - https://github.com/whitequark/parser rubocop - https://github.com/bbatsov/rubocop transpec - https://github.com/yujinakayama/transpec synvert - https://github.com/xinminlabs/synvert
63. Thank You