Refactor ruby code based on AST

Transcript

1. 1.

   Refactor ruby code based on AST Richard Huang @flyerhzm

2. 2.

   None
3. 3.

   None
4. 4.

   Problem

5. 5.

   Code Review

6. 6.

   None
7. 7.

   None
8. 8.

   Repeat, Repeat, Repeat

9. 9.

   None
10. 10.

    None
11. 11.

    Any solution?

12. 12.

    CodeClimate

13. 13.

    None
14. 14.

    None
15. 15.

    PullReview

16. 16.

    How they work?

17. 17.

    CodeClimate / PullReview flay flog brakeman rails_best_practices … Open Source

    Gems
18. 18.

    flay analyzes code for structural similarities

19. 19.

    None
20. 20.

    flog reports the most tortured code

21. 21.

    None
22. 22.

    brakeman a static analysis security vulnerability scanner for rails applications

23. 23.

    None
24. 24.

    rails_best_practices checks the quality of rails code

25. 25.

    None
26. 26.

    How they work?

27. 27.

    flay flog brakeman rails_best_practices … ruby_parser ripper parser ruby parser

    => AST CodeClimate / PullReview
28. 28.

    ParseTree • First ruby parser • Not support ruby 1.9

    or newer
29. 29.

    ruby_parser • Most popular ruby parser • Output is 100%

    equivalent to ParseTree
30. 30.

    None
31. 31.

    None
32. 32.

    ActiveRecord::Base belongs_to :user touch :archived_at def archive

33. 33.

    ripper • Ruby built-in parser • Support ruby

34. 34.

    None
35. 35.

    ActiveRecord::Base belongs_to :user def archive touch :archived_at

36. 36.

    parser • A new ruby parser • Support rewriting

37. 37.

    None
38. 38.

    ActiveRecord::Base belongs_to :user def archive touch :archived_at

39. 39.

    Good enough?

40. 40.

    Auto rewrite!

41. 41.

    transpec the rspec syntax converter

42. 42.

    None
43. 43.

    None
44. 44.

    None
45. 45.

    None
46. 46.

    rubocop static code analyzer based on the community ruby style

    guide
47. 47.

    None
48. 48.

    None
49. 49.

    transpec rubocop parser

50. 50.

    None
51. 51.

    Generic Solution

52. 52.

    Synvert converts ruby code to better syntax

53. 53.

    DSL • within_file / within_files • with_node / within_node •

    if_exist_node / unless_exist_node • append / insert / insert_after / replace_with / remove • ……
54. 54.

    None
55. 55.

    None
56. 56.

    None
57. 57.

    Demo Convert rspec to new syntax Convert rails code from

    2.3 to 3.0 Convert rails code from 3.2 to 4.0
58. 58.

    Side Project not published yet

59. 59.

    None
60. 60.

    None
61. 61.

    Refs CodeClimate - https://codeclimate.com/ PullReview - https://www.pullreview.com/ flay - https://github.com/seattlerb/flay

    flog - https://github.com/seattlerb/flog brakeman - https://github.com/presidentbeef/brakeman rails_best_practices - https://github.com/railsbp/ rails_best_practices
62. 62.

    Refs parsetree - https://github.com/seattlerb/parsetree ruby_parser - https://github.com/seattlerb/ruby_parser parser - https://github.com/whitequark/parser

    rubocop - https://github.com/bbatsov/rubocop transpec - https://github.com/yujinakayama/transpec synvert - https://github.com/xinminlabs/synvert
63. 63.

    Thank You