Code review beyond code style - php.gent

Reviewing code can feel like a secondary task. Discussing code can be easy though,
if you leave out syntax details. Following a couple of guide lines for pull requests can make code reviewing much easier.

Some code style rules can drastically reduce the mental overhead needed to understand code changes. Furthermore this talk will give some general guidelines on how to give feedback on PRs as a peer developer or coworker. These rules are not to keep for yourself, share them with your peers and your life will get easier.

Transcript

1. Code reviews @hannesvdvreken @phpgent
2. Hi, my name is Hannes.
3. !
4. madewithlove.be
5. Code reviews
6. What makes a code review?
7. push commits review commits reply approve
8. git add -p WHAT MAKES A CODE REVIEW?
9. Why spend time on that?
10. Submitter WHY SPEND TIME ON THAT?
11. Reviewer WHY SPEND TIME ON THAT?
12. Management WHY SPEND TIME ON THAT?
13. @PHP_CEO YOU THINK DEPLOYING HUNDREDS OF TIMES A DAY IS COOL? WE DEPLOY *INFINITY* TIMES A DAY BY CUTTING OUT THE MIDDLEMAN AND EDITING LIVE CODE
14. Management WHY SPEND TIME ON THAT?
15. What should a submitter do?
16. Intermezzo: code style
17. PSR-2 (soon PSR-12) Symfony code style
19. multiline_array_trailing_comma
21. phpdoc_params align_double_arrow align_equals
22. Braces
25. new_with_braces
27. What should a reviewer do?
28. don’ts ❌ WHAT SHOULD A REVIEWER DO?
29. do ✓ WHAT SHOULD A REVIEWER DO?
30. Language
31. LANGUAGE
36. OMG I'M A BIG FAN OF UR CODES LANGUAGE
37. LANGUAGE
39. Thank you! @hannesvdvreken @phpgent
40. Time for questions. @hannesvdvreken @phpgent