Hidden Gems in Code Reviews

Code reviews are one of the most helpful instruments that engineers have in their toolbox to enable teams to ship reliable and sustainable features. In her talk, Olena shares tips and tricks that she learned during her 4 years at Webflow that help teams accomplish even more through code reviews.

Transcript

1. Hidden Gems in Code Reviews Olena Sovyn
2. ➔ 󰑒 & 󰏅 ➔ 9 years in software industry ➔ 4,5 years with Webflow ➔ Tech lead & Staff SE ➔ 1000+ PRs, 1000+ CRs
3. doing better job with code reviews matter? Why
4. It is a WIN - WIN - WIN enable folks to take more responsibilities, rather than gatekeeping complex changes PR author(s) Company Growing your career as you’ll be able to work on larger context You enable sustainable company growth 󰩽 󰡰 ©
5. Cycle of typical PR PR ready for code review Code review
6. PR ready for code review Code review 🔍 Self-review
7. Why Where
8. PR ready for code review Code review 🔍 Self-review
9. PR ready for code review Code review 🔍 Self-review 󰡲 Choosing CR buddy
10. 🏻 ♀ 🏼 Rose Mark Boris - Senior Software Engineer - 10+ years of experience - 5+ years working at the company - Junior Software Engineer - less 1 year of experience - 3+ years working at the company - Software Engineer - 5 years of experience - second week at the company
11. Rose Mark Boris - Senior Software Engineer - 10+ years of experience - 5+ years working at the company - Junior Software Engineer - less 1 year of experience - 3+ years working at the company - Software Engineer - 5 years of experience - second week at the company
12. Rose Mark Boris - Senior Software Engineer - 10+ years of experience - 5+ years working at the company - Junior Software Engineer - less 1 year of experience - 3+ years working at the company - Software Engineer - 5 years of experience - second week at the company
13. Hi! I’ve added you as one of the code reviewers for PR12345. Please, feel free to ask any questions about changes that you’ll see there
14. Use code reviews as a way to share general or domain specific knowledge
15. PR ready for code review Code review 🔍 Self-review 󰡲 Choosing CR buddy
16. PR ready for code review Code review 🔍 Self-review 󰡲 Choosing CR buddy 🦄 Reading code first time
17. Reading this code for the first time is something that you never will be able to do again 🦄
18. 1. Take notes 2. Ask yourself questions: a. how easy code is to understand? (for example, variable names, code structure, code organisation) b. is it obvious what code is doing? 3. Your first impression is an invaluable signal How to read code first time:
19. PR ready for code review Code review 🔍 Self-review 󰡲 Choosing CR buddy 🦄 Reading code first time
20. PR ready for code review Code review 🔍 Self-review 󰡲 Choosing CR buddy 🦄 Reading code first time 🤿 Deep dive
21. 🛠 Change request 👍 LGTM
22. 🗣 Sharing feedback
23. • if not sure about anything ask rather than state • review changes, not a person • be as specific as possible Talk from the place of respect
24. • if not sure about anything ask rather than state • review changes, not a person • be as specific as possible Talk from the place of respect
25. provides information why changes are needed generous with examples
26. Make sure that CR comments include everything needed
28. Clearly indicate expected outcome Read more about this https://twitter.com/swyx/status/1235678969162338304 🔴 [Change request] 🟨 [Suggestion] 💚 [Appreciation]
29. Praise & positivity☺
30. PR ready for code review Code review 🔍 Self-review 󰡲 Choosing CR buddy 🦄 Reading code first time 🤿 Deep dive
31. PR ready for code review Code review 🔍 Self-review 󰡲 Choosing CR buddy 🦄 Reading code first time 🤿 Deep dive 🔮 THE END
32. Praise & positivity☺
33. PR ready for code review Code review 🔍 Self-review 󰡲 Choosing CR buddy 🦄 Reading code first time 🤿 Deep dive 🔮 Bigger picture
34. 🙂
35. 🤩
36. PR ready for code review Code review 🔍 Self-review 󰡲 Choosing CR buddy 🦄 Reading code first time 🤿 Deep dive 🔮 Bigger picture
37. PR ready for code review Code review 🔍 Self-review 󰡲 Choosing CR buddy 🦄 Reading code first time 🤿 Deep dive 🔮 Bigger picture 💎 ? 💎 ? 💎 ? 💎 ? 💎 ?
38. Thank you! @frontendgirl from @webflow