Code Review: Pitfalls and Good Practices

RubyConf AU 2016

Some of us have practiced code review as part of our software development process. But it is more than just a peer review of code written by another. I will attempt to summarise some of the good practices that worked for us to review code effectively and some of the common mistakes not to make when setting out a code review programme for your team.

Transcript

1. CODE REVIEW
2. THONG KUAH CODE REVIEW I have a white cat. His twitter is @awesomemuffin My twitter handle is @kuahyeow Email ? thong.kuah@powershop.co.nz
3. POWERSHOP
4. HOW WE FIXED OUR CODE REVIEW PROCESS
6. SPRINT 119 APRIL 2015
7. VERY LARGE CHANGES
8. COMPLEX SOLUTIONS
9. LARGE DIFFS
10. OMG !
11. RETROSPECTIVE
12. WORKS WELL... • CODE REVIEWS ARE NOT OPTIONAL • WE HAVE A DEFINITION OF DONE • WE TEST OUR CODE
13. REVIEW OFTEN • EVERYONE PLANS OUT THE WORK • WE SEEK FEEDBACK OFTEN • FINAL REVIEW
14. MAKE CHANGES SMALL
15. EVERYONE REVIEWS
16. OMG, BAD CODE TO PROD ?
17. MORE REVIEWS • FINAL REVIEW • 2ND BREAKFAST • QA TESTING • RELEASE REVIEW
18. GROW THE TEAM • LOTS OF ENCOURAGEMENT • OPEN TO FEEDBACK • OTHER CODE REVIEWS
19. SIX MONTHS LATER...