Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code Review: Pitfalls and Good Practices

Thong Kuah
February 11, 2016

Code Review: Pitfalls and Good Practices

RubyConf AU 2016

Some of us have practiced code review as part of our software development process. But it is more than just a peer review of code written by another. I will attempt to summarise some of the good practices that worked for us to review code effectively and some of the common mistakes not to make when setting out a code review programme for your team.

Thong Kuah

February 11, 2016
Tweet

More Decks by Thong Kuah

Other Decks in Technology

Transcript

  1. THONG KUAH CODE REVIEW I have a white cat. His

    twitter is @awesomemuffin My twitter handle is @kuahyeow Email ? [email protected]
  2. WORKS WELL... • CODE REVIEWS ARE NOT OPTIONAL • WE

    HAVE A DEFINITION OF DONE • WE TEST OUR CODE
  3. REVIEW OFTEN • EVERYONE PLANS OUT THE WORK • WE

    SEEK FEEDBACK OFTEN • FINAL REVIEW
  4. GROW THE TEAM • LOTS OF ENCOURAGEMENT • OPEN TO

    FEEDBACK • OTHER CODE REVIEWS