Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code Review
Search
pluulove (노현석)
May 03, 2019
Education
2
520
Code Review
회사 사내 팀에서 라이트닝토크로 발표한
Code Review에 대한 발표자료입니다.
pluulove (노현석)
May 03, 2019
Tweet
Share
More Decks by pluulove (노현석)
See All by pluulove (노현석)
Google I/O Extended Incheon 2025 ~ What's new in Android development tools
pluu
1
340
N.E.X.T LEVEL
pluu
3
530
안드로이드 기술 이력서의 최소 조건
pluu
1
3k
I/O Extended Android in Korea 2024 ~ Whats new in Android development tools
pluu
0
690
Android Studio와 좀 더 친해지기
pluu
0
190
우리모두 삽질한다
pluu
0
1.4k
Re:Android Studio 설정 살펴보기 및 생산성 올리기
pluu
0
1.7k
What's new in Android development tools
pluu
1
910
What's new in Android development tools
pluu
1
460
Other Decks in Education
See All in Education
シリコンバレーでスタートアップを共同創業したファウンディングエンジニアとしての学び
tomoima525
1
1.2k
中間活動報告会 人材育成WG・技術サブWG / 20250808-oidfj-eduWG-techSWG
oidfj
0
710
2026 g0v 零時政府年會啟動提案 / g0v Summit 2026 Kickstart
rschiang
0
320
令和政経義塾第2期説明会
nxji
0
230
万博非公式マップとFOSS4G
barsaka2
0
1.3k
American Airlines® USA Contact Numbers: The Ultimate 2025 Guide
lievliev
0
260
Презентация "Знаю Россию"
spilsart
0
250
[Segah 2025] Gamified Interventions for Composting Behavior in the Workplace
ezefranca
0
150
フィードバックの伝え方、受け身のココロ / The Way of Feedback: Words and the Receiving Heart
spring_aki
1
160
EVOLUCIÓN DE LAS NEUROCIENCIAS EN LOS CONTEXTOS ORGANIZACIONALES
jvpcubias
0
180
ハッカソンを活用したモノづくり教育について
yusk1450
PRO
2
110
生成AI活用セミナー/GAI-workshop
gnutar
0
120
Featured
See All Featured
Helping Users Find Their Own Way: Creating Modern Search Experiences
danielanewman
30
2.9k
Side Projects
sachag
455
43k
The Art of Delivering Value - GDevCon NA Keynote
reverentgeek
15
1.7k
Creating an realtime collaboration tool: Agile Flush - .NET Oxford
marcduiker
32
2.2k
The Power of CSS Pseudo Elements
geoffreycrofte
79
6k
Six Lessons from altMBA
skipperchong
28
4k
Producing Creativity
orderedlist
PRO
347
40k
Sharpening the Axe: The Primacy of Toolmaking
bcantrill
45
2.5k
Context Engineering - Making Every Token Count
addyosmani
5
180
Templates, Plugins, & Blocks: Oh My! Creating the theme that thinks of everything
marktimemedia
31
2.5k
The Language of Interfaces
destraynor
162
25k
Making Projects Easy
brettharned
119
6.4k
Transcript
Code Review by Pluu
None
৵ ܻ࠭о ਃೠо? 1 2 ੌନ Ѿೣਸ ߊѼೞҊ Ҋӝ ਤ೧
٘ ߬झ ೧ܳ ҕਬܳ ా೧ ࢲ۽ ߓ ࣻ ٣ੋҗ ҳഅীࢲ ੌҙࢿਸ ਬೞӝ ਤ೧ 3
৵ ܻ࠭о ਃೠо? 4 5 ী ൔೠ (common) Ѿೣਸ
6 ܲ ҙਸ ыח. زܐ ܻ࠭ח ޙઁܳ ߊѼೞӝ ਤ೧ ਃೠ Ѣܻܳ ઁҕ ೧ Ӑ١ ݯߡٜ Үী بਸ ળ
৵ ܻ࠭о ਃೠо? 7 8 ࠗब/ࠁ࢚. ٬ ӝ ੋ ਃೠ
ࠁ࢚ ۱. ݯߡٜрী ؊ оөਕ ࣻ ѱ ب
None
Code Review Checklist General • ٘о زפө? ب ೠ ӝמਸ
ࣻ೯פө, ֤ܻо ৢ߄ܲ ١. • ݽٚ ٘ܳ औѱ ೧ೡ ࣻ णפө? • https://pl.kotl.in/MR0H0GQ_7 • ೠ ٬ ӏਸ ળࣻפө? Ѫٜ ѐ Қഐ, ߸ࣻ ߂ ೣ ࣻ ܴ, ӡ, ٜৈ ॳӝ, ࢲध ߂ ࢳ ਤܳ ನೣפ. • ࠂغѢա ࠂ ػ ٘о णפө?
Code Review Checklist General • оמೠ ٘ܳ ݽٕച ೠ Ѫੑפө?
• https://pl.kotl.in/A9ZVqkTBC • ݽٚ ߸ࣻܳ ߄Ե ࣻ णפө? • ࢳ ܻ ػ ٘о णפө? • Do ܖח ࢸػ ӡ৬ ৢ߄ܲ ઙܐ ઑѤਸ оҊ णפө? • ۽Ӓ۔ীࢲ ࢎਊ ػ ܴ بܳ ׳פө?
Code Review Checklist Performance • ࢿמਸ ೱ࢚दఆ ഛपೠ ୭ചо णפө?
• ٘ܳ ۄ࠳۞ܻ ա ղ ೣࣻ۽ ೡ ࣻ णפө? • https://pl.kotl.in/qLizl3RrH • ۽Ӧ ژח ٣ߡӦ ٘ܳ ઁѢ ೡ ࣻ णפө?
Code Review Checklist Security • ݽٚ ؘఠ ੑ۱ਸ Ѩ (ৢ߄ܲ
ਬഋ, ӡ, ഋध ߂ ߧਤ)ೞҊ ੋ ٬ ೮णפө? • ఋࢎ ਬܻ౭ܳ ࢎਊೞח ҃ ߈ജغח য়ܨо ߊѼؾפө? • ۱ чਸ ѨࢎೞҊ ੋ٬פө? • ੜޅػ ݒѐ ߸ࣻ ч ܻؾפө?
Code Review Checklist Documentation • ࢳ ઓೞҊ ٘ بܳ ࢸݺפө?
• ݽٚ ೣࣻо ࢳ ܻ غणפө? • ࠺࢚ੋ زա оܻ ாझ ܻо ࢸݺغয णפө? • ఋࢎ ۄ࠳۞ܻ ࢎਊҗ ӝמ ޙࢲചغয णפө? • ؘఠ ҳઑ৬ ஏ ױਤо ࢸݺ غणפө? • ࠛ৮ೠ ٘о णפө? Ӓۧݶ 'TODO'৬ э ೠ ݃ழ ܳ ࢎਊೞৈ ઁѢೞѢա ېӒܳ ೧ঠפө?
Code Review Checklist Testing • ٘ܳ పझ ೡ ࣻ णפө?
٘о ցޖ ݆Ѣա ઙࣘޛਸ ऀӝ ঋҊ, ёܳ ୡӝച ೡ ࣻ হਵݴ, పझ ۨ ਕо ݫࣗ٘ ١ਸ ࢎਊೡ ࣻ ب۾ ҳઑചغযঠפ. • పझо ઓೞݴ ನҚੑפө? • पઁ۽ ٘о ਗೞח ӝמਸ ࣻ೯ೞח పझפө? • పझ ٘ܳ ӝઓ APIܳ ࢎਊೞৈ ೡ ࣻ णפө?
ܻ࠭যܳ ਤೠ 1 2 ࢎۈ नী ٘ܳ ࠺ಣೞۄ. ѐߊীѱ
, ٘ী ೧ࢶ ࠛೞۄ. 3 ਤ۽ࠗఠо ইצ धਵ۽ࠗఠ ೠ ӂਤ नࠁ ؊ ݽܰח ࢎۈਸ ઓ҃, ઓ, ੋղबਵ۽ ࢎۈਸ ೞۄ
ܻ࠭যܳ ਤೠ 4 5 ܻ࠭ ഥח ޙઁܳ ೧Ѿೞӝ ਤೠ
ഥо ইשਸ 6 “Why”ۄח ޙਸ ೖೞۄ ޙࠁח ޙਸ ೞۄ
ܻ࠭যܳ ਤೠ 7 8 டଲೞח Ѫਸ ݃ۄ 9 ೧Ѿ଼ী
Ӕೞӝ ਤೠ ೠо ࢚ ӡ ח Ѫਸ ӝরೞۄ. न न ଵઑೞח જ ળ ٬ਸ оҊ ח Ѫਸ ݺबೞۄ
ܻ࠭যܳ ਤೠ 10 11 ٘ ܻ࠭ܳ ࢲفܰ ঋইب ػ.
ೞ݅ ߄۽ ೧ঠೡ ਃо . ೠߣী 200~400 ۄੋࠁ ٘ܳ ܻ࠭ೞۄ
Reference • Effective Code Reviews ~ Code Review Checklist •
Embedded System Code Review Checklist • Code review guidelines – Part 1 • https://flyburi.com/576