Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code Review

Sponsored · Your Podcast. Everywhere. Effortlessly. Share. Educate. Inspire. Entertain. You do you. We'll handle the rest. →
Avatar for pluulove (노현석) pluulove (노현석)
May 03, 2019
Education
520
2

Code Review

회사 사내 팀에서 라이트닝토크로 발표한
Code Review에 대한 발표자료입니다.

Avatar for pluulove (노현석)

pluulove (노현석)

May 03, 2019

More Decks by pluulove (노현석)

See All by pluulove (노현석)
Google I/O Extended Incheon 2025 ~ What's new in Android development tools
Avatar for pluulove (노현석) pluu
1
470
N.E.X.T LEVEL
Avatar for pluulove (노현석) pluu
3
590
안드로이드 기술 이력서의 최소 조건
Avatar for pluulove (노현석) pluu
1
3.8k
I/O Extended Android in Korea 2024 ~ Whats new in Android development tools
Avatar for pluulove (노현석) pluu
0
730
Android Studio와 좀 더 친해지기
Avatar for pluulove (노현석) pluu
0
230
우리모두 삽질한다
Avatar for pluulove (노현석) pluu
0
1.5k
Re:Android Studio 설정 살펴보기 및 생산성 올리기
Avatar for pluulove (노현석) pluu
0
1.7k
What's new in Android development tools
Avatar for pluulove (노현석) pluu
1
940
What's new in 
Android development tools
Avatar for pluulove (노현석) pluu
1
490

Other Decks in Education

See All in Education
高校数学とJulia言語
Avatar for Shimizu Dan shimizudan
0
140
Referendum Costituzionale Giustizia
Avatar for Nostra Dalmine nostradalmine
0
110
Pen-based Interaction - Lecture 4 - Next Generation User Interfaces (4018166FNR)
Avatar for Beat Signer signer
PRO
0
2.2k
Tangible, Embedded and Embodied Interaction - Lecture 7 - Next Generation User Interfaces (4018166FNR)
Avatar for Beat Signer signer
PRO
0
2.1k
次期バージョン 14.5.1 Early Access Program が始まりました
Avatar for Haruyuki Nakano harunakano
1
130
P3NFEST 2026 Spring ハンズオン「ハッキング・ラブ！はじめてのハッキングをやってみよう」資料
Avatar for Nomizo Nomizo nomizone
0
380
反応する前に「受容する」力を鍛える。 自分の安全地帯🌱 を育てよう / Cultivating and sharing ventral vagal safety.
Avatar for Aki spring_aki
0
120
Introduction - Lecture 1 - Advanced Topics in Big Data (4023256FNR)
Avatar for Beat Signer signer
PRO
2
2.3k
演習：GitHubの基本操作 / 06-github-basic
Avatar for kaityo256 kaityo256
PRO
0
240
計算物理におけるGitの使い方 / 01-c-compphys
Avatar for kaityo256 kaityo256
PRO
2
530
小学校5,6年生向けキャリア教育 大人になるまでの道
Avatar for Satoru Takeuchi sat
PRO
8
3.4k
Analysis and Validation - Lecture 4 - Information Visualisation (4019538FNR)
Avatar for Beat Signer signer
PRO
0
2.6k

Featured

See All Featured
Digital Ethics as a Driver of Design Innovation
Avatar for Per Axbom axbom
PRO
1
250
Information Architects: The Missing Link in Design Systems
Avatar for Michelle Chin soysaucechin
0
860
Understanding Cognitive Biases in Performance Measurement
Avatar for Philip Tellis bluesmoon
32
2.8k
Groundhog Day: Seeking Process in Gaming for Health
Avatar for Sebastian Deterding codingconduct
0
140
SEO Brein meetup: CTRL+C is not how to scale international SEO
Avatar for Linda Hogenes lindahogenes
1
2.5k
Designing Dashboards & Data Visualisations in Web Apps
Avatar for Des Traynor destraynor
231
54k
The Spectacular Lies of Maps
Avatar for Per Axbom axbom
PRO
1
670
Hiding What from Whom? A Critical Review of the History of Programming languages for Music
Avatar for Tomoya Matsuura tomoyanonymous
2
640
ラッコキーワード サービス紹介資料
Avatar for ラッコ株式会社 rakko
1
2.9M
Visualization
Avatar for Eitan Lees eitanlees
150
17k
エンジニアに許された特別な時間の終わり
Avatar for watany watany
106
240k
Noah Learner - AI + Me: how we built a GSC Bulk Export data pipeline
Avatar for Tech SEO Connect techseoconnect
PRO
0
150

Transcript

  1. Code Review by Pluu

  2. None

  3. ৵ ܻ࠭о ઺ਃೠо? 1 2 ੌନ Ѿೣਸ ߊѼೞҊ Ҋ஖ӝ ਤ೧

    ௏٘ ߬੉झ੄ ੉೧ܳ ҕਬܳ ా೧ ࢲ۽ ߓ਎ ࣻ ੓׮ ٣੗ੋҗ ҳഅীࢲ ੌҙࢿਸ ਬ૑ೞӝ ਤ೧ 3

  4. ৵ ܻ࠭о ઺ਃೠо? 4 5 ౱ ੹୓ী ൔೠ (common) Ѿೣਸ

    ୓௼ 6 ׮ܲ ҙ੼ਸ ыח׮. زܐ੄ ܻ࠭ח ޙઁܳ ߊѼೞӝ ਤ೧ ೙ਃೠ Ѣܻܳ ઁҕ ੉೧੄ Ӑ١਷ ౱ ݯߡٜ੄ Ү؀ী ب਑ਸ ળ׮

  5. ৵ ܻ࠭о ઺ਃೠо? 7 8 ੗ࠗब/ࠁ࢚. ௏٬ ӝ۝੄ ੋ੿਷ ઺ਃೠ

    ࠁ࢚ ౱੄ ਽૘۱. ౱ ݯߡٜрী ؊ оөਕ૕ ࣻ ੓ѱ ب਑
  6. None

  7. Code Review Checklist General • ௏٘о ੘ز೤פө? ੄ب ೠ ӝמਸ

    ࣻ೯೤פө, ֤ܻо ৢ߄ܲ૑ ١. • ݽٚ ௏٘ܳ औѱ ੉೧ೡ ࣻ ੓णפө? • https://pl.kotl.in/MR0H0GQ_7 • ೤੄ೠ ௏٬ ӏ஗ਸ ળࣻ೤פө? ੉Ѫٜ਷ ؀ѐ ઺Қഐ, ߸ࣻ ߂ ೣ ࣻ ੉ܴ, ઴ ӡ੉, ٜৈ ॳӝ, ࢲध ߂ ઱ࢳ੄ ਤ஖ܳ ನೣ೤פ׮. • ઺ࠂغѢա ઺ࠂ ػ ௏٘о ੓णפө?

  8. Code Review Checklist General • оמೠ ௏٘ܳ ݽٕച ೠ Ѫੑפө?

    • https://pl.kotl.in/A9ZVqkTBC • ݽٚ ੹৉ ߸ࣻܳ ߄Ե ࣻ ੓णפө? • ઱ࢳ ୊ܻ ػ ௏٘о ੓णפө? • Do ܖ೐ח ࢸ੿ػ ӡ੉৬ ৢ߄ܲ ઙܐ ઑѤਸ о૑Ҋ ੓णפө? • ೐۽Ӓ۔ীࢲ ࢎਊ ػ ੉ܴ੉ ੄بܳ ੹׳೤פө?

  9. Code Review Checklist Performance • ࢿמਸ ೱ࢚दఆ ഛपೠ ୭੸ചо ੓णפө?

    • ௏٘ܳ ۄ੉࠳۞ܻ ա ղ੢ ೣࣻ۽ ؀୓ ೡ ࣻ ੓णפө? • https://pl.kotl.in/qLizl3RrH • ۽Ӧ ژח ٣ߡӦ ௏٘ܳ ઁѢ ೡ ࣻ ੓णפө?

  10. Code Review Checklist Security • ݽٚ ؘ੉ఠ ੑ۱ਸ ੼Ѩ (ৢ߄ܲ

    ਬഋ, ӡ੉, ഋध ߂ ߧਤ)ೞҊ ੋ ௏٬ ೮णפө? • ఋࢎ ਬ౰ܻ౭ܳ ࢎਊೞח ҃਋ ߈ജغח য়ܨо ߊѼؾפө? • ୹۱ чਸ ѨࢎೞҊ ੋ௏٬೤פө? • ੜޅػ ݒѐ ߸ࣻ ч੉ ୊ܻؾפө?

  11. Code Review Checklist Documentation • ઱ࢳ੉ ઓ੤ೞҊ ௏٘੄ ੄بܳ ࢸݺ೤פө?

    • ݽٚ ೣࣻо ઱ࢳ ୊ܻ غ঻णפө? • ࠺੿࢚੸ੋ ز੘੉ա о੢੗ܻ ா੉झ ୊ܻо ࢸݺغয ੓णפө? • ఋࢎ ۄ੉࠳۞ܻ੄ ࢎਊҗ ӝמ੉ ޙࢲചغয ੓णפө? • ؘ੉ఠ ҳઑ৬ ஏ੿ ױਤо ࢸݺ غ঻णפө? • ࠛ৮੹ೠ ௏٘о ੓णפө? Ӓۧ׮ݶ 'TODO'৬ э਷ ੸੺ೠ ݃ழ ܳ ࢎਊೞৈ ઁѢೞѢա ೒ېӒܳ ૑੿೧ঠ೤פө?

  12. Code Review Checklist Testing • ௏٘ܳ పझ౟ ೡ ࣻ ੓णפө?

    ௏٘о ցޖ ݆Ѣա ઙࣘޛਸ ऀӝ ૑ ঋҊ, ё୓ܳ ୡӝച ೡ ࣻ হਵݴ, పझ౟ ೐ۨ੐ ਕ௼о ݫࣗ٘ ١ਸ ࢎਊೡ ࣻ ੓ب۾ ҳઑചغযঠ೤פ׮. • పझ౟о ઓ੤ೞݴ ನҚ੸ੑפө? • पઁ۽ ௏٘о ਗೞח ӝמਸ ࣻ೯ೞח૑ పझ౟೤פө? • పझ౟ ௏٘ܳ ӝઓ APIܳ ࢎਊೞৈ ؀୓ ೡ ࣻ ੓णפө?

  13. ܻ࠭যܳ ਤೠ ౲ 1 2 ࢎۈ ؀नী ௏٘ܳ ࠺ಣೞۄ. ѐߊ੗ীѱ

    ஘੺, ௏٘ী ؀೧ࢶ ࠛ஘੺ೞۄ. 3 ૒ਤ۽ࠗఠо ইצ ૑धਵ۽ࠗఠ੄ ૓੿ೠ ӂਤ ׼नࠁ׮ ؊ ݽܰח ࢎۈਸ ઓ҃, ઓ઺, ੋղबਵ۽ ࢎۈਸ ؀ೞۄ

  14. ܻ࠭যܳ ਤೠ ౲ 4 5 ܻ࠭ ഥ੄ח ޙઁܳ ೧Ѿೞӝ ਤೠ

    ഥ੄о ইשਸ ઱੄ 6 “Why”ۄח ૕ޙਸ ೖೞۄ ޙ੢ࠁ׮ח ૕ޙਸ ೞۄ

  15. ܻ࠭যܳ ਤೠ ౲ 7 8 டଲೞח Ѫਸ ੕૑݃ۄ 9 ೧Ѿ଼ী

    ੽Ӕೞӝ ਤೠ ೠо૑ ੉࢚੄ ӡ੉ ੓׮ח Ѫਸ ӝরೞۄ. ׼न਷ ׼न੉ ଵઑೞח જ਷ ಴ળ ௏٬ਸ о૑Ҋ ੓׮ח Ѫਸ ݺबೞۄ

  16. ܻ࠭যܳ ਤೠ ౲ 10 11 ௏٘ ܻ࠭ܳ ࢲفܰ૑ ঋইب ػ׮.

    ೞ૑݅ ߄۽ ೧ঠೡ ೙ਃо ੓׮. ೠߣী 200~400 ۄੋࠁ׮ ੸਷ ௏٘ܳ ܻ࠭ೞۄ

  17. Reference • Effective Code Reviews ~ Code Review Checklist •

    Embedded System Code Review Checklist • Code review guidelines – Part 1 • https://flyburi.com/576