Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code Review

Sponsored · Your Podcast. Everywhere. Effortlessly. Share. Educate. Inspire. Entertain. You do you. We'll handle the rest. →
Avatar for pluulove (노현석) pluulove (노현석)
May 03, 2019
Education
530
2

Code Review

회사 사내 팀에서 라이트닝토크로 발표한
Code Review에 대한 발표자료입니다.

Avatar for pluulove (노현석)

pluulove (노현석)

May 03, 2019

More Decks by pluulove (노현석)

See All by pluulove (노현석)
Google I/O Extended Incheon 2025 ~ What's new in Android development tools
Avatar for pluulove (노현석) pluu
1
530
N.E.X.T LEVEL
Avatar for pluulove (노현석) pluu
3
610
안드로이드 기술 이력서의 최소 조건
Avatar for pluulove (노현석) pluu
1
4.2k
I/O Extended Android in Korea 2024 ~ Whats new in Android development tools
Avatar for pluulove (노현석) pluu
0
780
Android Studio와 좀 더 친해지기
Avatar for pluulove (노현석) pluu
0
250
우리모두 삽질한다
Avatar for pluulove (노현석) pluu
0
1.5k
Re:Android Studio 설정 살펴보기 및 생산성 올리기
Avatar for pluulove (노현석) pluu
0
1.8k
What's new in Android development tools
Avatar for pluulove (노현석) pluu
1
970
What's new in 
Android development tools
Avatar for pluulove (노현석) pluu
1
510

Other Decks in Education

See All in Education
2026年度春学期　統計学　第5回　分布をまとめるー記述統計量（平均・分散など） (2026. 5. 7)
Avatar for Akira Asano akiraasano
PRO
0
170
DECADE_ゴルフ_コースマネジメント完全ガイド.pdf
Avatar for Takashi Ozeki ozekinote
0
110
Visionary Initiative: Future Intelligence 「未来の知性と社会の礎を築く」｜Science Tokyo（東京科学大学）
Avatar for Science Tokyo （東京科学大学） / Science Tokyo (Institute of Science Tokyo) sciencetokyo
PRO
0
730
プロポーザルを書く技術とアンチパターン/proposal-writing-and-antipatterns
Avatar for moriyuya moriyuya
13
3.5k
Modern Data Fetching Techniques in Angular
Avatar for Dhananjay Kumar debug_mode
0
230
[2026前期火５] 論理学（京都大学文学部 前期 第5回）「 ならばの問題演習・proof net・かつの規則」
Avatar for Shunsuke Yatabe yatabe
0
350
[2026前期火５] 論理学（京都大学文学部 前期 第3回）「形式言語と四つのキーワード：メタ・構成・意味論・ハーモニー」
Avatar for Shunsuke Yatabe yatabe
0
590
現場最前線から教えるデータサイエンス１ -ITベンダーにおけるデータサイエンティスト-
Avatar for Hidetoshi Kawaguchi hidetoshikawaguchi
0
130
Examen de Selectividad. Geografía junio 2026 (Convocatoria Ordinaria). UCLM
Avatar for Juan Martín Martín juanmartin2026
1
1.4k
2026年度春学期　統計学　第7回　データの関係を知る（２）ー 回帰と決定係数 (2026. 5. 21)
Avatar for Akira Asano akiraasano
PRO
0
180
「答えを出す」より「わかる」をつくる
Avatar for Kazuki Maeda kzkmaeda
1
210
[2026前期火５] 論理学（京都大学文学部 前期 第6回）「かつとまたはの規則」
Avatar for Shunsuke Yatabe yatabe
0
410

Featured

See All Featured
Building a Scalable Design System with Sketch
Avatar for Laura Van Doore lauravandoore
463
34k
Typedesign – Prime Four
Avatar for Hannes Fritz hannesfritz
42
3.1k
How To Stay Up To Date on Web Technology
Avatar for Chris Coyier chriscoyier
790
250k
技術選定の審美眼（2025年版） / Understanding the Spiral of Technologies 2025 edition
Avatar for Takuto Wada twada
PRO
118
120k
Being A Developer After 40
Avatar for Adrian Kosmaczewski akosma
91
590k
Navigating Team Friction
Avatar for Lara Hogan lara
192
16k
New Earth Scene 8
Avatar for Sydney Stone popppiees
3
2.4k
How Fast Is Fast Enough? [PerfNow 2025]
Avatar for Tammy Everts tammyeverts
3
640
RailsConf & Balkan Ruby 2019: The Past, Present, and Future of Rails at GitHub
Avatar for Eileen M. Uchitelle eileencodes
141
35k
Max Prin - Stacking Signals: How International SEO Comes Together (And Falls Apart)
Avatar for Tech SEO Connect techseoconnect
PRO
0
200
How to train your dragon (web standard)
Avatar for Monica Dinculescu notwaldorf
97
6.7k
Optimising Largest Contentful Paint
Avatar for Harry Roberts csswizardry
37
3.8k

Transcript

  1. Code Review by Pluu

  2. None

  3. ৵ ܻ࠭о ઺ਃೠо? 1 2 ੌନ Ѿೣਸ ߊѼೞҊ Ҋ஖ӝ ਤ೧

    ௏٘ ߬੉झ੄ ੉೧ܳ ҕਬܳ ా೧ ࢲ۽ ߓ਎ ࣻ ੓׮ ٣੗ੋҗ ҳഅীࢲ ੌҙࢿਸ ਬ૑ೞӝ ਤ೧ 3

  4. ৵ ܻ࠭о ઺ਃೠо? 4 5 ౱ ੹୓ী ൔೠ (common) Ѿೣਸ

    ୓௼ 6 ׮ܲ ҙ੼ਸ ыח׮. زܐ੄ ܻ࠭ח ޙઁܳ ߊѼೞӝ ਤ೧ ೙ਃೠ Ѣܻܳ ઁҕ ੉೧੄ Ӑ١਷ ౱ ݯߡٜ੄ Ү؀ী ب਑ਸ ળ׮

  5. ৵ ܻ࠭о ઺ਃೠо? 7 8 ੗ࠗब/ࠁ࢚. ௏٬ ӝ۝੄ ੋ੿਷ ઺ਃೠ

    ࠁ࢚ ౱੄ ਽૘۱. ౱ ݯߡٜрী ؊ оөਕ૕ ࣻ ੓ѱ ب਑
  6. None

  7. Code Review Checklist General • ௏٘о ੘ز೤פө? ੄ب ೠ ӝמਸ

    ࣻ೯೤פө, ֤ܻо ৢ߄ܲ૑ ١. • ݽٚ ௏٘ܳ औѱ ੉೧ೡ ࣻ ੓णפө? • https://pl.kotl.in/MR0H0GQ_7 • ೤੄ೠ ௏٬ ӏ஗ਸ ળࣻ೤פө? ੉Ѫٜ਷ ؀ѐ ઺Қഐ, ߸ࣻ ߂ ೣ ࣻ ੉ܴ, ઴ ӡ੉, ٜৈ ॳӝ, ࢲध ߂ ઱ࢳ੄ ਤ஖ܳ ನೣ೤פ׮. • ઺ࠂغѢա ઺ࠂ ػ ௏٘о ੓णפө?

  8. Code Review Checklist General • оמೠ ௏٘ܳ ݽٕച ೠ Ѫੑפө?

    • https://pl.kotl.in/A9ZVqkTBC • ݽٚ ੹৉ ߸ࣻܳ ߄Ե ࣻ ੓णפө? • ઱ࢳ ୊ܻ ػ ௏٘о ੓णפө? • Do ܖ೐ח ࢸ੿ػ ӡ੉৬ ৢ߄ܲ ઙܐ ઑѤਸ о૑Ҋ ੓णפө? • ೐۽Ӓ۔ীࢲ ࢎਊ ػ ੉ܴ੉ ੄بܳ ੹׳೤פө?

  9. Code Review Checklist Performance • ࢿמਸ ೱ࢚दఆ ഛपೠ ୭੸ചо ੓णפө?

    • ௏٘ܳ ۄ੉࠳۞ܻ ա ղ੢ ೣࣻ۽ ؀୓ ೡ ࣻ ੓णפө? • https://pl.kotl.in/qLizl3RrH • ۽Ӧ ژח ٣ߡӦ ௏٘ܳ ઁѢ ೡ ࣻ ੓णפө?

  10. Code Review Checklist Security • ݽٚ ؘ੉ఠ ੑ۱ਸ ੼Ѩ (ৢ߄ܲ

    ਬഋ, ӡ੉, ഋध ߂ ߧਤ)ೞҊ ੋ ௏٬ ೮णפө? • ఋࢎ ਬ౰ܻ౭ܳ ࢎਊೞח ҃਋ ߈ജغח য়ܨо ߊѼؾפө? • ୹۱ чਸ ѨࢎೞҊ ੋ௏٬೤פө? • ੜޅػ ݒѐ ߸ࣻ ч੉ ୊ܻؾפө?

  11. Code Review Checklist Documentation • ઱ࢳ੉ ઓ੤ೞҊ ௏٘੄ ੄بܳ ࢸݺ೤פө?

    • ݽٚ ೣࣻо ઱ࢳ ୊ܻ غ঻णפө? • ࠺੿࢚੸ੋ ز੘੉ա о੢੗ܻ ா੉झ ୊ܻо ࢸݺغয ੓णפө? • ఋࢎ ۄ੉࠳۞ܻ੄ ࢎਊҗ ӝמ੉ ޙࢲചغয ੓णפө? • ؘ੉ఠ ҳઑ৬ ஏ੿ ױਤо ࢸݺ غ঻णפө? • ࠛ৮੹ೠ ௏٘о ੓णפө? Ӓۧ׮ݶ 'TODO'৬ э਷ ੸੺ೠ ݃ழ ܳ ࢎਊೞৈ ઁѢೞѢա ೒ېӒܳ ૑੿೧ঠ೤פө?

  12. Code Review Checklist Testing • ௏٘ܳ పझ౟ ೡ ࣻ ੓णפө?

    ௏٘о ցޖ ݆Ѣա ઙࣘޛਸ ऀӝ ૑ ঋҊ, ё୓ܳ ୡӝച ೡ ࣻ হਵݴ, పझ౟ ೐ۨ੐ ਕ௼о ݫࣗ٘ ١ਸ ࢎਊೡ ࣻ ੓ب۾ ҳઑചغযঠ೤פ׮. • పझ౟о ઓ੤ೞݴ ನҚ੸ੑפө? • पઁ۽ ௏٘о ਗೞח ӝמਸ ࣻ೯ೞח૑ పझ౟೤פө? • పझ౟ ௏٘ܳ ӝઓ APIܳ ࢎਊೞৈ ؀୓ ೡ ࣻ ੓णפө?

  13. ܻ࠭যܳ ਤೠ ౲ 1 2 ࢎۈ ؀नী ௏٘ܳ ࠺ಣೞۄ. ѐߊ੗ীѱ

    ஘੺, ௏٘ী ؀೧ࢶ ࠛ஘੺ೞۄ. 3 ૒ਤ۽ࠗఠо ইצ ૑धਵ۽ࠗఠ੄ ૓੿ೠ ӂਤ ׼नࠁ׮ ؊ ݽܰח ࢎۈਸ ઓ҃, ઓ઺, ੋղबਵ۽ ࢎۈਸ ؀ೞۄ

  14. ܻ࠭যܳ ਤೠ ౲ 4 5 ܻ࠭ ഥ੄ח ޙઁܳ ೧Ѿೞӝ ਤೠ

    ഥ੄о ইשਸ ઱੄ 6 “Why”ۄח ૕ޙਸ ೖೞۄ ޙ੢ࠁ׮ח ૕ޙਸ ೞۄ

  15. ܻ࠭যܳ ਤೠ ౲ 7 8 டଲೞח Ѫਸ ੕૑݃ۄ 9 ೧Ѿ଼ী

    ੽Ӕೞӝ ਤೠ ೠо૑ ੉࢚੄ ӡ੉ ੓׮ח Ѫਸ ӝরೞۄ. ׼न਷ ׼न੉ ଵઑೞח જ਷ ಴ળ ௏٬ਸ о૑Ҋ ੓׮ח Ѫਸ ݺबೞۄ

  16. ܻ࠭যܳ ਤೠ ౲ 10 11 ௏٘ ܻ࠭ܳ ࢲفܰ૑ ঋইب ػ׮.

    ೞ૑݅ ߄۽ ೧ঠೡ ೙ਃо ੓׮. ೠߣী 200~400 ۄੋࠁ׮ ੸਷ ௏٘ܳ ܻ࠭ೞۄ

  17. Reference • Effective Code Reviews ~ Code Review Checklist •

    Embedded System Code Review Checklist • Code review guidelines – Part 1 • https://flyburi.com/576