Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code Review
Search
pluulove (노현석)
May 03, 2019
Education
2
490
Code Review
회사 사내 팀에서 라이트닝토크로 발표한
Code Review에 대한 발표자료입니다.
pluulove (노현석)
May 03, 2019
Tweet
Share
More Decks by pluulove (노현석)
See All by pluulove (노현석)
우리모두 삽질한다
pluu
0
990
Re:Android Studio 설정 살펴보기 및 생산성 올리기
pluu
0
1.3k
What's new in Android development tools
pluu
0
750
What's new in Android development tools
pluu
0
350
개발자 Side Next Step ~ 커뮤니티 x Android
pluu
2
200
Modern Android Developer ~ 안내서
pluu
1
2.6k
I/O Extended 2022 in Android ~ Whats new in Android development tools
pluu
0
2.6k
코드 품질 1% 올리기
pluu
2
3.1k
시작하는 안드로이드 개발자를 위해 ~ THINK
pluu
1
250
Other Decks in Education
See All in Education
第1回全国商業高校Webアプリコンテスト総括
asial_corp
0
400
自己紹介 / who-am-i
yasulab
2
3.1k
「小・中・高等学校における情報教育の体系的な学習を目指したカリキュラムモデル基本方針」
codeforeveryone
0
1.3k
Data Management and Analytics Specialisation
signer
PRO
0
980
【潔能講堂】永續環境、擁抱綠能 太陽能光電發展現況與產業製程解析
learnenergy2
0
110
全員参加型で会社を強くしていく活動を考えてみる
ikefukurou777
0
190
ISMSってどんなもの?
fbei_ot
0
160
20240319AJG
tosseto
0
290
【滋賀大学データサイエンス学部】PropTech(不動産テック)における AI・データサイエンス活用
takehikohashimoto
0
4.1k
Information Architectures - Lecture 2 - Next Generation User Interfaces (4018166FNR)
signer
PRO
0
1.1k
Data Presentation - Lecture 5 - Information Visualisation (4019538FNR)
signer
PRO
0
1.8k
Virtual and Augmented Reality - Lecture 8 - Next Generation User Interfaces (4018166FNR)
signer
PRO
0
1.2k
Featured
See All Featured
Designing for humans not robots
tammielis
247
25k
Bootstrapping a Software Product
garrettdimon
PRO
301
110k
Templates, Plugins, & Blocks: Oh My! Creating the theme that thinks of everything
marktimemedia
18
1.7k
StorybookのUI Testing Handbookを読んだ
zakiyama
11
4.6k
Gamification - CAS2011
davidbonilla
76
4.6k
Navigating Team Friction
lara
177
13k
It's Worth the Effort
3n
180
27k
Put a Button on it: Removing Barriers to Going Fast.
kastner
58
3k
Unsuck your backbone
ammeep
662
57k
Fantastic passwords and where to find them - at NoRuKo
philnash
36
2.5k
Building a Modern Day E-commerce SEO Strategy
aleyda
16
6.3k
In The Pink: A Labor of Love
frogandcode
138
21k
Transcript
Code Review by Pluu
None
৵ ܻ࠭о ਃೠо? 1 2 ੌନ Ѿೣਸ ߊѼೞҊ Ҋӝ ਤ೧
٘ ߬झ ೧ܳ ҕਬܳ ా೧ ࢲ۽ ߓ ࣻ ٣ੋҗ ҳഅীࢲ ੌҙࢿਸ ਬೞӝ ਤ೧ 3
৵ ܻ࠭о ਃೠо? 4 5 ী ൔೠ (common) Ѿೣਸ
6 ܲ ҙਸ ыח. زܐ ܻ࠭ח ޙઁܳ ߊѼೞӝ ਤ೧ ਃೠ Ѣܻܳ ઁҕ ೧ Ӑ١ ݯߡٜ Үী بਸ ળ
৵ ܻ࠭о ਃೠо? 7 8 ࠗब/ࠁ࢚. ٬ ӝ ੋ ਃೠ
ࠁ࢚ ۱. ݯߡٜрী ؊ оөਕ ࣻ ѱ ب
None
Code Review Checklist General • ٘о زפө? ب ೠ ӝמਸ
ࣻ೯פө, ֤ܻо ৢ߄ܲ ١. • ݽٚ ٘ܳ औѱ ೧ೡ ࣻ णפө? • https://pl.kotl.in/MR0H0GQ_7 • ೠ ٬ ӏਸ ળࣻפө? Ѫٜ ѐ Қഐ, ߸ࣻ ߂ ೣ ࣻ ܴ, ӡ, ٜৈ ॳӝ, ࢲध ߂ ࢳ ਤܳ ನೣפ. • ࠂغѢա ࠂ ػ ٘о णפө?
Code Review Checklist General • оמೠ ٘ܳ ݽٕച ೠ Ѫੑפө?
• https://pl.kotl.in/A9ZVqkTBC • ݽٚ ߸ࣻܳ ߄Ե ࣻ णפө? • ࢳ ܻ ػ ٘о णפө? • Do ܖח ࢸػ ӡ৬ ৢ߄ܲ ઙܐ ઑѤਸ оҊ णפө? • ۽Ӓ۔ীࢲ ࢎਊ ػ ܴ بܳ ׳פө?
Code Review Checklist Performance • ࢿמਸ ೱ࢚दఆ ഛपೠ ୭ചо णפө?
• ٘ܳ ۄ࠳۞ܻ ա ղ ೣࣻ۽ ೡ ࣻ णפө? • https://pl.kotl.in/qLizl3RrH • ۽Ӧ ژח ٣ߡӦ ٘ܳ ઁѢ ೡ ࣻ णפө?
Code Review Checklist Security • ݽٚ ؘఠ ੑ۱ਸ Ѩ (ৢ߄ܲ
ਬഋ, ӡ, ഋध ߂ ߧਤ)ೞҊ ੋ ٬ ೮णפө? • ఋࢎ ਬܻ౭ܳ ࢎਊೞח ҃ ߈ജغח য়ܨо ߊѼؾפө? • ۱ чਸ ѨࢎೞҊ ੋ٬פө? • ੜޅػ ݒѐ ߸ࣻ ч ܻؾפө?
Code Review Checklist Documentation • ࢳ ઓೞҊ ٘ بܳ ࢸݺפө?
• ݽٚ ೣࣻо ࢳ ܻ غणפө? • ࠺࢚ੋ زա оܻ ாझ ܻо ࢸݺغয णפө? • ఋࢎ ۄ࠳۞ܻ ࢎਊҗ ӝמ ޙࢲചغয णפө? • ؘఠ ҳઑ৬ ஏ ױਤо ࢸݺ غणפө? • ࠛ৮ೠ ٘о णפө? Ӓۧݶ 'TODO'৬ э ೠ ݃ழ ܳ ࢎਊೞৈ ઁѢೞѢա ېӒܳ ೧ঠפө?
Code Review Checklist Testing • ٘ܳ పझ ೡ ࣻ णפө?
٘о ցޖ ݆Ѣա ઙࣘޛਸ ऀӝ ঋҊ, ёܳ ୡӝച ೡ ࣻ হਵݴ, పझ ۨ ਕо ݫࣗ٘ ١ਸ ࢎਊೡ ࣻ ب۾ ҳઑചغযঠפ. • పझо ઓೞݴ ನҚੑפө? • पઁ۽ ٘о ਗೞח ӝמਸ ࣻ೯ೞח పझפө? • పझ ٘ܳ ӝઓ APIܳ ࢎਊೞৈ ೡ ࣻ णפө?
ܻ࠭যܳ ਤೠ 1 2 ࢎۈ नী ٘ܳ ࠺ಣೞۄ. ѐߊীѱ
, ٘ী ೧ࢶ ࠛೞۄ. 3 ਤ۽ࠗఠо ইצ धਵ۽ࠗఠ ೠ ӂਤ नࠁ ؊ ݽܰח ࢎۈਸ ઓ҃, ઓ, ੋղबਵ۽ ࢎۈਸ ೞۄ
ܻ࠭যܳ ਤೠ 4 5 ܻ࠭ ഥח ޙઁܳ ೧Ѿೞӝ ਤೠ
ഥо ইשਸ 6 “Why”ۄח ޙਸ ೖೞۄ ޙࠁח ޙਸ ೞۄ
ܻ࠭যܳ ਤೠ 7 8 டଲೞח Ѫਸ ݃ۄ 9 ೧Ѿ଼ী
Ӕೞӝ ਤೠ ೠо ࢚ ӡ ח Ѫਸ ӝরೞۄ. न न ଵઑೞח જ ળ ٬ਸ оҊ ח Ѫਸ ݺबೞۄ
ܻ࠭যܳ ਤೠ 10 11 ٘ ܻ࠭ܳ ࢲفܰ ঋইب ػ.
ೞ݅ ߄۽ ೧ঠೡ ਃо . ೠߣী 200~400 ۄੋࠁ ٘ܳ ܻ࠭ೞۄ
Reference • Effective Code Reviews ~ Code Review Checklist •
Embedded System Code Review Checklist • Code review guidelines – Part 1 • https://flyburi.com/576