Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code Review
Search
pluulove (노현석)
May 03, 2019
Education
2
520
Code Review
회사 사내 팀에서 라이트닝토크로 발표한
Code Review에 대한 발표자료입니다.
pluulove (노현석)
May 03, 2019
Tweet
Share
More Decks by pluulove (노현석)
See All by pluulove (노현석)
Google I/O Extended Incheon 2025 ~ What's new in Android development tools
pluu
1
310
N.E.X.T LEVEL
pluu
3
520
안드로이드 기술 이력서의 최소 조건
pluu
1
2.9k
I/O Extended Android in Korea 2024 ~ Whats new in Android development tools
pluu
0
690
Android Studio와 좀 더 친해지기
pluu
0
190
우리모두 삽질한다
pluu
0
1.4k
Re:Android Studio 설정 살펴보기 및 생산성 올리기
pluu
0
1.6k
What's new in Android development tools
pluu
1
900
What's new in Android development tools
pluu
1
460
Other Decks in Education
See All in Education
2025/06/05_読み漁り学習
nag8
0
190
20250611_なんでもCopilot1年続いたぞ~
ponponmikankan
0
160
仮説の取扱説明書/User_Guide_to_a_Hypothesis
florets1
4
350
Human-AI Interaction - Lecture 11 - Next Generation User Interfaces (4018166FNR)
signer
PRO
0
520
Alumnote inc. Company Deck
yukinumata
0
1.8k
実務プログラム
takenawa
0
15k
2025年度春学期 統計学 第10回 分布の推測とは ー 標本調査,度数分布と確率分布 (2025. 6. 12)
akiraasano
PRO
0
220
2026 g0v 零時政府年會啟動提案 / g0v Summit 2026 Kickstart
rschiang
0
230
IUM-03-Short Series of Functions
kanaya
0
120
万博マニアックマップを支えるオープンデータとその裏側
barsaka2
0
800
EVOLUCIÓN DE LAS NEUROCIENCIAS EN LOS CONTEXTOS ORGANIZACIONALES
jvpcubias
0
130
Common STIs in London: Symptoms, Risks & Prevention
medicaldental
0
140
Featured
See All Featured
Building Flexible Design Systems
yeseniaperezcruz
328
39k
Unsuck your backbone
ammeep
671
58k
Documentation Writing (for coders)
carmenintech
73
5k
Keith and Marios Guide to Fast Websites
keithpitt
411
22k
Building Better People: How to give real-time feedback that sticks.
wjessup
368
19k
Producing Creativity
orderedlist
PRO
347
40k
CSS Pre-Processors: Stylus, Less & Sass
bermonpainter
358
30k
A designer walks into a library…
pauljervisheath
207
24k
Making Projects Easy
brettharned
117
6.4k
Why Our Code Smells
bkeepers
PRO
339
57k
Balancing Empowerment & Direction
lara
3
610
The Psychology of Web Performance [Beyond Tellerrand 2023]
tammyeverts
49
3k
Transcript
Code Review by Pluu
None
৵ ܻ࠭о ਃೠо? 1 2 ੌନ Ѿೣਸ ߊѼೞҊ Ҋӝ ਤ೧
٘ ߬झ ೧ܳ ҕਬܳ ా೧ ࢲ۽ ߓ ࣻ ٣ੋҗ ҳഅীࢲ ੌҙࢿਸ ਬೞӝ ਤ೧ 3
৵ ܻ࠭о ਃೠо? 4 5 ী ൔೠ (common) Ѿೣਸ
6 ܲ ҙਸ ыח. زܐ ܻ࠭ח ޙઁܳ ߊѼೞӝ ਤ೧ ਃೠ Ѣܻܳ ઁҕ ೧ Ӑ١ ݯߡٜ Үী بਸ ળ
৵ ܻ࠭о ਃೠо? 7 8 ࠗब/ࠁ࢚. ٬ ӝ ੋ ਃೠ
ࠁ࢚ ۱. ݯߡٜрী ؊ оөਕ ࣻ ѱ ب
None
Code Review Checklist General • ٘о زפө? ب ೠ ӝמਸ
ࣻ೯פө, ֤ܻо ৢ߄ܲ ١. • ݽٚ ٘ܳ औѱ ೧ೡ ࣻ णפө? • https://pl.kotl.in/MR0H0GQ_7 • ೠ ٬ ӏਸ ળࣻפө? Ѫٜ ѐ Қഐ, ߸ࣻ ߂ ೣ ࣻ ܴ, ӡ, ٜৈ ॳӝ, ࢲध ߂ ࢳ ਤܳ ನೣפ. • ࠂغѢա ࠂ ػ ٘о णפө?
Code Review Checklist General • оמೠ ٘ܳ ݽٕച ೠ Ѫੑפө?
• https://pl.kotl.in/A9ZVqkTBC • ݽٚ ߸ࣻܳ ߄Ե ࣻ णפө? • ࢳ ܻ ػ ٘о णפө? • Do ܖח ࢸػ ӡ৬ ৢ߄ܲ ઙܐ ઑѤਸ оҊ णפө? • ۽Ӓ۔ীࢲ ࢎਊ ػ ܴ بܳ ׳פө?
Code Review Checklist Performance • ࢿמਸ ೱ࢚दఆ ഛपೠ ୭ചо णפө?
• ٘ܳ ۄ࠳۞ܻ ա ղ ೣࣻ۽ ೡ ࣻ णפө? • https://pl.kotl.in/qLizl3RrH • ۽Ӧ ژח ٣ߡӦ ٘ܳ ઁѢ ೡ ࣻ णפө?
Code Review Checklist Security • ݽٚ ؘఠ ੑ۱ਸ Ѩ (ৢ߄ܲ
ਬഋ, ӡ, ഋध ߂ ߧਤ)ೞҊ ੋ ٬ ೮णפө? • ఋࢎ ਬܻ౭ܳ ࢎਊೞח ҃ ߈ജغח য়ܨо ߊѼؾפө? • ۱ чਸ ѨࢎೞҊ ੋ٬פө? • ੜޅػ ݒѐ ߸ࣻ ч ܻؾפө?
Code Review Checklist Documentation • ࢳ ઓೞҊ ٘ بܳ ࢸݺפө?
• ݽٚ ೣࣻо ࢳ ܻ غणפө? • ࠺࢚ੋ زա оܻ ாझ ܻо ࢸݺغয णפө? • ఋࢎ ۄ࠳۞ܻ ࢎਊҗ ӝמ ޙࢲചغয णפө? • ؘఠ ҳઑ৬ ஏ ױਤо ࢸݺ غणפө? • ࠛ৮ೠ ٘о णפө? Ӓۧݶ 'TODO'৬ э ೠ ݃ழ ܳ ࢎਊೞৈ ઁѢೞѢա ېӒܳ ೧ঠפө?
Code Review Checklist Testing • ٘ܳ పझ ೡ ࣻ णפө?
٘о ցޖ ݆Ѣա ઙࣘޛਸ ऀӝ ঋҊ, ёܳ ୡӝച ೡ ࣻ হਵݴ, పझ ۨ ਕо ݫࣗ٘ ١ਸ ࢎਊೡ ࣻ ب۾ ҳઑചغযঠפ. • పझо ઓೞݴ ನҚੑפө? • पઁ۽ ٘о ਗೞח ӝמਸ ࣻ೯ೞח పझפө? • పझ ٘ܳ ӝઓ APIܳ ࢎਊೞৈ ೡ ࣻ णפө?
ܻ࠭যܳ ਤೠ 1 2 ࢎۈ नী ٘ܳ ࠺ಣೞۄ. ѐߊীѱ
, ٘ী ೧ࢶ ࠛೞۄ. 3 ਤ۽ࠗఠо ইצ धਵ۽ࠗఠ ೠ ӂਤ नࠁ ؊ ݽܰח ࢎۈਸ ઓ҃, ઓ, ੋղबਵ۽ ࢎۈਸ ೞۄ
ܻ࠭যܳ ਤೠ 4 5 ܻ࠭ ഥח ޙઁܳ ೧Ѿೞӝ ਤೠ
ഥо ইשਸ 6 “Why”ۄח ޙਸ ೖೞۄ ޙࠁח ޙਸ ೞۄ
ܻ࠭যܳ ਤೠ 7 8 டଲೞח Ѫਸ ݃ۄ 9 ೧Ѿ଼ী
Ӕೞӝ ਤೠ ೠо ࢚ ӡ ח Ѫਸ ӝরೞۄ. न न ଵઑೞח જ ળ ٬ਸ оҊ ח Ѫਸ ݺबೞۄ
ܻ࠭যܳ ਤೠ 10 11 ٘ ܻ࠭ܳ ࢲفܰ ঋইب ػ.
ೞ݅ ߄۽ ೧ঠೡ ਃо . ೠߣী 200~400 ۄੋࠁ ٘ܳ ܻ࠭ೞۄ
Reference • Effective Code Reviews ~ Code Review Checklist •
Embedded System Code Review Checklist • Code review guidelines – Part 1 • https://flyburi.com/576