Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code Review
Search
pluulove (노현석)
May 03, 2019
Education
2
520
Code Review
회사 사내 팀에서 라이트닝토크로 발표한
Code Review에 대한 발표자료입니다.
pluulove (노현석)
May 03, 2019
Tweet
Share
More Decks by pluulove (노현석)
See All by pluulove (노현석)
Google I/O Extended Incheon 2025 ~ What's new in Android development tools
pluu
1
320
N.E.X.T LEVEL
pluu
3
530
안드로이드 기술 이력서의 최소 조건
pluu
1
2.9k
I/O Extended Android in Korea 2024 ~ Whats new in Android development tools
pluu
0
690
Android Studio와 좀 더 친해지기
pluu
0
190
우리모두 삽질한다
pluu
0
1.4k
Re:Android Studio 설정 살펴보기 및 생산성 올리기
pluu
0
1.6k
What's new in Android development tools
pluu
1
900
What's new in Android development tools
pluu
1
460
Other Decks in Education
See All in Education
Ch1_-_Partie_1.pdf
bernhardsvt
0
220
マネジメント「される側」 こそ覚悟を決めろ
nao_randd
9
5.5k
Test-NUTMEG紹介スライド
mugiiicha
0
160
Alumnote inc. Company Deck
yukinumata
0
2k
サンキッズゾーン 春日井駅前 ご案内
sanyohomes
0
920
チーム開発における責任と感謝の話
ssk1991
0
240
登壇未経験者のための登壇戦略~LTは設計が9割!!!~
masakiokuda
3
670
Course Review - Lecture 12 - Next Generation User Interfaces (4018166FNR)
signer
PRO
0
1.8k
Transición del Management al Neuromanagement
jvpcubias
0
210
OJTに夢を見すぎていませんか? ロールプレイ研修の試行錯誤/tryanderror-in-roleplaying-training
takipone
1
220
(キラキラ)人事教育担当のつらみ~教育担当として知っておくポイント~
masakiokuda
0
130
20250830_MIEE祭_会社員視点での学びのヒント
ponponmikankan
1
150
Featured
See All Featured
XXLCSS - How to scale CSS and keep your sanity
sugarenia
248
1.3M
Speed Design
sergeychernyshev
32
1.1k
The Myth of the Modular Monolith - Day 2 Keynote - Rails World 2024
eileencodes
26
3k
Connecting the Dots Between Site Speed, User Experience & Your Business [WebExpo 2025]
tammyeverts
8
520
BBQ
matthewcrist
89
9.8k
Imperfection Machines: The Place of Print at Facebook
scottboms
268
13k
A designer walks into a library…
pauljervisheath
207
24k
Raft: Consensus for Rubyists
vanstee
140
7.1k
We Have a Design System, Now What?
morganepeng
53
7.8k
JavaScript: Past, Present, and Future - NDC Porto 2020
reverentgeek
51
5.6k
The Cult of Friendly URLs
andyhume
79
6.6k
Context Engineering - Making Every Token Count
addyosmani
2
41
Transcript
Code Review by Pluu
None
৵ ܻ࠭о ਃೠо? 1 2 ੌନ Ѿೣਸ ߊѼೞҊ Ҋӝ ਤ೧
٘ ߬झ ೧ܳ ҕਬܳ ా೧ ࢲ۽ ߓ ࣻ ٣ੋҗ ҳഅীࢲ ੌҙࢿਸ ਬೞӝ ਤ೧ 3
৵ ܻ࠭о ਃೠо? 4 5 ী ൔೠ (common) Ѿೣਸ
6 ܲ ҙਸ ыח. زܐ ܻ࠭ח ޙઁܳ ߊѼೞӝ ਤ೧ ਃೠ Ѣܻܳ ઁҕ ೧ Ӑ١ ݯߡٜ Үী بਸ ળ
৵ ܻ࠭о ਃೠо? 7 8 ࠗब/ࠁ࢚. ٬ ӝ ੋ ਃೠ
ࠁ࢚ ۱. ݯߡٜрী ؊ оөਕ ࣻ ѱ ب
None
Code Review Checklist General • ٘о زפө? ب ೠ ӝמਸ
ࣻ೯פө, ֤ܻо ৢ߄ܲ ١. • ݽٚ ٘ܳ औѱ ೧ೡ ࣻ णפө? • https://pl.kotl.in/MR0H0GQ_7 • ೠ ٬ ӏਸ ળࣻפө? Ѫٜ ѐ Қഐ, ߸ࣻ ߂ ೣ ࣻ ܴ, ӡ, ٜৈ ॳӝ, ࢲध ߂ ࢳ ਤܳ ನೣפ. • ࠂغѢա ࠂ ػ ٘о णפө?
Code Review Checklist General • оמೠ ٘ܳ ݽٕച ೠ Ѫੑפө?
• https://pl.kotl.in/A9ZVqkTBC • ݽٚ ߸ࣻܳ ߄Ե ࣻ णפө? • ࢳ ܻ ػ ٘о णפө? • Do ܖח ࢸػ ӡ৬ ৢ߄ܲ ઙܐ ઑѤਸ оҊ णפө? • ۽Ӓ۔ীࢲ ࢎਊ ػ ܴ بܳ ׳פө?
Code Review Checklist Performance • ࢿמਸ ೱ࢚दఆ ഛपೠ ୭ചо णפө?
• ٘ܳ ۄ࠳۞ܻ ա ղ ೣࣻ۽ ೡ ࣻ णפө? • https://pl.kotl.in/qLizl3RrH • ۽Ӧ ژח ٣ߡӦ ٘ܳ ઁѢ ೡ ࣻ णפө?
Code Review Checklist Security • ݽٚ ؘఠ ੑ۱ਸ Ѩ (ৢ߄ܲ
ਬഋ, ӡ, ഋध ߂ ߧਤ)ೞҊ ੋ ٬ ೮णפө? • ఋࢎ ਬܻ౭ܳ ࢎਊೞח ҃ ߈ജغח য়ܨо ߊѼؾפө? • ۱ чਸ ѨࢎೞҊ ੋ٬פө? • ੜޅػ ݒѐ ߸ࣻ ч ܻؾפө?
Code Review Checklist Documentation • ࢳ ઓೞҊ ٘ بܳ ࢸݺפө?
• ݽٚ ೣࣻо ࢳ ܻ غणפө? • ࠺࢚ੋ زա оܻ ாझ ܻо ࢸݺغয णפө? • ఋࢎ ۄ࠳۞ܻ ࢎਊҗ ӝמ ޙࢲചغয णפө? • ؘఠ ҳઑ৬ ஏ ױਤо ࢸݺ غणפө? • ࠛ৮ೠ ٘о णפө? Ӓۧݶ 'TODO'৬ э ೠ ݃ழ ܳ ࢎਊೞৈ ઁѢೞѢա ېӒܳ ೧ঠפө?
Code Review Checklist Testing • ٘ܳ పझ ೡ ࣻ णפө?
٘о ցޖ ݆Ѣա ઙࣘޛਸ ऀӝ ঋҊ, ёܳ ୡӝച ೡ ࣻ হਵݴ, పझ ۨ ਕо ݫࣗ٘ ١ਸ ࢎਊೡ ࣻ ب۾ ҳઑചغযঠפ. • పझо ઓೞݴ ನҚੑפө? • पઁ۽ ٘о ਗೞח ӝמਸ ࣻ೯ೞח పझפө? • పझ ٘ܳ ӝઓ APIܳ ࢎਊೞৈ ೡ ࣻ णפө?
ܻ࠭যܳ ਤೠ 1 2 ࢎۈ नী ٘ܳ ࠺ಣೞۄ. ѐߊীѱ
, ٘ী ೧ࢶ ࠛೞۄ. 3 ਤ۽ࠗఠо ইצ धਵ۽ࠗఠ ೠ ӂਤ नࠁ ؊ ݽܰח ࢎۈਸ ઓ҃, ઓ, ੋղबਵ۽ ࢎۈਸ ೞۄ
ܻ࠭যܳ ਤೠ 4 5 ܻ࠭ ഥח ޙઁܳ ೧Ѿೞӝ ਤೠ
ഥо ইשਸ 6 “Why”ۄח ޙਸ ೖೞۄ ޙࠁח ޙਸ ೞۄ
ܻ࠭যܳ ਤೠ 7 8 டଲೞח Ѫਸ ݃ۄ 9 ೧Ѿ଼ী
Ӕೞӝ ਤೠ ೠо ࢚ ӡ ח Ѫਸ ӝরೞۄ. न न ଵઑೞח જ ળ ٬ਸ оҊ ח Ѫਸ ݺबೞۄ
ܻ࠭যܳ ਤೠ 10 11 ٘ ܻ࠭ܳ ࢲفܰ ঋইب ػ.
ೞ݅ ߄۽ ೧ঠೡ ਃо . ೠߣী 200~400 ۄੋࠁ ٘ܳ ܻ࠭ೞۄ
Reference • Effective Code Reviews ~ Code Review Checklist •
Embedded System Code Review Checklist • Code review guidelines – Part 1 • https://flyburi.com/576