Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Amanda Sopkin - The Refactoring Balance Beam: When to Make Changes and When to Leave it Alone

Amanda Sopkin - The Refactoring Balance Beam: When to Make Changes and When to Leave it Alone

Many developers struggle to find the balance between striving to improve existing code and letting good enough alone by accepting certain shortcomings. As a new developer to a team it can be difficult to understand existing strategies and patterns that are sometimes flat out bad (and often openly acknowledged as such). Often the result of tight deadlines or unclear specifications, even the best developers write code they later look back upon with shudders. So how do we decide when refactoring is worth it? Come learn strategies for refactoring with minimal impact, methods for working with bad code you can’t change, and strategies for knowing the difference between what is fixable and what is better left alone.

https://us.pycon.org/2019/schedule/presentation/213/

PyCon 2019

May 05, 2019
Tweet

More Decks by PyCon 2019

Other Decks in Programming

Transcript

  1. View Slide

  2. View Slide

  3. View Slide

  4. View Slide

  5. View Slide

  6. Why refactor?

    View Slide

  7. Why refactor?

    View Slide

  8. View Slide

  9. View Slide

  10. View Slide

  11. View Slide

  12. View Slide

  13. View Slide

  14. View Slide

  15. View Slide

  16. View Slide

  17. Common Code Smell #1
    It’s too long!

    View Slide






  18. View Slide

  19. View Slide



  20. View Slide



  21. View Slide

  22. View Slide

  23. Code Smells: Long methods







    View Slide

  24. Tool: Replace Method with Method Object

    View Slide

  25. Tool: Replace Method with Method Object

    View Slide

  26. Tool: Introduce a parameter object

    View Slide





  27. View Slide

  28. Common Code Smell #2:
    It’s not useful enough!

    View Slide







  29. View Slide

  30. View Slide

  31. View Slide






  32. View Slide

  33. Common Code Smell #3:
    OOP issues

    View Slide

  34. Code smell: Divergent change





    View Slide

  35. Code smell: Shotgun surgery





    View Slide

  36. Code smell: shotgun surgery

    View Slide

  37. Tool: Move Class

    View Slide

  38. Code smell: Parallel inheritance hierarchies






    View Slide

  39. Code Smell: Parallel inheritance hierarchies

    View Slide

  40. Tool: Move Class

    View Slide






  41. View Slide






  42. View Slide

  43. Tool: Extract Class

    View Slide

  44. Tool: Extract Class

    View Slide




  45. View Slide

  46. Tool: Replace Type Code with State

    View Slide






  47. View Slide

  48. Tool: Hide Delegate

    View Slide

  49. Tool: Hide Delegate

    View Slide





  50. View Slide





  51. View Slide

  52. Do I need to inherit this class?

    View Slide

  53. View Slide

  54. Lets talk Pythonic Code Smells!

    View Slide







  55. View Slide






  56. View Slide

  57. Codesmell: Unnecessary boilerplate code

    View Slide

  58. Dataclasses and attrs

    View Slide

  59. Dataclasses and attrs

    View Slide





  60. View Slide





  61. View Slide

  62. View Slide

  63. View Slide

  64. View Slide

  65. View Slide

  66. View Slide

  67. View Slide

  68. View Slide

  69. View Slide

  70. View Slide

  71. View Slide

  72. View Slide

  73. View Slide

  74. View Slide

  75. View Slide

  76. View Slide

  77. View Slide

  78. View Slide

  79. View Slide

  80. View Slide

  81. View Slide

  82. View Slide

  83. View Slide





  84. View Slide






  85. View Slide



  86. View Slide



  87. View Slide



  88. View Slide

  89. View Slide

  90. View Slide


  91. (Expand) (Contract)
    (Transition)

    View Slide



  92. View Slide

  93. View Slide

  94. View Slide

  95. View Slide

  96. View Slide

  97. View Slide

  98. View Slide

  99. View Slide

  100. View Slide

  101. View Slide

  102. View Slide

  103. View Slide

  104. View Slide

  105. View Slide

  106. View Slide

  107. THANK YOU!
    @amandasopkin

    View Slide

  108. Sources
    Flat Icon: https://www.flaticon.com/
    Refactoring Python by Brett Slatkin: https://www.youtube.com/watch?v=D_6ybDcU5gc
    Real Python: https://realpython.com/python-refactoring/
    Pep 20: https://www.python.org/dev/peps/pep-0020/
    Beyond Pep 8 by Raymond Hettinger: https://www.youtube.com/watch?v=wf-BqAjZb8M
    Refactoring by Martin Fowler:
    https://www.csie.ntu.edu.tw/~r95004/Refactoring_improving_the_design_of_existing_code.pdf

    View Slide