Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
There's more to code review than you might think
Search
Daniel Shaw
June 11, 2016
Programming
0
180
There's more to code review than you might think
Lightning talk, given at PHPSC 2016
Daniel Shaw
June 11, 2016
Tweet
Share
More Decks by Daniel Shaw
See All by Daniel Shaw
There's more to code review than you might think
thatdamnqa
1
250
Educating Enfys (lightning talk)
thatdamnqa
0
200
There's More to Code Reviews than You Might Think ✩
thatdamnqa
0
98
There's More To Code Reviews Than You Might Think (lightning talk)
thatdamnqa
0
200
The Less Dull Bits of Testing
thatdamnqa
0
170
Other Decks in Programming
See All in Programming
SRE チーム立ち上げ前に考えたこと・取り組んだこと / Considerations and Preparations Before Establishing an SRE Team
mackey0225
3
320
ピグパーティにおけるMongoDB CommunityバージョンからAtlasへの移行事例
10969hotaka
0
130
しくじり先生 Image Matching Challenge 2024 編
goosehaaan
0
810
みんなのオブザーバビリティプラットフォームを作ってるんだがパフォーマンスがやばい #mackerelio #srenext
ne_sachirou
0
370
ぼっちを避けて楽しむためのアノテコノテ / Various Tips and Tricks to Avoid Loneliness and Have Fun
nrslib
3
1.7k
Async Await: Mastering Python's Time-Bending Tricks - EuroPython2024
yanbo
1
290
SDCon2024: Enabling DevOps and Team Topologies thru architecture: architecting for fast flow
cer
PRO
0
780
社内 LT 会を発足し、アウトプット文化を醸成させるために考えたこと・やったこと / Starting internal LT meetings and fostering an output culture
mackey0225
3
120
Folding Cheat Sheet #7
philipschwarz
PRO
0
150
Trial
cairolibrary720
1
130
はしめてのプログラミングとロボット制御
watawatavoltage
0
290
20240706_CDKConf
takuyay0ne
0
1.2k
Featured
See All Featured
Debugging Ruby Performance
tmm1
71
11k
We Have a Design System, Now What?
morganepeng
46
7k
Git: the NoSQL Database
bkeepers
PRO
423
64k
CSS Pre-Processors: Stylus, Less & Sass
bermonpainter
353
29k
Code Reviewing Like a Champion
maltzj
517
39k
How GitHub (no longer) Works
holman
305
140k
The World Runs on Bad Software
bkeepers
PRO
63
11k
KATA
mclloyd
20
13k
A Philosophy of Restraint
colly
200
16k
RailsConf 2023
tenderlove
16
720
ReactJS: Keep Simple. Everything can be a component!
pedronauck
662
120k
Build your cross-platform service in a week with App Engine
jlugia
227
17k
Transcript
THERE’S MORE TO CODE REVIEW THAN YOU MIGHT THINK Clair
Shaw @clairs · clairshaw.co.uk
What are Code reviews for?
Code reviews are not an indication of anybody's abilities
Check code style
Check code style Pick a house style, use it, communicate
it
Check code style Pick a house style, use it, communicate
it
Check code style Don't get too distracted by checking code
style
Check code style Automate if you can. Bad news can
be better received by a cruel and lifeless script
Review the configuration
Review the configuration { "require": { "usefultool/tool": "1.1" } }
Review the configuration { "require": { "usefultool/tool": "1.2.1" } }
Review the configuration { "require": { "usefultool/tool": "^1.2" } }
Check forwards compatibility
Check forwards compatibility PHP 5.5.32 PHP 5.6.18 PHP 7.0.3
Check forwards compatibility jQuery 1.12.1 jQuery 2.2.1
Review the documentation
Review the commit message
Review the commit message Update usefultool
Review the commit message [MYCOOLAPP-1234] Update UsefulTool lib Wider company
policy dictates that the latest UsefulTool v1 should be used. Update Composer config to reflect this.
Double check the code
Double check the code if (in_array($input, $expected)) { $this->showRestrictedSecrets(); }
else { $this->goAway(); }
Double check the code $expected = ['2', '4', '5', 'cake'];
$input = 0; if (in_array($input, $expected)) { echo "I'm in!"; }
Double check the tests
Final thoughts…
Final thoughts… All output should be reviewed. It’s not personal
Final thoughts… Often, a peer review can teach something to
two people
Thanks. Feedback please! https://joind.in/talk/29752
[email protected]
@clairs