Upgrade to Pro — share decks privately, control downloads, hide ads and more …

There's more to code review than you might think

There's more to code review than you might think

Lightning talk, given at PHPSC 2016

Daniel Shaw

June 11, 2016

More Decks by Daniel Shaw

Other Decks in Programming


  1. Check code style Automate if you can. Bad news can

    be better received by
 a cruel and lifeless script
  2. Review the commit message [MYCOOLAPP-1234] Update UsefulTool lib Wider company

    policy dictates that the latest UsefulTool v1 should be used. Update Composer config to reflect this.
  3. Double check the code $expected = ['2', '4', '5', 'cake'];

    $input = 0; if (in_array($input, $expected)) { echo "I'm in!"; }