Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
There's more to code review than you might think
Search
Daniel Shaw
June 11, 2016
Programming
0
220
There's more to code review than you might think
Lightning talk, given at PHPSC 2016
Daniel Shaw
June 11, 2016
Tweet
Share
More Decks by Daniel Shaw
See All by Daniel Shaw
There's more to code review than you might think
thatdamnqa
1
290
Educating Enfys (lightning talk)
thatdamnqa
0
230
There's More to Code Reviews than You Might Think ✩
thatdamnqa
0
100
There's More To Code Reviews Than You Might Think (lightning talk)
thatdamnqa
0
230
The Less Dull Bits of Testing
thatdamnqa
0
210
Other Decks in Programming
See All in Programming
テストコードのガイドライン 〜作成から運用まで〜
riku929hr
6
1.3k
Amazon S3 NYJavaSIG 2024-12-12
sullis
0
130
開発者とQAの越境で自動テストが増える開発プロセスを実現する
92thunder
1
220
선언형 UI에서의 상태관리
l2hyunwoo
0
250
traP の部内 ISUCON とそれを支えるポータル / PISCON Portal
ikura_hamu
0
120
月刊 競技プログラミングをお仕事に役立てるには
terryu16
1
1k
CloudflareStack でRAGに入門
asahiiwm
0
140
EC2からECSへ 念願のコンテナ移行と巨大レガシーPHPアプリケーションの再構築
sumiyae
3
540
Внедряем бюджетирование, или Как сделать хорошо?
lamodatech
0
860
オニオンアーキテクチャを使って、 Unityと.NETでコードを共有する
soi013
0
350
ATDDで素早く安定した デリバリを実現しよう!
tonnsama
1
980
Package Traits
ikesyo
1
130
Featured
See All Featured
Designing for Performance
lara
604
68k
YesSQL, Process and Tooling at Scale
rocio
170
14k
Building Your Own Lightsaber
phodgson
104
6.2k
Dealing with People You Can't Stand - Big Design 2015
cassininazir
365
25k
Music & Morning Musume
bryan
46
6.3k
Thoughts on Productivity
jonyablonski
68
4.4k
VelocityConf: Rendering Performance Case Studies
addyosmani
327
24k
Learning to Love Humans: Emotional Interface Design
aarron
274
40k
A Philosophy of Restraint
colly
203
16k
Unsuck your backbone
ammeep
669
57k
Imperfection Machines: The Place of Print at Facebook
scottboms
266
13k
Building Applications with DynamoDB
mza
92
6.1k
Transcript
THERE’S MORE TO CODE REVIEW THAN YOU MIGHT THINK Clair
Shaw @clairs · clairshaw.co.uk
What are Code reviews for?
Code reviews are not an indication of anybody's abilities
Check code style
Check code style Pick a house style, use it, communicate
it
Check code style Pick a house style, use it, communicate
it
Check code style Don't get too distracted by checking code
style
Check code style Automate if you can. Bad news can
be better received by a cruel and lifeless script
Review the configuration
Review the configuration { "require": { "usefultool/tool": "1.1" } }
Review the configuration { "require": { "usefultool/tool": "1.2.1" } }
Review the configuration { "require": { "usefultool/tool": "^1.2" } }
Check forwards compatibility
Check forwards compatibility PHP 5.5.32 PHP 5.6.18 PHP 7.0.3
Check forwards compatibility jQuery 1.12.1 jQuery 2.2.1
Review the documentation
Review the commit message
Review the commit message Update usefultool
Review the commit message [MYCOOLAPP-1234] Update UsefulTool lib Wider company
policy dictates that the latest UsefulTool v1 should be used. Update Composer config to reflect this.
Double check the code
Double check the code if (in_array($input, $expected)) { $this->showRestrictedSecrets(); }
else { $this->goAway(); }
Double check the code $expected = ['2', '4', '5', 'cake'];
$input = 0; if (in_array($input, $expected)) { echo "I'm in!"; }
Double check the tests
Final thoughts…
Final thoughts… All output should be reviewed. It’s not personal
Final thoughts… Often, a peer review can teach something to
two people
Thanks. Feedback please! https://joind.in/talk/29752
[email protected]
@clairs