Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
There's more to code review than you might think
Search
Daniel Shaw
June 11, 2016
Programming
0
260
There's more to code review than you might think
Lightning talk, given at PHPSC 2016
Daniel Shaw
June 11, 2016
Tweet
Share
More Decks by Daniel Shaw
See All by Daniel Shaw
There's more to code review than you might think
thatdamnqa
1
310
Educating Enfys (lightning talk)
thatdamnqa
0
250
There's More to Code Reviews than You Might Think ✩
thatdamnqa
0
110
There's More To Code Reviews Than You Might Think (lightning talk)
thatdamnqa
0
260
The Less Dull Bits of Testing
thatdamnqa
0
240
Other Decks in Programming
See All in Programming
Claude Code + Container Use と Cursor で作る ローカル並列開発環境のススメ / ccc local dev
kaelaela
11
6.5k
イベントストーミング図からコードへの変換手順 / Procedure for Converting Event Storming Diagrams to Code
nrslib
2
940
20250628_非エンジニアがバイブコーディングしてみた
ponponmikankan
0
710
Python型ヒント完全ガイド 初心者でも分かる、現代的で実践的な使い方
mickey_kubo
1
150
PicoRuby on Rails
makicamel
2
140
NPOでのDevinの活用
codeforeveryone
0
870
git worktree × Claude Code × MCP ~生成AI時代の並列開発フロー~
hisuzuya
1
590
ISUCON研修おかわり会 講義スライド
arfes0e2b3c
1
460
テストから始めるAgentic Coding 〜Claude Codeと共に行うTDD〜 / Agentic Coding starts with testing
rkaga
14
5.2k
「テストは愚直&&網羅的に書くほどよい」という誤解 / Test Smarter, Not Harder
munetoshi
0
190
iOS 26にアップデートすると実機でのHot Reloadができない?
umigishiaoi
0
130
Quand Symfony, ApiPlatform, OpenAI et LangChain s'allient pour exploiter vos PDF : de la théorie à la production…
ahmedbhs123
0
210
Featured
See All Featured
Rails Girls Zürich Keynote
gr2m
95
14k
No one is an island. Learnings from fostering a developers community.
thoeni
21
3.4k
Mobile First: as difficult as doing things right
swwweet
223
9.7k
[RailsConf 2023] Rails as a piece of cake
palkan
55
5.7k
Building Flexible Design Systems
yeseniaperezcruz
328
39k
GraphQLとの向き合い方2022年版
quramy
49
14k
Unsuck your backbone
ammeep
671
58k
The Power of CSS Pseudo Elements
geoffreycrofte
77
5.9k
Embracing the Ebb and Flow
colly
86
4.7k
How to Think Like a Performance Engineer
csswizardry
25
1.7k
Building Better People: How to give real-time feedback that sticks.
wjessup
367
19k
Music & Morning Musume
bryan
46
6.7k
Transcript
THERE’S MORE TO CODE REVIEW THAN YOU MIGHT THINK Clair
Shaw @clairs · clairshaw.co.uk
What are Code reviews for?
Code reviews are not an indication of anybody's abilities
Check code style
Check code style Pick a house style, use it, communicate
it
Check code style Pick a house style, use it, communicate
it
Check code style Don't get too distracted by checking code
style
Check code style Automate if you can. Bad news can
be better received by a cruel and lifeless script
Review the configuration
Review the configuration { "require": { "usefultool/tool": "1.1" } }
Review the configuration { "require": { "usefultool/tool": "1.2.1" } }
Review the configuration { "require": { "usefultool/tool": "^1.2" } }
Check forwards compatibility
Check forwards compatibility PHP 5.5.32 PHP 5.6.18 PHP 7.0.3
Check forwards compatibility jQuery 1.12.1 jQuery 2.2.1
Review the documentation
Review the commit message
Review the commit message Update usefultool
Review the commit message [MYCOOLAPP-1234] Update UsefulTool lib Wider company
policy dictates that the latest UsefulTool v1 should be used. Update Composer config to reflect this.
Double check the code
Double check the code if (in_array($input, $expected)) { $this->showRestrictedSecrets(); }
else { $this->goAway(); }
Double check the code $expected = ['2', '4', '5', 'cake'];
$input = 0; if (in_array($input, $expected)) { echo "I'm in!"; }
Double check the tests
Final thoughts…
Final thoughts… All output should be reviewed. It’s not personal
Final thoughts… Often, a peer review can teach something to
two people
Thanks. Feedback please! https://joind.in/talk/29752
[email protected]
@clairs