Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
There's more to code review than you might think
Search
Daniel Shaw
June 11, 2016
Programming
0
270
There's more to code review than you might think
Lightning talk, given at PHPSC 2016
Daniel Shaw
June 11, 2016
Tweet
Share
More Decks by Daniel Shaw
See All by Daniel Shaw
There's more to code review than you might think
thatdamnqa
1
320
Educating Enfys (lightning talk)
thatdamnqa
0
260
There's More to Code Reviews than You Might Think ✩
thatdamnqa
0
110
There's More To Code Reviews Than You Might Think (lightning talk)
thatdamnqa
0
270
The Less Dull Bits of Testing
thatdamnqa
0
250
Other Decks in Programming
See All in Programming
バッチ処理を「状態の記録」から「事実の記録」へ
panda728
PRO
0
170
はじめてのDSPy - 言語モデルを『プロンプト』ではなく『プログラミング』するための仕組み
masahiro_nishimi
3
710
Google Opalで使える37のライブラリ
mickey_kubo
2
110
登壇は dynamic! な営みである / speech is dynamic
da1chi
0
350
iOSエンジニア向けの英語学習アプリを作る!
yukawashouhei
0
200
Writing Better Go: Lessons from 10 Code Reviews
konradreiche
0
3.2k
(Extension DC 2025) Actor境界を越える技術
teamhimeh
1
270
チームの境界をブチ抜いていけ
tokai235
0
200
Le côté obscur des IA génératives
pascallemerrer
0
150
Catch Up: Go Style Guide Update
andpad
0
230
20251016_Rails News ~Rails 8.1の足音を聴く~
morimorihoge
2
580
Pull-Requestの内容を1クリックで動作確認可能にするワークフロー
natmark
2
520
Featured
See All Featured
The Psychology of Web Performance [Beyond Tellerrand 2023]
tammyeverts
49
3.1k
XXLCSS - How to scale CSS and keep your sanity
sugarenia
249
1.3M
Designing Dashboards & Data Visualisations in Web Apps
destraynor
231
53k
No one is an island. Learnings from fostering a developers community.
thoeni
21
3.5k
Into the Great Unknown - MozCon
thekraken
40
2.1k
Practical Tips for Bootstrapping Information Extraction Pipelines
honnibal
PRO
23
1.5k
個人開発の失敗を避けるイケてる考え方 / tips for indie hackers
panda_program
115
20k
Leading Effective Engineering Teams in the AI Era
addyosmani
7
510
Building an army of robots
kneath
306
46k
Statistics for Hackers
jakevdp
799
220k
Easily Structure & Communicate Ideas using Wireframe
afnizarnur
194
16k
A Tale of Four Properties
chriscoyier
161
23k
Transcript
THERE’S MORE TO CODE REVIEW THAN YOU MIGHT THINK Clair
Shaw @clairs · clairshaw.co.uk
What are Code reviews for?
Code reviews are not an indication of anybody's abilities
Check code style
Check code style Pick a house style, use it, communicate
it
Check code style Pick a house style, use it, communicate
it
Check code style Don't get too distracted by checking code
style
Check code style Automate if you can. Bad news can
be better received by a cruel and lifeless script
Review the configuration
Review the configuration { "require": { "usefultool/tool": "1.1" } }
Review the configuration { "require": { "usefultool/tool": "1.2.1" } }
Review the configuration { "require": { "usefultool/tool": "^1.2" } }
Check forwards compatibility
Check forwards compatibility PHP 5.5.32 PHP 5.6.18 PHP 7.0.3
Check forwards compatibility jQuery 1.12.1 jQuery 2.2.1
Review the documentation
Review the commit message
Review the commit message Update usefultool
Review the commit message [MYCOOLAPP-1234] Update UsefulTool lib Wider company
policy dictates that the latest UsefulTool v1 should be used. Update Composer config to reflect this.
Double check the code
Double check the code if (in_array($input, $expected)) { $this->showRestrictedSecrets(); }
else { $this->goAway(); }
Double check the code $expected = ['2', '4', '5', 'cake'];
$input = 0; if (in_array($input, $expected)) { echo "I'm in!"; }
Double check the tests
Final thoughts…
Final thoughts… All output should be reviewed. It’s not personal
Final thoughts… Often, a peer review can teach something to
two people
Thanks. Feedback please! https://joind.in/talk/29752
[email protected]
@clairs