There's More To Code Reviews Than You Might Think (lightning talk)

So, you do code reviews. But there's probably much more you might want to check too.

Slides to my 10 minute lightning talk.

Transcript

1. THERE’S MORE TO CODE REVIEW THAN YOU MIGHT THINK Clair Shaw @clairs · clairshaw.co.uk
2. Check code style
3. Check code style Don’t go down the rabbit hole
4. Check code style Automate if you can. Bad news can be better received by
 a cruel and lifeless script
5. Two reviewers per commit
6. Two reviewers per commit You might miss something
7. Two reviewers per commit There can be no disagreements
8. Code review everything
9. Code review everything Composer configs, documents, templates,
 database changes, commit messages
10. Code review everything Steps to run this script: * chmod 644 install.sh * ./install.sh * Relax!
11. Review the commit message
12. Review the commit message Fix typo
13. Review the commit message [MYCOOLAPP-1234] Fix typo in install docs I set the install.sh permissions to be 644, it was supposed to be 744. We want it to be executed by the user.
14. Double check the code
15. Double check the code if (in_array($input, $expected)) { $this->showRestrictedSecrets(); } else { $this->goAway(); }
16. Double check the code $expected = ['2', '4', '5', 'cake']; $input = 0; if (in_array($input, $expected)) { echo "I'm in!"; }
17. Final thoughts…
18. Final thoughts… It’s not personal
19. Final thoughts… Often, a peer review can teach
 something to two people
20. Thanks.